| Message ID | 1551256894-21954-1-git-send-email-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V10,1/4] dt-bindings: fsl: scu: add thermal binding | expand |
On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang wrote: > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > system controller, the system controller is in charge of system > power, clock and thermal sensors etc. management, Linux kernel > has to communicate with system controller via MU (message unit) > IPC to get temperature from thermal sensors, this patch adds > binding doc for i.MX system controller thermal driver. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > Changes since V9: > - change #thermal-sensor-cells value in example to 1, since there are other > thermal sensors inside system controller, it is just because there are still > some issue, so system controller does NOT expose them for now, they could > be exposed later, so it should be 1 from HW perspective. > --- > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > index 72d481c..855270b 100644 > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > @@ -122,6 +122,21 @@ RTC bindings based on SCU Message Protocol > Required properties: > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > +Thermal bindings based on SCU Message Protocol > +------------------------------------------------------------ > + > +Required properties: > +- compatible: Should be : > + "fsl,imx8qxp-sc-thermal" > + followed by "fsl,imx-sc-thermal"; > + > +- #thermal-sensor-cells: See Documentation/devicetree/bindings/thermal/thermal.txt > + for a description. > + > +- imx,sensor-resource-id: A single integer for single thermal zone's resource ID or > + an array of integers to specify each thermal zone's sensor > + resource ID. Can't you put the resource ids in the thermal-sensor cells? Why do you need to list them here? Rob
Hi, Rob Best Regards! Anson Huang > -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: 2019年2月28日 7:55 > To: Anson Huang <anson.huang@nxp.com> > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > catalin.marinas@arm.com; will.deacon@arm.com; rui.zhang@intel.com; > edubezval@gmail.com; daniel.lezcano@linaro.org; Aisheng Dong > <aisheng.dong@nxp.com>; ulf.hansson@linaro.org; sboyd@kernel.org; > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > <andy.gross@linaro.org>; horms+renesas@verge.net.au; heiko@sntech.de; > arnd@arndb.de; maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > marc.w.gonzalez@free.fr; olof@lixom.net; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal binding > > On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang wrote: > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > > controller, the system controller is in charge of system power, clock > > and thermal sensors etc. management, Linux kernel has to communicate > > with system controller via MU (message unit) IPC to get temperature > > from thermal sensors, this patch adds binding doc for i.MX system > > controller thermal driver. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > --- > > Changes since V9: > > - change #thermal-sensor-cells value in example to 1, since there are > other > > thermal sensors inside system controller, it is just because there are > still > > some issue, so system controller does NOT expose them for now, > they could > > be exposed later, so it should be 1 from HW perspective. > > --- > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 21 > +++++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > index 72d481c..855270b 100644 > > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > @@ -122,6 +122,21 @@ RTC bindings based on SCU Message Protocol > > Required properties: > > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > +Thermal bindings based on SCU Message Protocol > > +------------------------------------------------------------ > > + > > +Required properties: > > +- compatible: Should be : > > + "fsl,imx8qxp-sc-thermal" > > + followed by "fsl,imx-sc-thermal"; > > + > > +- #thermal-sensor-cells: See > Documentation/devicetree/bindings/thermal/thermal.txt > > + for a description. > > + > > +- imx,sensor-resource-id: A single integer for single thermal zone's > resource ID or > > + an array of integers to specify each thermal > zone's sensor > > + resource ID. > > Can't you put the resource ids in the thermal-sensor cells? Why do you need > to list them here? For the thermal-sensor cells, if you meant the argument of tsens phandle, then the reason is that argument is for sensor index starting from 0, previous I use it for our resource ID, but it looks confused, since user will think there are many sensors there per Eduardo's comment. + thermal-sensors = <&tsens 0>; If you meant putting it in each thermal sensor node instead of "tsens" node, then in previous patch series, I put this " imx,sensor-resource-id " property in each thermal sensor node, but the thermal sensor nodes are parsed by common thermal framework, thermal driver will need to find the thermal zone node and go through every child node to get the resource id again, so Eduardo suggested to put it in our platform tsens node, that makes our thermal driver code much more simple. Thanks, Anson. > > Rob
On Wed, Feb 27, 2019 at 6:48 PM Anson Huang <anson.huang@nxp.com> wrote: > > Hi, Rob > > Best Regards! > Anson Huang > > > -----Original Message----- > > From: Rob Herring [mailto:robh@kernel.org] > > Sent: 2019年2月28日 7:55 > > To: Anson Huang <anson.huang@nxp.com> > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > > catalin.marinas@arm.com; will.deacon@arm.com; rui.zhang@intel.com; > > edubezval@gmail.com; daniel.lezcano@linaro.org; Aisheng Dong > > <aisheng.dong@nxp.com>; ulf.hansson@linaro.org; sboyd@kernel.org; > > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > > <andy.gross@linaro.org>; horms+renesas@verge.net.au; heiko@sntech.de; > > arnd@arndb.de; maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > marc.w.gonzalez@free.fr; olof@lixom.net; devicetree@vger.kernel.org; > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal binding > > > > On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang wrote: > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > > > controller, the system controller is in charge of system power, clock > > > and thermal sensors etc. management, Linux kernel has to communicate > > > with system controller via MU (message unit) IPC to get temperature > > > from thermal sensors, this patch adds binding doc for i.MX system > > > controller thermal driver. > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > --- > > > Changes since V9: > > > - change #thermal-sensor-cells value in example to 1, since there are > > other > > > thermal sensors inside system controller, it is just because there are > > still > > > some issue, so system controller does NOT expose them for now, > > they could > > > be exposed later, so it should be 1 from HW perspective. > > > --- > > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 21 > > +++++++++++++++++++++ > > > 1 file changed, 21 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > index 72d481c..855270b 100644 > > > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > @@ -122,6 +122,21 @@ RTC bindings based on SCU Message Protocol > > > Required properties: > > > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > > > +Thermal bindings based on SCU Message Protocol > > > +------------------------------------------------------------ > > > + > > > +Required properties: > > > +- compatible: Should be : > > > + "fsl,imx8qxp-sc-thermal" > > > + followed by "fsl,imx-sc-thermal"; > > > + > > > +- #thermal-sensor-cells: See > > Documentation/devicetree/bindings/thermal/thermal.txt > > > + for a description. > > > + > > > +- imx,sensor-resource-id: A single integer for single thermal zone's > > resource ID or > > > + an array of integers to specify each thermal > > zone's sensor > > > + resource ID. > > > > Can't you put the resource ids in the thermal-sensor cells? Why do you need > > to list them here? > > For the thermal-sensor cells, if you meant the argument of tsens phandle, then > the reason is that argument is for sensor index starting from 0, previous I use > it for our resource ID, but it looks confused, since user will think there are many > sensors there per Eduardo's comment. > > + thermal-sensors = <&tsens 0>; > > If you meant putting it in each thermal sensor node instead of "tsens" node, then > in previous patch series, I put this " imx,sensor-resource-id " property in each thermal > sensor node, but the thermal sensor nodes are parsed by common thermal framework, > thermal driver will need to find the thermal zone node and go through every child node > to get the resource id again, so Eduardo suggested to put it in our platform tsens node, that makes > our thermal driver code much more simple. The phandle args are meant to be an id typically. There's absolutely no requirement they are 0-N based. They often are because things like interrupts are 0-N or clocks have no h/w id. If you already have an id, use it. Don't invent your own. Rob
Hi, Rob/Eduardo Best Regards! Anson Huang > -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: 2019年2月28日 22:49 > To: Anson Huang <anson.huang@nxp.com> > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > catalin.marinas@arm.com; will.deacon@arm.com; rui.zhang@intel.com; > edubezval@gmail.com; daniel.lezcano@linaro.org; Aisheng Dong > <aisheng.dong@nxp.com>; ulf.hansson@linaro.org; sboyd@kernel.org; > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > <andy.gross@linaro.org>; horms+renesas@verge.net.au; heiko@sntech.de; > arnd@arndb.de; maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > marc.w.gonzalez@free.fr; olof@lixom.net; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal binding > > On Wed, Feb 27, 2019 at 6:48 PM Anson Huang <anson.huang@nxp.com> > wrote: > > > > Hi, Rob > > > > Best Regards! > > Anson Huang > > > > > -----Original Message----- > > > From: Rob Herring [mailto:robh@kernel.org] > > > Sent: 2019年2月28日 7:55 > > > To: Anson Huang <anson.huang@nxp.com> > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > > > catalin.marinas@arm.com; will.deacon@arm.com; rui.zhang@intel.com; > > > edubezval@gmail.com; daniel.lezcano@linaro.org; Aisheng Dong > > > <aisheng.dong@nxp.com>; ulf.hansson@linaro.org; sboyd@kernel.org; > > > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > > > <andy.gross@linaro.org>; horms+renesas@verge.net.au; > > > heiko@sntech.de; arnd@arndb.de; maxime.ripard@bootlin.com; > > > bjorn.andersson@linaro.org; jagan@amarulasolutions.com; > > > enric.balletbo@collabora.com; marc.w.gonzalez@free.fr; > > > olof@lixom.net; devicetree@vger.kernel.org; > > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > binding > > > > > > On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang wrote: > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > > > > system controller, the system controller is in charge of system > > > > power, clock and thermal sensors etc. management, Linux kernel has > > > > to communicate with system controller via MU (message unit) IPC to > > > > get temperature from thermal sensors, this patch adds binding doc > > > > for i.MX system controller thermal driver. > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > --- > > > > Changes since V9: > > > > - change #thermal-sensor-cells value in example to 1, since > > > > there are > > > other > > > > thermal sensors inside system controller, it is just because > > > > there are > > > still > > > > some issue, so system controller does NOT expose them for > > > > now, > > > they could > > > > be exposed later, so it should be 1 from HW perspective. > > > > --- > > > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 21 > > > +++++++++++++++++++++ > > > > 1 file changed, 21 insertions(+) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > index 72d481c..855270b 100644 > > > > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > @@ -122,6 +122,21 @@ RTC bindings based on SCU Message Protocol > > > > Required properties: > > > > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > > > > > +Thermal bindings based on SCU Message Protocol > > > > +------------------------------------------------------------ > > > > + > > > > +Required properties: > > > > +- compatible: Should be : > > > > + "fsl,imx8qxp-sc-thermal" > > > > + followed by "fsl,imx-sc-thermal"; > > > > + > > > > +- #thermal-sensor-cells: See > > > Documentation/devicetree/bindings/thermal/thermal.txt > > > > + for a description. > > > > + > > > > +- imx,sensor-resource-id: A single integer for single thermal > > > > +zone's > > > resource ID or > > > > + an array of integers to specify each > > > > + thermal > > > zone's sensor > > > > + resource ID. > > > > > > Can't you put the resource ids in the thermal-sensor cells? Why do > > > you need to list them here? > > > > For the thermal-sensor cells, if you meant the argument of tsens > > phandle, then the reason is that argument is for sensor index starting > > from 0, previous I use it for our resource ID, but it looks confused, > > since user will think there are many sensors there per Eduardo's comment. > > > > + thermal-sensors = <&tsens 0>; > > > > If you meant putting it in each thermal sensor node instead of "tsens" > > node, then in previous patch series, I put this " > > imx,sensor-resource-id " property in each thermal sensor node, but the > > thermal sensor nodes are parsed by common thermal framework, thermal > > driver will need to find the thermal zone node and go through every > > child node to get the resource id again, so Eduardo suggested to put it in > our platform tsens node, that makes our thermal driver code much more > simple. > > The phandle args are meant to be an id typically. There's absolutely no > requirement they are 0-N based. They often are because things like > interrupts are 0-N or clocks have no h/w id. If you already have an id, use it. > Don't invent your own. At the beginning, I put the HW resource ID in the "tsens" phandle argument of "thermal-sensors" node, see below patch I sent before, the benefit is I do NOT need to add new property for passing HW resource ID to driver, the disadvantage is, I have to parse the thermal_zones' each child node and get the HW resource ID from phandle argument(searing thermal_zones node and go through all its child node, and get the phandle argument), they are by default ONLY parsed by thermal core driver. When we register thermal zone, we have to pass the HW resource ID when calling devm_thermal_zone_of_sensor_register(), if we add our own property to pass the HW resource ID, then no need to do so, we just pass the index 0-N for each thermal sensors in devicetree which also with phandle argument 0-N. So using our own property makes the driver much more simple. So, @Eduardo, which direction I should go? Looks like Rob suggests just put the HW resource ID in the phandle argument like what I did at the beginning, can you advise? Thanks, Anson. https://patchwork.kernel.org/patch/10703849/ > + thermal_zones: thermal-zones { > + cpu-thermal0 { > + polling-delay-passive = <250>; > + polling-delay = <2000>; > + thermal-sensors = <&tsens 355>; > + trips { > + cpu_alert0: trip0 { > + temperature = <107000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > > Rob
Ping... Hi, Eduardo Looks like we are going around in circle, can we make decision of which direction to go? Best Regards! Anson Huang > -----Original Message----- > From: Anson Huang > Sent: 2019年3月1日 9:41 > To: 'Rob Herring' <robh@kernel.org>; edubezval@gmail.com > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > catalin.marinas@arm.com; will.deacon@arm.com; rui.zhang@intel.com; > edubezval@gmail.com; daniel.lezcano@linaro.org; Aisheng Dong > <aisheng.dong@nxp.com>; ulf.hansson@linaro.org; sboyd@kernel.org; > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > <andy.gross@linaro.org>; horms+renesas@verge.net.au; heiko@sntech.de; > arnd@arndb.de; maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > marc.w.gonzalez@free.fr; olof@lixom.net; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal binding > > Hi, Rob/Eduardo > > Best Regards! > Anson Huang > > > -----Original Message----- > > From: Rob Herring [mailto:robh@kernel.org] > > Sent: 2019年2月28日 22:49 > > To: Anson Huang <anson.huang@nxp.com> > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > s.hauer@pengutronix.de; > > kernel@pengutronix.de; festevam@gmail.com; catalin.marinas@arm.com; > > will.deacon@arm.com; rui.zhang@intel.com; edubezval@gmail.com; > > daniel.lezcano@linaro.org; Aisheng Dong <aisheng.dong@nxp.com>; > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > > <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > marc.w.gonzalez@free.fr; olof@lixom.net; devicetree@vger.kernel.org; > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > binding > > > > On Wed, Feb 27, 2019 at 6:48 PM Anson Huang <anson.huang@nxp.com> > > wrote: > > > > > > Hi, Rob > > > > > > Best Regards! > > > Anson Huang > > > > > > > -----Original Message----- > > > > From: Rob Herring [mailto:robh@kernel.org] > > > > Sent: 2019年2月28日 7:55 > > > > To: Anson Huang <anson.huang@nxp.com> > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > s.hauer@pengutronix.de; kernel@pengutronix.de; > festevam@gmail.com; > > > > catalin.marinas@arm.com; will.deacon@arm.com; > rui.zhang@intel.com; > > > > edubezval@gmail.com; daniel.lezcano@linaro.org; Aisheng Dong > > > > <aisheng.dong@nxp.com>; ulf.hansson@linaro.org; sboyd@kernel.org; > > > > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > > > > <andy.gross@linaro.org>; horms+renesas@verge.net.au; > > > > heiko@sntech.de; arnd@arndb.de; maxime.ripard@bootlin.com; > > > > bjorn.andersson@linaro.org; jagan@amarulasolutions.com; > > > > enric.balletbo@collabora.com; marc.w.gonzalez@free.fr; > > > > olof@lixom.net; devicetree@vger.kernel.org; > > > > linux-kernel@vger.kernel.org; > > > > linux-arm-kernel@lists.infradead.org; > > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > > binding > > > > > > > > On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang wrote: > > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > > > > > system controller, the system controller is in charge of system > > > > > power, clock and thermal sensors etc. management, Linux kernel > > > > > has to communicate with system controller via MU (message unit) > > > > > IPC to get temperature from thermal sensors, this patch adds > > > > > binding doc for i.MX system controller thermal driver. > > > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > > --- > > > > > Changes since V9: > > > > > - change #thermal-sensor-cells value in example to 1, since > > > > > there are > > > > other > > > > > thermal sensors inside system controller, it is just > > > > > because there are > > > > still > > > > > some issue, so system controller does NOT expose them for > > > > > now, > > > > they could > > > > > be exposed later, so it should be 1 from HW perspective. > > > > > --- > > > > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 21 > > > > +++++++++++++++++++++ > > > > > 1 file changed, 21 insertions(+) > > > > > > > > > > diff --git > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > > index 72d481c..855270b 100644 > > > > > --- > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.tx > > > > > +++ t > > > > > @@ -122,6 +122,21 @@ RTC bindings based on SCU Message > Protocol > > > > > Required properties: > > > > > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > > > > > > > +Thermal bindings based on SCU Message Protocol > > > > > +------------------------------------------------------------ > > > > > + > > > > > +Required properties: > > > > > +- compatible: Should be : > > > > > + "fsl,imx8qxp-sc-thermal" > > > > > + followed by "fsl,imx-sc-thermal"; > > > > > + > > > > > +- #thermal-sensor-cells: See > > > > Documentation/devicetree/bindings/thermal/thermal.txt > > > > > + for a description. > > > > > + > > > > > +- imx,sensor-resource-id: A single integer for single thermal > > > > > +zone's > > > > resource ID or > > > > > + an array of integers to specify each > > > > > + thermal > > > > zone's sensor > > > > > + resource ID. > > > > > > > > Can't you put the resource ids in the thermal-sensor cells? Why do > > > > you need to list them here? > > > > > > For the thermal-sensor cells, if you meant the argument of tsens > > > phandle, then the reason is that argument is for sensor index > > > starting from 0, previous I use it for our resource ID, but it looks > > > confused, since user will think there are many sensors there per > Eduardo's comment. > > > > > > + thermal-sensors = <&tsens 0>; > > > > > > If you meant putting it in each thermal sensor node instead of "tsens" > > > node, then in previous patch series, I put this " > > > imx,sensor-resource-id " property in each thermal sensor node, but > > > the thermal sensor nodes are parsed by common thermal framework, > > > thermal driver will need to find the thermal zone node and go > > > through every child node to get the resource id again, so Eduardo > > > suggested to put it in > > our platform tsens node, that makes our thermal driver code much more > > simple. > > > > The phandle args are meant to be an id typically. There's absolutely > > no requirement they are 0-N based. They often are because things like > > interrupts are 0-N or clocks have no h/w id. If you already have an id, use it. > > Don't invent your own. > > At the beginning, I put the HW resource ID in the "tsens" phandle argument > of "thermal-sensors" node, see below patch I sent before, the benefit is I do > NOT need to add new property for passing HW resource ID to driver, the > disadvantage is, I have to parse the thermal_zones' each child node and get > the HW resource ID from phandle argument(searing thermal_zones node > and go through all its child node, and get the phandle argument), they are by > default ONLY parsed by thermal core driver. When we register thermal zone, > we have to pass the HW resource ID when calling > devm_thermal_zone_of_sensor_register(), if we add our own property to > pass the HW resource ID, then no need to do so, we just pass the index 0-N > for each thermal sensors in devicetree which also with phandle argument 0- > N. So using our own property makes the driver much more simple. > > So, @Eduardo, which direction I should go? Looks like Rob suggests just put > the HW resource ID in the phandle argument like what I did at the beginning, > can you advise? > > Thanks, > Anson. > > https://patchwork.kernel.org/patch/10703849/ > > + thermal_zones: thermal-zones { > > + cpu-thermal0 { > > + polling-delay-passive = <250>; > > + polling-delay = <2000>; > > + thermal-sensors = <&tsens 355>; > > + trips { > > + cpu_alert0: trip0 { > > + temperature = <107000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > > > > Rob
[...] > > > > > diff --git > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > > index 72d481c..855270b 100644 > > > > > --- > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.tx > > > > > +++ t > > > > > @@ -122,6 +122,21 @@ RTC bindings based on SCU Message Protocol > > > > > Required properties: > > > > > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > > > > > > > +Thermal bindings based on SCU Message Protocol > > > > > +------------------------------------------------------------ > > > > > + > > > > > +Required properties: > > > > > +- compatible: Should be : > > > > > + "fsl,imx8qxp-sc-thermal" > > > > > + followed by "fsl,imx-sc-thermal"; > > > > > + > > > > > +- #thermal-sensor-cells: See > > > > Documentation/devicetree/bindings/thermal/thermal.txt > > > > > + for a description. > > > > > + > > > > > +- imx,sensor-resource-id: A single integer for single thermal > > > > > +zone's > > > > resource ID or > > > > > + an array of integers to specify each > > > > > + thermal > > > > zone's sensor > > > > > + resource ID. > > > > > > > > Can't you put the resource ids in the thermal-sensor cells? Why do > > > > you need to list them here? > > > > > > For the thermal-sensor cells, if you meant the argument of tsens > > > phandle, then the reason is that argument is for sensor index > > > starting from 0, previous I use it for our resource ID, but it looks > > > confused, since user will think there are many sensors there per Eduardo's > comment. > > > > > > + thermal-sensors = <&tsens 0>; > > > > > > If you meant putting it in each thermal sensor node instead of "tsens" > > > node, then in previous patch series, I put this " > > > imx,sensor-resource-id " property in each thermal sensor node, but > > > the thermal sensor nodes are parsed by common thermal framework, > > > thermal driver will need to find the thermal zone node and go > > > through every child node to get the resource id again, so Eduardo > > > suggested to put it in > > our platform tsens node, that makes our thermal driver code much more > > simple. > > > > The phandle args are meant to be an id typically. There's absolutely > > no requirement they are 0-N based. They often are because things like > > interrupts are 0-N or clocks have no h/w id. If you already have an id, use it. > > Don't invent your own. > > At the beginning, I put the HW resource ID in the "tsens" phandle argument of > "thermal-sensors" node, see below patch I sent before, the benefit is I do > NOT need to add new property for passing HW resource ID to driver, the > disadvantage is, I have to parse the thermal_zones' each child node and get the > HW resource ID from phandle argument(searing thermal_zones node and go > through all its child node, and get the phandle argument), they are by default > ONLY parsed by thermal core driver. When we register thermal zone, we have > to pass the HW resource ID when calling > devm_thermal_zone_of_sensor_register(), if we add our own property to pass > the HW resource ID, then no need to do so, we just pass the index 0-N for each > thermal sensors in devicetree which also with phandle argument 0-N. So using > our own property makes the driver much more simple. > > So, @Eduardo, which direction I should go? Looks like Rob suggests just put > the HW resource ID in the phandle argument like what I did at the beginning, > can you advise? > I prefer to Rob suggested way that directly use resource id for thermal-sensor cells. For SW implementation, we can either parse the sensor resource id from device tree or statically define it in driver. Parsing from DT could make the driver more generic and do not need change for the number Of sensor changes in furture SoCs which probably is better. One more suggestion is please list all supported sensors in binding doc to avoid confusing. Regards Dong Aisheng > Thanks, > Anson. > > https://patchwork.kernel.org/patch/10703849/ > > + thermal_zones: thermal-zones { > > + cpu-thermal0 { > > + polling-delay-passive = <250>; > > + polling-delay = <2000>; > > + thermal-sensors = <&tsens 355>; > > + trips { > > + cpu_alert0: trip0 { > > + temperature = <107000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > > > > Rob
Ping... Hi, Eduardo Can you take a look at this thread? Thanks. Best Regards! Anson Huang > -----Original Message----- > From: Anson Huang > Sent: 2019年3月6日 13:27 > To: 'Rob Herring' <robh@kernel.org>; 'edubezval@gmail.com' > <edubezval@gmail.com> > Cc: 'mark.rutland@arm.com' <mark.rutland@arm.com>; > 'shawnguo@kernel.org' <shawnguo@kernel.org>; 's.hauer@pengutronix.de' > <s.hauer@pengutronix.de>; 'kernel@pengutronix.de' > <kernel@pengutronix.de>; 'festevam@gmail.com' <festevam@gmail.com>; > 'catalin.marinas@arm.com' <catalin.marinas@arm.com>; > 'will.deacon@arm.com' <will.deacon@arm.com>; 'rui.zhang@intel.com' > <rui.zhang@intel.com>; 'edubezval@gmail.com' <edubezval@gmail.com>; > 'daniel.lezcano@linaro.org' <daniel.lezcano@linaro.org>; Aisheng Dong > <aisheng.dong@nxp.com>; 'ulf.hansson@linaro.org' > <ulf.hansson@linaro.org>; 'sboyd@kernel.org' <sboyd@kernel.org>; Daniel > Baluta <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > 'horms+renesas@verge.net.au' <horms+renesas@verge.net.au>; > 'heiko@sntech.de' <heiko@sntech.de>; 'arnd@arndb.de' <arnd@arndb.de>; > 'maxime.ripard@bootlin.com' <maxime.ripard@bootlin.com>; > 'bjorn.andersson@linaro.org' <bjorn.andersson@linaro.org>; > 'jagan@amarulasolutions.com' <jagan@amarulasolutions.com>; > 'enric.balletbo@collabora.com' <enric.balletbo@collabora.com>; > 'marc.w.gonzalez@free.fr' <marc.w.gonzalez@free.fr>; 'olof@lixom.net' > <olof@lixom.net>; 'devicetree@vger.kernel.org' > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' <linux- > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' <linux-arm- > kernel@lists.infradead.org>; 'linux-pm@vger.kernel.org' <linux- > pm@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com> > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal binding > > Ping... > > Hi, Eduardo > Looks like we are going around in circle, can we make decision of > which direction to go? > > Best Regards! > Anson Huang > > > -----Original Message----- > > From: Anson Huang > > Sent: 2019年3月1日 9:41 > > To: 'Rob Herring' <robh@kernel.org>; edubezval@gmail.com > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > s.hauer@pengutronix.de; > > kernel@pengutronix.de; festevam@gmail.com; catalin.marinas@arm.com; > > will.deacon@arm.com; rui.zhang@intel.com; edubezval@gmail.com; > > daniel.lezcano@linaro.org; Aisheng Dong <aisheng.dong@nxp.com>; > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > > <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > marc.w.gonzalez@free.fr; olof@lixom.net; devicetree@vger.kernel.org; > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > binding > > > > Hi, Rob/Eduardo > > > > Best Regards! > > Anson Huang > > > > > -----Original Message----- > > > From: Rob Herring [mailto:robh@kernel.org] > > > Sent: 2019年2月28日 22:49 > > > To: Anson Huang <anson.huang@nxp.com> > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > s.hauer@pengutronix.de; > > > kernel@pengutronix.de; festevam@gmail.com; > catalin.marinas@arm.com; > > > will.deacon@arm.com; rui.zhang@intel.com; edubezval@gmail.com; > > > daniel.lezcano@linaro.org; Aisheng Dong <aisheng.dong@nxp.com>; > > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > > > <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > > marc.w.gonzalez@free.fr; olof@lixom.net; devicetree@vger.kernel.org; > > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > binding > > > > > > On Wed, Feb 27, 2019 at 6:48 PM Anson Huang <anson.huang@nxp.com> > > > wrote: > > > > > > > > Hi, Rob > > > > > > > > Best Regards! > > > > Anson Huang > > > > > > > > > -----Original Message----- > > > > > From: Rob Herring [mailto:robh@kernel.org] > > > > > Sent: 2019年2月28日 7:55 > > > > > To: Anson Huang <anson.huang@nxp.com> > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > > s.hauer@pengutronix.de; kernel@pengutronix.de; > > festevam@gmail.com; > > > > > catalin.marinas@arm.com; will.deacon@arm.com; > > rui.zhang@intel.com; > > > > > edubezval@gmail.com; daniel.lezcano@linaro.org; Aisheng Dong > > > > > <aisheng.dong@nxp.com>; ulf.hansson@linaro.org; > > > > > sboyd@kernel.org; Daniel Baluta <daniel.baluta@nxp.com>; Andy > > > > > Gross <andy.gross@linaro.org>; horms+renesas@verge.net.au; > > > > > heiko@sntech.de; arnd@arndb.de; maxime.ripard@bootlin.com; > > > > > bjorn.andersson@linaro.org; jagan@amarulasolutions.com; > > > > > enric.balletbo@collabora.com; marc.w.gonzalez@free.fr; > > > > > olof@lixom.net; devicetree@vger.kernel.org; > > > > > linux-kernel@vger.kernel.org; > > > > > linux-arm-kernel@lists.infradead.org; > > > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > > > binding > > > > > > > > > > On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang wrote: > > > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > > > > > > system controller, the system controller is in charge of > > > > > > system power, clock and thermal sensors etc. management, Linux > > > > > > kernel has to communicate with system controller via MU > > > > > > (message unit) IPC to get temperature from thermal sensors, > > > > > > this patch adds binding doc for i.MX system controller thermal > driver. > > > > > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > > > --- > > > > > > Changes since V9: > > > > > > - change #thermal-sensor-cells value in example to 1, > > > > > > since there are > > > > > other > > > > > > thermal sensors inside system controller, it is just > > > > > > because there are > > > > > still > > > > > > some issue, so system controller does NOT expose them > > > > > > for now, > > > > > they could > > > > > > be exposed later, so it should be 1 from HW perspective. > > > > > > --- > > > > > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 21 > > > > > +++++++++++++++++++++ > > > > > > 1 file changed, 21 insertions(+) > > > > > > > > > > > > diff --git > > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > > > index 72d481c..855270b 100644 > > > > > > --- > > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > > > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu. > > > > > > +++ tx > > > > > > +++ t > > > > > > @@ -122,6 +122,21 @@ RTC bindings based on SCU Message > > Protocol > > > > > > Required properties: > > > > > > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > > > > > > > > > +Thermal bindings based on SCU Message Protocol > > > > > > +------------------------------------------------------------ > > > > > > + > > > > > > +Required properties: > > > > > > +- compatible: Should be : > > > > > > + "fsl,imx8qxp-sc-thermal" > > > > > > + followed by "fsl,imx-sc-thermal"; > > > > > > + > > > > > > +- #thermal-sensor-cells: See > > > > > Documentation/devicetree/bindings/thermal/thermal.txt > > > > > > + for a description. > > > > > > + > > > > > > +- imx,sensor-resource-id: A single integer for single > > > > > > +thermal zone's > > > > > resource ID or > > > > > > + an array of integers to specify > > > > > > + each thermal > > > > > zone's sensor > > > > > > + resource ID. > > > > > > > > > > Can't you put the resource ids in the thermal-sensor cells? Why > > > > > do you need to list them here? > > > > > > > > For the thermal-sensor cells, if you meant the argument of tsens > > > > phandle, then the reason is that argument is for sensor index > > > > starting from 0, previous I use it for our resource ID, but it > > > > looks confused, since user will think there are many sensors there > > > > per > > Eduardo's comment. > > > > > > > > + thermal-sensors = <&tsens 0>; > > > > > > > > If you meant putting it in each thermal sensor node instead of "tsens" > > > > node, then in previous patch series, I put this " > > > > imx,sensor-resource-id " property in each thermal sensor node, but > > > > the thermal sensor nodes are parsed by common thermal framework, > > > > thermal driver will need to find the thermal zone node and go > > > > through every child node to get the resource id again, so Eduardo > > > > suggested to put it in > > > our platform tsens node, that makes our thermal driver code much > > > more simple. > > > > > > The phandle args are meant to be an id typically. There's absolutely > > > no requirement they are 0-N based. They often are because things > > > like interrupts are 0-N or clocks have no h/w id. If you already have an id, > use it. > > > Don't invent your own. > > > > At the beginning, I put the HW resource ID in the "tsens" phandle > > argument of "thermal-sensors" node, see below patch I sent before, > > the benefit is I do NOT need to add new property for passing HW > > resource ID to driver, the disadvantage is, I have to parse the > > thermal_zones' each child node and get the HW resource ID from phandle > > argument(searing thermal_zones node and go through all its child node, > > and get the phandle argument), they are by default ONLY parsed by > > thermal core driver. When we register thermal zone, we have to pass > > the HW resource ID when calling > > devm_thermal_zone_of_sensor_register(), if we add our own property to > > pass the HW resource ID, then no need to do so, we just pass the index > > 0-N for each thermal sensors in devicetree which also with phandle > argument 0- N. So using our own property makes the driver much more > simple. > > > > So, @Eduardo, which direction I should go? Looks like Rob suggests > > just put the HW resource ID in the phandle argument like what I did at > > the beginning, can you advise? > > > > Thanks, > > Anson. > > > > https://patchwork.kernel.org/patch/10703849/ > > > + thermal_zones: thermal-zones { > > > + cpu-thermal0 { > > > + polling-delay-passive = <250>; > > > + polling-delay = <2000>; > > > + thermal-sensors = <&tsens 355>; > > > + trips { > > > + cpu_alert0: trip0 { > > > + temperature = <107000>; > > > + hysteresis = <2000>; > > > + type = "passive"; > > > + }; > > > > > > > > Rob
Ping... Hi, Eduardo What is your opinion about where to put the HW resource ID in DT? Best Regards! Anson Huang > -----Original Message----- > From: Anson Huang > Sent: 2019年3月13日 16:12 > To: 'Rob Herring' <robh@kernel.org>; 'edubezval@gmail.com' > <edubezval@gmail.com> > Cc: 'mark.rutland@arm.com' <mark.rutland@arm.com>; > 'shawnguo@kernel.org' <shawnguo@kernel.org>; 's.hauer@pengutronix.de' > <s.hauer@pengutronix.de>; 'kernel@pengutronix.de' > <kernel@pengutronix.de>; 'festevam@gmail.com' <festevam@gmail.com>; > 'catalin.marinas@arm.com' <catalin.marinas@arm.com>; > 'will.deacon@arm.com' <will.deacon@arm.com>; 'rui.zhang@intel.com' > <rui.zhang@intel.com>; 'edubezval@gmail.com' <edubezval@gmail.com>; > 'daniel.lezcano@linaro.org' <daniel.lezcano@linaro.org>; Aisheng Dong > <aisheng.dong@nxp.com>; 'ulf.hansson@linaro.org' > <ulf.hansson@linaro.org>; 'sboyd@kernel.org' <sboyd@kernel.org>; Daniel > Baluta <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > 'horms+renesas@verge.net.au' <horms+renesas@verge.net.au>; > 'heiko@sntech.de' <heiko@sntech.de>; 'arnd@arndb.de' <arnd@arndb.de>; > 'maxime.ripard@bootlin.com' <maxime.ripard@bootlin.com>; > 'bjorn.andersson@linaro.org' <bjorn.andersson@linaro.org>; > 'jagan@amarulasolutions.com' <jagan@amarulasolutions.com>; > 'enric.balletbo@collabora.com' <enric.balletbo@collabora.com>; > 'marc.w.gonzalez@free.fr' <marc.w.gonzalez@free.fr>; 'olof@lixom.net' > <olof@lixom.net>; 'devicetree@vger.kernel.org' > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' <linux- > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' <linux-arm- > kernel@lists.infradead.org>; 'linux-pm@vger.kernel.org' <linux- > pm@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com> > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal binding > > Ping... > Hi, Eduardo > Can you take a look at this thread? Thanks. > > > Best Regards! > Anson Huang > > > -----Original Message----- > > From: Anson Huang > > Sent: 2019年3月6日 13:27 > > To: 'Rob Herring' <robh@kernel.org>; 'edubezval@gmail.com' > > <edubezval@gmail.com> > > Cc: 'mark.rutland@arm.com' <mark.rutland@arm.com>; > > 'shawnguo@kernel.org' <shawnguo@kernel.org>; > 's.hauer@pengutronix.de' > > <s.hauer@pengutronix.de>; 'kernel@pengutronix.de' > > <kernel@pengutronix.de>; 'festevam@gmail.com' <festevam@gmail.com>; > > 'catalin.marinas@arm.com' <catalin.marinas@arm.com>; > > 'will.deacon@arm.com' <will.deacon@arm.com>; 'rui.zhang@intel.com' > > <rui.zhang@intel.com>; 'edubezval@gmail.com' <edubezval@gmail.com>; > > 'daniel.lezcano@linaro.org' <daniel.lezcano@linaro.org>; Aisheng Dong > > <aisheng.dong@nxp.com>; 'ulf.hansson@linaro.org' > > <ulf.hansson@linaro.org>; 'sboyd@kernel.org' <sboyd@kernel.org>; > > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > > <andy.gross@linaro.org>; 'horms+renesas@verge.net.au' > > <horms+renesas@verge.net.au>; 'heiko@sntech.de' <heiko@sntech.de>; > > 'arnd@arndb.de' <arnd@arndb.de>; 'maxime.ripard@bootlin.com' > > <maxime.ripard@bootlin.com>; 'bjorn.andersson@linaro.org' > > <bjorn.andersson@linaro.org>; 'jagan@amarulasolutions.com' > > <jagan@amarulasolutions.com>; 'enric.balletbo@collabora.com' > > <enric.balletbo@collabora.com>; 'marc.w.gonzalez@free.fr' > <marc.w.gonzalez@free.fr>; 'olof@lixom.net' > > <olof@lixom.net>; 'devicetree@vger.kernel.org' > > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' <linux- > > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' > > <linux-arm- kernel@lists.infradead.org>; 'linux-pm@vger.kernel.org' > > <linux- pm@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com> > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > binding > > > > Ping... > > > > Hi, Eduardo > > Looks like we are going around in circle, can we make decision of > > which direction to go? > > > > Best Regards! > > Anson Huang > > > > > -----Original Message----- > > > From: Anson Huang > > > Sent: 2019年3月1日 9:41 > > > To: 'Rob Herring' <robh@kernel.org>; edubezval@gmail.com > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > s.hauer@pengutronix.de; > > > kernel@pengutronix.de; festevam@gmail.com; > catalin.marinas@arm.com; > > > will.deacon@arm.com; rui.zhang@intel.com; edubezval@gmail.com; > > > daniel.lezcano@linaro.org; Aisheng Dong <aisheng.dong@nxp.com>; > > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > > > <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > > marc.w.gonzalez@free.fr; olof@lixom.net; devicetree@vger.kernel.org; > > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > binding > > > > > > Hi, Rob/Eduardo > > > > > > Best Regards! > > > Anson Huang > > > > > > > -----Original Message----- > > > > From: Rob Herring [mailto:robh@kernel.org] > > > > Sent: 2019年2月28日 22:49 > > > > To: Anson Huang <anson.huang@nxp.com> > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > s.hauer@pengutronix.de; > > > > kernel@pengutronix.de; festevam@gmail.com; > > catalin.marinas@arm.com; > > > > will.deacon@arm.com; rui.zhang@intel.com; edubezval@gmail.com; > > > > daniel.lezcano@linaro.org; Aisheng Dong <aisheng.dong@nxp.com>; > > > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > > > > <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > > > marc.w.gonzalez@free.fr; olof@lixom.net; > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > linux-arm-kernel@lists.infradead.org; > > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > > binding > > > > > > > > On Wed, Feb 27, 2019 at 6:48 PM Anson Huang > <anson.huang@nxp.com> > > > > wrote: > > > > > > > > > > Hi, Rob > > > > > > > > > > Best Regards! > > > > > Anson Huang > > > > > > > > > > > -----Original Message----- > > > > > > From: Rob Herring [mailto:robh@kernel.org] > > > > > > Sent: 2019年2月28日 7:55 > > > > > > To: Anson Huang <anson.huang@nxp.com> > > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > > > s.hauer@pengutronix.de; kernel@pengutronix.de; > > > festevam@gmail.com; > > > > > > catalin.marinas@arm.com; will.deacon@arm.com; > > > rui.zhang@intel.com; > > > > > > edubezval@gmail.com; daniel.lezcano@linaro.org; Aisheng Dong > > > > > > <aisheng.dong@nxp.com>; ulf.hansson@linaro.org; > > > > > > sboyd@kernel.org; Daniel Baluta <daniel.baluta@nxp.com>; Andy > > > > > > Gross <andy.gross@linaro.org>; horms+renesas@verge.net.au; > > > > > > heiko@sntech.de; arnd@arndb.de; maxime.ripard@bootlin.com; > > > > > > bjorn.andersson@linaro.org; jagan@amarulasolutions.com; > > > > > > enric.balletbo@collabora.com; marc.w.gonzalez@free.fr; > > > > > > olof@lixom.net; devicetree@vger.kernel.org; > > > > > > linux-kernel@vger.kernel.org; > > > > > > linux-arm-kernel@lists.infradead.org; > > > > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add > > > > > > thermal binding > > > > > > > > > > > > On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang wrote: > > > > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > > > > > > > system controller, the system controller is in charge of > > > > > > > system power, clock and thermal sensors etc. management, > > > > > > > Linux kernel has to communicate with system controller via > > > > > > > MU (message unit) IPC to get temperature from thermal > > > > > > > sensors, this patch adds binding doc for i.MX system > > > > > > > controller thermal > > driver. > > > > > > > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > > > > --- > > > > > > > Changes since V9: > > > > > > > - change #thermal-sensor-cells value in example to 1, > > > > > > > since there are > > > > > > other > > > > > > > thermal sensors inside system controller, it is just > > > > > > > because there are > > > > > > still > > > > > > > some issue, so system controller does NOT expose them > > > > > > > for now, > > > > > > they could > > > > > > > be exposed later, so it should be 1 from HW perspective. > > > > > > > --- > > > > > > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 21 > > > > > > +++++++++++++++++++++ > > > > > > > 1 file changed, 21 insertions(+) > > > > > > > > > > > > > > diff --git > > > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.tx > > > > > > > t > > > > > > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.tx > > > > > > > t index 72d481c..855270b 100644 > > > > > > > --- > > > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.tx > > > > > > > t > > > > > > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu. > > > > > > > +++ tx > > > > > > > +++ t > > > > > > > @@ -122,6 +122,21 @@ RTC bindings based on SCU Message > > > Protocol > > > > > > > Required properties: > > > > > > > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > > > > > > > > > > > +Thermal bindings based on SCU Message Protocol > > > > > > > +----------------------------------------------------------- > > > > > > > +- > > > > > > > + > > > > > > > +Required properties: > > > > > > > +- compatible: Should be : > > > > > > > + "fsl,imx8qxp-sc-thermal" > > > > > > > + followed by > > > > > > > +"fsl,imx-sc-thermal"; > > > > > > > + > > > > > > > +- #thermal-sensor-cells: See > > > > > > Documentation/devicetree/bindings/thermal/thermal.txt > > > > > > > + for a description. > > > > > > > + > > > > > > > +- imx,sensor-resource-id: A single integer for single > > > > > > > +thermal zone's > > > > > > resource ID or > > > > > > > + an array of integers to specify > > > > > > > + each thermal > > > > > > zone's sensor > > > > > > > + resource ID. > > > > > > > > > > > > Can't you put the resource ids in the thermal-sensor cells? > > > > > > Why do you need to list them here? > > > > > > > > > > For the thermal-sensor cells, if you meant the argument of tsens > > > > > phandle, then the reason is that argument is for sensor index > > > > > starting from 0, previous I use it for our resource ID, but it > > > > > looks confused, since user will think there are many sensors > > > > > there per > > > Eduardo's comment. > > > > > > > > > > + thermal-sensors = <&tsens 0>; > > > > > > > > > > If you meant putting it in each thermal sensor node instead of "tsens" > > > > > node, then in previous patch series, I put this " > > > > > imx,sensor-resource-id " property in each thermal sensor node, > > > > > but the thermal sensor nodes are parsed by common thermal > > > > > framework, thermal driver will need to find the thermal zone > > > > > node and go through every child node to get the resource id > > > > > again, so Eduardo suggested to put it in > > > > our platform tsens node, that makes our thermal driver code much > > > > more simple. > > > > > > > > The phandle args are meant to be an id typically. There's > > > > absolutely no requirement they are 0-N based. They often are > > > > because things like interrupts are 0-N or clocks have no h/w id. > > > > If you already have an id, > > use it. > > > > Don't invent your own. > > > > > > At the beginning, I put the HW resource ID in the "tsens" phandle > > > argument of "thermal-sensors" node, see below patch I sent before, > > > the benefit is I do NOT need to add new property for passing HW > > > resource ID to driver, the disadvantage is, I have to parse the > > > thermal_zones' each child node and get the HW resource ID from > > > phandle argument(searing thermal_zones node and go through all its > > > child node, and get the phandle argument), they are by default ONLY > > > parsed by thermal core driver. When we register thermal zone, we > > > have to pass the HW resource ID when calling > > > devm_thermal_zone_of_sensor_register(), if we add our own property > > > to pass the HW resource ID, then no need to do so, we just pass the > > > index 0-N for each thermal sensors in devicetree which also with > > > phandle > > argument 0- N. So using our own property makes the driver much more > > simple. > > > > > > So, @Eduardo, which direction I should go? Looks like Rob suggests > > > just put the HW resource ID in the phandle argument like what I did > > > at the beginning, can you advise? > > > > > > Thanks, > > > Anson. > > > > > > https://patchwork.kernel.org/patch/10703849/ > > > > + thermal_zones: thermal-zones { > > > > + cpu-thermal0 { > > > > + polling-delay-passive = <250>; > > > > + polling-delay = <2000>; > > > > + thermal-sensors = <&tsens 355>; > > > > + trips { > > > > + cpu_alert0: trip0 { > > > > + temperature = <107000>; > > > > + hysteresis = <2000>; > > > > + type = "passive"; > > > > + }; > > > > > > > > > > > Rob
Ping... Can anyone provide some suggestion about how to proceed next? Best Regards! Anson Huang > -----Original Message----- > From: Anson Huang > Sent: 2019年3月26日 10:45 > To: 'Rob Herring' <robh@kernel.org>; 'edubezval@gmail.com' > <edubezval@gmail.com> > Cc: 'mark.rutland@arm.com' <mark.rutland@arm.com>; > 'shawnguo@kernel.org' <shawnguo@kernel.org>; 's.hauer@pengutronix.de' > <s.hauer@pengutronix.de>; 'kernel@pengutronix.de' > <kernel@pengutronix.de>; 'festevam@gmail.com' <festevam@gmail.com>; > 'catalin.marinas@arm.com' <catalin.marinas@arm.com>; > 'will.deacon@arm.com' <will.deacon@arm.com>; 'rui.zhang@intel.com' > <rui.zhang@intel.com>; 'edubezval@gmail.com' <edubezval@gmail.com>; > 'daniel.lezcano@linaro.org' <daniel.lezcano@linaro.org>; Aisheng Dong > <aisheng.dong@nxp.com>; 'ulf.hansson@linaro.org' > <ulf.hansson@linaro.org>; 'sboyd@kernel.org' <sboyd@kernel.org>; Daniel > Baluta <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > 'horms+renesas@verge.net.au' <horms+renesas@verge.net.au>; > 'heiko@sntech.de' <heiko@sntech.de>; 'arnd@arndb.de' <arnd@arndb.de>; > 'maxime.ripard@bootlin.com' <maxime.ripard@bootlin.com>; > 'bjorn.andersson@linaro.org' <bjorn.andersson@linaro.org>; > 'jagan@amarulasolutions.com' <jagan@amarulasolutions.com>; > 'enric.balletbo@collabora.com' <enric.balletbo@collabora.com>; > 'marc.w.gonzalez@free.fr' <marc.w.gonzalez@free.fr>; 'olof@lixom.net' > <olof@lixom.net>; 'devicetree@vger.kernel.org' > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' <linux- > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' <linux-arm- > kernel@lists.infradead.org>; 'linux-pm@vger.kernel.org' <linux- > pm@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com> > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal binding > > Ping... > > Hi, Eduardo > What is your opinion about where to put the HW resource ID in DT? > > Best Regards! > Anson Huang > > > -----Original Message----- > > From: Anson Huang > > Sent: 2019年3月13日 16:12 > > To: 'Rob Herring' <robh@kernel.org>; 'edubezval@gmail.com' > > <edubezval@gmail.com> > > Cc: 'mark.rutland@arm.com' <mark.rutland@arm.com>; > > 'shawnguo@kernel.org' <shawnguo@kernel.org>; > 's.hauer@pengutronix.de' > > <s.hauer@pengutronix.de>; 'kernel@pengutronix.de' > > <kernel@pengutronix.de>; 'festevam@gmail.com' <festevam@gmail.com>; > > 'catalin.marinas@arm.com' <catalin.marinas@arm.com>; > > 'will.deacon@arm.com' <will.deacon@arm.com>; 'rui.zhang@intel.com' > > <rui.zhang@intel.com>; 'edubezval@gmail.com' <edubezval@gmail.com>; > > 'daniel.lezcano@linaro.org' <daniel.lezcano@linaro.org>; Aisheng Dong > > <aisheng.dong@nxp.com>; 'ulf.hansson@linaro.org' > > <ulf.hansson@linaro.org>; 'sboyd@kernel.org' <sboyd@kernel.org>; > > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > > <andy.gross@linaro.org>; 'horms+renesas@verge.net.au' > > <horms+renesas@verge.net.au>; 'heiko@sntech.de' <heiko@sntech.de>; > > 'arnd@arndb.de' <arnd@arndb.de>; 'maxime.ripard@bootlin.com' > > <maxime.ripard@bootlin.com>; 'bjorn.andersson@linaro.org' > > <bjorn.andersson@linaro.org>; 'jagan@amarulasolutions.com' > > <jagan@amarulasolutions.com>; 'enric.balletbo@collabora.com' > > <enric.balletbo@collabora.com>; 'marc.w.gonzalez@free.fr' > <marc.w.gonzalez@free.fr>; 'olof@lixom.net' > > <olof@lixom.net>; 'devicetree@vger.kernel.org' > > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' <linux- > > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' > > <linux-arm- kernel@lists.infradead.org>; 'linux-pm@vger.kernel.org' > > <linux- pm@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com> > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > binding > > > > Ping... > > Hi, Eduardo > > Can you take a look at this thread? Thanks. > > > > > > Best Regards! > > Anson Huang > > > > > -----Original Message----- > > > From: Anson Huang > > > Sent: 2019年3月6日 13:27 > > > To: 'Rob Herring' <robh@kernel.org>; 'edubezval@gmail.com' > > > <edubezval@gmail.com> > > > Cc: 'mark.rutland@arm.com' <mark.rutland@arm.com>; > > > 'shawnguo@kernel.org' <shawnguo@kernel.org>; > > 's.hauer@pengutronix.de' > > > <s.hauer@pengutronix.de>; 'kernel@pengutronix.de' > > > <kernel@pengutronix.de>; 'festevam@gmail.com' > <festevam@gmail.com>; > > > 'catalin.marinas@arm.com' <catalin.marinas@arm.com>; > > > 'will.deacon@arm.com' <will.deacon@arm.com>; 'rui.zhang@intel.com' > > > <rui.zhang@intel.com>; 'edubezval@gmail.com' > <edubezval@gmail.com>; > > > 'daniel.lezcano@linaro.org' <daniel.lezcano@linaro.org>; Aisheng > > > Dong <aisheng.dong@nxp.com>; 'ulf.hansson@linaro.org' > > > <ulf.hansson@linaro.org>; 'sboyd@kernel.org' <sboyd@kernel.org>; > > > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > > > <andy.gross@linaro.org>; 'horms+renesas@verge.net.au' > > > <horms+renesas@verge.net.au>; 'heiko@sntech.de' <heiko@sntech.de>; > > > 'arnd@arndb.de' <arnd@arndb.de>; 'maxime.ripard@bootlin.com' > > > <maxime.ripard@bootlin.com>; 'bjorn.andersson@linaro.org' > > > <bjorn.andersson@linaro.org>; 'jagan@amarulasolutions.com' > > > <jagan@amarulasolutions.com>; 'enric.balletbo@collabora.com' > > > <enric.balletbo@collabora.com>; 'marc.w.gonzalez@free.fr' > > <marc.w.gonzalez@free.fr>; 'olof@lixom.net' > > > <olof@lixom.net>; 'devicetree@vger.kernel.org' > > > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' <linux- > > > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' > > > <linux-arm- kernel@lists.infradead.org>; 'linux-pm@vger.kernel.org' > > > <linux- pm@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com> > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > binding > > > > > > Ping... > > > > > > Hi, Eduardo > > > Looks like we are going around in circle, can we make decision of > > > which direction to go? > > > > > > Best Regards! > > > Anson Huang > > > > > > > -----Original Message----- > > > > From: Anson Huang > > > > Sent: 2019年3月1日 9:41 > > > > To: 'Rob Herring' <robh@kernel.org>; edubezval@gmail.com > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > s.hauer@pengutronix.de; > > > > kernel@pengutronix.de; festevam@gmail.com; > > catalin.marinas@arm.com; > > > > will.deacon@arm.com; rui.zhang@intel.com; edubezval@gmail.com; > > > > daniel.lezcano@linaro.org; Aisheng Dong <aisheng.dong@nxp.com>; > > > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > > > > <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > > > marc.w.gonzalez@free.fr; olof@lixom.net; > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > linux-arm-kernel@lists.infradead.org; > > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > > binding > > > > > > > > Hi, Rob/Eduardo > > > > > > > > Best Regards! > > > > Anson Huang > > > > > > > > > -----Original Message----- > > > > > From: Rob Herring [mailto:robh@kernel.org] > > > > > Sent: 2019年2月28日 22:49 > > > > > To: Anson Huang <anson.huang@nxp.com> > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > s.hauer@pengutronix.de; > > > > > kernel@pengutronix.de; festevam@gmail.com; > > > catalin.marinas@arm.com; > > > > > will.deacon@arm.com; rui.zhang@intel.com; edubezval@gmail.com; > > > > > daniel.lezcano@linaro.org; Aisheng Dong <aisheng.dong@nxp.com>; > > > > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > > > > > <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > > > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > > > > marc.w.gonzalez@free.fr; olof@lixom.net; > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > > linux-arm-kernel@lists.infradead.org; > > > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > > > binding > > > > > > > > > > On Wed, Feb 27, 2019 at 6:48 PM Anson Huang > > <anson.huang@nxp.com> > > > > > wrote: > > > > > > > > > > > > Hi, Rob > > > > > > > > > > > > Best Regards! > > > > > > Anson Huang > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Rob Herring [mailto:robh@kernel.org] > > > > > > > Sent: 2019年2月28日 7:55 > > > > > > > To: Anson Huang <anson.huang@nxp.com> > > > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > > > > s.hauer@pengutronix.de; kernel@pengutronix.de; > > > > festevam@gmail.com; > > > > > > > catalin.marinas@arm.com; will.deacon@arm.com; > > > > rui.zhang@intel.com; > > > > > > > edubezval@gmail.com; daniel.lezcano@linaro.org; Aisheng Dong > > > > > > > <aisheng.dong@nxp.com>; ulf.hansson@linaro.org; > > > > > > > sboyd@kernel.org; Daniel Baluta <daniel.baluta@nxp.com>; > > > > > > > Andy Gross <andy.gross@linaro.org>; > > > > > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > > > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > > > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > > > > > > marc.w.gonzalez@free.fr; olof@lixom.net; > > > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > > > > linux-arm-kernel@lists.infradead.org; > > > > > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > > > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add > > > > > > > thermal binding > > > > > > > > > > > > > > On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang wrote: > > > > > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside > > > > > > > > as system controller, the system controller is in charge > > > > > > > > of system power, clock and thermal sensors etc. > > > > > > > > management, Linux kernel has to communicate with system > > > > > > > > controller via MU (message unit) IPC to get temperature > > > > > > > > from thermal sensors, this patch adds binding doc for i.MX > > > > > > > > system controller thermal > > > driver. > > > > > > > > > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > > > > > --- > > > > > > > > Changes since V9: > > > > > > > > - change #thermal-sensor-cells value in example to 1, > > > > > > > > since there are > > > > > > > other > > > > > > > > thermal sensors inside system controller, it is just > > > > > > > > because there are > > > > > > > still > > > > > > > > some issue, so system controller does NOT expose > > > > > > > > them for now, > > > > > > > they could > > > > > > > > be exposed later, so it should be 1 from HW perspective. > > > > > > > > --- > > > > > > > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 21 > > > > > > > +++++++++++++++++++++ > > > > > > > > 1 file changed, 21 insertions(+) > > > > > > > > > > > > > > > > diff --git > > > > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu. > > > > > > > > tx > > > > > > > > t > > > > > > > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu. > > > > > > > > tx t index 72d481c..855270b 100644 > > > > > > > > --- > > > > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu. > > > > > > > > tx > > > > > > > > t > > > > > > > > +++ > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu. > > > > > > > > +++ tx > > > > > > > > +++ t > > > > > > > > @@ -122,6 +122,21 @@ RTC bindings based on SCU Message > > > > Protocol > > > > > > > > Required properties: > > > > > > > > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > > > > > > > > > > > > > +Thermal bindings based on SCU Message Protocol > > > > > > > > +--------------------------------------------------------- > > > > > > > > +-- > > > > > > > > +- > > > > > > > > + > > > > > > > > +Required properties: > > > > > > > > +- compatible: Should be : > > > > > > > > + "fsl,imx8qxp-sc-thermal" > > > > > > > > + followed by > > > > > > > > +"fsl,imx-sc-thermal"; > > > > > > > > + > > > > > > > > +- #thermal-sensor-cells: See > > > > > > > Documentation/devicetree/bindings/thermal/thermal.txt > > > > > > > > + for a description. > > > > > > > > + > > > > > > > > +- imx,sensor-resource-id: A single integer for single > > > > > > > > +thermal zone's > > > > > > > resource ID or > > > > > > > > + an array of integers to > > > > > > > > + specify each thermal > > > > > > > zone's sensor > > > > > > > > + resource ID. > > > > > > > > > > > > > > Can't you put the resource ids in the thermal-sensor cells? > > > > > > > Why do you need to list them here? > > > > > > > > > > > > For the thermal-sensor cells, if you meant the argument of > > > > > > tsens phandle, then the reason is that argument is for sensor > > > > > > index starting from 0, previous I use it for our resource ID, > > > > > > but it looks confused, since user will think there are many > > > > > > sensors there per > > > > Eduardo's comment. > > > > > > > > > > > > + thermal-sensors = <&tsens 0>; > > > > > > > > > > > > If you meant putting it in each thermal sensor node instead of > "tsens" > > > > > > node, then in previous patch series, I put this " > > > > > > imx,sensor-resource-id " property in each thermal sensor node, > > > > > > but the thermal sensor nodes are parsed by common thermal > > > > > > framework, thermal driver will need to find the thermal zone > > > > > > node and go through every child node to get the resource id > > > > > > again, so Eduardo suggested to put it in > > > > > our platform tsens node, that makes our thermal driver code much > > > > > more simple. > > > > > > > > > > The phandle args are meant to be an id typically. There's > > > > > absolutely no requirement they are 0-N based. They often are > > > > > because things like interrupts are 0-N or clocks have no h/w id. > > > > > If you already have an id, > > > use it. > > > > > Don't invent your own. > > > > > > > > At the beginning, I put the HW resource ID in the "tsens" phandle > > > > argument of "thermal-sensors" node, see below patch I sent > > > > before, the benefit is I do NOT need to add new property for > > > > passing HW resource ID to driver, the disadvantage is, I have to > > > > parse the thermal_zones' each child node and get the HW resource > > > > ID from phandle argument(searing thermal_zones node and go through > > > > all its child node, and get the phandle argument), they are by > > > > default ONLY parsed by thermal core driver. When we register > > > > thermal zone, we have to pass the HW resource ID when calling > > > > devm_thermal_zone_of_sensor_register(), if we add our own property > > > > to pass the HW resource ID, then no need to do so, we just pass > > > > the index 0-N for each thermal sensors in devicetree which also > > > > with phandle > > > argument 0- N. So using our own property makes the driver much more > > > simple. > > > > > > > > So, @Eduardo, which direction I should go? Looks like Rob suggests > > > > just put the HW resource ID in the phandle argument like what I > > > > did at the beginning, can you advise? > > > > > > > > Thanks, > > > > Anson. > > > > > > > > https://patchwork.kernel.org/patch/10703849/ > > > > > + thermal_zones: thermal-zones { > > > > > + cpu-thermal0 { > > > > > + polling-delay-passive = <250>; > > > > > + polling-delay = <2000>; > > > > > + thermal-sensors = <&tsens 355>; > > > > > + trips { > > > > > + cpu_alert0: trip0 { > > > > > + temperature = <107000>; > > > > > + hysteresis = <2000>; > > > > > + type = "passive"; > > > > > + }; > > > > > > > > > > > > > > Rob
On 二, 2019-04-09 at 05:28 +0000, Anson Huang wrote: > Ping... > Can anyone provide some suggestion about how to proceed next? > Hi, Eduardo, I guess you will comment on this patch, right? Or else I will take the patch following Rob' suggestion. thanks, rui > Best Regards! > Anson Huang > > > > > -----Original Message----- > > From: Anson Huang > > Sent: 2019年3月26日 10:45 > > To: 'Rob Herring' <robh@kernel.org>; 'edubezval@gmail.com' > > <edubezval@gmail.com> > > Cc: 'mark.rutland@arm.com' <mark.rutland@arm.com>; > > 'shawnguo@kernel.org' <shawnguo@kernel.org>; 's.hauer@pengutronix.d > > e' > > <s.hauer@pengutronix.de>; 'kernel@pengutronix.de' > > <kernel@pengutronix.de>; 'festevam@gmail.com' <festevam@gmail.com>; > > 'catalin.marinas@arm.com' <catalin.marinas@arm.com>; > > 'will.deacon@arm.com' <will.deacon@arm.com>; 'rui.zhang@intel.com' > > <rui.zhang@intel.com>; 'edubezval@gmail.com' <edubezval@gmail.com>; > > 'daniel.lezcano@linaro.org' <daniel.lezcano@linaro.org>; Aisheng > > Dong > > <aisheng.dong@nxp.com>; 'ulf.hansson@linaro.org' > > <ulf.hansson@linaro.org>; 'sboyd@kernel.org' <sboyd@kernel.org>; > > Daniel > > Baluta <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > > 'horms+renesas@verge.net.au' <horms+renesas@verge.net.au>; > > 'heiko@sntech.de' <heiko@sntech.de>; 'arnd@arndb.de' <arnd@arndb.de > > >; > > 'maxime.ripard@bootlin.com' <maxime.ripard@bootlin.com>; > > 'bjorn.andersson@linaro.org' <bjorn.andersson@linaro.org>; > > 'jagan@amarulasolutions.com' <jagan@amarulasolutions.com>; > > 'enric.balletbo@collabora.com' <enric.balletbo@collabora.com>; > > 'marc.w.gonzalez@free.fr' <marc.w.gonzalez@free.fr>; 'olof@lixom.ne > > t' > > <olof@lixom.net>; 'devicetree@vger.kernel.org' > > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' > > <linux- > > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' > > <linux-arm- > > kernel@lists.infradead.org>; 'linux-pm@vger.kernel.org' <linux- > > pm@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com> > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > binding > > > > Ping... > > > > Hi, Eduardo > > What is your opinion about where to put the HW resource ID in > > DT? > > > > Best Regards! > > Anson Huang > > > > > > > > -----Original Message----- > > > From: Anson Huang > > > Sent: 2019年3月13日 16:12 > > > To: 'Rob Herring' <robh@kernel.org>; 'edubezval@gmail.com' > > > <edubezval@gmail.com> > > > Cc: 'mark.rutland@arm.com' <mark.rutland@arm.com>; > > > 'shawnguo@kernel.org' <shawnguo@kernel.org>; > > 's.hauer@pengutronix.de' > > > > > > <s.hauer@pengutronix.de>; 'kernel@pengutronix.de' > > > <kernel@pengutronix.de>; 'festevam@gmail.com' <festevam@gmail.com > > > >; > > > 'catalin.marinas@arm.com' <catalin.marinas@arm.com>; > > > 'will.deacon@arm.com' <will.deacon@arm.com>; 'rui.zhang@intel.com > > > ' > > > <rui.zhang@intel.com>; 'edubezval@gmail.com' <edubezval@gmail.com > > > >; > > > 'daniel.lezcano@linaro.org' <daniel.lezcano@linaro.org>; Aisheng > > > Dong > > > <aisheng.dong@nxp.com>; 'ulf.hansson@linaro.org' > > > <ulf.hansson@linaro.org>; 'sboyd@kernel.org' <sboyd@kernel.org>; > > > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > > > <andy.gross@linaro.org>; 'horms+renesas@verge.net.au' > > > <horms+renesas@verge.net.au>; 'heiko@sntech.de' <heiko@sntech.de> > > > ; > > > 'arnd@arndb.de' <arnd@arndb.de>; 'maxime.ripard@bootlin.com' > > > <maxime.ripard@bootlin.com>; 'bjorn.andersson@linaro.org' > > > <bjorn.andersson@linaro.org>; 'jagan@amarulasolutions.com' > > > <jagan@amarulasolutions.com>; 'enric.balletbo@collabora.com' > > > <enric.balletbo@collabora.com>; 'marc.w.gonzalez@free.fr' > > <marc.w.gonzalez@free.fr>; 'olof@lixom.net' > > > > > > <olof@lixom.net>; 'devicetree@vger.kernel.org' > > > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' > > > <linux- > > > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' > > > <linux-arm- kernel@lists.infradead.org>; 'linux-pm@vger.kernel.or > > > g' > > > <linux- pm@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com> > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > binding > > > > > > Ping... > > > Hi, Eduardo > > > Can you take a look at this thread? Thanks. > > > > > > > > > Best Regards! > > > Anson Huang > > > > > > > > > > > -----Original Message----- > > > > From: Anson Huang > > > > Sent: 2019年3月6日 13:27 > > > > To: 'Rob Herring' <robh@kernel.org>; 'edubezval@gmail.com' > > > > <edubezval@gmail.com> > > > > Cc: 'mark.rutland@arm.com' <mark.rutland@arm.com>; > > > > 'shawnguo@kernel.org' <shawnguo@kernel.org>; > > > 's.hauer@pengutronix.de' > > > > > > > > <s.hauer@pengutronix.de>; 'kernel@pengutronix.de' > > > > <kernel@pengutronix.de>; 'festevam@gmail.com' > > <festevam@gmail.com>; > > > > > > > > > > > 'catalin.marinas@arm.com' <catalin.marinas@arm.com>; > > > > 'will.deacon@arm.com' <will.deacon@arm.com>; 'rui.zhang@intel.c > > > > om' > > > > <rui.zhang@intel.com>; 'edubezval@gmail.com' > > <edubezval@gmail.com>; > > > > > > > > > > > 'daniel.lezcano@linaro.org' <daniel.lezcano@linaro.org>; > > > > Aisheng > > > > Dong <aisheng.dong@nxp.com>; 'ulf.hansson@linaro.org' > > > > <ulf.hansson@linaro.org>; 'sboyd@kernel.org' <sboyd@kernel.org> > > > > ; > > > > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > > > > <andy.gross@linaro.org>; 'horms+renesas@verge.net.au' > > > > <horms+renesas@verge.net.au>; 'heiko@sntech.de' <heiko@sntech.d > > > > e>; > > > > 'arnd@arndb.de' <arnd@arndb.de>; 'maxime.ripard@bootlin.com' > > > > <maxime.ripard@bootlin.com>; 'bjorn.andersson@linaro.org' > > > > <bjorn.andersson@linaro.org>; 'jagan@amarulasolutions.com' > > > > <jagan@amarulasolutions.com>; 'enric.balletbo@collabora.com' > > > > <enric.balletbo@collabora.com>; 'marc.w.gonzalez@free.fr' > > > <marc.w.gonzalez@free.fr>; 'olof@lixom.net' > > > > > > > > <olof@lixom.net>; 'devicetree@vger.kernel.org' > > > > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' > > > > <linux- > > > > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' > > > > <linux-arm- kernel@lists.infradead.org>; 'linux-pm@vger.kernel. > > > > org' > > > > <linux- pm@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com> > > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > > binding > > > > > > > > Ping... > > > > > > > > Hi, Eduardo > > > > Looks like we are going around in circle, can we make > > > > decision of > > > > which direction to go? > > > > > > > > Best Regards! > > > > Anson Huang > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Anson Huang > > > > > Sent: 2019年3月1日 9:41 > > > > > To: 'Rob Herring' <robh@kernel.org>; edubezval@gmail.com > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > s.hauer@pengutronix.de; > > > > > > > > > > kernel@pengutronix.de; festevam@gmail.com; > > > catalin.marinas@arm.com; > > > > > > > > > > > > > > will.deacon@arm.com; rui.zhang@intel.com; edubezval@gmail.com > > > > > ; > > > > > daniel.lezcano@linaro.org; Aisheng Dong <aisheng.dong@nxp.com > > > > > >; > > > > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > > > > > <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > > > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > > > > marc.w.gonzalez@free.fr; olof@lixom.net; > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > > linux-arm-kernel@lists.infradead.org; > > > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add > > > > > thermal > > > > > binding > > > > > > > > > > Hi, Rob/Eduardo > > > > > > > > > > Best Regards! > > > > > Anson Huang > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Rob Herring [mailto:robh@kernel.org] > > > > > > Sent: 2019年2月28日 22:49 > > > > > > To: Anson Huang <anson.huang@nxp.com> > > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > > s.hauer@pengutronix.de; > > > > > > > > > > > > kernel@pengutronix.de; festevam@gmail.com; > > > > catalin.marinas@arm.com; > > > > > > > > > > > > > > > > > will.deacon@arm.com; rui.zhang@intel.com; edubezval@gmail.c > > > > > > om; > > > > > > daniel.lezcano@linaro.org; Aisheng Dong <aisheng.dong@nxp.c > > > > > > om>; > > > > > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > > > > > > <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org> > > > > > > ; > > > > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > > > > > marc.w.gonzalez@free.fr; olof@lixom.net; > > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > > > linux-arm-kernel@lists.infradead.org; > > > > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add > > > > > > thermal > > > > > > binding > > > > > > > > > > > > On Wed, Feb 27, 2019 at 6:48 PM Anson Huang > > > <anson.huang@nxp.com> > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Hi, Rob > > > > > > > > > > > > > > Best Regards! > > > > > > > Anson Huang > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Rob Herring [mailto:robh@kernel.org] > > > > > > > > Sent: 2019年2月28日 7:55 > > > > > > > > To: Anson Huang <anson.huang@nxp.com> > > > > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > > > > > s.hauer@pengutronix.de; kernel@pengutronix.de; > > > > > festevam@gmail.com; > > > > > > > > > > > > > > > > > > > > > > > > > > > > > catalin.marinas@arm.com; will.deacon@arm.com; > > > > > rui.zhang@intel.com; > > > > > > > > > > > > > > > > > > > > > > > > > > > > > edubezval@gmail.com; daniel.lezcano@linaro.org; Aisheng > > > > > > > > Dong > > > > > > > > <aisheng.dong@nxp.com>; ulf.hansson@linaro.org; > > > > > > > > sboyd@kernel.org; Daniel Baluta <daniel.baluta@nxp.com> > > > > > > > > ; > > > > > > > > Andy Gross <andy.gross@linaro.org>; > > > > > > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb > > > > > > > > .de; > > > > > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > > > > > jagan@amarulasolutions.com; enric.balletbo@collabora.co > > > > > > > > m; > > > > > > > > marc.w.gonzalez@free.fr; olof@lixom.net; > > > > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.or > > > > > > > > g; > > > > > > > > linux-arm-kernel@lists.infradead.org; > > > > > > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp. > > > > > > > > com> > > > > > > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add > > > > > > > > thermal binding > > > > > > > > > > > > > > > > On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core > > > > > > > > > inside > > > > > > > > > as system controller, the system controller is in > > > > > > > > > charge > > > > > > > > > of system power, clock and thermal sensors etc. > > > > > > > > > management, Linux kernel has to communicate with > > > > > > > > > system > > > > > > > > > controller via MU (message unit) IPC to get > > > > > > > > > temperature > > > > > > > > > from thermal sensors, this patch adds binding doc for > > > > > > > > > i.MX > > > > > > > > > system controller thermal > > > > driver. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > > > > > > --- > > > > > > > > > Changes since V9: > > > > > > > > > - change #thermal-sensor-cells value in example > > > > > > > > > to 1, > > > > > > > > > since there are > > > > > > > > other > > > > > > > > > > > > > > > > > > thermal sensors inside system controller, it is > > > > > > > > > just > > > > > > > > > because there are > > > > > > > > still > > > > > > > > > > > > > > > > > > some issue, so system controller does NOT > > > > > > > > > expose > > > > > > > > > them for now, > > > > > > > > they could > > > > > > > > > > > > > > > > > > be exposed later, so it should be 1 from HW > > > > > > > > > perspective. > > > > > > > > > --- > > > > > > > > > .../devicetree/bindings/arm/freescale/fsl,scu.txt > > > > > > > > > | 21 > > > > > > > > +++++++++++++++++++++ > > > > > > > > > > > > > > > > > > 1 file changed, 21 insertions(+) > > > > > > > > > > > > > > > > > > diff --git > > > > > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl > > > > > > > > > ,scu. > > > > > > > > > tx > > > > > > > > > t > > > > > > > > > b/Documentation/devicetree/bindings/arm/freescale/fsl > > > > > > > > > ,scu. > > > > > > > > > tx t index 72d481c..855270b 100644 > > > > > > > > > --- > > > > > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl > > > > > > > > > ,scu. > > > > > > > > > tx > > > > > > > > > t > > > > > > > > > +++ > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > +++ tx > > > > > > > > > +++ t > > > > > > > > > @@ -122,6 +122,21 @@ RTC bindings based on SCU > > > > > > > > > Message > > > > > Protocol > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Required properties: > > > > > > > > > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > > > > > > > > > > > > > > > +Thermal bindings based on SCU Message Protocol > > > > > > > > > +-------------------------------------------------- > > > > > > > > > ------- > > > > > > > > > +-- > > > > > > > > > +- > > > > > > > > > + > > > > > > > > > +Required properties: > > > > > > > > > +- compatible: Should be : > > > > > > > > > + "fsl,imx8qxp-sc- > > > > > > > > > thermal" > > > > > > > > > + followed by > > > > > > > > > +"fsl,imx-sc-thermal"; > > > > > > > > > + > > > > > > > > > +- #thermal-sensor-cells: See > > > > > > > > Documentation/devicetree/bindings/thermal/thermal.txt > > > > > > > > > > > > > > > > > > + for a description. > > > > > > > > > + > > > > > > > > > +- imx,sensor-resource-id: A single integer for > > > > > > > > > single > > > > > > > > > +thermal zone's > > > > > > > > resource ID or > > > > > > > > > > > > > > > > > > + an array of integers to > > > > > > > > > + specify each thermal > > > > > > > > zone's sensor > > > > > > > > > > > > > > > > > > + resource ID. > > > > > > > > Can't you put the resource ids in the thermal-sensor > > > > > > > > cells? > > > > > > > > Why do you need to list them here? > > > > > > > For the thermal-sensor cells, if you meant the argument > > > > > > > of > > > > > > > tsens phandle, then the reason is that argument is for > > > > > > > sensor > > > > > > > index starting from 0, previous I use it for our resource > > > > > > > ID, > > > > > > > but it looks confused, since user will think there are > > > > > > > many > > > > > > > sensors there per > > > > > Eduardo's comment. > > > > > > > > > > > > > > > > > > > > > > > > > > > + thermal-sensors = <&tsens 0>; > > > > > > > > > > > > > > If you meant putting it in each thermal sensor node > > > > > > > instead of > > "tsens" > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > node, then in previous patch series, I put this " > > > > > > > imx,sensor-resource-id " property in each thermal sensor > > > > > > > node, > > > > > > > but the thermal sensor nodes are parsed by common thermal > > > > > > > framework, thermal driver will need to find the thermal > > > > > > > zone > > > > > > > node and go through every child node to get the resource > > > > > > > id > > > > > > > again, so Eduardo suggested to put it in > > > > > > our platform tsens node, that makes our thermal driver code > > > > > > much > > > > > > more simple. > > > > > > > > > > > > The phandle args are meant to be an id typically. There's > > > > > > absolutely no requirement they are 0-N based. They often > > > > > > are > > > > > > because things like interrupts are 0-N or clocks have no > > > > > > h/w id. > > > > > > If you already have an id, > > > > use it. > > > > > > > > > > > > > > > > > Don't invent your own. > > > > > At the beginning, I put the HW resource ID in the "tsens" > > > > > phandle > > > > > argument of "thermal-sensors" node, see below patch I sent > > > > > before, the benefit is I do NOT need to add new property for > > > > > passing HW resource ID to driver, the disadvantage is, I have > > > > > to > > > > > parse the thermal_zones' each child node and get the HW > > > > > resource > > > > > ID from phandle argument(searing thermal_zones node and go > > > > > through > > > > > all its child node, and get the phandle argument), they are > > > > > by > > > > > default ONLY parsed by thermal core driver. When we register > > > > > thermal zone, we have to pass the HW resource ID when calling > > > > > devm_thermal_zone_of_sensor_register(), if we add our own > > > > > property > > > > > to pass the HW resource ID, then no need to do so, we just > > > > > pass > > > > > the index 0-N for each thermal sensors in devicetree which > > > > > also > > > > > with phandle > > > > argument 0- N. So using our own property makes the driver much > > > > more > > > > simple. > > > > > > > > > > > > > > > So, @Eduardo, which direction I should go? Looks like Rob > > > > > suggests > > > > > just put the HW resource ID in the phandle argument like what > > > > > I > > > > > did at the beginning, can you advise? > > > > > > > > > > Thanks, > > > > > Anson. > > > > > > > > > > https://patchwork.kernel.org/patch/10703849/ > > > > > > > > > > > > + thermal_zones: thermal-zones { > > > > > > + cpu-thermal0 { > > > > > > + polling-delay-passive = <250>; > > > > > > + polling-delay = <2000>; > > > > > > + thermal-sensors = <&tsens 355>; > > > > > > + trips { > > > > > > + cpu_alert0: trip0 { > > > > > > + temperature = > > > > > > <107000>; > > > > > > + hysteresis = > > > > > > <2000>; > > > > > > + type = "passive"; > > > > > > + }; > > > > > > > > > > > > > > > > > > Rob
Hi, Rui/Eduardo I just sent out a V11 patch series following Rob's suggestion, please help review it. So if the HW resource ID can be as phandle's argument, then go with V11 patch series, if it MUST be virtual ID starting from 0-N, then pick V10 patch series. Thanks for your time. Best Regards! Anson Huang > -----Original Message----- > From: Zhang Rui [mailto:rui.zhang@intel.com] > Sent: 2019年4月9日 15:29 > To: Anson Huang <anson.huang@nxp.com>; Rob Herring <robh@kernel.org>; > edubezval@gmail.com > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > catalin.marinas@arm.com; will.deacon@arm.com; > daniel.lezcano@linaro.org; Aisheng Dong <aisheng.dong@nxp.com>; > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > marc.w.gonzalez@free.fr; olof@lixom.net; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > Subject: [EXT] Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal binding > > WARNING: This email was created outside of NXP. DO NOT CLICK links or > attachments unless you recognize the sender and know the content is safe. > > > > On 二, 2019-04-09 at 05:28 +0000, Anson Huang wrote: > > Ping... > > Can anyone provide some suggestion about how to proceed next? > > > Hi, Eduardo, > > I guess you will comment on this patch, right? > Or else I will take the patch following Rob' suggestion. > > thanks, > rui > > > > Best Regards! > > Anson Huang > > > > > > > > -----Original Message----- > > > From: Anson Huang > > > Sent: 2019年3月26日 10:45 > > > To: 'Rob Herring' <robh@kernel.org>; 'edubezval@gmail.com' > > > <edubezval@gmail.com> > > > Cc: 'mark.rutland@arm.com' <mark.rutland@arm.com>; > > > 'shawnguo@kernel.org' <shawnguo@kernel.org>; > 's.hauer@pengutronix.d > > > e' > > > <s.hauer@pengutronix.de>; 'kernel@pengutronix.de' > > > <kernel@pengutronix.de>; 'festevam@gmail.com' > <festevam@gmail.com>; > > > 'catalin.marinas@arm.com' <catalin.marinas@arm.com>; > > > 'will.deacon@arm.com' <will.deacon@arm.com>; 'rui.zhang@intel.com' > > > <rui.zhang@intel.com>; 'edubezval@gmail.com' > <edubezval@gmail.com>; > > > 'daniel.lezcano@linaro.org' <daniel.lezcano@linaro.org>; Aisheng > > > Dong <aisheng.dong@nxp.com>; 'ulf.hansson@linaro.org' > > > <ulf.hansson@linaro.org>; 'sboyd@kernel.org' <sboyd@kernel.org>; > > > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > > > <andy.gross@linaro.org>; 'horms+renesas@verge.net.au' > > > <horms+renesas@verge.net.au>; 'heiko@sntech.de' <heiko@sntech.de>; > > > 'arnd@arndb.de' <arnd@arndb.de > > > >; > > > 'maxime.ripard@bootlin.com' <maxime.ripard@bootlin.com>; > > > 'bjorn.andersson@linaro.org' <bjorn.andersson@linaro.org>; > > > 'jagan@amarulasolutions.com' <jagan@amarulasolutions.com>; > > > 'enric.balletbo@collabora.com' <enric.balletbo@collabora.com>; > > > 'marc.w.gonzalez@free.fr' <marc.w.gonzalez@free.fr>; 'olof@lixom.ne > > > t' > > > <olof@lixom.net>; 'devicetree@vger.kernel.org' > > > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' > > > <linux- > > > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' > > > <linux-arm- > > > kernel@lists.infradead.org>; 'linux-pm@vger.kernel.org' <linux- > > > pm@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com> > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > binding > > > > > > Ping... > > > > > > Hi, Eduardo > > > What is your opinion about where to put the HW resource ID in > > > DT? > > > > > > Best Regards! > > > Anson Huang > > > > > > > > > > > -----Original Message----- > > > > From: Anson Huang > > > > Sent: 2019年3月13日 16:12 > > > > To: 'Rob Herring' <robh@kernel.org>; 'edubezval@gmail.com' > > > > <edubezval@gmail.com> > > > > Cc: 'mark.rutland@arm.com' <mark.rutland@arm.com>; > > > > 'shawnguo@kernel.org' <shawnguo@kernel.org>; > > > 's.hauer@pengutronix.de' > > > > > > > > <s.hauer@pengutronix.de>; 'kernel@pengutronix.de' > > > > <kernel@pengutronix.de>; 'festevam@gmail.com' > <festevam@gmail.com > > > > >; > > > > 'catalin.marinas@arm.com' <catalin.marinas@arm.com>; > > > > 'will.deacon@arm.com' <will.deacon@arm.com>; 'rui.zhang@intel.com > > > > ' > > > > <rui.zhang@intel.com>; 'edubezval@gmail.com' > <edubezval@gmail.com > > > > >; > > > > 'daniel.lezcano@linaro.org' <daniel.lezcano@linaro.org>; Aisheng > > > > Dong <aisheng.dong@nxp.com>; 'ulf.hansson@linaro.org' > > > > <ulf.hansson@linaro.org>; 'sboyd@kernel.org' <sboyd@kernel.org>; > > > > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > > > > <andy.gross@linaro.org>; 'horms+renesas@verge.net.au' > > > > <horms+renesas@verge.net.au>; 'heiko@sntech.de' <heiko@sntech.de> > > > > ; 'arnd@arndb.de' <arnd@arndb.de>; 'maxime.ripard@bootlin.com' > > > > <maxime.ripard@bootlin.com>; 'bjorn.andersson@linaro.org' > > > > <bjorn.andersson@linaro.org>; 'jagan@amarulasolutions.com' > > > > <jagan@amarulasolutions.com>; 'enric.balletbo@collabora.com' > > > > <enric.balletbo@collabora.com>; 'marc.w.gonzalez@free.fr' > > > <marc.w.gonzalez@free.fr>; 'olof@lixom.net' > > > > > > > > <olof@lixom.net>; 'devicetree@vger.kernel.org' > > > > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' > > > > <linux- > > > > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' > > > > <linux-arm- kernel@lists.infradead.org>; 'linux-pm@vger.kernel.or > > > > g' > > > > <linux- pm@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com> > > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > > binding > > > > > > > > Ping... > > > > Hi, Eduardo > > > > Can you take a look at this thread? Thanks. > > > > > > > > > > > > Best Regards! > > > > Anson Huang > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Anson Huang > > > > > Sent: 2019年3月6日 13:27 > > > > > To: 'Rob Herring' <robh@kernel.org>; 'edubezval@gmail.com' > > > > > <edubezval@gmail.com> > > > > > Cc: 'mark.rutland@arm.com' <mark.rutland@arm.com>; > > > > > 'shawnguo@kernel.org' <shawnguo@kernel.org>; > > > > 's.hauer@pengutronix.de' > > > > > > > > > > <s.hauer@pengutronix.de>; 'kernel@pengutronix.de' > > > > > <kernel@pengutronix.de>; 'festevam@gmail.com' > > > <festevam@gmail.com>; > > > > > > > > > > > > > > 'catalin.marinas@arm.com' <catalin.marinas@arm.com>; > > > > > 'will.deacon@arm.com' <will.deacon@arm.com>; 'rui.zhang@intel.c > > > > > om' > > > > > <rui.zhang@intel.com>; 'edubezval@gmail.com' > > > <edubezval@gmail.com>; > > > > > > > > > > > > > > 'daniel.lezcano@linaro.org' <daniel.lezcano@linaro.org>; Aisheng > > > > > Dong <aisheng.dong@nxp.com>; 'ulf.hansson@linaro.org' > > > > > <ulf.hansson@linaro.org>; 'sboyd@kernel.org' <sboyd@kernel.org> > > > > > ; Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > > > > > <andy.gross@linaro.org>; 'horms+renesas@verge.net.au' > > > > > <horms+renesas@verge.net.au>; 'heiko@sntech.de' > <heiko@sntech.d > > > > > e>; > > > > > 'arnd@arndb.de' <arnd@arndb.de>; 'maxime.ripard@bootlin.com' > > > > > <maxime.ripard@bootlin.com>; 'bjorn.andersson@linaro.org' > > > > > <bjorn.andersson@linaro.org>; 'jagan@amarulasolutions.com' > > > > > <jagan@amarulasolutions.com>; 'enric.balletbo@collabora.com' > > > > > <enric.balletbo@collabora.com>; 'marc.w.gonzalez@free.fr' > > > > <marc.w.gonzalez@free.fr>; 'olof@lixom.net' > > > > > > > > > > <olof@lixom.net>; 'devicetree@vger.kernel.org' > > > > > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' > > > > > <linux- > > > > > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' > > > > > <linux-arm- kernel@lists.infradead.org>; 'linux-pm@vger.kernel. > > > > > org' > > > > > <linux- pm@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com> > > > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > > > binding > > > > > > > > > > Ping... > > > > > > > > > > Hi, Eduardo > > > > > Looks like we are going around in circle, can we make > > > > > decision of which direction to go? > > > > > > > > > > Best Regards! > > > > > Anson Huang > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Anson Huang > > > > > > Sent: 2019年3月1日 9:41 > > > > > > To: 'Rob Herring' <robh@kernel.org>; edubezval@gmail.com > > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > > s.hauer@pengutronix.de; > > > > > > > > > > > > kernel@pengutronix.de; festevam@gmail.com; > > > > catalin.marinas@arm.com; > > > > > > > > > > > > > > > > > will.deacon@arm.com; rui.zhang@intel.com; edubezval@gmail.com > > > > > > ; daniel.lezcano@linaro.org; Aisheng Dong > > > > > > <aisheng.dong@nxp.com > > > > > > >; > > > > > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > > > > > > <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > > > > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > > > > > marc.w.gonzalez@free.fr; olof@lixom.net; > > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > > > linux-arm-kernel@lists.infradead.org; > > > > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add > > > > > > thermal binding > > > > > > > > > > > > Hi, Rob/Eduardo > > > > > > > > > > > > Best Regards! > > > > > > Anson Huang > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Rob Herring [mailto:robh@kernel.org] > > > > > > > Sent: 2019年2月28日 22:49 > > > > > > > To: Anson Huang <anson.huang@nxp.com> > > > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > > > s.hauer@pengutronix.de; > > > > > > > > > > > > > > kernel@pengutronix.de; festevam@gmail.com; > > > > > catalin.marinas@arm.com; > > > > > > > > > > > > > > > > > > > > will.deacon@arm.com; rui.zhang@intel.com; edubezval@gmail.c > > > > > > > om; daniel.lezcano@linaro.org; Aisheng Dong > > > > > > > <aisheng.dong@nxp.c > > > > > > > om>; > > > > > > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > > > > > > > <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org> > > > > > > > ; > > > > > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > > > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > > > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > > > > > > marc.w.gonzalez@free.fr; olof@lixom.net; > > > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > > > > linux-arm-kernel@lists.infradead.org; > > > > > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > > > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add > > > > > > > thermal binding > > > > > > > > > > > > > > On Wed, Feb 27, 2019 at 6:48 PM Anson Huang > > > > <anson.huang@nxp.com> > > > > > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > Hi, Rob > > > > > > > > > > > > > > > > Best Regards! > > > > > > > > Anson Huang > > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: Rob Herring [mailto:robh@kernel.org] > > > > > > > > > Sent: 2019年2月28日 7:55 > > > > > > > > > To: Anson Huang <anson.huang@nxp.com> > > > > > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > > > > > > s.hauer@pengutronix.de; kernel@pengutronix.de; > > > > > > festevam@gmail.com; > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > catalin.marinas@arm.com; will.deacon@arm.com; > > > > > > rui.zhang@intel.com; > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > edubezval@gmail.com; daniel.lezcano@linaro.org; Aisheng > > > > > > > > > Dong <aisheng.dong@nxp.com>; ulf.hansson@linaro.org; > > > > > > > > > sboyd@kernel.org; Daniel Baluta <daniel.baluta@nxp.com> > > > > > > > > > ; Andy Gross <andy.gross@linaro.org>; > > > > > > > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb > > > > > > > > > .de; > > > > > > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > > > > > > jagan@amarulasolutions.com; enric.balletbo@collabora.co > > > > > > > > > m; marc.w.gonzalez@free.fr; olof@lixom.net; > > > > > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.or > > > > > > > > > g; linux-arm-kernel@lists.infradead.org; > > > > > > > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp. > > > > > > > > > com> > > > > > > > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add > > > > > > > > > thermal binding > > > > > > > > > > > > > > > > > > On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core > > > > > > > > > > inside as system controller, the system controller is > > > > > > > > > > in charge of system power, clock and thermal sensors > > > > > > > > > > etc. > > > > > > > > > > management, Linux kernel has to communicate with > > > > > > > > > > system controller via MU (message unit) IPC to get > > > > > > > > > > temperature from thermal sensors, this patch adds > > > > > > > > > > binding doc for i.MX system controller thermal > > > > > driver. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > > > > > > > --- > > > > > > > > > > Changes since V9: > > > > > > > > > > - change #thermal-sensor-cells value in example to > > > > > > > > > > 1, since there are > > > > > > > > > other > > > > > > > > > > > > > > > > > > > > thermal sensors inside system controller, it is > > > > > > > > > > just because there are > > > > > > > > > still > > > > > > > > > > > > > > > > > > > > some issue, so system controller does NOT expose > > > > > > > > > > them for now, > > > > > > > > > they could > > > > > > > > > > > > > > > > > > > > be exposed later, so it should be 1 from HW > > > > > > > > > > perspective. > > > > > > > > > > --- > > > > > > > > > > .../devicetree/bindings/arm/freescale/fsl,scu.txt > > > > > > > > > > | 21 > > > > > > > > > +++++++++++++++++++++ > > > > > > > > > > > > > > > > > > > > 1 file changed, 21 insertions(+) > > > > > > > > > > > > > > > > > > > > diff --git > > > > > > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl > > > > > > > > > > ,scu. > > > > > > > > > > tx > > > > > > > > > > t > > > > > > > > > > b/Documentation/devicetree/bindings/arm/freescale/fsl > > > > > > > > > > ,scu. > > > > > > > > > > tx t index 72d481c..855270b 100644 > > > > > > > > > > --- > > > > > > > > > > a/Documentation/devicetree/bindings/arm/freescale/fsl > > > > > > > > > > ,scu. > > > > > > > > > > tx > > > > > > > > > > t > > > > > > > > > > +++ > > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > +++ tx > > > > > > > > > > +++ t > > > > > > > > > > @@ -122,6 +122,21 @@ RTC bindings based on SCU Message > > > > > > Protocol > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Required properties: > > > > > > > > > > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > > > > > > > > > > > > > > > > > +Thermal bindings based on SCU Message Protocol > > > > > > > > > > +-------------------------------------------------- > > > > > > > > > > ------- > > > > > > > > > > +-- > > > > > > > > > > +- > > > > > > > > > > + > > > > > > > > > > +Required properties: > > > > > > > > > > +- compatible: Should be : > > > > > > > > > > + "fsl,imx8qxp-sc- > > > > > > > > > > thermal" > > > > > > > > > > + followed by > > > > > > > > > > +"fsl,imx-sc-thermal"; > > > > > > > > > > + > > > > > > > > > > +- #thermal-sensor-cells: See > > > > > > > > > Documentation/devicetree/bindings/thermal/thermal.txt > > > > > > > > > > > > > > > > > > > > + for a description. > > > > > > > > > > + > > > > > > > > > > +- imx,sensor-resource-id: A single integer for > > > > > > > > > > single > > > > > > > > > > +thermal zone's > > > > > > > > > resource ID or > > > > > > > > > > > > > > > > > > > > + an array of integers to > > > > > > > > > > + specify each thermal > > > > > > > > > zone's sensor > > > > > > > > > > > > > > > > > > > > + resource ID. > > > > > > > > > Can't you put the resource ids in the thermal-sensor > > > > > > > > > cells? > > > > > > > > > Why do you need to list them here? > > > > > > > > For the thermal-sensor cells, if you meant the argument of > > > > > > > > tsens phandle, then the reason is that argument is for > > > > > > > > sensor index starting from 0, previous I use it for our > > > > > > > > resource ID, but it looks confused, since user will think > > > > > > > > there are many sensors there per > > > > > > Eduardo's comment. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > + thermal-sensors = <&tsens 0>; > > > > > > > > > > > > > > > > If you meant putting it in each thermal sensor node > > > > > > > > instead of > > > "tsens" > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > node, then in previous patch series, I put this " > > > > > > > > imx,sensor-resource-id " property in each thermal sensor > > > > > > > > node, but the thermal sensor nodes are parsed by common > > > > > > > > thermal framework, thermal driver will need to find the > > > > > > > > thermal zone node and go through every child node to get > > > > > > > > the resource id again, so Eduardo suggested to put it in > > > > > > > our platform tsens node, that makes our thermal driver code > > > > > > > much more simple. > > > > > > > > > > > > > > The phandle args are meant to be an id typically. There's > > > > > > > absolutely no requirement they are 0-N based. They often are > > > > > > > because things like interrupts are 0-N or clocks have no h/w > > > > > > > id. > > > > > > > If you already have an id, > > > > > use it. > > > > > > > > > > > > > > > > > > > > Don't invent your own. > > > > > > At the beginning, I put the HW resource ID in the "tsens" > > > > > > phandle > > > > > > argument of "thermal-sensors" node, see below patch I sent > > > > > > before, the benefit is I do NOT need to add new property for > > > > > > passing HW resource ID to driver, the disadvantage is, I have > > > > > > to parse the thermal_zones' each child node and get the HW > > > > > > resource ID from phandle argument(searing thermal_zones node > > > > > > and go through all its child node, and get the phandle > > > > > > argument), they are by default ONLY parsed by thermal core > > > > > > driver. When we register thermal zone, we have to pass the HW > > > > > > resource ID when calling > > > > > > devm_thermal_zone_of_sensor_register(), if we add our own > > > > > > property to pass the HW resource ID, then no need to do so, we > > > > > > just pass the index 0-N for each thermal sensors in devicetree > > > > > > which also with phandle > > > > > argument 0- N. So using our own property makes the driver much > > > > > more simple. > > > > > > > > > > > > > > > > > > So, @Eduardo, which direction I should go? Looks like Rob > > > > > > suggests just put the HW resource ID in the phandle argument > > > > > > like what I did at the beginning, can you advise? > > > > > > > > > > > > Thanks, > > > > > > Anson. > > > > > > > > > > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch > work.kernel.org%2Fpatch%2F10703849%2F&data=02%7C01%7Canson.h > uang%40nxp.com%7C4ccced2bc4c94541605a08d6bcbcff74%7C686ea1d3bc2 > b4c6fa92cd99c5c301635%7C0%7C0%7C636903917265841194&sdata=k > Q3dReprke6VnseMnOkHtP97p%2BD3IBCuRwBLj0rPCGI%3D&reserved= > 0 > > > > > > > > > > > > > > + thermal_zones: thermal-zones { > > > > > > > + cpu-thermal0 { > > > > > > > + polling-delay-passive = <250>; > > > > > > > + polling-delay = <2000>; > > > > > > > + thermal-sensors = <&tsens 355>; > > > > > > > + trips { > > > > > > > + cpu_alert0: trip0 { > > > > > > > + temperature = > > > > > > > <107000>; > > > > > > > + hysteresis = > > > > > > > <2000>; > > > > > > > + type = "passive"; > > > > > > > + }; > > > > > > > > > > > > > > > > > > > > > Rob
Hi, Rui/ Eduardo I just resent the V11 patch series as I found previous patch series has conflict on the dt-binding patch, can NOT be applied directly, sorry for the inconvenience. Best Regards! Anson Huang > -----Original Message----- > From: Anson Huang > Sent: 2019年4月10日 14:06 > To: Zhang Rui <rui.zhang@intel.com>; Rob Herring <robh@kernel.org>; > edubezval@gmail.com > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > catalin.marinas@arm.com; will.deacon@arm.com; > daniel.lezcano@linaro.org; Aisheng Dong <aisheng.dong@nxp.com>; > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > marc.w.gonzalez@free.fr; olof@lixom.net; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > Subject: RE: [EXT] Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > binding > > Hi, Rui/Eduardo > I just sent out a V11 patch series following Rob's suggestion, please > help review it. > So if the HW resource ID can be as phandle's argument, then go with > V11 patch series, if it MUST be virtual ID starting from 0-N, then pick V10 > patch series. > Thanks for your time. > > Best Regards! > Anson Huang > > > -----Original Message----- > > From: Zhang Rui [mailto:rui.zhang@intel.com] > > Sent: 2019年4月9日 15:29 > > To: Anson Huang <anson.huang@nxp.com>; Rob Herring > <robh@kernel.org>; > > edubezval@gmail.com > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > s.hauer@pengutronix.de; > > kernel@pengutronix.de; festevam@gmail.com; catalin.marinas@arm.com; > > will.deacon@arm.com; daniel.lezcano@linaro.org; Aisheng Dong > > <aisheng.dong@nxp.com>; ulf.hansson@linaro.org; sboyd@kernel.org; > > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > > <andy.gross@linaro.org>; > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > marc.w.gonzalez@free.fr; olof@lixom.net; devicetree@vger.kernel.org; > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > Subject: [EXT] Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > binding > > > > WARNING: This email was created outside of NXP. DO NOT CLICK links or > > attachments unless you recognize the sender and know the content is safe. > > > > > > > > On 二, 2019-04-09 at 05:28 +0000, Anson Huang wrote: > > > Ping... > > > Can anyone provide some suggestion about how to proceed next? > > > > > Hi, Eduardo, > > > > I guess you will comment on this patch, right? > > Or else I will take the patch following Rob' suggestion. > > > > thanks, > > rui > > > > > > > Best Regards! > > > Anson Huang > > > > > > > > > > > -----Original Message----- > > > > From: Anson Huang > > > > Sent: 2019年3月26日 10:45 > > > > To: 'Rob Herring' <robh@kernel.org>; 'edubezval@gmail.com' > > > > <edubezval@gmail.com> > > > > Cc: 'mark.rutland@arm.com' <mark.rutland@arm.com>; > > > > 'shawnguo@kernel.org' <shawnguo@kernel.org>; > > 's.hauer@pengutronix.d > > > > e' > > > > <s.hauer@pengutronix.de>; 'kernel@pengutronix.de' > > > > <kernel@pengutronix.de>; 'festevam@gmail.com' > > <festevam@gmail.com>; > > > > 'catalin.marinas@arm.com' <catalin.marinas@arm.com>; > > > > 'will.deacon@arm.com' <will.deacon@arm.com>; > 'rui.zhang@intel.com' > > > > <rui.zhang@intel.com>; 'edubezval@gmail.com' > > <edubezval@gmail.com>; > > > > 'daniel.lezcano@linaro.org' <daniel.lezcano@linaro.org>; Aisheng > > > > Dong <aisheng.dong@nxp.com>; 'ulf.hansson@linaro.org' > > > > <ulf.hansson@linaro.org>; 'sboyd@kernel.org' <sboyd@kernel.org>; > > > > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > > > > <andy.gross@linaro.org>; 'horms+renesas@verge.net.au' > > > > <horms+renesas@verge.net.au>; 'heiko@sntech.de' > <heiko@sntech.de>; > > > > 'arnd@arndb.de' <arnd@arndb.de > > > > >; > > > > 'maxime.ripard@bootlin.com' <maxime.ripard@bootlin.com>; > > > > 'bjorn.andersson@linaro.org' <bjorn.andersson@linaro.org>; > > > > 'jagan@amarulasolutions.com' <jagan@amarulasolutions.com>; > > > > 'enric.balletbo@collabora.com' <enric.balletbo@collabora.com>; > > > > 'marc.w.gonzalez@free.fr' <marc.w.gonzalez@free.fr>; > > > > 'olof@lixom.ne t' > > > > <olof@lixom.net>; 'devicetree@vger.kernel.org' > > > > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' > > > > <linux- > > > > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' > > > > <linux-arm- > > > > kernel@lists.infradead.org>; 'linux-pm@vger.kernel.org' <linux- > > > > pm@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com> > > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > > binding > > > > > > > > Ping... > > > > > > > > Hi, Eduardo > > > > What is your opinion about where to put the HW resource ID in > > > > DT? > > > > > > > > Best Regards! > > > > Anson Huang > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Anson Huang > > > > > Sent: 2019年3月13日 16:12 > > > > > To: 'Rob Herring' <robh@kernel.org>; 'edubezval@gmail.com' > > > > > <edubezval@gmail.com> > > > > > Cc: 'mark.rutland@arm.com' <mark.rutland@arm.com>; > > > > > 'shawnguo@kernel.org' <shawnguo@kernel.org>; > > > > 's.hauer@pengutronix.de' > > > > > > > > > > <s.hauer@pengutronix.de>; 'kernel@pengutronix.de' > > > > > <kernel@pengutronix.de>; 'festevam@gmail.com' > > <festevam@gmail.com > > > > > >; > > > > > 'catalin.marinas@arm.com' <catalin.marinas@arm.com>; > > > > > 'will.deacon@arm.com' <will.deacon@arm.com>; > > > > > 'rui.zhang@intel.com ' > > > > > <rui.zhang@intel.com>; 'edubezval@gmail.com' > > <edubezval@gmail.com > > > > > >; > > > > > 'daniel.lezcano@linaro.org' <daniel.lezcano@linaro.org>; Aisheng > > > > > Dong <aisheng.dong@nxp.com>; 'ulf.hansson@linaro.org' > > > > > <ulf.hansson@linaro.org>; 'sboyd@kernel.org' <sboyd@kernel.org>; > > > > > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > > > > > <andy.gross@linaro.org>; 'horms+renesas@verge.net.au' > > > > > <horms+renesas@verge.net.au>; 'heiko@sntech.de' > > > > > <heiko@sntech.de> ; 'arnd@arndb.de' <arnd@arndb.de>; > 'maxime.ripard@bootlin.com' > > > > > <maxime.ripard@bootlin.com>; 'bjorn.andersson@linaro.org' > > > > > <bjorn.andersson@linaro.org>; 'jagan@amarulasolutions.com' > > > > > <jagan@amarulasolutions.com>; 'enric.balletbo@collabora.com' > > > > > <enric.balletbo@collabora.com>; 'marc.w.gonzalez@free.fr' > > > > <marc.w.gonzalez@free.fr>; 'olof@lixom.net' > > > > > > > > > > <olof@lixom.net>; 'devicetree@vger.kernel.org' > > > > > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' > > > > > <linux- > > > > > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' > > > > > <linux-arm- kernel@lists.infradead.org>; > > > > > 'linux-pm@vger.kernel.or g' > > > > > <linux- pm@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com> > > > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add thermal > > > > > binding > > > > > > > > > > Ping... > > > > > Hi, Eduardo > > > > > Can you take a look at this thread? Thanks. > > > > > > > > > > > > > > > Best Regards! > > > > > Anson Huang > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Anson Huang > > > > > > Sent: 2019年3月6日 13:27 > > > > > > To: 'Rob Herring' <robh@kernel.org>; 'edubezval@gmail.com' > > > > > > <edubezval@gmail.com> > > > > > > Cc: 'mark.rutland@arm.com' <mark.rutland@arm.com>; > > > > > > 'shawnguo@kernel.org' <shawnguo@kernel.org>; > > > > > 's.hauer@pengutronix.de' > > > > > > > > > > > > <s.hauer@pengutronix.de>; 'kernel@pengutronix.de' > > > > > > <kernel@pengutronix.de>; 'festevam@gmail.com' > > > > <festevam@gmail.com>; > > > > > > > > > > > > > > > > > 'catalin.marinas@arm.com' <catalin.marinas@arm.com>; > > > > > > 'will.deacon@arm.com' <will.deacon@arm.com>; > > > > > > 'rui.zhang@intel.c om' > > > > > > <rui.zhang@intel.com>; 'edubezval@gmail.com' > > > > <edubezval@gmail.com>; > > > > > > > > > > > > > > > > > 'daniel.lezcano@linaro.org' <daniel.lezcano@linaro.org>; > > > > > > Aisheng Dong <aisheng.dong@nxp.com>; 'ulf.hansson@linaro.org' > > > > > > <ulf.hansson@linaro.org>; 'sboyd@kernel.org' > > > > > > <sboyd@kernel.org> ; Daniel Baluta <daniel.baluta@nxp.com>; > > > > > > Andy Gross <andy.gross@linaro.org>; > 'horms+renesas@verge.net.au' > > > > > > <horms+renesas@verge.net.au>; 'heiko@sntech.de' > > <heiko@sntech.d > > > > > > e>; > > > > > > 'arnd@arndb.de' <arnd@arndb.de>; 'maxime.ripard@bootlin.com' > > > > > > <maxime.ripard@bootlin.com>; 'bjorn.andersson@linaro.org' > > > > > > <bjorn.andersson@linaro.org>; 'jagan@amarulasolutions.com' > > > > > > <jagan@amarulasolutions.com>; 'enric.balletbo@collabora.com' > > > > > > <enric.balletbo@collabora.com>; 'marc.w.gonzalez@free.fr' > > > > > <marc.w.gonzalez@free.fr>; 'olof@lixom.net' > > > > > > > > > > > > <olof@lixom.net>; 'devicetree@vger.kernel.org' > > > > > > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' > > > > > > <linux- > > > > > > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' > > > > > > <linux-arm- kernel@lists.infradead.org>; 'linux-pm@vger.kernel. > > > > > > org' > > > > > > <linux- pm@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com> > > > > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add > > > > > > thermal binding > > > > > > > > > > > > Ping... > > > > > > > > > > > > Hi, Eduardo > > > > > > Looks like we are going around in circle, can we make > > > > > > decision of which direction to go? > > > > > > > > > > > > Best Regards! > > > > > > Anson Huang > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Anson Huang > > > > > > > Sent: 2019年3月1日 9:41 > > > > > > > To: 'Rob Herring' <robh@kernel.org>; edubezval@gmail.com > > > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > > > s.hauer@pengutronix.de; > > > > > > > > > > > > > > kernel@pengutronix.de; festevam@gmail.com; > > > > > catalin.marinas@arm.com; > > > > > > > > > > > > > > > > > > > > will.deacon@arm.com; rui.zhang@intel.com; > > > > > > > edubezval@gmail.com ; daniel.lezcano@linaro.org; Aisheng > > > > > > > Dong <aisheng.dong@nxp.com > > > > > > > >; > > > > > > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > > > > > > > <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > > > > > > > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > > > > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > > > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > > > > > > marc.w.gonzalez@free.fr; olof@lixom.net; > > > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > > > > linux-arm-kernel@lists.infradead.org; > > > > > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > > > > > > > Subject: RE: [PATCH V10 1/4] dt-bindings: fsl: scu: add > > > > > > > thermal binding > > > > > > > > > > > > > > Hi, Rob/Eduardo > > > > > > > > > > > > > > Best Regards! > > > > > > > Anson Huang > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Rob Herring [mailto:robh@kernel.org] > > > > > > > > Sent: 2019年2月28日 22:49 > > > > > > > > To: Anson Huang <anson.huang@nxp.com> > > > > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > > > > s.hauer@pengutronix.de; > > > > > > > > > > > > > > > > kernel@pengutronix.de; festevam@gmail.com; > > > > > > catalin.marinas@arm.com; > > > > > > > > > > > > > > > > > > > > > > > will.deacon@arm.com; rui.zhang@intel.com; > > > > > > > > edubezval@gmail.c om; daniel.lezcano@linaro.org; Aisheng > > > > > > > > Dong <aisheng.dong@nxp.c > > > > > > > > om>; > > > > > > > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > > > > > > > > <daniel.baluta@nxp.com>; Andy Gross > > > > > > > > <andy.gross@linaro.org> ; > > > > > > > > horms+renesas@verge.net.au; heiko@sntech.de; > > > > > > > > horms+arnd@arndb.de; > > > > > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > > > > > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > > > > > > > > marc.w.gonzalez@free.fr; olof@lixom.net; > > > > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > > > > > linux-arm-kernel@lists.infradead.org; > > > > > > > > linux- pm@vger.kernel.org; dl-linux-imx > > > > > > > > <linux-imx@nxp.com> > > > > > > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: add > > > > > > > > thermal binding > > > > > > > > > > > > > > > > On Wed, Feb 27, 2019 at 6:48 PM Anson Huang > > > > > <anson.huang@nxp.com> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > Hi, Rob > > > > > > > > > > > > > > > > > > Best Regards! > > > > > > > > > Anson Huang > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > > From: Rob Herring [mailto:robh@kernel.org] > > > > > > > > > > Sent: 2019年2月28日 7:55 > > > > > > > > > > To: Anson Huang <anson.huang@nxp.com> > > > > > > > > > > Cc: mark.rutland@arm.com; shawnguo@kernel.org; > > > > > > > > > > s.hauer@pengutronix.de; kernel@pengutronix.de; > > > > > > > festevam@gmail.com; > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > catalin.marinas@arm.com; will.deacon@arm.com; > > > > > > > rui.zhang@intel.com; > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > edubezval@gmail.com; daniel.lezcano@linaro.org; > > > > > > > > > > Aisheng Dong <aisheng.dong@nxp.com>; > > > > > > > > > > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel > > > > > > > > > > Baluta <daniel.baluta@nxp.com> ; Andy Gross > > > > > > > > > > <andy.gross@linaro.org>; > > > > > > > > > > horms+renesas@verge.net.au; heiko@sntech.de; > > > > > > > > > > horms+arnd@arndb > > > > > > > > > > .de; > > > > > > > > > > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > > > > > > > > > > jagan@amarulasolutions.com; > > > > > > > > > > enric.balletbo@collabora.co m; > > > > > > > > > > marc.w.gonzalez@free.fr; olof@lixom.net; > > > > > > > > > > devicetree@vger.kernel.org; > > > > > > > > > > linux-kernel@vger.kernel.or g; > > > > > > > > > > linux-arm-kernel@lists.infradead.org; > > > > > > > > > > linux- pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp. > > > > > > > > > > com> > > > > > > > > > > Subject: Re: [PATCH V10 1/4] dt-bindings: fsl: scu: > > > > > > > > > > add thermal binding > > > > > > > > > > > > > > > > > > > > On Wed, Feb 27, 2019 at 08:46:21AM +0000, Anson Huang > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core > > > > > > > > > > > inside as system controller, the system controller > > > > > > > > > > > is in charge of system power, clock and thermal > > > > > > > > > > > sensors etc. > > > > > > > > > > > management, Linux kernel has to communicate with > > > > > > > > > > > system controller via MU (message unit) IPC to get > > > > > > > > > > > temperature from thermal sensors, this patch adds > > > > > > > > > > > binding doc for i.MX system controller thermal > > > > > > driver. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > > > > > > > > --- > > > > > > > > > > > Changes since V9: > > > > > > > > > > > - change #thermal-sensor-cells value in example > > > > > > > > > > > to 1, since there are > > > > > > > > > > other > > > > > > > > > > > > > > > > > > > > > > thermal sensors inside system controller, it > > > > > > > > > > > is just because there are > > > > > > > > > > still > > > > > > > > > > > > > > > > > > > > > > some issue, so system controller does NOT > > > > > > > > > > > expose them for now, > > > > > > > > > > they could > > > > > > > > > > > > > > > > > > > > > > be exposed later, so it should be 1 from HW > > > > > > > > > > > perspective. > > > > > > > > > > > --- > > > > > > > > > > > .../devicetree/bindings/arm/freescale/fsl,scu.txt > > > > > > > > > > > | 21 > > > > > > > > > > +++++++++++++++++++++ > > > > > > > > > > > > > > > > > > > > > > 1 file changed, 21 insertions(+) > > > > > > > > > > > > > > > > > > > > > > diff --git > > > > > > > > > > > a/Documentation/devicetree/bindings/arm/freescale/fs > > > > > > > > > > > l > > > > > > > > > > > ,scu. > > > > > > > > > > > tx > > > > > > > > > > > t > > > > > > > > > > > b/Documentation/devicetree/bindings/arm/freescale/fs > > > > > > > > > > > l > > > > > > > > > > > ,scu. > > > > > > > > > > > tx t index 72d481c..855270b 100644 > > > > > > > > > > > --- > > > > > > > > > > > a/Documentation/devicetree/bindings/arm/freescale/fs > > > > > > > > > > > l > > > > > > > > > > > ,scu. > > > > > > > > > > > tx > > > > > > > > > > > t > > > > > > > > > > > +++ > > > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > +++ tx > > > > > > > > > > > +++ t > > > > > > > > > > > @@ -122,6 +122,21 @@ RTC bindings based on SCU > > > > > > > > > > > Message > > > > > > > Protocol > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Required properties: > > > > > > > > > > > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > > > > > > > > > > > > > > > > > > > +Thermal bindings based on SCU Message Protocol > > > > > > > > > > > +-------------------------------------------------- > > > > > > > > > > > ------- > > > > > > > > > > > +-- > > > > > > > > > > > +- > > > > > > > > > > > + > > > > > > > > > > > +Required properties: > > > > > > > > > > > +- compatible: Should be : > > > > > > > > > > > + "fsl,imx8qxp-sc- > > > > > > > > > > > thermal" > > > > > > > > > > > + followed by > > > > > > > > > > > +"fsl,imx-sc-thermal"; > > > > > > > > > > > + > > > > > > > > > > > +- #thermal-sensor-cells: See > > > > > > > > > > Documentation/devicetree/bindings/thermal/thermal.txt > > > > > > > > > > > > > > > > > > > > > > + for a description. > > > > > > > > > > > + > > > > > > > > > > > +- imx,sensor-resource-id: A single integer for > > > > > > > > > > > single > > > > > > > > > > > +thermal zone's > > > > > > > > > > resource ID or > > > > > > > > > > > > > > > > > > > > > > + an array of integers to > > > > > > > > > > > + specify each thermal > > > > > > > > > > zone's sensor > > > > > > > > > > > > > > > > > > > > > > + resource ID. > > > > > > > > > > Can't you put the resource ids in the thermal-sensor > > > > > > > > > > cells? > > > > > > > > > > Why do you need to list them here? > > > > > > > > > For the thermal-sensor cells, if you meant the argument > > > > > > > > > of tsens phandle, then the reason is that argument is > > > > > > > > > for sensor index starting from 0, previous I use it for > > > > > > > > > our resource ID, but it looks confused, since user will > > > > > > > > > think there are many sensors there per > > > > > > > Eduardo's comment. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > + thermal-sensors = <&tsens 0>; > > > > > > > > > > > > > > > > > > If you meant putting it in each thermal sensor node > > > > > > > > > instead of > > > > "tsens" > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > node, then in previous patch series, I put this " > > > > > > > > > imx,sensor-resource-id " property in each thermal sensor > > > > > > > > > node, but the thermal sensor nodes are parsed by common > > > > > > > > > thermal framework, thermal driver will need to find the > > > > > > > > > thermal zone node and go through every child node to get > > > > > > > > > the resource id again, so Eduardo suggested to put it in > > > > > > > > our platform tsens node, that makes our thermal driver > > > > > > > > code much more simple. > > > > > > > > > > > > > > > > The phandle args are meant to be an id typically. There's > > > > > > > > absolutely no requirement they are 0-N based. They often > > > > > > > > are because things like interrupts are 0-N or clocks have > > > > > > > > no h/w id. > > > > > > > > If you already have an id, > > > > > > use it. > > > > > > > > > > > > > > > > > > > > > > > Don't invent your own. > > > > > > > At the beginning, I put the HW resource ID in the "tsens" > > > > > > > phandle > > > > > > > argument of "thermal-sensors" node, see below patch I sent > > > > > > > before, the benefit is I do NOT need to add new property for > > > > > > > passing HW resource ID to driver, the disadvantage is, I > > > > > > > have to parse the thermal_zones' each child node and get the > > > > > > > HW resource ID from phandle argument(searing thermal_zones > > > > > > > node and go through all its child node, and get the phandle > > > > > > > argument), they are by default ONLY parsed by thermal core > > > > > > > driver. When we register thermal zone, we have to pass the > > > > > > > HW resource ID when calling > > > > > > > devm_thermal_zone_of_sensor_register(), if we add our own > > > > > > > property to pass the HW resource ID, then no need to do so, > > > > > > > we just pass the index 0-N for each thermal sensors in > > > > > > > devicetree which also with phandle > > > > > > argument 0- N. So using our own property makes the driver much > > > > > > more simple. > > > > > > > > > > > > > > > > > > > > > So, @Eduardo, which direction I should go? Looks like Rob > > > > > > > suggests just put the HW resource ID in the phandle argument > > > > > > > like what I did at the beginning, can you advise? > > > > > > > > > > > > > > Thanks, > > > > > > > Anson. > > > > > > > > > > > > > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc > > h > work.kernel.org%2Fpatch%2F10703849%2F&data=02%7C01%7Canson.h > > > uang%40nxp.com%7C4ccced2bc4c94541605a08d6bcbcff74%7C686ea1d3bc2 > > > b4c6fa92cd99c5c301635%7C0%7C0%7C636903917265841194&sdata=k > > > Q3dReprke6VnseMnOkHtP97p%2BD3IBCuRwBLj0rPCGI%3D&reserved= > > 0 > > > > > > > > > > > > > > > > + thermal_zones: thermal-zones { > > > > > > > > + cpu-thermal0 { > > > > > > > > + polling-delay-passive = <250>; > > > > > > > > + polling-delay = <2000>; > > > > > > > > + thermal-sensors = <&tsens 355>; > > > > > > > > + trips { > > > > > > > > + cpu_alert0: trip0 { > > > > > > > > + temperature = > > > > > > > > <107000>; > > > > > > > > + hysteresis = > > > > > > > > <2000>; > > > > > > > > + type = "passive"; > > > > > > > > + }; > > > > > > > > > > > > > > > > > > > > > > > > Rob
diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt index 72d481c..855270b 100644 --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt @@ -122,6 +122,21 @@ RTC bindings based on SCU Message Protocol Required properties: - compatible: should be "fsl,imx8qxp-sc-rtc"; +Thermal bindings based on SCU Message Protocol +------------------------------------------------------------ + +Required properties: +- compatible: Should be : + "fsl,imx8qxp-sc-thermal" + followed by "fsl,imx-sc-thermal"; + +- #thermal-sensor-cells: See Documentation/devicetree/bindings/thermal/thermal.txt + for a description. + +- imx,sensor-resource-id: A single integer for single thermal zone's resource ID or + an array of integers to specify each thermal zone's sensor + resource ID. + Example (imx8qxp): ------------- lsio_mu1: mailbox@5d1c0000 { @@ -168,6 +183,12 @@ firmware { rtc: rtc { compatible = "fsl,imx8qxp-sc-rtc"; }; + + tsens: thermal-sensor { + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc-thermal"; + #thermal-sensor-cells = <1>; + imx,sensor-resource-id = <IMX_SC_R_SYSTEM>; + }; }; };
NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system controller, the system controller is in charge of system power, clock and thermal sensors etc. management, Linux kernel has to communicate with system controller via MU (message unit) IPC to get temperature from thermal sensors, this patch adds binding doc for i.MX system controller thermal driver. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- Changes since V9: - change #thermal-sensor-cells value in example to 1, since there are other thermal sensors inside system controller, it is just because there are still some issue, so system controller does NOT expose them for now, they could be exposed later, so it should be 1 from HW perspective. --- .../devicetree/bindings/arm/freescale/fsl,scu.txt | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)