| Message ID | 20190228222923.30418-1-papadakospan@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: rockchip: fix rk3328-roc-cc gmac2io tx/rx_delay | expand |
Am Donnerstag, 28. Februar 2019, 23:29:23 CET schrieb Leonidas P. Papadakos: > The rk3328-roc-cc board exhibits tx stability issues with large packets, > as does the rock64 board, which was fixed with this patch > https://patchwork.kernel.org/patch/10178969/ > > A similar patch was merged for the rk3328-roc-cc here > https://patchwork.kernel.org/patch/10804863/ > but it doesn't include the tx/rx_delay tweaks, and I find that they > help with an issue where large transfers would bring the ethernet > link down, causing a link reset regularly. > > Signed-off-by: Leonidas P. Papadakos <papadakospan@gmail.com> applied as fix for the 5.1-rc cycle starting in about 2 weeks. Thanks Heiko
Στις Κυρ, 3 Μαρ, 2019 at 4:10 ΜΜ, ο/η Heiko Stuebner <heiko@sntech.de> έγραψε: > Am Donnerstag, 28. Februar 2019, 23:29:23 CET schrieb Leonidas P. > Papadakos: >> The rk3328-roc-cc board exhibits tx stability issues with large >> packets, >> as does the rock64 board, which was fixed with this patch >> https://patchwork.kernel.org/patch/10178969/ >> >> A similar patch was merged for the rk3328-roc-cc here >> https://patchwork.kernel.org/patch/10804863/ >> but it doesn't include the tx/rx_delay tweaks, and I find that they >> help with an issue where large transfers would bring the ethernet >> link down, causing a link reset regularly. >> >> Signed-off-by: Leonidas P. Papadakos <papadakospan@gmail.com> > > applied as fix for the 5.1-rc cycle starting in about 2 weeks. > > Thanks > Heiko > > It seems like the delays for the rk3328-roc-cc should be like this: tx_delay = <0x28>; rx_delay = <0x16>; What should I do? Make a new patch? If so, what tree do I base it on?
Hi, Am Mittwoch, 6. März 2019, 02:36:59 CET schrieb Leonidas P. Papadakos: > Στις Κυρ, 3 Μαρ, 2019 at 4:10 ΜΜ, ο/η Heiko Stuebner > > <heiko@sntech.de> έγραψε: > > Am Donnerstag, 28. Februar 2019, 23:29:23 CET schrieb Leonidas P. > > > > Papadakos: > >> The rk3328-roc-cc board exhibits tx stability issues with large > >> > >> packets, > >> > >> as does the rock64 board, which was fixed with this patch > >> https://patchwork.kernel.org/patch/10178969/ > >> > >> A similar patch was merged for the rk3328-roc-cc here > >> https://patchwork.kernel.org/patch/10804863/ > >> but it doesn't include the tx/rx_delay tweaks, and I find that they > >> help with an issue where large transfers would bring the ethernet > >> link down, causing a link reset regularly. > >> > >> Signed-off-by: Leonidas P. Papadakos <papadakospan@gmail.com> > > > > applied as fix for the 5.1-rc cycle starting in about 2 weeks. > > > > Thanks > > Heiko > > It seems like the delays for the rk3328-roc-cc should be like this: > tx_delay = <0x28>; > rx_delay = <0x16>; > What should I do? Make a new patch? If so, what tree do I base it on? yeah just make a new patch, replacing the old one. The original patch is targeted at 5.2, so is sitting in a temporary branch right now - so replacing the whole patch it is possible without hickups right now. Heiko
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts index 33c44e857..0e34354b2 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts @@ -108,8 +108,8 @@ snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>; snps,reset-active-low; snps,reset-delays-us = <0 10000 50000>; - tx_delay = <0x25>; - rx_delay = <0x11>; + tx_delay = <0x24>; + rx_delay = <0x18>; status = "okay"; };
The rk3328-roc-cc board exhibits tx stability issues with large packets, as does the rock64 board, which was fixed with this patch https://patchwork.kernel.org/patch/10178969/ A similar patch was merged for the rk3328-roc-cc here https://patchwork.kernel.org/patch/10804863/ but it doesn't include the tx/rx_delay tweaks, and I find that they help with an issue where large transfers would bring the ethernet link down, causing a link reset regularly. Signed-off-by: Leonidas P. Papadakos <papadakospan@gmail.com> --- arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)