| Message ID | 20190310160227.103090-1-liq3ea@163.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests: test-qgraph: fix a memory leak | expand |
On 10/03/2019 17.02, Li Qiang wrote: > Spotted by ASAN when 'make check'. > > Signed-off-by: Li Qiang <liq3ea@163.com> > --- > tests/test-qgraph.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/test-qgraph.c b/tests/test-qgraph.c > index f6a6565e31..5c7e457075 100644 > --- a/tests/test-qgraph.c > +++ b/tests/test-qgraph.c > @@ -122,7 +122,7 @@ static void check_driver(const char *driver) > static void check_test(const char *test, const char *interface) > { > QOSGraphEdge *edge; > - const char *full_name = g_strdup_printf("%s-tests/%s", interface, test); > + char *full_name = g_strdup_printf("%s-tests/%s", interface, test); > > qos_add_test(test, interface, testfunct, NULL); > g_assert_cmpint(qos_graph_has_machine(test), ==, FALSE); > @@ -138,6 +138,7 @@ static void check_test(const char *test, const char *interface) > g_assert_cmpint(qos_graph_get_node_availability(full_name), ==, TRUE); > qos_graph_node_set_availability(full_name, FALSE); > g_assert_cmpint(qos_graph_get_node_availability(full_name), ==, FALSE); > + g_free(full_name); > } > > static void count_each_test(QOSGraphNode *path, int len) > Reviewed-by: Thomas Huth <thuth@redhat.com>
On 3/10/19 5:02 PM, Li Qiang wrote: > Spotted by ASAN when 'make check'. > Fixes: fc281c80202 > Signed-off-by: Li Qiang <liq3ea@163.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > tests/test-qgraph.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/test-qgraph.c b/tests/test-qgraph.c > index f6a6565e31..5c7e457075 100644 > --- a/tests/test-qgraph.c > +++ b/tests/test-qgraph.c > @@ -122,7 +122,7 @@ static void check_driver(const char *driver) > static void check_test(const char *test, const char *interface) > { > QOSGraphEdge *edge; > - const char *full_name = g_strdup_printf("%s-tests/%s", interface, test); > + char *full_name = g_strdup_printf("%s-tests/%s", interface, test); > > qos_add_test(test, interface, testfunct, NULL); > g_assert_cmpint(qos_graph_has_machine(test), ==, FALSE); > @@ -138,6 +138,7 @@ static void check_test(const char *test, const char *interface) > g_assert_cmpint(qos_graph_get_node_availability(full_name), ==, TRUE); > qos_graph_node_set_availability(full_name, FALSE); > g_assert_cmpint(qos_graph_get_node_availability(full_name), ==, FALSE); > + g_free(full_name); > } > > static void count_each_test(QOSGraphNode *path, int len) >
On 10/03/19 17:02, Li Qiang wrote: > Spotted by ASAN when 'make check'. > > Signed-off-by: Li Qiang <liq3ea@163.com> > --- > tests/test-qgraph.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/test-qgraph.c b/tests/test-qgraph.c > index f6a6565e31..5c7e457075 100644 > --- a/tests/test-qgraph.c > +++ b/tests/test-qgraph.c > @@ -122,7 +122,7 @@ static void check_driver(const char *driver) > static void check_test(const char *test, const char *interface) > { > QOSGraphEdge *edge; > - const char *full_name = g_strdup_printf("%s-tests/%s", interface, test); > + char *full_name = g_strdup_printf("%s-tests/%s", interface, test); > > qos_add_test(test, interface, testfunct, NULL); > g_assert_cmpint(qos_graph_has_machine(test), ==, FALSE); > @@ -138,6 +138,7 @@ static void check_test(const char *test, const char *interface) > g_assert_cmpint(qos_graph_get_node_availability(full_name), ==, TRUE); > qos_graph_node_set_availability(full_name, FALSE); > g_assert_cmpint(qos_graph_get_node_availability(full_name), ==, FALSE); > + g_free(full_name); > } > > static void count_each_test(QOSGraphNode *path, int len) > Queued, thanks. Paolo
diff --git a/tests/test-qgraph.c b/tests/test-qgraph.c index f6a6565e31..5c7e457075 100644 --- a/tests/test-qgraph.c +++ b/tests/test-qgraph.c @@ -122,7 +122,7 @@ static void check_driver(const char *driver) static void check_test(const char *test, const char *interface) { QOSGraphEdge *edge; - const char *full_name = g_strdup_printf("%s-tests/%s", interface, test); + char *full_name = g_strdup_printf("%s-tests/%s", interface, test); qos_add_test(test, interface, testfunct, NULL); g_assert_cmpint(qos_graph_has_machine(test), ==, FALSE); @@ -138,6 +138,7 @@ static void check_test(const char *test, const char *interface) g_assert_cmpint(qos_graph_get_node_availability(full_name), ==, TRUE); qos_graph_node_set_availability(full_name, FALSE); g_assert_cmpint(qos_graph_get_node_availability(full_name), ==, FALSE); + g_free(full_name); } static void count_each_test(QOSGraphNode *path, int len)
Spotted by ASAN when 'make check'. Signed-off-by: Li Qiang <liq3ea@163.com> --- tests/test-qgraph.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)