| Message ID | 1552317693-21979-1-git-send-email-jjherne@linux.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | s390: vfio-ccw dasd ipl support | expand |
Patchew URL: https://patchew.org/QEMU/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1552317693-21979-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v4 00/15] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' bd94e50234 s390-bios: Support booting from real dasd device aad5bf130c s390-bios: Add channel command codes/structs needed for dasd-ipl e258b66057 s390-bios: Use control unit type to determine boot method cc8935297c s390-bios: Refactor virtio to run channel programs via cio 7bdaffbf3f s390-bios: cio error handling 5f3bd7198d s390-bios: Support for running format-0/1 channel programs eb2acc2e8a s390-bios: ptr2u32 and u32toptr 0e981d74ac s390-bios: Map low core memory f059965201 s390-bios: Decouple channel i/o logic from virtio 7fc7e860d1 s390-bios: Clean up cio.h 4e4ed7410e s390-bios: Factor finding boot device out of virtio code path 7d0cb3a7d8 s390-bios: Extend find_dev() for non-virtio devices c716ab8964 s390-bios: decouple common boot logic from virtio de40d8226e s390-bios: decouple cio setup from virtio 832381495b s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/15 Checking commit 832381495ba0 (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #220: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 1/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/15 Checking commit de40d8226eed (s390-bios: decouple cio setup from virtio) 3/15 Checking commit c716ab896424 (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/15 Checking commit 7d0cb3a7d837 (s390-bios: Extend find_dev() for non-virtio devices) 5/15 Checking commit 4e4ed7410ed2 (s390-bios: Factor finding boot device out of virtio code path) 6/15 Checking commit 7fc7e860d1a8 (s390-bios: Clean up cio.h) 7/15 Checking commit f05996520135 (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 123 lines checked Patch 7/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/15 Checking commit 0e981d74ac1d (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 total: 0 errors, 1 warnings, 104 lines checked Patch 8/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/15 Checking commit eb2acc2e8abf (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 31 lines checked Patch 9/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/15 Checking commit 5f3bd7198d22 (s390-bios: Support for running format-0/1 channel programs) ERROR: trailing whitespace #137: FILE: pc-bios/s390-ccw/cio.c:145: + * active (generating i/o interrupts). $ total: 1 errors, 0 warnings, 375 lines checked Patch 10/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/15 Checking commit 7bdaffbf3f39 (s390-bios: cio error handling) 12/15 Checking commit cc8935297cb1 (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/15 Checking commit e258b660570b (s390-bios: Use control unit type to determine boot method) 14/15 Checking commit aad5bf130c00 (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/15 Checking commit bd94e50234c5 (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 448 lines checked Patch 15/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1552317693-21979-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v4 00/15] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' ea96f08482 s390-bios: Support booting from real dasd device ab7d59e218 s390-bios: Add channel command codes/structs needed for dasd-ipl 2ad6920563 s390-bios: Use control unit type to determine boot method c1dd91dcab s390-bios: Refactor virtio to run channel programs via cio 783a5d992e s390-bios: cio error handling ed5a01a4d1 s390-bios: Support for running format-0/1 channel programs ce04b580ff s390-bios: ptr2u32 and u32toptr d0bf9e13e4 s390-bios: Map low core memory bef31e545b s390-bios: Decouple channel i/o logic from virtio 9d517b7d84 s390-bios: Clean up cio.h 19fba0fd56 s390-bios: Factor finding boot device out of virtio code path 6c0daf90e7 s390-bios: Extend find_dev() for non-virtio devices a500db9f58 s390-bios: decouple common boot logic from virtio 1a8b1f01ab s390-bios: decouple cio setup from virtio 22aef1c027 s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/15 Checking commit 22aef1c02747 (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #220: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 1/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/15 Checking commit 1a8b1f01abf8 (s390-bios: decouple cio setup from virtio) 3/15 Checking commit a500db9f58bc (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/15 Checking commit 6c0daf90e7a2 (s390-bios: Extend find_dev() for non-virtio devices) 5/15 Checking commit 19fba0fd568a (s390-bios: Factor finding boot device out of virtio code path) 6/15 Checking commit 9d517b7d847e (s390-bios: Clean up cio.h) 7/15 Checking commit bef31e545b82 (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 123 lines checked Patch 7/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/15 Checking commit d0bf9e13e4f2 (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 total: 0 errors, 1 warnings, 104 lines checked Patch 8/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/15 Checking commit ce04b580ff16 (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 31 lines checked Patch 9/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/15 Checking commit ed5a01a4d1bb (s390-bios: Support for running format-0/1 channel programs) ERROR: trailing whitespace #137: FILE: pc-bios/s390-ccw/cio.c:145: + * active (generating i/o interrupts). $ total: 1 errors, 0 warnings, 375 lines checked Patch 10/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/15 Checking commit 783a5d992e32 (s390-bios: cio error handling) 12/15 Checking commit c1dd91dcabf5 (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/15 Checking commit 2ad69205637b (s390-bios: Use control unit type to determine boot method) 14/15 Checking commit ab7d59e21880 (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/15 Checking commit ea96f08482fb (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 448 lines checked Patch 15/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1552317693-21979-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v4 00/15] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' fc8f35f68b s390-bios: Support booting from real dasd device cc8f9b9582 s390-bios: Add channel command codes/structs needed for dasd-ipl b29dbdc21e s390-bios: Use control unit type to determine boot method 302635f2b0 s390-bios: Refactor virtio to run channel programs via cio d97780d732 s390-bios: cio error handling 4d96946c21 s390-bios: Support for running format-0/1 channel programs f46e7a874b s390-bios: ptr2u32 and u32toptr fa38f7e829 s390-bios: Map low core memory d8b568caf7 s390-bios: Decouple channel i/o logic from virtio a25758c37b s390-bios: Clean up cio.h eba9c2f352 s390-bios: Factor finding boot device out of virtio code path 0b7c5d9020 s390-bios: Extend find_dev() for non-virtio devices 6da07615a3 s390-bios: decouple common boot logic from virtio c09f8e28ca s390-bios: decouple cio setup from virtio 8289560b25 s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/15 Checking commit 8289560b250a (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #220: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 1/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/15 Checking commit c09f8e28ca6a (s390-bios: decouple cio setup from virtio) 3/15 Checking commit 6da07615a32e (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/15 Checking commit 0b7c5d90207b (s390-bios: Extend find_dev() for non-virtio devices) 5/15 Checking commit eba9c2f35241 (s390-bios: Factor finding boot device out of virtio code path) 6/15 Checking commit a25758c37b49 (s390-bios: Clean up cio.h) 7/15 Checking commit d8b568caf728 (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 123 lines checked Patch 7/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/15 Checking commit fa38f7e82947 (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 total: 0 errors, 1 warnings, 104 lines checked Patch 8/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/15 Checking commit f46e7a874b6c (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 31 lines checked Patch 9/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/15 Checking commit 4d96946c21d4 (s390-bios: Support for running format-0/1 channel programs) ERROR: trailing whitespace #137: FILE: pc-bios/s390-ccw/cio.c:145: + * active (generating i/o interrupts). $ total: 1 errors, 0 warnings, 375 lines checked Patch 10/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/15 Checking commit d97780d73213 (s390-bios: cio error handling) 12/15 Checking commit 302635f2b0b1 (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/15 Checking commit b29dbdc21e67 (s390-bios: Use control unit type to determine boot method) 14/15 Checking commit cc8f9b958217 (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/15 Checking commit fc8f35f68b0a (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 448 lines checked Patch 15/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1552317693-21979-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v4 00/15] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' 38160b4042 s390-bios: Support booting from real dasd device 316515709f s390-bios: Add channel command codes/structs needed for dasd-ipl cb625acff9 s390-bios: Use control unit type to determine boot method e0cf56f04f s390-bios: Refactor virtio to run channel programs via cio 50a001e04d s390-bios: cio error handling 8be89d08ab s390-bios: Support for running format-0/1 channel programs c4bd8ffe51 s390-bios: ptr2u32 and u32toptr 8ba6f9783a s390-bios: Map low core memory c2be0a3e0d s390-bios: Decouple channel i/o logic from virtio 02e12ec27b s390-bios: Clean up cio.h ba01d1cded s390-bios: Factor finding boot device out of virtio code path bff0b93ce8 s390-bios: Extend find_dev() for non-virtio devices 6b9542b07a s390-bios: decouple common boot logic from virtio 1b23a9248e s390-bios: decouple cio setup from virtio eaef648c5f s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/15 Checking commit eaef648c5ffe (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #220: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 1/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/15 Checking commit 1b23a9248e2c (s390-bios: decouple cio setup from virtio) 3/15 Checking commit 6b9542b07a35 (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/15 Checking commit bff0b93ce80d (s390-bios: Extend find_dev() for non-virtio devices) 5/15 Checking commit ba01d1cdeda4 (s390-bios: Factor finding boot device out of virtio code path) 6/15 Checking commit 02e12ec27b64 (s390-bios: Clean up cio.h) 7/15 Checking commit c2be0a3e0d87 (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 123 lines checked Patch 7/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/15 Checking commit 8ba6f9783a0d (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 total: 0 errors, 1 warnings, 104 lines checked Patch 8/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/15 Checking commit c4bd8ffe510b (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 31 lines checked Patch 9/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/15 Checking commit 8be89d08ab08 (s390-bios: Support for running format-0/1 channel programs) ERROR: trailing whitespace #137: FILE: pc-bios/s390-ccw/cio.c:145: + * active (generating i/o interrupts). $ total: 1 errors, 0 warnings, 375 lines checked Patch 10/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/15 Checking commit 50a001e04daa (s390-bios: cio error handling) 12/15 Checking commit e0cf56f04fb1 (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/15 Checking commit cb625acff93d (s390-bios: Use control unit type to determine boot method) 14/15 Checking commit 316515709f62 (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/15 Checking commit 38160b404298 (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 448 lines checked Patch 15/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1552317693-21979-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v4 00/15] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' 74e39a4097 s390-bios: Support booting from real dasd device 6d452a448d s390-bios: Add channel command codes/structs needed for dasd-ipl cb492caa6c s390-bios: Use control unit type to determine boot method 0620776b87 s390-bios: Refactor virtio to run channel programs via cio 4558a4d4c8 s390-bios: cio error handling e715629662 s390-bios: Support for running format-0/1 channel programs ba523e4c71 s390-bios: ptr2u32 and u32toptr 0c748e5dae s390-bios: Map low core memory 92ea0fe2d0 s390-bios: Decouple channel i/o logic from virtio e676252115 s390-bios: Clean up cio.h a94f87a361 s390-bios: Factor finding boot device out of virtio code path 295fd42af0 s390-bios: Extend find_dev() for non-virtio devices 7a5e64f51e s390-bios: decouple common boot logic from virtio 2fd1205555 s390-bios: decouple cio setup from virtio 4925bc96f1 s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/15 Checking commit 4925bc96f171 (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #220: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 1/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/15 Checking commit 2fd120555517 (s390-bios: decouple cio setup from virtio) 3/15 Checking commit 7a5e64f51ee9 (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/15 Checking commit 295fd42af0bd (s390-bios: Extend find_dev() for non-virtio devices) 5/15 Checking commit a94f87a361cc (s390-bios: Factor finding boot device out of virtio code path) 6/15 Checking commit e676252115d6 (s390-bios: Clean up cio.h) 7/15 Checking commit 92ea0fe2d0b6 (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 123 lines checked Patch 7/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/15 Checking commit 0c748e5dae63 (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 total: 0 errors, 1 warnings, 104 lines checked Patch 8/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/15 Checking commit ba523e4c71f7 (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 31 lines checked Patch 9/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/15 Checking commit e7156296626a (s390-bios: Support for running format-0/1 channel programs) ERROR: trailing whitespace #137: FILE: pc-bios/s390-ccw/cio.c:145: + * active (generating i/o interrupts). $ total: 1 errors, 0 warnings, 375 lines checked Patch 10/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/15 Checking commit 4558a4d4c855 (s390-bios: cio error handling) 12/15 Checking commit 0620776b87c4 (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/15 Checking commit cb492caa6c49 (s390-bios: Use control unit type to determine boot method) 14/15 Checking commit 6d452a448d58 (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/15 Checking commit 74e39a40972c (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 448 lines checked Patch 15/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1552317693-21979-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v4 00/15] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 79d8b1dc5b..2e35c7738e master -> master t [tag update] patchew/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' ee5930c12b s390-bios: Support booting from real dasd device 5ff6fc17a5 s390-bios: Add channel command codes/structs needed for dasd-ipl cb041a4b32 s390-bios: Use control unit type to determine boot method b8416017c4 s390-bios: Refactor virtio to run channel programs via cio df2ec37e43 s390-bios: cio error handling 63b18eb97b s390-bios: Support for running format-0/1 channel programs e6900566ed s390-bios: ptr2u32 and u32toptr 9de84fcb45 s390-bios: Map low core memory 5116bdb9e5 s390-bios: Decouple channel i/o logic from virtio 06f7810bbc s390-bios: Clean up cio.h b488965a0b s390-bios: Factor finding boot device out of virtio code path 509467af29 s390-bios: Extend find_dev() for non-virtio devices 5a2fb35f34 s390-bios: decouple common boot logic from virtio 3a37549e53 s390-bios: decouple cio setup from virtio 959a2b698e s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/15 Checking commit 959a2b698e70 (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #220: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 1/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/15 Checking commit 3a37549e53cb (s390-bios: decouple cio setup from virtio) 3/15 Checking commit 5a2fb35f34cd (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/15 Checking commit 509467af2963 (s390-bios: Extend find_dev() for non-virtio devices) 5/15 Checking commit b488965a0b21 (s390-bios: Factor finding boot device out of virtio code path) 6/15 Checking commit 06f7810bbc26 (s390-bios: Clean up cio.h) 7/15 Checking commit 5116bdb9e5ab (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 123 lines checked Patch 7/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/15 Checking commit 9de84fcb45af (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 total: 0 errors, 1 warnings, 104 lines checked Patch 8/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/15 Checking commit e6900566edda (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 31 lines checked Patch 9/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/15 Checking commit 63b18eb97b3d (s390-bios: Support for running format-0/1 channel programs) ERROR: trailing whitespace #137: FILE: pc-bios/s390-ccw/cio.c:145: + * active (generating i/o interrupts). $ total: 1 errors, 0 warnings, 375 lines checked Patch 10/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/15 Checking commit df2ec37e43e8 (s390-bios: cio error handling) 12/15 Checking commit b8416017c4b3 (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/15 Checking commit cb041a4b3249 (s390-bios: Use control unit type to determine boot method) 14/15 Checking commit 5ff6fc17a5ea (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/15 Checking commit ee5930c12b96 (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 448 lines checked Patch 15/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Mon, 11 Mar 2019 11:21:18 -0400 "Jason J. Herne" <jjherne@linux.ibm.com> wrote: > This is to support booting from vfio-ccw dasd devices. We basically implement > the real hardware ipl procedure. This allows for booting Linux guests on > vfio-ccw devices. > > vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl > channel programs dynamically modify themselves. Details on the ipl process and > how we worked around this issue can be found in docs/devel/s390-dasd-ipl.txt. > > ********************* > NOTE: Newer DASD units which initially present as control unit type 3990 may in > fact really be 2107. Some operating systems may enable 2107 features for these > devices thereby making sense id return a control unit type of 2107. I've added > support for control unit type 2107 so we can ipl from these devices. > ********************* Ugh. I'd have hoped that would have been recognized as A Bad Idea the last time we had a design like that... Does that cu type switch persist over subchannel enable/disable? Subsystem reset? > > Changelog > ========== > v4 > 01/16: s390 vfio-ccw: Add bootindex property and IPLB data > - Adding CCW_DEVTYPE_VIRTIO_NET type. > - s390_get_ccw_device can now accept a NULL devtype argument > - Other minor refactors > > 06/16: s390-bios: Clean up cio.h > - Remove whitespace changes to cmd_orb struct > > 07/16: s390-bios: Decouple channel i/o logic from virtio > - Fix copyright line > > 08/16: s390-bios: Map low core memory > - Remove Lowcore entries >= 0x200 > - Repositioned const keywords > > 09/16: s390-bios: ptr2u32 and u32toptr > - Add assert to ensure pointer being converted to u32 is below 32 bits in length > - Add missing copyright comment > > 10/16: s390-bios: Support for running format-0/1 channel programs > - basic_sense now calls __do_cio instead of do_cio. Further protection from > infinite recursion. > - __do_cio now asks for retry for subchannel busy case. > - Minor fixups to comments and message wording > - start.S: Formating and register naming cleanups > - Added CU_TYPE_DASD_2107 > > 11/16: s390-bios: cio error handling > - Only print sense data when it is provided > > 15/16: > - Added support for CU_TYPE_DASD_2107 > > 16/16: > - Merged with various earlier patches > > Jason J. Herne (15): > s390 vfio-ccw: Add bootindex property and IPLB data > s390-bios: decouple cio setup from virtio > s390-bios: decouple common boot logic from virtio > s390-bios: Extend find_dev() for non-virtio devices > s390-bios: Factor finding boot device out of virtio code path > s390-bios: Clean up cio.h > s390-bios: Decouple channel i/o logic from virtio > s390-bios: Map low core memory > s390-bios: ptr2u32 and u32toptr > s390-bios: Support for running format-0/1 channel programs > s390-bios: cio error handling > s390-bios: Refactor virtio to run channel programs via cio > s390-bios: Use control unit type to determine boot method > s390-bios: Add channel command codes/structs needed for dasd-ipl > s390-bios: Support booting from real dasd device > > MAINTAINERS | 2 + > docs/devel/s390-dasd-ipl.txt | 133 ++++++++++++++ > hw/s390x/ipl.c | 61 +++++-- > hw/s390x/s390-ccw.c | 9 + > hw/vfio/ccw.c | 2 +- > include/hw/s390x/s390-ccw.h | 1 + > include/hw/s390x/vfio-ccw.h | 28 +++ > pc-bios/s390-ccw/Makefile | 2 +- > pc-bios/s390-ccw/cio.c | 423 +++++++++++++++++++++++++++++++++++++++++++ > pc-bios/s390-ccw/cio.h | 270 +++++++++++++++++++++------ > pc-bios/s390-ccw/dasd-ipl.c | 250 +++++++++++++++++++++++++ > pc-bios/s390-ccw/dasd-ipl.h | 16 ++ > pc-bios/s390-ccw/helper.h | 31 ++++ > pc-bios/s390-ccw/libc.h | 11 ++ > pc-bios/s390-ccw/main.c | 161 ++++++++++------ > pc-bios/s390-ccw/netboot.mak | 2 +- > pc-bios/s390-ccw/netmain.c | 2 + > pc-bios/s390-ccw/s390-arch.h | 103 +++++++++++ > pc-bios/s390-ccw/s390-ccw.h | 10 +- > pc-bios/s390-ccw/start.S | 29 +++ > pc-bios/s390-ccw/virtio.c | 73 ++------ > tests/boot-serial-test.c | 2 +- > 22 files changed, 1425 insertions(+), 196 deletions(-) > create mode 100644 docs/devel/s390-dasd-ipl.txt > create mode 100644 include/hw/s390x/vfio-ccw.h > create mode 100644 pc-bios/s390-ccw/cio.c > create mode 100644 pc-bios/s390-ccw/dasd-ipl.c > create mode 100644 pc-bios/s390-ccw/dasd-ipl.h > create mode 100644 pc-bios/s390-ccw/helper.h > create mode 100644 pc-bios/s390-ccw/s390-arch.h > > -- > 2.7.4 >
On 3/11/19 1:33 PM, Cornelia Huck wrote: > On Mon, 11 Mar 2019 11:21:18 -0400 > "Jason J. Herne" <jjherne@linux.ibm.com> wrote: > >> This is to support booting from vfio-ccw dasd devices. We basically implement >> the real hardware ipl procedure. This allows for booting Linux guests on >> vfio-ccw devices. >> >> vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl >> channel programs dynamically modify themselves. Details on the ipl process and >> how we worked around this issue can be found in docs/devel/s390-dasd-ipl.txt. >> >> ********************* >> NOTE: Newer DASD units which initially present as control unit type 3990 may in >> fact really be 2107. Some operating systems may enable 2107 features for these >> devices thereby making sense id return a control unit type of 2107. I've added >> support for control unit type 2107 so we can ipl from these devices. >> ********************* > > Ugh. I'd have hoped that would have been recognized as A Bad Idea the > last time we had a design like that... > > Does that cu type switch persist over subchannel enable/disable? > Subsystem reset? It persists over a disable/enable, but not a reset it seems.
Patchew URL: https://patchew.org/QEMU/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1552317693-21979-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v4 00/15] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com t [tag update] patchew/20190311083234.20841-1-richardw.yang@linux.intel.com -> patchew/20190311083234.20841-1-richardw.yang@linux.intel.com Switched to a new branch 'test' 28d0ad5902 s390-bios: Support booting from real dasd device 9863aa7f1a s390-bios: Add channel command codes/structs needed for dasd-ipl a1ed77d45c s390-bios: Use control unit type to determine boot method 860ce9f087 s390-bios: Refactor virtio to run channel programs via cio 0b90862497 s390-bios: cio error handling 4a5815fd2d s390-bios: Support for running format-0/1 channel programs 6f541fc6ff s390-bios: ptr2u32 and u32toptr 5a73c3809c s390-bios: Map low core memory b6fdd420ca s390-bios: Decouple channel i/o logic from virtio ef25638533 s390-bios: Clean up cio.h 83ad1a9aaa s390-bios: Factor finding boot device out of virtio code path cc5a61d5ce s390-bios: Extend find_dev() for non-virtio devices e500fc51bf s390-bios: decouple common boot logic from virtio aa95743df7 s390-bios: decouple cio setup from virtio e57421e58c s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/15 Checking commit e57421e58ca0 (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #220: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 1/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/15 Checking commit aa95743df7d3 (s390-bios: decouple cio setup from virtio) 3/15 Checking commit e500fc51bff8 (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/15 Checking commit cc5a61d5ce83 (s390-bios: Extend find_dev() for non-virtio devices) 5/15 Checking commit 83ad1a9aaa66 (s390-bios: Factor finding boot device out of virtio code path) 6/15 Checking commit ef25638533aa (s390-bios: Clean up cio.h) 7/15 Checking commit b6fdd420cac1 (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 123 lines checked Patch 7/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/15 Checking commit 5a73c3809c0a (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 total: 0 errors, 1 warnings, 104 lines checked Patch 8/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/15 Checking commit 6f541fc6ff3c (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 31 lines checked Patch 9/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/15 Checking commit 4a5815fd2dc3 (s390-bios: Support for running format-0/1 channel programs) ERROR: trailing whitespace #137: FILE: pc-bios/s390-ccw/cio.c:145: + * active (generating i/o interrupts). $ total: 1 errors, 0 warnings, 375 lines checked Patch 10/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/15 Checking commit 0b90862497ba (s390-bios: cio error handling) 12/15 Checking commit 860ce9f0871d (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/15 Checking commit a1ed77d45c63 (s390-bios: Use control unit type to determine boot method) 14/15 Checking commit 9863aa7f1a32 (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/15 Checking commit 28d0ad590207 (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 448 lines checked Patch 15/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1552317693-21979-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com