diff mbox series

arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED

Message ID 20190312083326.18029-1-gch981213@gmail.com (mailing list archive)
State Mainlined
Commit 7e09092aee006b21d830b99f8498b5640b8711f6
Headers show
Series arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED | expand

Commit Message

Chuanhong Guo March 12, 2019, 8:33 a.m. UTC
There is a white LED on the front panel behind the logo and the
manufacturer uses that LED to indicate network and USB drive status.

Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
---
 .../boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts    | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Neil Armstrong March 12, 2019, 8:59 a.m. UTC | #1
Hi Chuanhong,

On 12/03/2019 09:33, Chuanhong Guo wrote:
> There is a white LED on the front panel behind the logo and the
> manufacturer uses that LED to indicate network and USB drive status.
> 
> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
> ---
>  .../boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts    | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> index 9a8a8a7e4b53..b5667f1fb2c8 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> @@ -14,6 +14,16 @@
>  	cvbs-connector {
>  		status = "disabled";
>  	};
> +
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		status {
> +			label = "n1:white:status";
> +			gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
> +			default-state = "on";
> +		};
> +	};
>  };
>  
>  &cvbs_vdac_port {
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

BTW, do you know if it's possible to have a sample of the Phicomm N1
in order to be added in kernelci ?

Neil
Chuanhong Guo March 12, 2019, 10:29 a.m. UTC | #2
Hi!
On Tue, Mar 12, 2019 at 4:59 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
> [...]
> BTW, do you know if it's possible to have a sample of the Phicomm N1
> in order to be added in kernelci ?
It's easy to purchase one in China and second-handed ones are dirt
cheap, but I don't think it's available worldwide.
I'm not familiar with world-wide shipping or exporting stuff so I
can't help much here.
>
> Neil
Kevin Hilman March 14, 2019, 6:08 p.m. UTC | #3
Neil Armstrong <narmstrong@baylibre.com> writes:

> Hi Chuanhong,
>
> On 12/03/2019 09:33, Chuanhong Guo wrote:
>> There is a white LED on the front panel behind the logo and the
>> manufacturer uses that LED to indicate network and USB drive status.
>> 
>> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
>> ---
>>  .../boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts    | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>> index 9a8a8a7e4b53..b5667f1fb2c8 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>> @@ -14,6 +14,16 @@
>>  	cvbs-connector {
>>  		status = "disabled";
>>  	};
>> +
>> +	leds {
>> +		compatible = "gpio-leds";
>> +
>> +		status {
>> +			label = "n1:white:status";
>> +			gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
>> +			default-state = "on";
>> +		};
>> +	};
>>  };
>>  
>>  &cvbs_vdac_port {
>> 
>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

Queued for v5.2 with Neil's tag (branch: v5.2/dt64)

Kevin
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
index 9a8a8a7e4b53..b5667f1fb2c8 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
@@ -14,6 +14,16 @@ 
 	cvbs-connector {
 		status = "disabled";
 	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		status {
+			label = "n1:white:status";
+			gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
+			default-state = "on";
+		};
+	};
 };
 
 &cvbs_vdac_port {