diff mbox series

[03/10] tests/uefi-test-tools/build.sh: work around TianoCore#1607

Message ID 20190309004826.9027-4-lersek@redhat.com (mailing list archive)
State New, archived
Headers show
Series bundle edk2 platform firmware with QEMU | expand

Commit Message

Laszlo Ersek March 9, 2019, 12:48 a.m. UTC
The edk2-stabe201903 release introduced Python3 support to edk2's
BaseTools; however the Python3 enablement breaks in a corner case (which
is nevertheless supported by the edk2 community), namely the in-module
parallelization that we utilize.

This is tracked under
<https://bugzilla.tianocore.org/show_bug.cgi?id=1607>. For now, work
around the issue (in advance) by forcing Python2. (The workaround is a
no-op before we move to edk2-stabe201903 in the roms/edk2 submodule.)

Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 tests/uefi-test-tools/build.sh | 3 +++
 1 file changed, 3 insertions(+)

Comments

Philippe Mathieu-Daudé March 12, 2019, 11:10 p.m. UTC | #1
On 3/9/19 1:48 AM, Laszlo Ersek wrote:
> The edk2-stabe201903 release introduced Python3 support to edk2's
> BaseTools; however the Python3 enablement breaks in a corner case (which
> is nevertheless supported by the edk2 community), namely the in-module
> parallelization that we utilize.
> 
> This is tracked under
> <https://bugzilla.tianocore.org/show_bug.cgi?id=1607>. For now, work
> around the issue (in advance) by forcing Python2. (The workaround is a
> no-op before we move to edk2-stabe201903 in the roms/edk2 submodule.)
> 
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  tests/uefi-test-tools/build.sh | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/uefi-test-tools/build.sh b/tests/uefi-test-tools/build.sh
> index e2b52c855c39..8aa7935c43bb 100755
> --- a/tests/uefi-test-tools/build.sh
> +++ b/tests/uefi-test-tools/build.sh
> @@ -29,6 +29,9 @@ export PACKAGES_PATH=$(realpath -- "$edk2_dir")
>  export WORKSPACE=$PWD
>  mkdir -p Conf
>  
> +# Work around <https://bugzilla.tianocore.org/show_bug.cgi?id=1607>.
> +export PYTHON_COMMAND=python2
> +
>  # Source "edksetup.sh" carefully.
>  set +e +u +C
>  source "$PACKAGES_PATH/edksetup.sh"
>
diff mbox series

Patch

diff --git a/tests/uefi-test-tools/build.sh b/tests/uefi-test-tools/build.sh
index e2b52c855c39..8aa7935c43bb 100755
--- a/tests/uefi-test-tools/build.sh
+++ b/tests/uefi-test-tools/build.sh
@@ -29,6 +29,9 @@  export PACKAGES_PATH=$(realpath -- "$edk2_dir")
 export WORKSPACE=$PWD
 mkdir -p Conf
 
+# Work around <https://bugzilla.tianocore.org/show_bug.cgi?id=1607>.
+export PYTHON_COMMAND=python2
+
 # Source "edksetup.sh" carefully.
 set +e +u +C
 source "$PACKAGES_PATH/edksetup.sh"