diff mbox series

IB/iser: remove uninitialized variable len

Message ID 20190316230512.8933-1-colin.king@canonical.com (mailing list archive)
State Mainlined
Commit 9513ea4f67280a17365f5adfa31fac7d344150c6
Delegated to: Jason Gunthorpe
Headers show
Series IB/iser: remove uninitialized variable len | expand

Commit Message

Colin King March 16, 2019, 11:05 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The variable len is not being inintialized and the uninitialized
value is being returned. However, this return path is never reached
because the default case in the switch statement returns -ENOSYS.
Clean up the code by replacing the return -ENOSYS with a break
for the default case and returning -ENOSYS at the end of the
function.  This allows len to be removed.  Also remove redundant
break that follows a return statement.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/infiniband/ulp/iser/iscsi_iser.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comments

Max Gurtovoy March 17, 2019, 10:05 a.m. UTC | #1 
On 3/17/2019 1:05 AM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> The variable len is not being inintialized and the uninitialized
> value is being returned. However, this return path is never reached
> because the default case in the switch statement returns -ENOSYS.
> Clean up the code by replacing the return -ENOSYS with a break
> for the default case and returning -ENOSYS at the end of the
> function.  This allows len to be removed.  Also remove redundant
> break that follows a return statement.
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>

Looks good,

Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Sagi Grimberg March 18, 2019, 9:44 p.m. UTC | #2 
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Jason Gunthorpe March 27, 2019, 1:21 p.m. UTC | #3 
On Sat, Mar 16, 2019 at 11:05:12PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable len is not being inintialized and the uninitialized
> value is being returned. However, this return path is never reached
> because the default case in the switch statement returns -ENOSYS.
> Clean up the code by replacing the return -ENOSYS with a break
> for the default case and returning -ENOSYS at the end of the
> function.  This allows len to be removed.  Also remove redundant
> break that follows a return statement.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> ---
>  drivers/infiniband/ulp/iser/iscsi_iser.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

Applied to for-next

Thanks,
Jason
diff mbox series

Patch

diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c
index 8c707accd148..9c185a8dabd3 100644
--- a/drivers/infiniband/ulp/iser/iscsi_iser.c
+++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
@@ -763,7 +763,6 @@  static int iscsi_iser_get_ep_param(struct iscsi_endpoint *ep,
 				   enum iscsi_param param, char *buf)
 {
 	struct iser_conn *iser_conn = ep->dd_data;
-	int len;
 
 	switch (param) {
 	case ISCSI_PARAM_CONN_PORT:
@@ -774,12 +773,10 @@  static int iscsi_iser_get_ep_param(struct iscsi_endpoint *ep,
 		return iscsi_conn_get_addr_param((struct sockaddr_storage *)
 				&iser_conn->ib_conn.cma_id->route.addr.dst_addr,
 				param, buf);
-		break;
 	default:
-		return -ENOSYS;
+		break;
 	}
-
-	return len;
+	return -ENOSYS;
 }
 
 /**