mbox series

[v3,0/8] usb: typec: fusb302: Various fixes

Message ID 20190311104818.30216-1-hdegoede@redhat.com (mailing list archive)
Headers show
Series usb: typec: fusb302: Various fixes | expand

Message

Hans de Goede March 11, 2019, 10:48 a.m. UTC 
Hi All,

Here is v3 of my fusb302 bug-fix series, the main fix in this series
makes active adapters like Type-C to HDMI (often HDMI + USB-3-A) adapters
work when they are to be powered by the Type-C port and thus present both
an Ra and a Rd resistor on their Cc pins (patch 5).

Changes in v3:

[PATCH v3 4/8] usb: typec: fusb302: Check vconn is off when we start
-Use WARN with a message describing the problem, instead of WARN_ON

[PATCH v3 5/8] usb: typec: fusb302: Fix fusb302_handle_togdone_src Ra
-Keep the delays for measuring Rd / Ra the same as before instead of
 multiplying them by a factor 100

[PATCH v3 7/8] usb: typec: fusb302: Improve suspend/resume handling
-Change devm_request_irq to a regular request_irq free_irq, so that the work
 can be properly stopped on remove

Regards,

Hans

Comments

Heikki Krogerus March 15, 2019, 2:34 p.m. UTC | #1 
On Mon, Mar 11, 2019 at 11:48:10AM +0100, Hans de Goede wrote:
> Hi All,
> 
> Here is v3 of my fusb302 bug-fix series, the main fix in this series
> makes active adapters like Type-C to HDMI (often HDMI + USB-3-A) adapters
> work when they are to be powered by the Type-C port and thus present both
> an Ra and a Rd resistor on their Cc pins (patch 5).
> 
> Changes in v3:
> 
> [PATCH v3 4/8] usb: typec: fusb302: Check vconn is off when we start
> -Use WARN with a message describing the problem, instead of WARN_ON
> 
> [PATCH v3 5/8] usb: typec: fusb302: Fix fusb302_handle_togdone_src Ra
> -Keep the delays for measuring Rd / Ra the same as before instead of
>  multiplying them by a factor 100
> 
> [PATCH v3 7/8] usb: typec: fusb302: Improve suspend/resume handling
> -Change devm_request_irq to a regular request_irq free_irq, so that the work
>  can be properly stopped on remove

I tested these, and all of them look good to me:

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

thanks,
Heikki Krogerus March 19, 2019, 1:40 p.m. UTC | #2 
On Fri, Mar 15, 2019 at 04:34:59PM +0200, Heikki Krogerus wrote:
> On Mon, Mar 11, 2019 at 11:48:10AM +0100, Hans de Goede wrote:
> > Hi All,
> > 
> > Here is v3 of my fusb302 bug-fix series, the main fix in this series
> > makes active adapters like Type-C to HDMI (often HDMI + USB-3-A) adapters
> > work when they are to be powered by the Type-C port and thus present both
> > an Ra and a Rd resistor on their Cc pins (patch 5).
> > 
> > Changes in v3:
> > 
> > [PATCH v3 4/8] usb: typec: fusb302: Check vconn is off when we start
> > -Use WARN with a message describing the problem, instead of WARN_ON
> > 
> > [PATCH v3 5/8] usb: typec: fusb302: Fix fusb302_handle_togdone_src Ra
> > -Keep the delays for measuring Rd / Ra the same as before instead of
> >  multiplying them by a factor 100
> > 
> > [PATCH v3 7/8] usb: typec: fusb302: Improve suspend/resume handling
> > -Change devm_request_irq to a regular request_irq free_irq, so that the work
> >  can be properly stopped on remove
> 
> I tested these, and all of them look good to me:
> 
> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

I've also applied the entire series to my typec-next branch:
https://github.com/krohei/linux/commits/typec-next

thanks,