diff mbox series

[3/3] ARM: DTS: imx6q-logicpd: Fix Analog audio capture

Message ID 20190306140402.17122-3-aford173@gmail.com (mailing list archive)
State Mainlined, archived
Commit 45d91250405b08a13c41d879eb70d71f22773032
Headers show
Series [1/3] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend | expand

Commit Message

Adam Ford March 6, 2019, 2:04 p.m. UTC
The original submission had functional audio out and was based
on reviewing other boards using the same wm8962 codec. However,
the Logic PD board uses an analog microphone which was being
disabled for a digital mic.  This patch corrects that and
explicitly sets the gpio-cfg pins all to 0x0000 which allows the
analog microphone to capture audio.

Fixes: 1c207f911fe9 ("ARM: dts: imx: Add support for Logic PD
i.MX6QD EVM")

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

Shawn Guo March 20, 2019, 12:46 p.m. UTC | #1
On Wed, Mar 06, 2019 at 08:04:01AM -0600, Adam Ford wrote:
> The original submission had functional audio out and was based
> on reviewing other boards using the same wm8962 codec. However,
> the Logic PD board uses an analog microphone which was being
> disabled for a digital mic.  This patch corrects that and
> explicitly sets the gpio-cfg pins all to 0x0000 which allows the
> analog microphone to capture audio.
> 
> Fixes: 1c207f911fe9 ("ARM: dts: imx: Add support for Logic PD
> i.MX6QD EVM")

If audio capture has never worked, the change is more like a "new feature"
than critical fix.

Shawn

> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> index e31b6923cb72..db6b5b900826 100644
> --- a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> +++ b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> @@ -248,9 +248,9 @@
>  		gpio-cfg = <
>  			0x0000 /* 0:Default */
>  			0x0000 /* 1:Default */
> -			0x0013 /* 2:FN_DMICCLK */
> +			0x0000 /* 2:FN_DMICCLK */
>  			0x0000 /* 3:Default */
> -			0x8014 /* 4:FN_DMICCDAT */
> +			0x0000 /* 4:FN_DMICCDAT */
>  			0x0000 /* 5:Default */
>  		>;
>  	};
> -- 
> 2.17.1
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
index e31b6923cb72..db6b5b900826 100644
--- a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
+++ b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
@@ -248,9 +248,9 @@ 
 		gpio-cfg = <
 			0x0000 /* 0:Default */
 			0x0000 /* 1:Default */
-			0x0013 /* 2:FN_DMICCLK */
+			0x0000 /* 2:FN_DMICCLK */
 			0x0000 /* 3:Default */
-			0x8014 /* 4:FN_DMICCDAT */
+			0x0000 /* 4:FN_DMICCDAT */
 			0x0000 /* 5:Default */
 		>;
 	};