| Message ID | 20190321231037.25104-4-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/15] block: add a req_bvec helper | expand |
On 22/03/2019 00:10, Christoph Hellwig wrote: > In a lot of places we want to know the DMA direction for a given > struct request. Add a little helper to make it a littler easier. You introuduce the helper here but you're using it in 8/15 for the 1st time. Could you convert the possible users to use the new helper in this patch as well?
On 3/21/19 4:11 PM, Christoph Hellwig wrote: > In a lot of places we want to know the DMA direction for a given > struct request. Add a little helper to make it a littler easier. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > include/linux/blkdev.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index f9a072610d28..5279104527ad 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -638,6 +638,9 @@ static inline bool blk_account_rq(struct request *rq) > > #define rq_data_dir(rq) (op_is_write(req_op(rq)) ? WRITE : READ) > > +#define rq_dma_dir(rq) \ > + (op_is_write(req_op(rq)) ? DMA_TO_DEVICE : DMA_FROM_DEVICE) > + > static inline bool queue_is_mq(struct request_queue *q) > { > return q->mq_ops; > Apart from Johannes's comment looks good. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On Fri, Mar 22, 2019 at 02:06:43PM +0100, Johannes Thumshirn wrote: > On 22/03/2019 00:10, Christoph Hellwig wrote: > > In a lot of places we want to know the DMA direction for a given > > struct request. Add a little helper to make it a littler easier. > > You introuduce the helper here but you're using it in 8/15 for the 1st time. > > Could you convert the possible users to use the new helper in this patch > as well? I'd rather not throw that into a nvme series. Those are easily cleanups for later. Maybe we can even encourage people that would otherwise do whitespace cleanups or incorrect refcount_t conversions to take care of it :)
On 27/03/2019 15:20, Christoph Hellwig wrote: [...] > > I'd rather not throw that into a nvme series. Those are easily cleanups > for later. Maybe we can even encourage people that would otherwise > do whitespace cleanups or incorrect refcount_t conversions to take care > of it :) Fair enough. Byte, Johannes
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index f9a072610d28..5279104527ad 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -638,6 +638,9 @@ static inline bool blk_account_rq(struct request *rq) #define rq_data_dir(rq) (op_is_write(req_op(rq)) ? WRITE : READ) +#define rq_dma_dir(rq) \ + (op_is_write(req_op(rq)) ? DMA_TO_DEVICE : DMA_FROM_DEVICE) + static inline bool queue_is_mq(struct request_queue *q) { return q->mq_ops;
In a lot of places we want to know the DMA direction for a given struct request. Add a little helper to make it a littler easier. Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/linux/blkdev.h | 3 +++ 1 file changed, 3 insertions(+)