| Message ID | 20190320054724.14636-1-david1.zhou@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/9] dma-buf: add new dma_fence_chain container v6 | expand |
Hi Chunming,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.1-rc1 next-20190320]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v6/20190320-223607
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
sparse warnings: (new ones prefixed by >>)
>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in initializer (different address spaces) @@ expected struct dma_fence [noderef] <asn:4>*__old @@ got dma_fence [noderef] <asn:4>*__old @@
drivers/dma-buf/dma-fence-chain.c:73:23: expected struct dma_fence [noderef] <asn:4>*__old
drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence *[assigned] prev
>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in initializer (different address spaces) @@ expected struct dma_fence [noderef] <asn:4>*__new @@ got dma_fence [noderef] <asn:4>*__new @@
drivers/dma-buf/dma-fence-chain.c:73:23: expected struct dma_fence [noderef] <asn:4>*__new
drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence *[assigned] replacement
>> drivers/dma-buf/dma-fence-chain.c:73:21: sparse: incorrect type in assignment (different address spaces) @@ expected struct dma_fence *tmp @@ got struct dma_fence [noderef] <struct dma_fence *tmp @@
drivers/dma-buf/dma-fence-chain.c:73:21: expected struct dma_fence *tmp
drivers/dma-buf/dma-fence-chain.c:73:21: got struct dma_fence [noderef] <asn:4>*[assigned] __ret
>> drivers/dma-buf/dma-fence-chain.c:190:28: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct dma_fence *fence @@ got struct dma_fence struct dma_fence *fence @@
drivers/dma-buf/dma-fence-chain.c:190:28: expected struct dma_fence *fence
drivers/dma-buf/dma-fence-chain.c:190:28: got struct dma_fence [noderef] <asn:4>*prev
>> drivers/dma-buf/dma-fence-chain.c:222:21: sparse: incorrect type in assignment (different address spaces) @@ expected struct dma_fence [noderef] <asn:4>*prev @@ got [noderef] <asn:4>*prev @@
drivers/dma-buf/dma-fence-chain.c:222:21: expected struct dma_fence [noderef] <asn:4>*prev
drivers/dma-buf/dma-fence-chain.c:222:21: got struct dma_fence *prev
drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression using sizeof(void)
drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression using sizeof(void)
vim +73 drivers/dma-buf/dma-fence-chain.c
38
39 /**
40 * dma_fence_chain_walk - chain walking function
41 * @fence: current chain node
42 *
43 * Walk the chain to the next node. Returns the next fence or NULL if we are at
44 * the end of the chain. Garbage collects chain nodes which are already
45 * signaled.
46 */
47 struct dma_fence *dma_fence_chain_walk(struct dma_fence *fence)
48 {
49 struct dma_fence_chain *chain, *prev_chain;
50 struct dma_fence *prev, *replacement, *tmp;
51
52 chain = to_dma_fence_chain(fence);
53 if (!chain) {
54 dma_fence_put(fence);
55 return NULL;
56 }
57
58 while ((prev = dma_fence_chain_get_prev(chain))) {
59
60 prev_chain = to_dma_fence_chain(prev);
61 if (prev_chain) {
62 if (!dma_fence_is_signaled(prev_chain->fence))
63 break;
64
65 replacement = dma_fence_chain_get_prev(prev_chain);
66 } else {
67 if (!dma_fence_is_signaled(prev))
68 break;
69
70 replacement = NULL;
71 }
72
> 73 tmp = cmpxchg(&chain->prev, prev, replacement);
74 if (tmp == prev)
75 dma_fence_put(tmp);
76 else
77 dma_fence_put(replacement);
78 dma_fence_put(prev);
79 }
80
81 dma_fence_put(fence);
82 return prev;
83 }
84 EXPORT_SYMBOL(dma_fence_chain_walk);
85
86 /**
87 * dma_fence_chain_find_seqno - find fence chain node by seqno
88 * @pfence: pointer to the chain node where to start
89 * @seqno: the sequence number to search for
90 *
91 * Advance the fence pointer to the chain node which will signal this sequence
92 * number. If no sequence number is provided then this is a no-op.
93 *
94 * Returns EINVAL if the fence is not a chain node or the sequence number has
95 * not yet advanced far enough.
96 */
97 int dma_fence_chain_find_seqno(struct dma_fence **pfence, uint64_t seqno)
98 {
99 struct dma_fence_chain *chain;
100
101 if (!seqno)
102 return 0;
103
104 chain = to_dma_fence_chain(*pfence);
105 if (!chain || chain->base.seqno < seqno)
106 return -EINVAL;
107
108 dma_fence_chain_for_each(*pfence, &chain->base) {
109 if ((*pfence)->context != chain->base.context ||
110 to_dma_fence_chain(*pfence)->prev_seqno < seqno)
111 break;
112 }
113 dma_fence_put(&chain->base);
114
115 return 0;
116 }
117 EXPORT_SYMBOL(dma_fence_chain_find_seqno);
118
119 static const char *dma_fence_chain_get_driver_name(struct dma_fence *fence)
120 {
121 return "dma_fence_chain";
122 }
123
124 static const char *dma_fence_chain_get_timeline_name(struct dma_fence *fence)
125 {
126 return "unbound";
127 }
128
129 static void dma_fence_chain_irq_work(struct irq_work *work)
130 {
131 struct dma_fence_chain *chain;
132
133 chain = container_of(work, typeof(*chain), work);
134
135 /* Try to rearm the callback */
136 if (!dma_fence_chain_enable_signaling(&chain->base))
137 /* Ok, we are done. No more unsignaled fences left */
138 dma_fence_signal(&chain->base);
139 dma_fence_put(&chain->base);
140 }
141
142 static void dma_fence_chain_cb(struct dma_fence *f, struct dma_fence_cb *cb)
143 {
144 struct dma_fence_chain *chain;
145
146 chain = container_of(cb, typeof(*chain), cb);
147 irq_work_queue(&chain->work);
148 dma_fence_put(f);
149 }
150
151 static bool dma_fence_chain_enable_signaling(struct dma_fence *fence)
152 {
153 struct dma_fence_chain *head = to_dma_fence_chain(fence);
154
155 dma_fence_get(&head->base);
156 dma_fence_chain_for_each(fence, &head->base) {
157 struct dma_fence_chain *chain = to_dma_fence_chain(fence);
158 struct dma_fence *f = chain ? chain->fence : fence;
159
160 dma_fence_get(f);
161 if (!dma_fence_add_callback(f, &head->cb, dma_fence_chain_cb)) {
162 dma_fence_put(fence);
163 return true;
164 }
165 dma_fence_put(f);
166 }
167 dma_fence_put(&head->base);
168 return false;
169 }
170
171 static bool dma_fence_chain_signaled(struct dma_fence *fence)
172 {
173 dma_fence_chain_for_each(fence, fence) {
174 struct dma_fence_chain *chain = to_dma_fence_chain(fence);
175 struct dma_fence *f = chain ? chain->fence : fence;
176
177 if (!dma_fence_is_signaled(f)) {
178 dma_fence_put(fence);
179 return false;
180 }
181 }
182
183 return true;
184 }
185
186 static void dma_fence_chain_release(struct dma_fence *fence)
187 {
188 struct dma_fence_chain *chain = to_dma_fence_chain(fence);
189
> 190 dma_fence_put(chain->prev);
191 dma_fence_put(chain->fence);
192 dma_fence_free(fence);
193 }
194
195 const struct dma_fence_ops dma_fence_chain_ops = {
196 .get_driver_name = dma_fence_chain_get_driver_name,
197 .get_timeline_name = dma_fence_chain_get_timeline_name,
198 .enable_signaling = dma_fence_chain_enable_signaling,
199 .signaled = dma_fence_chain_signaled,
200 .release = dma_fence_chain_release,
201 };
202 EXPORT_SYMBOL(dma_fence_chain_ops);
203
204 /**
205 * dma_fence_chain_init - initialize a fence chain
206 * @chain: the chain node to initialize
207 * @prev: the previous fence
208 * @fence: the current fence
209 *
210 * Initialize a new chain node and either start a new chain or add the node to
211 * the existing chain of the previous fence.
212 */
213 void dma_fence_chain_init(struct dma_fence_chain *chain,
214 struct dma_fence *prev,
215 struct dma_fence *fence,
216 uint64_t seqno)
217 {
218 struct dma_fence_chain *prev_chain = to_dma_fence_chain(prev);
219 uint64_t context;
220
221 spin_lock_init(&chain->lock);
> 222 chain->prev = prev;
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi Lionel and Christian, Below is robot report for chain->prev, which was added __rcu as you suggested. How to fix this line "tmp = cmpxchg(&chain->prev, prev, replacement); "? I checked kernel header file, seems it has no cmpxchg for rcu. Any suggestion to fix this robot report? Thanks, -David On 2019年03月21日 08:24, kbuild test robot wrote: > Hi Chunming, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on linus/master] > [also build test WARNING on v5.1-rc1 next-20190320] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v6/20190320-223607 > reproduce: > # apt-get install sparse > make ARCH=x86_64 allmodconfig > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' > > > sparse warnings: (new ones prefixed by >>) > >>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in initializer (different address spaces) @@ expected struct dma_fence [noderef] <asn:4>*__old @@ got dma_fence [noderef] <asn:4>*__old @@ > drivers/dma-buf/dma-fence-chain.c:73:23: expected struct dma_fence [noderef] <asn:4>*__old > drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence *[assigned] prev >>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in initializer (different address spaces) @@ expected struct dma_fence [noderef] <asn:4>*__new @@ got dma_fence [noderef] <asn:4>*__new @@ > drivers/dma-buf/dma-fence-chain.c:73:23: expected struct dma_fence [noderef] <asn:4>*__new > drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence *[assigned] replacement >>> drivers/dma-buf/dma-fence-chain.c:73:21: sparse: incorrect type in assignment (different address spaces) @@ expected struct dma_fence *tmp @@ got struct dma_fence [noderef] <struct dma_fence *tmp @@ > drivers/dma-buf/dma-fence-chain.c:73:21: expected struct dma_fence *tmp > drivers/dma-buf/dma-fence-chain.c:73:21: got struct dma_fence [noderef] <asn:4>*[assigned] __ret >>> drivers/dma-buf/dma-fence-chain.c:190:28: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct dma_fence *fence @@ got struct dma_fence struct dma_fence *fence @@ > drivers/dma-buf/dma-fence-chain.c:190:28: expected struct dma_fence *fence > drivers/dma-buf/dma-fence-chain.c:190:28: got struct dma_fence [noderef] <asn:4>*prev >>> drivers/dma-buf/dma-fence-chain.c:222:21: sparse: incorrect type in assignment (different address spaces) @@ expected struct dma_fence [noderef] <asn:4>*prev @@ got [noderef] <asn:4>*prev @@ > drivers/dma-buf/dma-fence-chain.c:222:21: expected struct dma_fence [noderef] <asn:4>*prev > drivers/dma-buf/dma-fence-chain.c:222:21: got struct dma_fence *prev > drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression using sizeof(void) > drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression using sizeof(void) > > vim +73 drivers/dma-buf/dma-fence-chain.c > > 38 > 39 /** > 40 * dma_fence_chain_walk - chain walking function > 41 * @fence: current chain node > 42 * > 43 * Walk the chain to the next node. Returns the next fence or NULL if we are at > 44 * the end of the chain. Garbage collects chain nodes which are already > 45 * signaled. > 46 */ > 47 struct dma_fence *dma_fence_chain_walk(struct dma_fence *fence) > 48 { > 49 struct dma_fence_chain *chain, *prev_chain; > 50 struct dma_fence *prev, *replacement, *tmp; > 51 > 52 chain = to_dma_fence_chain(fence); > 53 if (!chain) { > 54 dma_fence_put(fence); > 55 return NULL; > 56 } > 57 > 58 while ((prev = dma_fence_chain_get_prev(chain))) { > 59 > 60 prev_chain = to_dma_fence_chain(prev); > 61 if (prev_chain) { > 62 if (!dma_fence_is_signaled(prev_chain->fence)) > 63 break; > 64 > 65 replacement = dma_fence_chain_get_prev(prev_chain); > 66 } else { > 67 if (!dma_fence_is_signaled(prev)) > 68 break; > 69 > 70 replacement = NULL; > 71 } > 72 > > 73 tmp = cmpxchg(&chain->prev, prev, replacement); > 74 if (tmp == prev) > 75 dma_fence_put(tmp); > 76 else > 77 dma_fence_put(replacement); > 78 dma_fence_put(prev); > 79 } > 80 > 81 dma_fence_put(fence); > 82 return prev; > 83 } > 84 EXPORT_SYMBOL(dma_fence_chain_walk); > 85 > 86 /** > 87 * dma_fence_chain_find_seqno - find fence chain node by seqno > 88 * @pfence: pointer to the chain node where to start > 89 * @seqno: the sequence number to search for > 90 * > 91 * Advance the fence pointer to the chain node which will signal this sequence > 92 * number. If no sequence number is provided then this is a no-op. > 93 * > 94 * Returns EINVAL if the fence is not a chain node or the sequence number has > 95 * not yet advanced far enough. > 96 */ > 97 int dma_fence_chain_find_seqno(struct dma_fence **pfence, uint64_t seqno) > 98 { > 99 struct dma_fence_chain *chain; > 100 > 101 if (!seqno) > 102 return 0; > 103 > 104 chain = to_dma_fence_chain(*pfence); > 105 if (!chain || chain->base.seqno < seqno) > 106 return -EINVAL; > 107 > 108 dma_fence_chain_for_each(*pfence, &chain->base) { > 109 if ((*pfence)->context != chain->base.context || > 110 to_dma_fence_chain(*pfence)->prev_seqno < seqno) > 111 break; > 112 } > 113 dma_fence_put(&chain->base); > 114 > 115 return 0; > 116 } > 117 EXPORT_SYMBOL(dma_fence_chain_find_seqno); > 118 > 119 static const char *dma_fence_chain_get_driver_name(struct dma_fence *fence) > 120 { > 121 return "dma_fence_chain"; > 122 } > 123 > 124 static const char *dma_fence_chain_get_timeline_name(struct dma_fence *fence) > 125 { > 126 return "unbound"; > 127 } > 128 > 129 static void dma_fence_chain_irq_work(struct irq_work *work) > 130 { > 131 struct dma_fence_chain *chain; > 132 > 133 chain = container_of(work, typeof(*chain), work); > 134 > 135 /* Try to rearm the callback */ > 136 if (!dma_fence_chain_enable_signaling(&chain->base)) > 137 /* Ok, we are done. No more unsignaled fences left */ > 138 dma_fence_signal(&chain->base); > 139 dma_fence_put(&chain->base); > 140 } > 141 > 142 static void dma_fence_chain_cb(struct dma_fence *f, struct dma_fence_cb *cb) > 143 { > 144 struct dma_fence_chain *chain; > 145 > 146 chain = container_of(cb, typeof(*chain), cb); > 147 irq_work_queue(&chain->work); > 148 dma_fence_put(f); > 149 } > 150 > 151 static bool dma_fence_chain_enable_signaling(struct dma_fence *fence) > 152 { > 153 struct dma_fence_chain *head = to_dma_fence_chain(fence); > 154 > 155 dma_fence_get(&head->base); > 156 dma_fence_chain_for_each(fence, &head->base) { > 157 struct dma_fence_chain *chain = to_dma_fence_chain(fence); > 158 struct dma_fence *f = chain ? chain->fence : fence; > 159 > 160 dma_fence_get(f); > 161 if (!dma_fence_add_callback(f, &head->cb, dma_fence_chain_cb)) { > 162 dma_fence_put(fence); > 163 return true; > 164 } > 165 dma_fence_put(f); > 166 } > 167 dma_fence_put(&head->base); > 168 return false; > 169 } > 170 > 171 static bool dma_fence_chain_signaled(struct dma_fence *fence) > 172 { > 173 dma_fence_chain_for_each(fence, fence) { > 174 struct dma_fence_chain *chain = to_dma_fence_chain(fence); > 175 struct dma_fence *f = chain ? chain->fence : fence; > 176 > 177 if (!dma_fence_is_signaled(f)) { > 178 dma_fence_put(fence); > 179 return false; > 180 } > 181 } > 182 > 183 return true; > 184 } > 185 > 186 static void dma_fence_chain_release(struct dma_fence *fence) > 187 { > 188 struct dma_fence_chain *chain = to_dma_fence_chain(fence); > 189 > > 190 dma_fence_put(chain->prev); > 191 dma_fence_put(chain->fence); > 192 dma_fence_free(fence); > 193 } > 194 > 195 const struct dma_fence_ops dma_fence_chain_ops = { > 196 .get_driver_name = dma_fence_chain_get_driver_name, > 197 .get_timeline_name = dma_fence_chain_get_timeline_name, > 198 .enable_signaling = dma_fence_chain_enable_signaling, > 199 .signaled = dma_fence_chain_signaled, > 200 .release = dma_fence_chain_release, > 201 }; > 202 EXPORT_SYMBOL(dma_fence_chain_ops); > 203 > 204 /** > 205 * dma_fence_chain_init - initialize a fence chain > 206 * @chain: the chain node to initialize > 207 * @prev: the previous fence > 208 * @fence: the current fence > 209 * > 210 * Initialize a new chain node and either start a new chain or add the node to > 211 * the existing chain of the previous fence. > 212 */ > 213 void dma_fence_chain_init(struct dma_fence_chain *chain, > 214 struct dma_fence *prev, > 215 struct dma_fence *fence, > 216 uint64_t seqno) > 217 { > 218 struct dma_fence_chain *prev_chain = to_dma_fence_chain(prev); > 219 uint64_t context; > 220 > 221 spin_lock_init(&chain->lock); > > 222 chain->prev = prev; > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi David, For the cmpxchg() case I of hand don't know either. Looks like so far nobody has used cmpxchg() with rcu protected structures. The other cases should be replaced by RCU_INIT_POINTER() or rcu_dereference_protected(.., true); Regards, Christian. Am 21.03.19 um 07:34 schrieb zhoucm1: > Hi Lionel and Christian, > > Below is robot report for chain->prev, which was added __rcu as you > suggested. > > How to fix this line "tmp = cmpxchg(&chain->prev, prev, replacement); "? > I checked kernel header file, seems it has no cmpxchg for rcu. > > Any suggestion to fix this robot report? > > Thanks, > -David > > On 2019年03月21日 08:24, kbuild test robot wrote: >> Hi Chunming, >> >> I love your patch! Perhaps something to improve: >> >> [auto build test WARNING on linus/master] >> [also build test WARNING on v5.1-rc1 next-20190320] >> [if your patch is applied to the wrong git tree, please drop us a >> note to help improve the system] >> >> url: >> https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v6/20190320-223607 >> reproduce: >> # apt-get install sparse >> make ARCH=x86_64 allmodconfig >> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' >> >> >> sparse warnings: (new ones prefixed by >>) >> >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in >>>> initializer (different address spaces) @@ expected struct >>>> dma_fence [noderef] <asn:4>*__old @@ got dma_fence [noderef] >>>> <asn:4>*__old @@ >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct >> dma_fence [noderef] <asn:4>*__old >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence >> *[assigned] prev >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in >>>> initializer (different address spaces) @@ expected struct >>>> dma_fence [noderef] <asn:4>*__new @@ got dma_fence [noderef] >>>> <asn:4>*__new @@ >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct >> dma_fence [noderef] <asn:4>*__new >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence >> *[assigned] replacement >>>> drivers/dma-buf/dma-fence-chain.c:73:21: sparse: incorrect type in >>>> assignment (different address spaces) @@ expected struct >>>> dma_fence *tmp @@ got struct dma_fence [noderef] <struct >>>> dma_fence *tmp @@ >> drivers/dma-buf/dma-fence-chain.c:73:21: expected struct >> dma_fence *tmp >> drivers/dma-buf/dma-fence-chain.c:73:21: got struct dma_fence >> [noderef] <asn:4>*[assigned] __ret >>>> drivers/dma-buf/dma-fence-chain.c:190:28: sparse: incorrect type in >>>> argument 1 (different address spaces) @@ expected struct >>>> dma_fence *fence @@ got struct dma_fence struct dma_fence *fence @@ >> drivers/dma-buf/dma-fence-chain.c:190:28: expected struct >> dma_fence *fence >> drivers/dma-buf/dma-fence-chain.c:190:28: got struct dma_fence >> [noderef] <asn:4>*prev >>>> drivers/dma-buf/dma-fence-chain.c:222:21: sparse: incorrect type in >>>> assignment (different address spaces) @@ expected struct >>>> dma_fence [noderef] <asn:4>*prev @@ got [noderef] <asn:4>*prev @@ >> drivers/dma-buf/dma-fence-chain.c:222:21: expected struct >> dma_fence [noderef] <asn:4>*prev >> drivers/dma-buf/dma-fence-chain.c:222:21: got struct dma_fence >> *prev >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression >> using sizeof(void) >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression >> using sizeof(void) >> >> vim +73 drivers/dma-buf/dma-fence-chain.c >> >> 38 >> 39 /** >> 40 * dma_fence_chain_walk - chain walking function >> 41 * @fence: current chain node >> 42 * >> 43 * Walk the chain to the next node. Returns the next fence >> or NULL if we are at >> 44 * the end of the chain. Garbage collects chain nodes >> which are already >> 45 * signaled. >> 46 */ >> 47 struct dma_fence *dma_fence_chain_walk(struct dma_fence >> *fence) >> 48 { >> 49 struct dma_fence_chain *chain, *prev_chain; >> 50 struct dma_fence *prev, *replacement, *tmp; >> 51 >> 52 chain = to_dma_fence_chain(fence); >> 53 if (!chain) { >> 54 dma_fence_put(fence); >> 55 return NULL; >> 56 } >> 57 >> 58 while ((prev = dma_fence_chain_get_prev(chain))) { >> 59 >> 60 prev_chain = to_dma_fence_chain(prev); >> 61 if (prev_chain) { >> 62 if (!dma_fence_is_signaled(prev_chain->fence)) >> 63 break; >> 64 >> 65 replacement = >> dma_fence_chain_get_prev(prev_chain); >> 66 } else { >> 67 if (!dma_fence_is_signaled(prev)) >> 68 break; >> 69 >> 70 replacement = NULL; >> 71 } >> 72 >> > 73 tmp = cmpxchg(&chain->prev, prev, replacement); >> 74 if (tmp == prev) >> 75 dma_fence_put(tmp); >> 76 else >> 77 dma_fence_put(replacement); >> 78 dma_fence_put(prev); >> 79 } >> 80 >> 81 dma_fence_put(fence); >> 82 return prev; >> 83 } >> 84 EXPORT_SYMBOL(dma_fence_chain_walk); >> 85 >> 86 /** >> 87 * dma_fence_chain_find_seqno - find fence chain node by >> seqno >> 88 * @pfence: pointer to the chain node where to start >> 89 * @seqno: the sequence number to search for >> 90 * >> 91 * Advance the fence pointer to the chain node which will >> signal this sequence >> 92 * number. If no sequence number is provided then this is >> a no-op. >> 93 * >> 94 * Returns EINVAL if the fence is not a chain node or the >> sequence number has >> 95 * not yet advanced far enough. >> 96 */ >> 97 int dma_fence_chain_find_seqno(struct dma_fence **pfence, >> uint64_t seqno) >> 98 { >> 99 struct dma_fence_chain *chain; >> 100 >> 101 if (!seqno) >> 102 return 0; >> 103 >> 104 chain = to_dma_fence_chain(*pfence); >> 105 if (!chain || chain->base.seqno < seqno) >> 106 return -EINVAL; >> 107 >> 108 dma_fence_chain_for_each(*pfence, &chain->base) { >> 109 if ((*pfence)->context != chain->base.context || >> 110 to_dma_fence_chain(*pfence)->prev_seqno < seqno) >> 111 break; >> 112 } >> 113 dma_fence_put(&chain->base); >> 114 >> 115 return 0; >> 116 } >> 117 EXPORT_SYMBOL(dma_fence_chain_find_seqno); >> 118 >> 119 static const char *dma_fence_chain_get_driver_name(struct >> dma_fence *fence) >> 120 { >> 121 return "dma_fence_chain"; >> 122 } >> 123 >> 124 static const char >> *dma_fence_chain_get_timeline_name(struct dma_fence *fence) >> 125 { >> 126 return "unbound"; >> 127 } >> 128 >> 129 static void dma_fence_chain_irq_work(struct irq_work *work) >> 130 { >> 131 struct dma_fence_chain *chain; >> 132 >> 133 chain = container_of(work, typeof(*chain), work); >> 134 >> 135 /* Try to rearm the callback */ >> 136 if (!dma_fence_chain_enable_signaling(&chain->base)) >> 137 /* Ok, we are done. No more unsignaled fences left */ >> 138 dma_fence_signal(&chain->base); >> 139 dma_fence_put(&chain->base); >> 140 } >> 141 >> 142 static void dma_fence_chain_cb(struct dma_fence *f, struct >> dma_fence_cb *cb) >> 143 { >> 144 struct dma_fence_chain *chain; >> 145 >> 146 chain = container_of(cb, typeof(*chain), cb); >> 147 irq_work_queue(&chain->work); >> 148 dma_fence_put(f); >> 149 } >> 150 >> 151 static bool dma_fence_chain_enable_signaling(struct >> dma_fence *fence) >> 152 { >> 153 struct dma_fence_chain *head = to_dma_fence_chain(fence); >> 154 >> 155 dma_fence_get(&head->base); >> 156 dma_fence_chain_for_each(fence, &head->base) { >> 157 struct dma_fence_chain *chain = >> to_dma_fence_chain(fence); >> 158 struct dma_fence *f = chain ? chain->fence : fence; >> 159 >> 160 dma_fence_get(f); >> 161 if (!dma_fence_add_callback(f, &head->cb, >> dma_fence_chain_cb)) { >> 162 dma_fence_put(fence); >> 163 return true; >> 164 } >> 165 dma_fence_put(f); >> 166 } >> 167 dma_fence_put(&head->base); >> 168 return false; >> 169 } >> 170 >> 171 static bool dma_fence_chain_signaled(struct dma_fence *fence) >> 172 { >> 173 dma_fence_chain_for_each(fence, fence) { >> 174 struct dma_fence_chain *chain = >> to_dma_fence_chain(fence); >> 175 struct dma_fence *f = chain ? chain->fence : fence; >> 176 >> 177 if (!dma_fence_is_signaled(f)) { >> 178 dma_fence_put(fence); >> 179 return false; >> 180 } >> 181 } >> 182 >> 183 return true; >> 184 } >> 185 >> 186 static void dma_fence_chain_release(struct dma_fence *fence) >> 187 { >> 188 struct dma_fence_chain *chain = >> to_dma_fence_chain(fence); >> 189 >> > 190 dma_fence_put(chain->prev); >> 191 dma_fence_put(chain->fence); >> 192 dma_fence_free(fence); >> 193 } >> 194 >> 195 const struct dma_fence_ops dma_fence_chain_ops = { >> 196 .get_driver_name = dma_fence_chain_get_driver_name, >> 197 .get_timeline_name = dma_fence_chain_get_timeline_name, >> 198 .enable_signaling = dma_fence_chain_enable_signaling, >> 199 .signaled = dma_fence_chain_signaled, >> 200 .release = dma_fence_chain_release, >> 201 }; >> 202 EXPORT_SYMBOL(dma_fence_chain_ops); >> 203 >> 204 /** >> 205 * dma_fence_chain_init - initialize a fence chain >> 206 * @chain: the chain node to initialize >> 207 * @prev: the previous fence >> 208 * @fence: the current fence >> 209 * >> 210 * Initialize a new chain node and either start a new >> chain or add the node to >> 211 * the existing chain of the previous fence. >> 212 */ >> 213 void dma_fence_chain_init(struct dma_fence_chain *chain, >> 214 struct dma_fence *prev, >> 215 struct dma_fence *fence, >> 216 uint64_t seqno) >> 217 { >> 218 struct dma_fence_chain *prev_chain = >> to_dma_fence_chain(prev); >> 219 uint64_t context; >> 220 >> 221 spin_lock_init(&chain->lock); >> > 222 chain->prev = prev; >> >> --- >> 0-DAY kernel test infrastructure Open Source >> Technology Center >> https://lists.01.org/pipermail/kbuild-all Intel Corporation >
cmpxchg be replaced by some simple c sentance? otherwise we have to remove __rcu of chian->prev. -David -------- Original Message -------- Subject: Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6 From: Christian König To: "Zhou, David(ChunMing)" ,kbuild test robot ,"Zhou, David(ChunMing)" CC: kbuild-all@01.org,dri-devel@lists.freedesktop.org,amd-gfx@lists.freedesktop.org,lionel.g.landwerlin@intel.com,jason@jlekstrand.net,"Koenig, Christian" ,"Hector, Tobias" Hi David, For the cmpxchg() case I of hand don't know either. Looks like so far nobody has used cmpxchg() with rcu protected structures. The other cases should be replaced by RCU_INIT_POINTER() or rcu_dereference_protected(.., true); Regards, Christian. Am 21.03.19 um 07:34 schrieb zhoucm1: > Hi Lionel and Christian, > > Below is robot report for chain->prev, which was added __rcu as you > suggested. > > How to fix this line "tmp = cmpxchg(&chain->prev, prev, replacement); "? > I checked kernel header file, seems it has no cmpxchg for rcu. > > Any suggestion to fix this robot report? > > Thanks, > -David > > On 2019年03月21日 08:24, kbuild test robot wrote: >> Hi Chunming, >> >> I love your patch! Perhaps something to improve: >> >> [auto build test WARNING on linus/master] >> [also build test WARNING on v5.1-rc1 next-20190320] >> [if your patch is applied to the wrong git tree, please drop us a >> note to help improve the system] >> >> url: >> https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v6/20190320-223607 >> reproduce: >> # apt-get install sparse >> make ARCH=x86_64 allmodconfig >> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' >> >> >> sparse warnings: (new ones prefixed by >>) >> >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in >>>> initializer (different address spaces) @@ expected struct >>>> dma_fence [noderef] <asn:4>*__old @@ got dma_fence [noderef] >>>> <asn:4>*__old @@ >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct >> dma_fence [noderef] <asn:4>*__old >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence >> *[assigned] prev >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in >>>> initializer (different address spaces) @@ expected struct >>>> dma_fence [noderef] <asn:4>*__new @@ got dma_fence [noderef] >>>> <asn:4>*__new @@ >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct >> dma_fence [noderef] <asn:4>*__new >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence >> *[assigned] replacement >>>> drivers/dma-buf/dma-fence-chain.c:73:21: sparse: incorrect type in >>>> assignment (different address spaces) @@ expected struct >>>> dma_fence *tmp @@ got struct dma_fence [noderef] <struct >>>> dma_fence *tmp @@ >> drivers/dma-buf/dma-fence-chain.c:73:21: expected struct >> dma_fence *tmp >> drivers/dma-buf/dma-fence-chain.c:73:21: got struct dma_fence >> [noderef] <asn:4>*[assigned] __ret >>>> drivers/dma-buf/dma-fence-chain.c:190:28: sparse: incorrect type in >>>> argument 1 (different address spaces) @@ expected struct >>>> dma_fence *fence @@ got struct dma_fence struct dma_fence *fence @@ >> drivers/dma-buf/dma-fence-chain.c:190:28: expected struct >> dma_fence *fence >> drivers/dma-buf/dma-fence-chain.c:190:28: got struct dma_fence >> [noderef] <asn:4>*prev >>>> drivers/dma-buf/dma-fence-chain.c:222:21: sparse: incorrect type in >>>> assignment (different address spaces) @@ expected struct >>>> dma_fence [noderef] <asn:4>*prev @@ got [noderef] <asn:4>*prev @@ >> drivers/dma-buf/dma-fence-chain.c:222:21: expected struct >> dma_fence [noderef] <asn:4>*prev >> drivers/dma-buf/dma-fence-chain.c:222:21: got struct dma_fence >> *prev >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression >> using sizeof(void) >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression >> using sizeof(void) >> >> vim +73 drivers/dma-buf/dma-fence-chain.c >> >> 38 >> 39 /** >> 40 * dma_fence_chain_walk - chain walking function >> 41 * @fence: current chain node >> 42 * >> 43 * Walk the chain to the next node. Returns the next fence >> or NULL if we are at >> 44 * the end of the chain. Garbage collects chain nodes >> which are already >> 45 * signaled. >> 46 */ >> 47 struct dma_fence *dma_fence_chain_walk(struct dma_fence >> *fence) >> 48 { >> 49 struct dma_fence_chain *chain, *prev_chain; >> 50 struct dma_fence *prev, *replacement, *tmp; >> 51 >> 52 chain = to_dma_fence_chain(fence); >> 53 if (!chain) { >> 54 dma_fence_put(fence); >> 55 return NULL; >> 56 } >> 57 >> 58 while ((prev = dma_fence_chain_get_prev(chain))) { >> 59 >> 60 prev_chain = to_dma_fence_chain(prev); >> 61 if (prev_chain) { >> 62 if (!dma_fence_is_signaled(prev_chain->fence)) >> 63 break; >> 64 >> 65 replacement = >> dma_fence_chain_get_prev(prev_chain); >> 66 } else { >> 67 if (!dma_fence_is_signaled(prev)) >> 68 break; >> 69 >> 70 replacement = NULL; >> 71 } >> 72 >> > 73 tmp = cmpxchg(&chain->prev, prev, replacement); >> 74 if (tmp == prev) >> 75 dma_fence_put(tmp); >> 76 else >> 77 dma_fence_put(replacement); >> 78 dma_fence_put(prev); >> 79 } >> 80 >> 81 dma_fence_put(fence); >> 82 return prev; >> 83 } >> 84 EXPORT_SYMBOL(dma_fence_chain_walk); >> 85 >> 86 /** >> 87 * dma_fence_chain_find_seqno - find fence chain node by >> seqno >> 88 * @pfence: pointer to the chain node where to start >> 89 * @seqno: the sequence number to search for >> 90 * >> 91 * Advance the fence pointer to the chain node which will >> signal this sequence >> 92 * number. If no sequence number is provided then this is >> a no-op. >> 93 * >> 94 * Returns EINVAL if the fence is not a chain node or the >> sequence number has >> 95 * not yet advanced far enough. >> 96 */ >> 97 int dma_fence_chain_find_seqno(struct dma_fence **pfence, >> uint64_t seqno) >> 98 { >> 99 struct dma_fence_chain *chain; >> 100 >> 101 if (!seqno) >> 102 return 0; >> 103 >> 104 chain = to_dma_fence_chain(*pfence); >> 105 if (!chain || chain->base.seqno < seqno) >> 106 return -EINVAL; >> 107 >> 108 dma_fence_chain_for_each(*pfence, &chain->base) { >> 109 if ((*pfence)->context != chain->base.context || >> 110 to_dma_fence_chain(*pfence)->prev_seqno < seqno) >> 111 break; >> 112 } >> 113 dma_fence_put(&chain->base); >> 114 >> 115 return 0; >> 116 } >> 117 EXPORT_SYMBOL(dma_fence_chain_find_seqno); >> 118 >> 119 static const char *dma_fence_chain_get_driver_name(struct >> dma_fence *fence) >> 120 { >> 121 return "dma_fence_chain"; >> 122 } >> 123 >> 124 static const char >> *dma_fence_chain_get_timeline_name(struct dma_fence *fence) >> 125 { >> 126 return "unbound"; >> 127 } >> 128 >> 129 static void dma_fence_chain_irq_work(struct irq_work *work) >> 130 { >> 131 struct dma_fence_chain *chain; >> 132 >> 133 chain = container_of(work, typeof(*chain), work); >> 134 >> 135 /* Try to rearm the callback */ >> 136 if (!dma_fence_chain_enable_signaling(&chain->base)) >> 137 /* Ok, we are done. No more unsignaled fences left */ >> 138 dma_fence_signal(&chain->base); >> 139 dma_fence_put(&chain->base); >> 140 } >> 141 >> 142 static void dma_fence_chain_cb(struct dma_fence *f, struct >> dma_fence_cb *cb) >> 143 { >> 144 struct dma_fence_chain *chain; >> 145 >> 146 chain = container_of(cb, typeof(*chain), cb); >> 147 irq_work_queue(&chain->work); >> 148 dma_fence_put(f); >> 149 } >> 150 >> 151 static bool dma_fence_chain_enable_signaling(struct >> dma_fence *fence) >> 152 { >> 153 struct dma_fence_chain *head = to_dma_fence_chain(fence); >> 154 >> 155 dma_fence_get(&head->base); >> 156 dma_fence_chain_for_each(fence, &head->base) { >> 157 struct dma_fence_chain *chain = >> to_dma_fence_chain(fence); >> 158 struct dma_fence *f = chain ? chain->fence : fence; >> 159 >> 160 dma_fence_get(f); >> 161 if (!dma_fence_add_callback(f, &head->cb, >> dma_fence_chain_cb)) { >> 162 dma_fence_put(fence); >> 163 return true; >> 164 } >> 165 dma_fence_put(f); >> 166 } >> 167 dma_fence_put(&head->base); >> 168 return false; >> 169 } >> 170 >> 171 static bool dma_fence_chain_signaled(struct dma_fence *fence) >> 172 { >> 173 dma_fence_chain_for_each(fence, fence) { >> 174 struct dma_fence_chain *chain = >> to_dma_fence_chain(fence); >> 175 struct dma_fence *f = chain ? chain->fence : fence; >> 176 >> 177 if (!dma_fence_is_signaled(f)) { >> 178 dma_fence_put(fence); >> 179 return false; >> 180 } >> 181 } >> 182 >> 183 return true; >> 184 } >> 185 >> 186 static void dma_fence_chain_release(struct dma_fence *fence) >> 187 { >> 188 struct dma_fence_chain *chain = >> to_dma_fence_chain(fence); >> 189 >> > 190 dma_fence_put(chain->prev); >> 191 dma_fence_put(chain->fence); >> 192 dma_fence_free(fence); >> 193 } >> 194 >> 195 const struct dma_fence_ops dma_fence_chain_ops = { >> 196 .get_driver_name = dma_fence_chain_get_driver_name, >> 197 .get_timeline_name = dma_fence_chain_get_timeline_name, >> 198 .enable_signaling = dma_fence_chain_enable_signaling, >> 199 .signaled = dma_fence_chain_signaled, >> 200 .release = dma_fence_chain_release, >> 201 }; >> 202 EXPORT_SYMBOL(dma_fence_chain_ops); >> 203 >> 204 /** >> 205 * dma_fence_chain_init - initialize a fence chain >> 206 * @chain: the chain node to initialize >> 207 * @prev: the previous fence >> 208 * @fence: the current fence >> 209 * >> 210 * Initialize a new chain node and either start a new >> chain or add the node to >> 211 * the existing chain of the previous fence. >> 212 */ >> 213 void dma_fence_chain_init(struct dma_fence_chain *chain, >> 214 struct dma_fence *prev, >> 215 struct dma_fence *fence, >> 216 uint64_t seqno) >> 217 { >> 218 struct dma_fence_chain *prev_chain = >> to_dma_fence_chain(prev); >> 219 uint64_t context; >> 220 >> 221 spin_lock_init(&chain->lock); >> > 222 chain->prev = prev; >> >> --- >> 0-DAY kernel test infrastructure Open Source >> Technology Center >> https://lists.01.org/pipermail/kbuild-all Intel Corporation > <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Exchange Server"> <!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style> </head> <body> <div>cmpxchg be replaced by some simple c sentance?<br> otherwise we have to remove __rcu of chian->prev.<br> <br> -David<br> <br> -------- Original Message --------<br> Subject: Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6<br> From: Christian König <br> To: "Zhou, David(ChunMing)" ,kbuild test robot ,"Zhou, David(ChunMing)" <br> CC: kbuild-all@01.org,dri-devel@lists.freedesktop.org,amd-gfx@lists.freedesktop.org,lionel.g.landwerlin@intel.com,jason@jlekstrand.net,"Koenig, Christian" ,"Hector, Tobias" <br> <br> </div> <font size="2"><span style="font-size:11pt;"> <div class="PlainText">Hi David,<br> <br> For the cmpxchg() case I of hand don't know either. Looks like so far <br> nobody has used cmpxchg() with rcu protected structures.<br> <br> The other cases should be replaced by RCU_INIT_POINTER() or <br> rcu_dereference_protected(.., true);<br> <br> Regards,<br> Christian.<br> <br> Am 21.03.19 um 07:34 schrieb zhoucm1:<br> > Hi Lionel and Christian,<br> ><br> > Below is robot report for chain->prev, which was added __rcu as you <br> > suggested.<br> ><br> > How to fix this line "tmp = cmpxchg(&chain->prev, prev, replacement); "?<br> > I checked kernel header file, seems it has no cmpxchg for rcu.<br> ><br> > Any suggestion to fix this robot report?<br> ><br> > Thanks,<br> > -David<br> ><br> > On 2019年03月21日 08:24, kbuild test robot wrote:<br> >> Hi Chunming,<br> >><br> >> I love your patch! Perhaps something to improve:<br> >><br> >> [auto build test WARNING on linus/master]<br> >> [also build test WARNING on v5.1-rc1 next-20190320]<br> >> [if your patch is applied to the wrong git tree, please drop us a <br> >> note to help improve the system]<br> >><br> >> url: <br> >> <a href="https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v6/20190320-223607"> https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v6/20190320-223607</a><br> >> reproduce:<br> >> # apt-get install sparse<br> >> make ARCH=x86_64 allmodconfig<br> >> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'<br> >><br> >><br> >> sparse warnings: (new ones prefixed by >>)<br> >><br> >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in <br> >>>> initializer (different address spaces) @@ expected struct <br> >>>> dma_fence [noderef] <asn:4>*__old @@ got dma_fence [noderef] <br> >>>> <asn:4>*__old @@<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct <br> >> dma_fence [noderef] <asn:4>*__old<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence <br> >> *[assigned] prev<br> >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in <br> >>>> initializer (different address spaces) @@ expected struct <br> >>>> dma_fence [noderef] <asn:4>*__new @@ got dma_fence [noderef] <br> >>>> <asn:4>*__new @@<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct <br> >> dma_fence [noderef] <asn:4>*__new<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence <br> >> *[assigned] replacement<br> >>>> drivers/dma-buf/dma-fence-chain.c:73:21: sparse: incorrect type in <br> >>>> assignment (different address spaces) @@ expected struct <br> >>>> dma_fence *tmp @@ got struct dma_fence [noderef] <struct <br> >>>> dma_fence *tmp @@<br> >> drivers/dma-buf/dma-fence-chain.c:73:21: expected struct <br> >> dma_fence *tmp<br> >> drivers/dma-buf/dma-fence-chain.c:73:21: got struct dma_fence <br> >> [noderef] <asn:4>*[assigned] __ret<br> >>>> drivers/dma-buf/dma-fence-chain.c:190:28: sparse: incorrect type in <br> >>>> argument 1 (different address spaces) @@ expected struct <br> >>>> dma_fence *fence @@ got struct dma_fence struct dma_fence *fence @@<br> >> drivers/dma-buf/dma-fence-chain.c:190:28: expected struct <br> >> dma_fence *fence<br> >> drivers/dma-buf/dma-fence-chain.c:190:28: got struct dma_fence <br> >> [noderef] <asn:4>*prev<br> >>>> drivers/dma-buf/dma-fence-chain.c:222:21: sparse: incorrect type in <br> >>>> assignment (different address spaces) @@ expected struct <br> >>>> dma_fence [noderef] <asn:4>*prev @@ got [noderef] <asn:4>*prev @@<br> >> drivers/dma-buf/dma-fence-chain.c:222:21: expected struct <br> >> dma_fence [noderef] <asn:4>*prev<br> >> drivers/dma-buf/dma-fence-chain.c:222:21: got struct dma_fence <br> >> *prev<br> >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression <br> >> using sizeof(void)<br> >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression <br> >> using sizeof(void)<br> >><br> >> vim +73 drivers/dma-buf/dma-fence-chain.c<br> >><br> >> 38<br> >> 39 /**<br> >> 40 * dma_fence_chain_walk - chain walking function<br> >> 41 * @fence: current chain node<br> >> 42 *<br> >> 43 * Walk the chain to the next node. Returns the next fence <br> >> or NULL if we are at<br> >> 44 * the end of the chain. Garbage collects chain nodes <br> >> which are already<br> >> 45 * signaled.<br> >> 46 */<br> >> 47 struct dma_fence *dma_fence_chain_walk(struct dma_fence <br> >> *fence)<br> >> 48 {<br> >> 49 struct dma_fence_chain *chain, *prev_chain;<br> >> 50 struct dma_fence *prev, *replacement, *tmp;<br> >> 51<br> >> 52 chain = to_dma_fence_chain(fence);<br> >> 53 if (!chain) {<br> >> 54 dma_fence_put(fence);<br> >> 55 return NULL;<br> >> 56 }<br> >> 57<br> >> 58 while ((prev = dma_fence_chain_get_prev(chain))) {<br> >> 59<br> >> 60 prev_chain = to_dma_fence_chain(prev);<br> >> 61 if (prev_chain) {<br> >> 62 if (!dma_fence_is_signaled(prev_chain->fence))<br> >> 63 break;<br> >> 64<br> >> 65 replacement = <br> >> dma_fence_chain_get_prev(prev_chain);<br> >> 66 } else {<br> >> 67 if (!dma_fence_is_signaled(prev))<br> >> 68 break;<br> >> 69<br> >> 70 replacement = NULL;<br> >> 71 }<br> >> 72<br> >> > 73 tmp = cmpxchg(&chain->prev, prev, replacement);<br> >> 74 if (tmp == prev)<br> >> 75 dma_fence_put(tmp);<br> >> 76 else<br> >> 77 dma_fence_put(replacement);<br> >> 78 dma_fence_put(prev);<br> >> 79 }<br> >> 80<br> >> 81 dma_fence_put(fence);<br> >> 82 return prev;<br> >> 83 }<br> >> 84 EXPORT_SYMBOL(dma_fence_chain_walk);<br> >> 85<br> >> 86 /**<br> >> 87 * dma_fence_chain_find_seqno - find fence chain node by <br> >> seqno<br> >> 88 * @pfence: pointer to the chain node where to start<br> >> 89 * @seqno: the sequence number to search for<br> >> 90 *<br> >> 91 * Advance the fence pointer to the chain node which will <br> >> signal this sequence<br> >> 92 * number. If no sequence number is provided then this is <br> >> a no-op.<br> >> 93 *<br> >> 94 * Returns EINVAL if the fence is not a chain node or the <br> >> sequence number has<br> >> 95 * not yet advanced far enough.<br> >> 96 */<br> >> 97 int dma_fence_chain_find_seqno(struct dma_fence **pfence, <br> >> uint64_t seqno)<br> >> 98 {<br> >> 99 struct dma_fence_chain *chain;<br> >> 100<br> >> 101 if (!seqno)<br> >> 102 return 0;<br> >> 103<br> >> 104 chain = to_dma_fence_chain(*pfence);<br> >> 105 if (!chain || chain->base.seqno < seqno)<br> >> 106 return -EINVAL;<br> >> 107<br> >> 108 dma_fence_chain_for_each(*pfence, &chain->base) {<br> >> 109 if ((*pfence)->context != chain->base.context ||<br> >> 110 to_dma_fence_chain(*pfence)->prev_seqno < seqno)<br> >> 111 break;<br> >> 112 }<br> >> 113 dma_fence_put(&chain->base);<br> >> 114<br> >> 115 return 0;<br> >> 116 }<br> >> 117 EXPORT_SYMBOL(dma_fence_chain_find_seqno);<br> >> 118<br> >> 119 static const char *dma_fence_chain_get_driver_name(struct <br> >> dma_fence *fence)<br> >> 120 {<br> >> 121 return "dma_fence_chain";<br> >> 122 }<br> >> 123<br> >> 124 static const char <br> >> *dma_fence_chain_get_timeline_name(struct dma_fence *fence)<br> >> 125 {<br> >> 126 return "unbound";<br> >> 127 }<br> >> 128<br> >> 129 static void dma_fence_chain_irq_work(struct irq_work *work)<br> >> 130 {<br> >> 131 struct dma_fence_chain *chain;<br> >> 132<br> >> 133 chain = container_of(work, typeof(*chain), work);<br> >> 134<br> >> 135 /* Try to rearm the callback */<br> >> 136 if (!dma_fence_chain_enable_signaling(&chain->base))<br> >> 137 /* Ok, we are done. No more unsignaled fences left */<br> >> 138 dma_fence_signal(&chain->base);<br> >> 139 dma_fence_put(&chain->base);<br> >> 140 }<br> >> 141<br> >> 142 static void dma_fence_chain_cb(struct dma_fence *f, struct <br> >> dma_fence_cb *cb)<br> >> 143 {<br> >> 144 struct dma_fence_chain *chain;<br> >> 145<br> >> 146 chain = container_of(cb, typeof(*chain), cb);<br> >> 147 irq_work_queue(&chain->work);<br> >> 148 dma_fence_put(f);<br> >> 149 }<br> >> 150<br> >> 151 static bool dma_fence_chain_enable_signaling(struct <br> >> dma_fence *fence)<br> >> 152 {<br> >> 153 struct dma_fence_chain *head = to_dma_fence_chain(fence);<br> >> 154<br> >> 155 dma_fence_get(&head->base);<br> >> 156 dma_fence_chain_for_each(fence, &head->base) {<br> >> 157 struct dma_fence_chain *chain = <br> >> to_dma_fence_chain(fence);<br> >> 158 struct dma_fence *f = chain ? chain->fence : fence;<br> >> 159<br> >> 160 dma_fence_get(f);<br> >> 161 if (!dma_fence_add_callback(f, &head->cb, <br> >> dma_fence_chain_cb)) {<br> >> 162 dma_fence_put(fence);<br> >> 163 return true;<br> >> 164 }<br> >> 165 dma_fence_put(f);<br> >> 166 }<br> >> 167 dma_fence_put(&head->base);<br> >> 168 return false;<br> >> 169 }<br> >> 170<br> >> 171 static bool dma_fence_chain_signaled(struct dma_fence *fence)<br> >> 172 {<br> >> 173 dma_fence_chain_for_each(fence, fence) {<br> >> 174 struct dma_fence_chain *chain = <br> >> to_dma_fence_chain(fence);<br> >> 175 struct dma_fence *f = chain ? chain->fence : fence;<br> >> 176<br> >> 177 if (!dma_fence_is_signaled(f)) {<br> >> 178 dma_fence_put(fence);<br> >> 179 return false;<br> >> 180 }<br> >> 181 }<br> >> 182<br> >> 183 return true;<br> >> 184 }<br> >> 185<br> >> 186 static void dma_fence_chain_release(struct dma_fence *fence)<br> >> 187 {<br> >> 188 struct dma_fence_chain *chain = <br> >> to_dma_fence_chain(fence);<br> >> 189<br> >> > 190 dma_fence_put(chain->prev);<br> >> 191 dma_fence_put(chain->fence);<br> >> 192 dma_fence_free(fence);<br> >> 193 }<br> >> 194<br> >> 195 const struct dma_fence_ops dma_fence_chain_ops = {<br> >> 196 .get_driver_name = dma_fence_chain_get_driver_name,<br> >> 197 .get_timeline_name = dma_fence_chain_get_timeline_name,<br> >> 198 .enable_signaling = dma_fence_chain_enable_signaling,<br> >> 199 .signaled = dma_fence_chain_signaled,<br> >> 200 .release = dma_fence_chain_release,<br> >> 201 };<br> >> 202 EXPORT_SYMBOL(dma_fence_chain_ops);<br> >> 203<br> >> 204 /**<br> >> 205 * dma_fence_chain_init - initialize a fence chain<br> >> 206 * @chain: the chain node to initialize<br> >> 207 * @prev: the previous fence<br> >> 208 * @fence: the current fence<br> >> 209 *<br> >> 210 * Initialize a new chain node and either start a new <br> >> chain or add the node to<br> >> 211 * the existing chain of the previous fence.<br> >> 212 */<br> >> 213 void dma_fence_chain_init(struct dma_fence_chain *chain,<br> >> 214 struct dma_fence *prev,<br> >> 215 struct dma_fence *fence,<br> >> 216 uint64_t seqno)<br> >> 217 {<br> >> 218 struct dma_fence_chain *prev_chain = <br> >> to_dma_fence_chain(prev);<br> >> 219 uint64_t context;<br> >> 220<br> >> 221 spin_lock_init(&chain->lock);<br> >> > 222 chain->prev = prev;<br> >><br> >> ---<br> >> 0-DAY kernel test infrastructure Open Source <br> >> Technology Center<br> >> <a href="https://lists.01.org/pipermail/kbuild-all">https://lists.01.org/pipermail/kbuild-all</a> Intel Corporation<br> ><br> <br> </div> </span></font> </body> </html>
No, atomic cmpxchg is a hardware operation. If you want to replace that you need a lock again. Maybe just add a comment and use an explicit cast to void* ? Not sure if that silences the warning. Christian. Am 21.03.19 um 15:13 schrieb Zhou, David(ChunMing): > cmpxchg be replaced by some simple c sentance? > otherwise we have to remove __rcu of chian->prev. > > -David > > -------- Original Message -------- > Subject: Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6 > From: Christian König > To: "Zhou, David(ChunMing)" ,kbuild test robot ,"Zhou, David(ChunMing)" > CC: > kbuild-all@01.org,dri-devel@lists.freedesktop.org,amd-gfx@lists.freedesktop.org,lionel.g.landwerlin@intel.com,jason@jlekstrand.net,"Koenig, > Christian" ,"Hector, Tobias" > > Hi David, > > For the cmpxchg() case I of hand don't know either. Looks like so far > nobody has used cmpxchg() with rcu protected structures. > > The other cases should be replaced by RCU_INIT_POINTER() or > rcu_dereference_protected(.., true); > > Regards, > Christian. > > Am 21.03.19 um 07:34 schrieb zhoucm1: > > Hi Lionel and Christian, > > > > Below is robot report for chain->prev, which was added __rcu as you > > suggested. > > > > How to fix this line "tmp = cmpxchg(&chain->prev, prev, replacement); "? > > I checked kernel header file, seems it has no cmpxchg for rcu. > > > > Any suggestion to fix this robot report? > > > > Thanks, > > -David > > > > On 2019年03月21日 08:24, kbuild test robot wrote: > >> Hi Chunming, > >> > >> I love your patch! Perhaps something to improve: > >> > >> [auto build test WARNING on linus/master] > >> [also build test WARNING on v5.1-rc1 next-20190320] > >> [if your patch is applied to the wrong git tree, please drop us a > >> note to help improve the system] > >> > >> url: > >> > https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v6/20190320-223607 > >> reproduce: > >> # apt-get install sparse > >> make ARCH=x86_64 allmodconfig > >> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' > >> > >> > >> sparse warnings: (new ones prefixed by >>) > >> > >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in > >>>> initializer (different address spaces) @@ expected struct > >>>> dma_fence [noderef] <asn:4>*__old @@ got dma_fence [noderef] > >>>> <asn:4>*__old @@ > >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct > >> dma_fence [noderef] <asn:4>*__old > >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence > >> *[assigned] prev > >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in > >>>> initializer (different address spaces) @@ expected struct > >>>> dma_fence [noderef] <asn:4>*__new @@ got dma_fence [noderef] > >>>> <asn:4>*__new @@ > >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct > >> dma_fence [noderef] <asn:4>*__new > >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence > >> *[assigned] replacement > >>>> drivers/dma-buf/dma-fence-chain.c:73:21: sparse: incorrect type in > >>>> assignment (different address spaces) @@ expected struct > >>>> dma_fence *tmp @@ got struct dma_fence [noderef] <struct > >>>> dma_fence *tmp @@ > >> drivers/dma-buf/dma-fence-chain.c:73:21: expected struct > >> dma_fence *tmp > >> drivers/dma-buf/dma-fence-chain.c:73:21: got struct dma_fence > >> [noderef] <asn:4>*[assigned] __ret > >>>> drivers/dma-buf/dma-fence-chain.c:190:28: sparse: incorrect type in > >>>> argument 1 (different address spaces) @@ expected struct > >>>> dma_fence *fence @@ got struct dma_fence struct dma_fence > *fence @@ > >> drivers/dma-buf/dma-fence-chain.c:190:28: expected struct > >> dma_fence *fence > >> drivers/dma-buf/dma-fence-chain.c:190:28: got struct dma_fence > >> [noderef] <asn:4>*prev > >>>> drivers/dma-buf/dma-fence-chain.c:222:21: sparse: incorrect type in > >>>> assignment (different address spaces) @@ expected struct > >>>> dma_fence [noderef] <asn:4>*prev @@ got [noderef] <asn:4>*prev @@ > >> drivers/dma-buf/dma-fence-chain.c:222:21: expected struct > >> dma_fence [noderef] <asn:4>*prev > >> drivers/dma-buf/dma-fence-chain.c:222:21: got struct dma_fence > >> *prev > >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression > >> using sizeof(void) > >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression > >> using sizeof(void) > >> > >> vim +73 drivers/dma-buf/dma-fence-chain.c > >> > >> 38 > >> 39 /** > >> 40 * dma_fence_chain_walk - chain walking function > >> 41 * @fence: current chain node > >> 42 * > >> 43 * Walk the chain to the next node. Returns the next fence > >> or NULL if we are at > >> 44 * the end of the chain. Garbage collects chain nodes > >> which are already > >> 45 * signaled. > >> 46 */ > >> 47 struct dma_fence *dma_fence_chain_walk(struct dma_fence > >> *fence) > >> 48 { > >> 49 struct dma_fence_chain *chain, *prev_chain; > >> 50 struct dma_fence *prev, *replacement, *tmp; > >> 51 > >> 52 chain = to_dma_fence_chain(fence); > >> 53 if (!chain) { > >> 54 dma_fence_put(fence); > >> 55 return NULL; > >> 56 } > >> 57 > >> 58 while ((prev = dma_fence_chain_get_prev(chain))) { > >> 59 > >> 60 prev_chain = to_dma_fence_chain(prev); > >> 61 if (prev_chain) { > >> 62 if (!dma_fence_is_signaled(prev_chain->fence)) > >> 63 break; > >> 64 > >> 65 replacement = > >> dma_fence_chain_get_prev(prev_chain); > >> 66 } else { > >> 67 if (!dma_fence_is_signaled(prev)) > >> 68 break; > >> 69 > >> 70 replacement = NULL; > >> 71 } > >> 72 > >> > 73 tmp = cmpxchg(&chain->prev, prev, replacement); > >> 74 if (tmp == prev) > >> 75 dma_fence_put(tmp); > >> 76 else > >> 77 dma_fence_put(replacement); > >> 78 dma_fence_put(prev); > >> 79 } > >> 80 > >> 81 dma_fence_put(fence); > >> 82 return prev; > >> 83 } > >> 84 EXPORT_SYMBOL(dma_fence_chain_walk); > >> 85 > >> 86 /** > >> 87 * dma_fence_chain_find_seqno - find fence chain node by > >> seqno > >> 88 * @pfence: pointer to the chain node where to start > >> 89 * @seqno: the sequence number to search for > >> 90 * > >> 91 * Advance the fence pointer to the chain node which will > >> signal this sequence > >> 92 * number. If no sequence number is provided then this is > >> a no-op. > >> 93 * > >> 94 * Returns EINVAL if the fence is not a chain node or the > >> sequence number has > >> 95 * not yet advanced far enough. > >> 96 */ > >> 97 int dma_fence_chain_find_seqno(struct dma_fence **pfence, > >> uint64_t seqno) > >> 98 { > >> 99 struct dma_fence_chain *chain; > >> 100 > >> 101 if (!seqno) > >> 102 return 0; > >> 103 > >> 104 chain = to_dma_fence_chain(*pfence); > >> 105 if (!chain || chain->base.seqno < seqno) > >> 106 return -EINVAL; > >> 107 > >> 108 dma_fence_chain_for_each(*pfence, &chain->base) { > >> 109 if ((*pfence)->context != chain->base.context || > >> 110 to_dma_fence_chain(*pfence)->prev_seqno < seqno) > >> 111 break; > >> 112 } > >> 113 dma_fence_put(&chain->base); > >> 114 > >> 115 return 0; > >> 116 } > >> 117 EXPORT_SYMBOL(dma_fence_chain_find_seqno); > >> 118 > >> 119 static const char *dma_fence_chain_get_driver_name(struct > >> dma_fence *fence) > >> 120 { > >> 121 return "dma_fence_chain"; > >> 122 } > >> 123 > >> 124 static const char > >> *dma_fence_chain_get_timeline_name(struct dma_fence *fence) > >> 125 { > >> 126 return "unbound"; > >> 127 } > >> 128 > >> 129 static void dma_fence_chain_irq_work(struct irq_work *work) > >> 130 { > >> 131 struct dma_fence_chain *chain; > >> 132 > >> 133 chain = container_of(work, typeof(*chain), work); > >> 134 > >> 135 /* Try to rearm the callback */ > >> 136 if (!dma_fence_chain_enable_signaling(&chain->base)) > >> 137 /* Ok, we are done. No more unsignaled fences > left */ > >> 138 dma_fence_signal(&chain->base); > >> 139 dma_fence_put(&chain->base); > >> 140 } > >> 141 > >> 142 static void dma_fence_chain_cb(struct dma_fence *f, struct > >> dma_fence_cb *cb) > >> 143 { > >> 144 struct dma_fence_chain *chain; > >> 145 > >> 146 chain = container_of(cb, typeof(*chain), cb); > >> 147 irq_work_queue(&chain->work); > >> 148 dma_fence_put(f); > >> 149 } > >> 150 > >> 151 static bool dma_fence_chain_enable_signaling(struct > >> dma_fence *fence) > >> 152 { > >> 153 struct dma_fence_chain *head = > to_dma_fence_chain(fence); > >> 154 > >> 155 dma_fence_get(&head->base); > >> 156 dma_fence_chain_for_each(fence, &head->base) { > >> 157 struct dma_fence_chain *chain = > >> to_dma_fence_chain(fence); > >> 158 struct dma_fence *f = chain ? chain->fence : fence; > >> 159 > >> 160 dma_fence_get(f); > >> 161 if (!dma_fence_add_callback(f, &head->cb, > >> dma_fence_chain_cb)) { > >> 162 dma_fence_put(fence); > >> 163 return true; > >> 164 } > >> 165 dma_fence_put(f); > >> 166 } > >> 167 dma_fence_put(&head->base); > >> 168 return false; > >> 169 } > >> 170 > >> 171 static bool dma_fence_chain_signaled(struct dma_fence > *fence) > >> 172 { > >> 173 dma_fence_chain_for_each(fence, fence) { > >> 174 struct dma_fence_chain *chain = > >> to_dma_fence_chain(fence); > >> 175 struct dma_fence *f = chain ? chain->fence : fence; > >> 176 > >> 177 if (!dma_fence_is_signaled(f)) { > >> 178 dma_fence_put(fence); > >> 179 return false; > >> 180 } > >> 181 } > >> 182 > >> 183 return true; > >> 184 } > >> 185 > >> 186 static void dma_fence_chain_release(struct dma_fence *fence) > >> 187 { > >> 188 struct dma_fence_chain *chain = > >> to_dma_fence_chain(fence); > >> 189 > >> > 190 dma_fence_put(chain->prev); > >> 191 dma_fence_put(chain->fence); > >> 192 dma_fence_free(fence); > >> 193 } > >> 194 > >> 195 const struct dma_fence_ops dma_fence_chain_ops = { > >> 196 .get_driver_name = dma_fence_chain_get_driver_name, > >> 197 .get_timeline_name = dma_fence_chain_get_timeline_name, > >> 198 .enable_signaling = dma_fence_chain_enable_signaling, > >> 199 .signaled = dma_fence_chain_signaled, > >> 200 .release = dma_fence_chain_release, > >> 201 }; > >> 202 EXPORT_SYMBOL(dma_fence_chain_ops); > >> 203 > >> 204 /** > >> 205 * dma_fence_chain_init - initialize a fence chain > >> 206 * @chain: the chain node to initialize > >> 207 * @prev: the previous fence > >> 208 * @fence: the current fence > >> 209 * > >> 210 * Initialize a new chain node and either start a new > >> chain or add the node to > >> 211 * the existing chain of the previous fence. > >> 212 */ > >> 213 void dma_fence_chain_init(struct dma_fence_chain *chain, > >> 214 struct dma_fence *prev, > >> 215 struct dma_fence *fence, > >> 216 uint64_t seqno) > >> 217 { > >> 218 struct dma_fence_chain *prev_chain = > >> to_dma_fence_chain(prev); > >> 219 uint64_t context; > >> 220 > >> 221 spin_lock_init(&chain->lock); > >> > 222 chain->prev = prev; > >> > >> --- > >> 0-DAY kernel test infrastructure Open Source > >> Technology Center > >> https://lists.01.org/pipermail/kbuild-all Intel Corporation > > > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">No, atomic cmpxchg is a hardware operation. If you want to replace that you need a lock again.<br> <br> Maybe just add a comment and use an explicit cast to void* ? Not sure if that silences the warning.<br> <br> Christian.<br> <br> Am 21.03.19 um 15:13 schrieb Zhou, David(ChunMing):<br> </div> <blockquote type="cite" cite="mid:2q1nzdv6akhy5260mi-2nbzia-ttsfc8-dz76ft-4ifnnm-oz4kfp-uezs6vwoq2oq-wd0h34-v7m6m7-cd3muc-v4wzqd-yktmtp-2338r6riorqe-ez3yxk-8jr766yyjh0ob0v5e8-33h712k31w5b1ntkih.1553177522341@email.android.com"> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <meta name="Generator" content="Microsoft Exchange Server"> <!-- converted from text --> <style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style> <div>cmpxchg be replaced by some simple c sentance?<br> otherwise we have to remove __rcu of chian->prev.<br> <br> -David<br> <br> -------- Original Message --------<br> Subject: Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6<br> From: Christian König <br> To: "Zhou, David(ChunMing)" ,kbuild test robot ,"Zhou, David(ChunMing)" <br> CC: <a class="moz-txt-link-abbreviated" href="mailto:kbuild-all@01.org,dri-devel@lists.freedesktop.org,amd-gfx@lists.freedesktop.org,lionel.g.landwerlin@intel.com,jason@jlekstrand.net">kbuild-all@01.org,dri-devel@lists.freedesktop.org,amd-gfx@lists.freedesktop.org,lionel.g.landwerlin@intel.com,jason@jlekstrand.net</a>,"Koenig, Christian" ,"Hector, Tobias" <br> <br> </div> <font size="2"><span style="font-size:11pt;"> <div class="PlainText">Hi David,<br> <br> For the cmpxchg() case I of hand don't know either. Looks like so far <br> nobody has used cmpxchg() with rcu protected structures.<br> <br> The other cases should be replaced by RCU_INIT_POINTER() or <br> rcu_dereference_protected(.., true);<br> <br> Regards,<br> Christian.<br> <br> Am 21.03.19 um 07:34 schrieb zhoucm1:<br> > Hi Lionel and Christian,<br> ><br> > Below is robot report for chain->prev, which was added __rcu as you <br> > suggested.<br> ><br> > How to fix this line "tmp = cmpxchg(&chain->prev, prev, replacement); "?<br> > I checked kernel header file, seems it has no cmpxchg for rcu.<br> ><br> > Any suggestion to fix this robot report?<br> ><br> > Thanks,<br> > -David<br> ><br> > On 2019年03月21日 08:24, kbuild test robot wrote:<br> >> Hi Chunming,<br> >><br> >> I love your patch! Perhaps something to improve:<br> >><br> >> [auto build test WARNING on linus/master]<br> >> [also build test WARNING on v5.1-rc1 next-20190320]<br> >> [if your patch is applied to the wrong git tree, please drop us a <br> >> note to help improve the system]<br> >><br> >> url: <br> >> <a href="https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v6/20190320-223607" moz-do-not-send="true"> https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v6/20190320-223607</a><br> >> reproduce:<br> >> # apt-get install sparse<br> >> make ARCH=x86_64 allmodconfig<br> >> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'<br> >><br> >><br> >> sparse warnings: (new ones prefixed by >>)<br> >><br> >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in <br> >>>> initializer (different address spaces) @@ expected struct <br> >>>> dma_fence [noderef] <asn:4>*__old @@ got dma_fence [noderef] <br> >>>> <asn:4>*__old @@<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct <br> >> dma_fence [noderef] <asn:4>*__old<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence <br> >> *[assigned] prev<br> >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in <br> >>>> initializer (different address spaces) @@ expected struct <br> >>>> dma_fence [noderef] <asn:4>*__new @@ got dma_fence [noderef] <br> >>>> <asn:4>*__new @@<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct <br> >> dma_fence [noderef] <asn:4>*__new<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence <br> >> *[assigned] replacement<br> >>>> drivers/dma-buf/dma-fence-chain.c:73:21: sparse: incorrect type in <br> >>>> assignment (different address spaces) @@ expected struct <br> >>>> dma_fence *tmp @@ got struct dma_fence [noderef] <struct <br> >>>> dma_fence *tmp @@<br> >> drivers/dma-buf/dma-fence-chain.c:73:21: expected struct <br> >> dma_fence *tmp<br> >> drivers/dma-buf/dma-fence-chain.c:73:21: got struct dma_fence <br> >> [noderef] <asn:4>*[assigned] __ret<br> >>>> drivers/dma-buf/dma-fence-chain.c:190:28: sparse: incorrect type in <br> >>>> argument 1 (different address spaces) @@ expected struct <br> >>>> dma_fence *fence @@ got struct dma_fence struct dma_fence *fence @@<br> >> drivers/dma-buf/dma-fence-chain.c:190:28: expected struct <br> >> dma_fence *fence<br> >> drivers/dma-buf/dma-fence-chain.c:190:28: got struct dma_fence <br> >> [noderef] <asn:4>*prev<br> >>>> drivers/dma-buf/dma-fence-chain.c:222:21: sparse: incorrect type in <br> >>>> assignment (different address spaces) @@ expected struct <br> >>>> dma_fence [noderef] <asn:4>*prev @@ got [noderef] <asn:4>*prev @@<br> >> drivers/dma-buf/dma-fence-chain.c:222:21: expected struct <br> >> dma_fence [noderef] <asn:4>*prev<br> >> drivers/dma-buf/dma-fence-chain.c:222:21: got struct dma_fence <br> >> *prev<br> >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression <br> >> using sizeof(void)<br> >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression <br> >> using sizeof(void)<br> >><br> >> vim +73 drivers/dma-buf/dma-fence-chain.c<br> >><br> >> 38<br> >> 39 /**<br> >> 40 * dma_fence_chain_walk - chain walking function<br> >> 41 * @fence: current chain node<br> >> 42 *<br> >> 43 * Walk the chain to the next node. Returns the next fence <br> >> or NULL if we are at<br> >> 44 * the end of the chain. Garbage collects chain nodes <br> >> which are already<br> >> 45 * signaled.<br> >> 46 */<br> >> 47 struct dma_fence *dma_fence_chain_walk(struct dma_fence <br> >> *fence)<br> >> 48 {<br> >> 49 struct dma_fence_chain *chain, *prev_chain;<br> >> 50 struct dma_fence *prev, *replacement, *tmp;<br> >> 51<br> >> 52 chain = to_dma_fence_chain(fence);<br> >> 53 if (!chain) {<br> >> 54 dma_fence_put(fence);<br> >> 55 return NULL;<br> >> 56 }<br> >> 57<br> >> 58 while ((prev = dma_fence_chain_get_prev(chain))) {<br> >> 59<br> >> 60 prev_chain = to_dma_fence_chain(prev);<br> >> 61 if (prev_chain) {<br> >> 62 if (!dma_fence_is_signaled(prev_chain->fence))<br> >> 63 break;<br> >> 64<br> >> 65 replacement = <br> >> dma_fence_chain_get_prev(prev_chain);<br> >> 66 } else {<br> >> 67 if (!dma_fence_is_signaled(prev))<br> >> 68 break;<br> >> 69<br> >> 70 replacement = NULL;<br> >> 71 }<br> >> 72<br> >> > 73 tmp = cmpxchg(&chain->prev, prev, replacement);<br> >> 74 if (tmp == prev)<br> >> 75 dma_fence_put(tmp);<br> >> 76 else<br> >> 77 dma_fence_put(replacement);<br> >> 78 dma_fence_put(prev);<br> >> 79 }<br> >> 80<br> >> 81 dma_fence_put(fence);<br> >> 82 return prev;<br> >> 83 }<br> >> 84 EXPORT_SYMBOL(dma_fence_chain_walk);<br> >> 85<br> >> 86 /**<br> >> 87 * dma_fence_chain_find_seqno - find fence chain node by <br> >> seqno<br> >> 88 * @pfence: pointer to the chain node where to start<br> >> 89 * @seqno: the sequence number to search for<br> >> 90 *<br> >> 91 * Advance the fence pointer to the chain node which will <br> >> signal this sequence<br> >> 92 * number. If no sequence number is provided then this is <br> >> a no-op.<br> >> 93 *<br> >> 94 * Returns EINVAL if the fence is not a chain node or the <br> >> sequence number has<br> >> 95 * not yet advanced far enough.<br> >> 96 */<br> >> 97 int dma_fence_chain_find_seqno(struct dma_fence **pfence, <br> >> uint64_t seqno)<br> >> 98 {<br> >> 99 struct dma_fence_chain *chain;<br> >> 100<br> >> 101 if (!seqno)<br> >> 102 return 0;<br> >> 103<br> >> 104 chain = to_dma_fence_chain(*pfence);<br> >> 105 if (!chain || chain->base.seqno < seqno)<br> >> 106 return -EINVAL;<br> >> 107<br> >> 108 dma_fence_chain_for_each(*pfence, &chain->base) {<br> >> 109 if ((*pfence)->context != chain->base.context ||<br> >> 110 to_dma_fence_chain(*pfence)->prev_seqno < seqno)<br> >> 111 break;<br> >> 112 }<br> >> 113 dma_fence_put(&chain->base);<br> >> 114<br> >> 115 return 0;<br> >> 116 }<br> >> 117 EXPORT_SYMBOL(dma_fence_chain_find_seqno);<br> >> 118<br> >> 119 static const char *dma_fence_chain_get_driver_name(struct <br> >> dma_fence *fence)<br> >> 120 {<br> >> 121 return "dma_fence_chain";<br> >> 122 }<br> >> 123<br> >> 124 static const char <br> >> *dma_fence_chain_get_timeline_name(struct dma_fence *fence)<br> >> 125 {<br> >> 126 return "unbound";<br> >> 127 }<br> >> 128<br> >> 129 static void dma_fence_chain_irq_work(struct irq_work *work)<br> >> 130 {<br> >> 131 struct dma_fence_chain *chain;<br> >> 132<br> >> 133 chain = container_of(work, typeof(*chain), work);<br> >> 134<br> >> 135 /* Try to rearm the callback */<br> >> 136 if (!dma_fence_chain_enable_signaling(&chain->base))<br> >> 137 /* Ok, we are done. No more unsignaled fences left */<br> >> 138 dma_fence_signal(&chain->base);<br> >> 139 dma_fence_put(&chain->base);<br> >> 140 }<br> >> 141<br> >> 142 static void dma_fence_chain_cb(struct dma_fence *f, struct <br> >> dma_fence_cb *cb)<br> >> 143 {<br> >> 144 struct dma_fence_chain *chain;<br> >> 145<br> >> 146 chain = container_of(cb, typeof(*chain), cb);<br> >> 147 irq_work_queue(&chain->work);<br> >> 148 dma_fence_put(f);<br> >> 149 }<br> >> 150<br> >> 151 static bool dma_fence_chain_enable_signaling(struct <br> >> dma_fence *fence)<br> >> 152 {<br> >> 153 struct dma_fence_chain *head = to_dma_fence_chain(fence);<br> >> 154<br> >> 155 dma_fence_get(&head->base);<br> >> 156 dma_fence_chain_for_each(fence, &head->base) {<br> >> 157 struct dma_fence_chain *chain = <br> >> to_dma_fence_chain(fence);<br> >> 158 struct dma_fence *f = chain ? chain->fence : fence;<br> >> 159<br> >> 160 dma_fence_get(f);<br> >> 161 if (!dma_fence_add_callback(f, &head->cb, <br> >> dma_fence_chain_cb)) {<br> >> 162 dma_fence_put(fence);<br> >> 163 return true;<br> >> 164 }<br> >> 165 dma_fence_put(f);<br> >> 166 }<br> >> 167 dma_fence_put(&head->base);<br> >> 168 return false;<br> >> 169 }<br> >> 170<br> >> 171 static bool dma_fence_chain_signaled(struct dma_fence *fence)<br> >> 172 {<br> >> 173 dma_fence_chain_for_each(fence, fence) {<br> >> 174 struct dma_fence_chain *chain = <br> >> to_dma_fence_chain(fence);<br> >> 175 struct dma_fence *f = chain ? chain->fence : fence;<br> >> 176<br> >> 177 if (!dma_fence_is_signaled(f)) {<br> >> 178 dma_fence_put(fence);<br> >> 179 return false;<br> >> 180 }<br> >> 181 }<br> >> 182<br> >> 183 return true;<br> >> 184 }<br> >> 185<br> >> 186 static void dma_fence_chain_release(struct dma_fence *fence)<br> >> 187 {<br> >> 188 struct dma_fence_chain *chain = <br> >> to_dma_fence_chain(fence);<br> >> 189<br> >> > 190 dma_fence_put(chain->prev);<br> >> 191 dma_fence_put(chain->fence);<br> >> 192 dma_fence_free(fence);<br> >> 193 }<br> >> 194<br> >> 195 const struct dma_fence_ops dma_fence_chain_ops = {<br> >> 196 .get_driver_name = dma_fence_chain_get_driver_name,<br> >> 197 .get_timeline_name = dma_fence_chain_get_timeline_name,<br> >> 198 .enable_signaling = dma_fence_chain_enable_signaling,<br> >> 199 .signaled = dma_fence_chain_signaled,<br> >> 200 .release = dma_fence_chain_release,<br> >> 201 };<br> >> 202 EXPORT_SYMBOL(dma_fence_chain_ops);<br> >> 203<br> >> 204 /**<br> >> 205 * dma_fence_chain_init - initialize a fence chain<br> >> 206 * @chain: the chain node to initialize<br> >> 207 * @prev: the previous fence<br> >> 208 * @fence: the current fence<br> >> 209 *<br> >> 210 * Initialize a new chain node and either start a new <br> >> chain or add the node to<br> >> 211 * the existing chain of the previous fence.<br> >> 212 */<br> >> 213 void dma_fence_chain_init(struct dma_fence_chain *chain,<br> >> 214 struct dma_fence *prev,<br> >> 215 struct dma_fence *fence,<br> >> 216 uint64_t seqno)<br> >> 217 {<br> >> 218 struct dma_fence_chain *prev_chain = <br> >> to_dma_fence_chain(prev);<br> >> 219 uint64_t context;<br> >> 220<br> >> 221 spin_lock_init(&chain->lock);<br> >> > 222 chain->prev = prev;<br> >><br> >> ---<br> >> 0-DAY kernel test infrastructure Open Source <br> >> Technology Center<br> >> <a href="https://lists.01.org/pipermail/kbuild-all" moz-do-not-send="true">https://lists.01.org/pipermail/kbuild-all</a> Intel Corporation<br> ><br> <br> </div> </span></font> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <pre class="moz-quote-pre" wrap="">_______________________________________________ amd-gfx mailing list <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></pre> </blockquote> <br> </body> </html>
how about the attached? If ok, I will merge to pathc#1. -David On 2019年03月21日 22:40, Christian König wrote: > No, atomic cmpxchg is a hardware operation. If you want to replace > that you need a lock again. > > Maybe just add a comment and use an explicit cast to void* ? Not sure > if that silences the warning. > > Christian. > > Am 21.03.19 um 15:13 schrieb Zhou, David(ChunMing): >> cmpxchg be replaced by some simple c sentance? >> otherwise we have to remove __rcu of chian->prev. >> >> -David >> >> -------- Original Message -------- >> Subject: Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6 >> From: Christian König >> To: "Zhou, David(ChunMing)" ,kbuild test robot ,"Zhou, David(ChunMing)" >> CC: >> kbuild-all@01.org,dri-devel@lists.freedesktop.org,amd-gfx@lists.freedesktop.org,lionel.g.landwerlin@intel.com,jason@jlekstrand.net,"Koenig, >> Christian" ,"Hector, Tobias" >> >> Hi David, >> >> For the cmpxchg() case I of hand don't know either. Looks like so far >> nobody has used cmpxchg() with rcu protected structures. >> >> The other cases should be replaced by RCU_INIT_POINTER() or >> rcu_dereference_protected(.., true); >> >> Regards, >> Christian. >> >> Am 21.03.19 um 07:34 schrieb zhoucm1: >> > Hi Lionel and Christian, >> > >> > Below is robot report for chain->prev, which was added __rcu as you >> > suggested. >> > >> > How to fix this line "tmp = cmpxchg(&chain->prev, prev, >> replacement); "? >> > I checked kernel header file, seems it has no cmpxchg for rcu. >> > >> > Any suggestion to fix this robot report? >> > >> > Thanks, >> > -David >> > >> > On 2019年03月21日 08:24, kbuild test robot wrote: >> >> Hi Chunming, >> >> >> >> I love your patch! Perhaps something to improve: >> >> >> >> [auto build test WARNING on linus/master] >> >> [also build test WARNING on v5.1-rc1 next-20190320] >> >> [if your patch is applied to the wrong git tree, please drop us a >> >> note to help improve the system] >> >> >> >> url: >> >> >> https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v6/20190320-223607 >> >> reproduce: >> >> # apt-get install sparse >> >> make ARCH=x86_64 allmodconfig >> >> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' >> >> >> >> >> >> sparse warnings: (new ones prefixed by >>) >> >> >> >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in >> >>>> initializer (different address spaces) @@ expected struct >> >>>> dma_fence [noderef] <asn:4>*__old @@ got dma_fence [noderef] >> >>>> <asn:4>*__old @@ >> >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct >> >> dma_fence [noderef] <asn:4>*__old >> >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence >> >> *[assigned] prev >> >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in >> >>>> initializer (different address spaces) @@ expected struct >> >>>> dma_fence [noderef] <asn:4>*__new @@ got dma_fence [noderef] >> >>>> <asn:4>*__new @@ >> >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct >> >> dma_fence [noderef] <asn:4>*__new >> >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence >> >> *[assigned] replacement >> >>>> drivers/dma-buf/dma-fence-chain.c:73:21: sparse: incorrect type in >> >>>> assignment (different address spaces) @@ expected struct >> >>>> dma_fence *tmp @@ got struct dma_fence [noderef] <struct >> >>>> dma_fence *tmp @@ >> >> drivers/dma-buf/dma-fence-chain.c:73:21: expected struct >> >> dma_fence *tmp >> >> drivers/dma-buf/dma-fence-chain.c:73:21: got struct dma_fence >> >> [noderef] <asn:4>*[assigned] __ret >> >>>> drivers/dma-buf/dma-fence-chain.c:190:28: sparse: incorrect type in >> >>>> argument 1 (different address spaces) @@ expected struct >> >>>> dma_fence *fence @@ got struct dma_fence struct dma_fence >> *fence @@ >> >> drivers/dma-buf/dma-fence-chain.c:190:28: expected struct >> >> dma_fence *fence >> >> drivers/dma-buf/dma-fence-chain.c:190:28: got struct dma_fence >> >> [noderef] <asn:4>*prev >> >>>> drivers/dma-buf/dma-fence-chain.c:222:21: sparse: incorrect type in >> >>>> assignment (different address spaces) @@ expected struct >> >>>> dma_fence [noderef] <asn:4>*prev @@ got [noderef] <asn:4>*prev @@ >> >> drivers/dma-buf/dma-fence-chain.c:222:21: expected struct >> >> dma_fence [noderef] <asn:4>*prev >> >> drivers/dma-buf/dma-fence-chain.c:222:21: got struct dma_fence >> >> *prev >> >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression >> >> using sizeof(void) >> >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression >> >> using sizeof(void) >> >> >> >> vim +73 drivers/dma-buf/dma-fence-chain.c >> >> >> >> 38 >> >> 39 /** >> >> 40 * dma_fence_chain_walk - chain walking function >> >> 41 * @fence: current chain node >> >> 42 * >> >> 43 * Walk the chain to the next node. Returns the next fence >> >> or NULL if we are at >> >> 44 * the end of the chain. Garbage collects chain nodes >> >> which are already >> >> 45 * signaled. >> >> 46 */ >> >> 47 struct dma_fence *dma_fence_chain_walk(struct dma_fence >> >> *fence) >> >> 48 { >> >> 49 struct dma_fence_chain *chain, *prev_chain; >> >> 50 struct dma_fence *prev, *replacement, *tmp; >> >> 51 >> >> 52 chain = to_dma_fence_chain(fence); >> >> 53 if (!chain) { >> >> 54 dma_fence_put(fence); >> >> 55 return NULL; >> >> 56 } >> >> 57 >> >> 58 while ((prev = dma_fence_chain_get_prev(chain))) { >> >> 59 >> >> 60 prev_chain = to_dma_fence_chain(prev); >> >> 61 if (prev_chain) { >> >> 62 if (!dma_fence_is_signaled(prev_chain->fence)) >> >> 63 break; >> >> 64 >> >> 65 replacement = >> >> dma_fence_chain_get_prev(prev_chain); >> >> 66 } else { >> >> 67 if (!dma_fence_is_signaled(prev)) >> >> 68 break; >> >> 69 >> >> 70 replacement = NULL; >> >> 71 } >> >> 72 >> >> > 73 tmp = cmpxchg(&chain->prev, prev, replacement); >> >> 74 if (tmp == prev) >> >> 75 dma_fence_put(tmp); >> >> 76 else >> >> 77 dma_fence_put(replacement); >> >> 78 dma_fence_put(prev); >> >> 79 } >> >> 80 >> >> 81 dma_fence_put(fence); >> >> 82 return prev; >> >> 83 } >> >> 84 EXPORT_SYMBOL(dma_fence_chain_walk); >> >> 85 >> >> 86 /** >> >> 87 * dma_fence_chain_find_seqno - find fence chain node by >> >> seqno >> >> 88 * @pfence: pointer to the chain node where to start >> >> 89 * @seqno: the sequence number to search for >> >> 90 * >> >> 91 * Advance the fence pointer to the chain node which will >> >> signal this sequence >> >> 92 * number. If no sequence number is provided then this is >> >> a no-op. >> >> 93 * >> >> 94 * Returns EINVAL if the fence is not a chain node or the >> >> sequence number has >> >> 95 * not yet advanced far enough. >> >> 96 */ >> >> 97 int dma_fence_chain_find_seqno(struct dma_fence **pfence, >> >> uint64_t seqno) >> >> 98 { >> >> 99 struct dma_fence_chain *chain; >> >> 100 >> >> 101 if (!seqno) >> >> 102 return 0; >> >> 103 >> >> 104 chain = to_dma_fence_chain(*pfence); >> >> 105 if (!chain || chain->base.seqno < seqno) >> >> 106 return -EINVAL; >> >> 107 >> >> 108 dma_fence_chain_for_each(*pfence, &chain->base) { >> >> 109 if ((*pfence)->context != chain->base.context || >> >> 110 to_dma_fence_chain(*pfence)->prev_seqno < seqno) >> >> 111 break; >> >> 112 } >> >> 113 dma_fence_put(&chain->base); >> >> 114 >> >> 115 return 0; >> >> 116 } >> >> 117 EXPORT_SYMBOL(dma_fence_chain_find_seqno); >> >> 118 >> >> 119 static const char *dma_fence_chain_get_driver_name(struct >> >> dma_fence *fence) >> >> 120 { >> >> 121 return "dma_fence_chain"; >> >> 122 } >> >> 123 >> >> 124 static const char >> >> *dma_fence_chain_get_timeline_name(struct dma_fence *fence) >> >> 125 { >> >> 126 return "unbound"; >> >> 127 } >> >> 128 >> >> 129 static void dma_fence_chain_irq_work(struct irq_work *work) >> >> 130 { >> >> 131 struct dma_fence_chain *chain; >> >> 132 >> >> 133 chain = container_of(work, typeof(*chain), work); >> >> 134 >> >> 135 /* Try to rearm the callback */ >> >> 136 if (!dma_fence_chain_enable_signaling(&chain->base)) >> >> 137 /* Ok, we are done. No more unsignaled fences >> left */ >> >> 138 dma_fence_signal(&chain->base); >> >> 139 dma_fence_put(&chain->base); >> >> 140 } >> >> 141 >> >> 142 static void dma_fence_chain_cb(struct dma_fence *f, struct >> >> dma_fence_cb *cb) >> >> 143 { >> >> 144 struct dma_fence_chain *chain; >> >> 145 >> >> 146 chain = container_of(cb, typeof(*chain), cb); >> >> 147 irq_work_queue(&chain->work); >> >> 148 dma_fence_put(f); >> >> 149 } >> >> 150 >> >> 151 static bool dma_fence_chain_enable_signaling(struct >> >> dma_fence *fence) >> >> 152 { >> >> 153 struct dma_fence_chain *head = >> to_dma_fence_chain(fence); >> >> 154 >> >> 155 dma_fence_get(&head->base); >> >> 156 dma_fence_chain_for_each(fence, &head->base) { >> >> 157 struct dma_fence_chain *chain = >> >> to_dma_fence_chain(fence); >> >> 158 struct dma_fence *f = chain ? chain->fence : fence; >> >> 159 >> >> 160 dma_fence_get(f); >> >> 161 if (!dma_fence_add_callback(f, &head->cb, >> >> dma_fence_chain_cb)) { >> >> 162 dma_fence_put(fence); >> >> 163 return true; >> >> 164 } >> >> 165 dma_fence_put(f); >> >> 166 } >> >> 167 dma_fence_put(&head->base); >> >> 168 return false; >> >> 169 } >> >> 170 >> >> 171 static bool dma_fence_chain_signaled(struct dma_fence >> *fence) >> >> 172 { >> >> 173 dma_fence_chain_for_each(fence, fence) { >> >> 174 struct dma_fence_chain *chain = >> >> to_dma_fence_chain(fence); >> >> 175 struct dma_fence *f = chain ? chain->fence : fence; >> >> 176 >> >> 177 if (!dma_fence_is_signaled(f)) { >> >> 178 dma_fence_put(fence); >> >> 179 return false; >> >> 180 } >> >> 181 } >> >> 182 >> >> 183 return true; >> >> 184 } >> >> 185 >> >> 186 static void dma_fence_chain_release(struct dma_fence >> *fence) >> >> 187 { >> >> 188 struct dma_fence_chain *chain = >> >> to_dma_fence_chain(fence); >> >> 189 >> >> > 190 dma_fence_put(chain->prev); >> >> 191 dma_fence_put(chain->fence); >> >> 192 dma_fence_free(fence); >> >> 193 } >> >> 194 >> >> 195 const struct dma_fence_ops dma_fence_chain_ops = { >> >> 196 .get_driver_name = dma_fence_chain_get_driver_name, >> >> 197 .get_timeline_name = dma_fence_chain_get_timeline_name, >> >> 198 .enable_signaling = dma_fence_chain_enable_signaling, >> >> 199 .signaled = dma_fence_chain_signaled, >> >> 200 .release = dma_fence_chain_release, >> >> 201 }; >> >> 202 EXPORT_SYMBOL(dma_fence_chain_ops); >> >> 203 >> >> 204 /** >> >> 205 * dma_fence_chain_init - initialize a fence chain >> >> 206 * @chain: the chain node to initialize >> >> 207 * @prev: the previous fence >> >> 208 * @fence: the current fence >> >> 209 * >> >> 210 * Initialize a new chain node and either start a new >> >> chain or add the node to >> >> 211 * the existing chain of the previous fence. >> >> 212 */ >> >> 213 void dma_fence_chain_init(struct dma_fence_chain *chain, >> >> 214 struct dma_fence *prev, >> >> 215 struct dma_fence *fence, >> >> 216 uint64_t seqno) >> >> 217 { >> >> 218 struct dma_fence_chain *prev_chain = >> >> to_dma_fence_chain(prev); >> >> 219 uint64_t context; >> >> 220 >> >> 221 spin_lock_init(&chain->lock); >> >> > 222 chain->prev = prev; >> >> >> >> --- >> >> 0-DAY kernel test infrastructure Open Source >> >> Technology Center >> >> https://lists.01.org/pipermail/kbuild-all Intel Corporation >> > >> >> >> _______________________________________________ >> amd-gfx mailing list >> amd-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> <p>how about the attached?</p> <p>If ok, I will merge to pathc#1.</p> <p><br> </p> <p>-David<br> </p> <br> <div class="moz-cite-prefix">On 2019年03月21日 22:40, Christian König wrote:<br> </div> <blockquote type="cite" cite="mid:6bd1f7e6-965b-3bd5-e4e0-f3b04e0638fd@gmail.com"> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <div class="moz-cite-prefix">No, atomic cmpxchg is a hardware operation. If you want to replace that you need a lock again.<br> <br> Maybe just add a comment and use an explicit cast to void* ? Not sure if that silences the warning.<br> <br> Christian.<br> <br> Am 21.03.19 um 15:13 schrieb Zhou, David(ChunMing):<br> </div> <blockquote type="cite" cite="mid:2q1nzdv6akhy5260mi-2nbzia-ttsfc8-dz76ft-4ifnnm-oz4kfp-uezs6vwoq2oq-wd0h34-v7m6m7-cd3muc-v4wzqd-yktmtp-2338r6riorqe-ez3yxk-8jr766yyjh0ob0v5e8-33h712k31w5b1ntkih.1553177522341@email.android.com"> <meta name="Generator" content="Microsoft Exchange Server"> <!-- converted from text --> <style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style> <div>cmpxchg be replaced by some simple c sentance?<br> otherwise we have to remove __rcu of chian->prev.<br> <br> -David<br> <br> -------- Original Message --------<br> Subject: Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6<br> From: Christian König <br> To: "Zhou, David(ChunMing)" ,kbuild test robot ,"Zhou, David(ChunMing)" <br> CC: <a class="moz-txt-link-abbreviated" href="mailto:kbuild-all@01.org,dri-devel@lists.freedesktop.org,amd-gfx@lists.freedesktop.org,lionel.g.landwerlin@intel.com,jason@jlekstrand.net" moz-do-not-send="true">kbuild-all@01.org,dri-devel@lists.freedesktop.org,amd-gfx@lists.freedesktop.org,lionel.g.landwerlin@intel.com,jason@jlekstrand.net</a>,"Koenig, Christian" ,"Hector, Tobias" <br> <br> </div> <font size="2"><span style="font-size:11pt;"> <div class="PlainText">Hi David,<br> <br> For the cmpxchg() case I of hand don't know either. Looks like so far <br> nobody has used cmpxchg() with rcu protected structures.<br> <br> The other cases should be replaced by RCU_INIT_POINTER() or <br> rcu_dereference_protected(.., true);<br> <br> Regards,<br> Christian.<br> <br> Am 21.03.19 um 07:34 schrieb zhoucm1:<br> > Hi Lionel and Christian,<br> ><br> > Below is robot report for chain->prev, which was added __rcu as you <br> > suggested.<br> ><br> > How to fix this line "tmp = cmpxchg(&chain->prev, prev, replacement); "?<br> > I checked kernel header file, seems it has no cmpxchg for rcu.<br> ><br> > Any suggestion to fix this robot report?<br> ><br> > Thanks,<br> > -David<br> ><br> > On 2019年03月21日 08:24, kbuild test robot wrote:<br> >> Hi Chunming,<br> >><br> >> I love your patch! Perhaps something to improve:<br> >><br> >> [auto build test WARNING on linus/master]<br> >> [also build test WARNING on v5.1-rc1 next-20190320]<br> >> [if your patch is applied to the wrong git tree, please drop us a <br> >> note to help improve the system]<br> >><br> >> url: <br> >> <a href="https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v6/20190320-223607" moz-do-not-send="true"> https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v6/20190320-223607</a><br> >> reproduce:<br> >> # apt-get install sparse<br> >> make ARCH=x86_64 allmodconfig<br> >> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'<br> >><br> >><br> >> sparse warnings: (new ones prefixed by >>)<br> >><br> >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in <br> >>>> initializer (different address spaces) @@ expected struct <br> >>>> dma_fence [noderef] <asn:4>*__old @@ got dma_fence [noderef] <br> >>>> <asn:4>*__old @@<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct <br> >> dma_fence [noderef] <asn:4>*__old<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence <br> >> *[assigned] prev<br> >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in <br> >>>> initializer (different address spaces) @@ expected struct <br> >>>> dma_fence [noderef] <asn:4>*__new @@ got dma_fence [noderef] <br> >>>> <asn:4>*__new @@<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct <br> >> dma_fence [noderef] <asn:4>*__new<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence <br> >> *[assigned] replacement<br> >>>> drivers/dma-buf/dma-fence-chain.c:73:21: sparse: incorrect type in <br> >>>> assignment (different address spaces) @@ expected struct <br> >>>> dma_fence *tmp @@ got struct dma_fence [noderef] <struct <br> >>>> dma_fence *tmp @@<br> >> drivers/dma-buf/dma-fence-chain.c:73:21: expected struct <br> >> dma_fence *tmp<br> >> drivers/dma-buf/dma-fence-chain.c:73:21: got struct dma_fence <br> >> [noderef] <asn:4>*[assigned] __ret<br> >>>> drivers/dma-buf/dma-fence-chain.c:190:28: sparse: incorrect type in <br> >>>> argument 1 (different address spaces) @@ expected struct <br> >>>> dma_fence *fence @@ got struct dma_fence struct dma_fence *fence @@<br> >> drivers/dma-buf/dma-fence-chain.c:190:28: expected struct <br> >> dma_fence *fence<br> >> drivers/dma-buf/dma-fence-chain.c:190:28: got struct dma_fence <br> >> [noderef] <asn:4>*prev<br> >>>> drivers/dma-buf/dma-fence-chain.c:222:21: sparse: incorrect type in <br> >>>> assignment (different address spaces) @@ expected struct <br> >>>> dma_fence [noderef] <asn:4>*prev @@ got [noderef] <asn:4>*prev @@<br> >> drivers/dma-buf/dma-fence-chain.c:222:21: expected struct <br> >> dma_fence [noderef] <asn:4>*prev<br> >> drivers/dma-buf/dma-fence-chain.c:222:21: got struct dma_fence <br> >> *prev<br> >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression <br> >> using sizeof(void)<br> >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression <br> >> using sizeof(void)<br> >><br> >> vim +73 drivers/dma-buf/dma-fence-chain.c<br> >><br> >> 38<br> >> 39 /**<br> >> 40 * dma_fence_chain_walk - chain walking function<br> >> 41 * @fence: current chain node<br> >> 42 *<br> >> 43 * Walk the chain to the next node. Returns the next fence <br> >> or NULL if we are at<br> >> 44 * the end of the chain. Garbage collects chain nodes <br> >> which are already<br> >> 45 * signaled.<br> >> 46 */<br> >> 47 struct dma_fence *dma_fence_chain_walk(struct dma_fence <br> >> *fence)<br> >> 48 {<br> >> 49 struct dma_fence_chain *chain, *prev_chain;<br> >> 50 struct dma_fence *prev, *replacement, *tmp;<br> >> 51<br> >> 52 chain = to_dma_fence_chain(fence);<br> >> 53 if (!chain) {<br> >> 54 dma_fence_put(fence);<br> >> 55 return NULL;<br> >> 56 }<br> >> 57<br> >> 58 while ((prev = dma_fence_chain_get_prev(chain))) {<br> >> 59<br> >> 60 prev_chain = to_dma_fence_chain(prev);<br> >> 61 if (prev_chain) {<br> >> 62 if (!dma_fence_is_signaled(prev_chain->fence))<br> >> 63 break;<br> >> 64<br> >> 65 replacement = <br> >> dma_fence_chain_get_prev(prev_chain);<br> >> 66 } else {<br> >> 67 if (!dma_fence_is_signaled(prev))<br> >> 68 break;<br> >> 69<br> >> 70 replacement = NULL;<br> >> 71 }<br> >> 72<br> >> > 73 tmp = cmpxchg(&chain->prev, prev, replacement);<br> >> 74 if (tmp == prev)<br> >> 75 dma_fence_put(tmp);<br> >> 76 else<br> >> 77 dma_fence_put(replacement);<br> >> 78 dma_fence_put(prev);<br> >> 79 }<br> >> 80<br> >> 81 dma_fence_put(fence);<br> >> 82 return prev;<br> >> 83 }<br> >> 84 EXPORT_SYMBOL(dma_fence_chain_walk);<br> >> 85<br> >> 86 /**<br> >> 87 * dma_fence_chain_find_seqno - find fence chain node by <br> >> seqno<br> >> 88 * @pfence: pointer to the chain node where to start<br> >> 89 * @seqno: the sequence number to search for<br> >> 90 *<br> >> 91 * Advance the fence pointer to the chain node which will <br> >> signal this sequence<br> >> 92 * number. If no sequence number is provided then this is <br> >> a no-op.<br> >> 93 *<br> >> 94 * Returns EINVAL if the fence is not a chain node or the <br> >> sequence number has<br> >> 95 * not yet advanced far enough.<br> >> 96 */<br> >> 97 int dma_fence_chain_find_seqno(struct dma_fence **pfence, <br> >> uint64_t seqno)<br> >> 98 {<br> >> 99 struct dma_fence_chain *chain;<br> >> 100<br> >> 101 if (!seqno)<br> >> 102 return 0;<br> >> 103<br> >> 104 chain = to_dma_fence_chain(*pfence);<br> >> 105 if (!chain || chain->base.seqno < seqno)<br> >> 106 return -EINVAL;<br> >> 107<br> >> 108 dma_fence_chain_for_each(*pfence, &chain->base) {<br> >> 109 if ((*pfence)->context != chain->base.context ||<br> >> 110 to_dma_fence_chain(*pfence)->prev_seqno < seqno)<br> >> 111 break;<br> >> 112 }<br> >> 113 dma_fence_put(&chain->base);<br> >> 114<br> >> 115 return 0;<br> >> 116 }<br> >> 117 EXPORT_SYMBOL(dma_fence_chain_find_seqno);<br> >> 118<br> >> 119 static const char *dma_fence_chain_get_driver_name(struct <br> >> dma_fence *fence)<br> >> 120 {<br> >> 121 return "dma_fence_chain";<br> >> 122 }<br> >> 123<br> >> 124 static const char <br> >> *dma_fence_chain_get_timeline_name(struct dma_fence *fence)<br> >> 125 {<br> >> 126 return "unbound";<br> >> 127 }<br> >> 128<br> >> 129 static void dma_fence_chain_irq_work(struct irq_work *work)<br> >> 130 {<br> >> 131 struct dma_fence_chain *chain;<br> >> 132<br> >> 133 chain = container_of(work, typeof(*chain), work);<br> >> 134<br> >> 135 /* Try to rearm the callback */<br> >> 136 if (!dma_fence_chain_enable_signaling(&chain->base))<br> >> 137 /* Ok, we are done. No more unsignaled fences left */<br> >> 138 dma_fence_signal(&chain->base);<br> >> 139 dma_fence_put(&chain->base);<br> >> 140 }<br> >> 141<br> >> 142 static void dma_fence_chain_cb(struct dma_fence *f, struct <br> >> dma_fence_cb *cb)<br> >> 143 {<br> >> 144 struct dma_fence_chain *chain;<br> >> 145<br> >> 146 chain = container_of(cb, typeof(*chain), cb);<br> >> 147 irq_work_queue(&chain->work);<br> >> 148 dma_fence_put(f);<br> >> 149 }<br> >> 150<br> >> 151 static bool dma_fence_chain_enable_signaling(struct <br> >> dma_fence *fence)<br> >> 152 {<br> >> 153 struct dma_fence_chain *head = to_dma_fence_chain(fence);<br> >> 154<br> >> 155 dma_fence_get(&head->base);<br> >> 156 dma_fence_chain_for_each(fence, &head->base) {<br> >> 157 struct dma_fence_chain *chain = <br> >> to_dma_fence_chain(fence);<br> >> 158 struct dma_fence *f = chain ? chain->fence : fence;<br> >> 159<br> >> 160 dma_fence_get(f);<br> >> 161 if (!dma_fence_add_callback(f, &head->cb, <br> >> dma_fence_chain_cb)) {<br> >> 162 dma_fence_put(fence);<br> >> 163 return true;<br> >> 164 }<br> >> 165 dma_fence_put(f);<br> >> 166 }<br> >> 167 dma_fence_put(&head->base);<br> >> 168 return false;<br> >> 169 }<br> >> 170<br> >> 171 static bool dma_fence_chain_signaled(struct dma_fence *fence)<br> >> 172 {<br> >> 173 dma_fence_chain_for_each(fence, fence) {<br> >> 174 struct dma_fence_chain *chain = <br> >> to_dma_fence_chain(fence);<br> >> 175 struct dma_fence *f = chain ? chain->fence : fence;<br> >> 176<br> >> 177 if (!dma_fence_is_signaled(f)) {<br> >> 178 dma_fence_put(fence);<br> >> 179 return false;<br> >> 180 }<br> >> 181 }<br> >> 182<br> >> 183 return true;<br> >> 184 }<br> >> 185<br> >> 186 static void dma_fence_chain_release(struct dma_fence *fence)<br> >> 187 {<br> >> 188 struct dma_fence_chain *chain = <br> >> to_dma_fence_chain(fence);<br> >> 189<br> >> > 190 dma_fence_put(chain->prev);<br> >> 191 dma_fence_put(chain->fence);<br> >> 192 dma_fence_free(fence);<br> >> 193 }<br> >> 194<br> >> 195 const struct dma_fence_ops dma_fence_chain_ops = {<br> >> 196 .get_driver_name = dma_fence_chain_get_driver_name,<br> >> 197 .get_timeline_name = dma_fence_chain_get_timeline_name,<br> >> 198 .enable_signaling = dma_fence_chain_enable_signaling,<br> >> 199 .signaled = dma_fence_chain_signaled,<br> >> 200 .release = dma_fence_chain_release,<br> >> 201 };<br> >> 202 EXPORT_SYMBOL(dma_fence_chain_ops);<br> >> 203<br> >> 204 /**<br> >> 205 * dma_fence_chain_init - initialize a fence chain<br> >> 206 * @chain: the chain node to initialize<br> >> 207 * @prev: the previous fence<br> >> 208 * @fence: the current fence<br> >> 209 *<br> >> 210 * Initialize a new chain node and either start a new <br> >> chain or add the node to<br> >> 211 * the existing chain of the previous fence.<br> >> 212 */<br> >> 213 void dma_fence_chain_init(struct dma_fence_chain *chain,<br> >> 214 struct dma_fence *prev,<br> >> 215 struct dma_fence *fence,<br> >> 216 uint64_t seqno)<br> >> 217 {<br> >> 218 struct dma_fence_chain *prev_chain = <br> >> to_dma_fence_chain(prev);<br> >> 219 uint64_t context;<br> >> 220<br> >> 221 spin_lock_init(&chain->lock);<br> >> > 222 chain->prev = prev;<br> >><br> >> ---<br> >> 0-DAY kernel test infrastructure Open Source <br> >> Technology Center<br> >> <a href="https://lists.01.org/pipermail/kbuild-all" moz-do-not-send="true">https://lists.01.org/pipermail/kbuild-all</a> Intel Corporation<br> ><br> <br> </div> </span></font> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <pre class="moz-quote-pre" wrap="">_______________________________________________ amd-gfx mailing list <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></pre> </blockquote> <br> </blockquote> <br> </body> </html> From 0cb7171b2a99b425323a8e02a968c9488de29608 Mon Sep 17 00:00:00 2001 From: Chunming Zhou <david1.zhou@amd.com> Date: Fri, 22 Mar 2019 15:33:01 +0800 Subject: [PATCH] fix rcu warning from kernel robot Signed-off-by: Chunming Zhou <david1.zhou@amd.com> --- drivers/dma-buf/dma-fence-chain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma-buf/dma-fence-chain.c b/drivers/dma-buf/dma-fence-chain.c index 0c5e3c902fa0..c729f98a7bd3 100644 --- a/drivers/dma-buf/dma-fence-chain.c +++ b/drivers/dma-buf/dma-fence-chain.c @@ -70,7 +70,7 @@ struct dma_fence *dma_fence_chain_walk(struct dma_fence *fence) replacement = NULL; } - tmp = cmpxchg(&chain->prev, prev, replacement); + tmp = cmpxchg((void **)&chain->prev, (void *)prev, (void *)replacement); if (tmp == prev) dma_fence_put(tmp); else @@ -187,7 +187,7 @@ static void dma_fence_chain_release(struct dma_fence *fence) { struct dma_fence_chain *chain = to_dma_fence_chain(fence); - dma_fence_put(chain->prev); + dma_fence_put(rcu_dereference_protected(chain->prev, true)); dma_fence_put(chain->fence); dma_fence_free(fence); } @@ -219,7 +219,7 @@ void dma_fence_chain_init(struct dma_fence_chain *chain, uint64_t context; spin_lock_init(&chain->lock); - chain->prev = prev; + rcu_assign_pointer(chain->prev, prev); chain->fence = fence; chain->prev_seqno = 0; init_irq_work(&chain->work, dma_fence_chain_irq_work);
Yeah, that should work. Christian. Am 22.03.19 um 08:34 schrieb zhoucm1: > > how about the attached? > > If ok, I will merge to pathc#1. > > > -David > > > On 2019年03月21日 22:40, Christian König wrote: >> No, atomic cmpxchg is a hardware operation. If you want to replace >> that you need a lock again. >> >> Maybe just add a comment and use an explicit cast to void* ? Not sure >> if that silences the warning. >> >> Christian. >> >> Am 21.03.19 um 15:13 schrieb Zhou, David(ChunMing): >>> cmpxchg be replaced by some simple c sentance? >>> otherwise we have to remove __rcu of chian->prev. >>> >>> -David >>> >>> -------- Original Message -------- >>> Subject: Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6 >>> From: Christian König >>> To: "Zhou, David(ChunMing)" ,kbuild test robot ,"Zhou, David(ChunMing)" >>> CC: >>> kbuild-all@01.org,dri-devel@lists.freedesktop.org,amd-gfx@lists.freedesktop.org,lionel.g.landwerlin@intel.com,jason@jlekstrand.net,"Koenig, >>> Christian" ,"Hector, Tobias" >>> >>> Hi David, >>> >>> For the cmpxchg() case I of hand don't know either. Looks like so far >>> nobody has used cmpxchg() with rcu protected structures. >>> >>> The other cases should be replaced by RCU_INIT_POINTER() or >>> rcu_dereference_protected(.., true); >>> >>> Regards, >>> Christian. >>> >>> Am 21.03.19 um 07:34 schrieb zhoucm1: >>> > Hi Lionel and Christian, >>> > >>> > Below is robot report for chain->prev, which was added __rcu as you >>> > suggested. >>> > >>> > How to fix this line "tmp = cmpxchg(&chain->prev, prev, >>> replacement); "? >>> > I checked kernel header file, seems it has no cmpxchg for rcu. >>> > >>> > Any suggestion to fix this robot report? >>> > >>> > Thanks, >>> > -David >>> > >>> > On 2019年03月21日 08:24, kbuild test robot wrote: >>> >> Hi Chunming, >>> >> >>> >> I love your patch! Perhaps something to improve: >>> >> >>> >> [auto build test WARNING on linus/master] >>> >> [also build test WARNING on v5.1-rc1 next-20190320] >>> >> [if your patch is applied to the wrong git tree, please drop us a >>> >> note to help improve the system] >>> >> >>> >> url: >>> >> >>> https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v6/20190320-223607 >>> >> reproduce: >>> >> # apt-get install sparse >>> >> make ARCH=x86_64 allmodconfig >>> >> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' >>> >> >>> >> >>> >> sparse warnings: (new ones prefixed by >>) >>> >> >>> >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in >>> >>>> initializer (different address spaces) @@ expected struct >>> >>>> dma_fence [noderef] <asn:4>*__old @@ got dma_fence [noderef] >>> >>>> <asn:4>*__old @@ >>> >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct >>> >> dma_fence [noderef] <asn:4>*__old >>> >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence >>> >> *[assigned] prev >>> >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in >>> >>>> initializer (different address spaces) @@ expected struct >>> >>>> dma_fence [noderef] <asn:4>*__new @@ got dma_fence [noderef] >>> >>>> <asn:4>*__new @@ >>> >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct >>> >> dma_fence [noderef] <asn:4>*__new >>> >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence >>> >> *[assigned] replacement >>> >>>> drivers/dma-buf/dma-fence-chain.c:73:21: sparse: incorrect type in >>> >>>> assignment (different address spaces) @@ expected struct >>> >>>> dma_fence *tmp @@ got struct dma_fence [noderef] <struct >>> >>>> dma_fence *tmp @@ >>> >> drivers/dma-buf/dma-fence-chain.c:73:21: expected struct >>> >> dma_fence *tmp >>> >> drivers/dma-buf/dma-fence-chain.c:73:21: got struct dma_fence >>> >> [noderef] <asn:4>*[assigned] __ret >>> >>>> drivers/dma-buf/dma-fence-chain.c:190:28: sparse: incorrect >>> type in >>> >>>> argument 1 (different address spaces) @@ expected struct >>> >>>> dma_fence *fence @@ got struct dma_fence struct dma_fence >>> *fence @@ >>> >> drivers/dma-buf/dma-fence-chain.c:190:28: expected struct >>> >> dma_fence *fence >>> >> drivers/dma-buf/dma-fence-chain.c:190:28: got struct dma_fence >>> >> [noderef] <asn:4>*prev >>> >>>> drivers/dma-buf/dma-fence-chain.c:222:21: sparse: incorrect >>> type in >>> >>>> assignment (different address spaces) @@ expected struct >>> >>>> dma_fence [noderef] <asn:4>*prev @@ got [noderef] >>> <asn:4>*prev @@ >>> >> drivers/dma-buf/dma-fence-chain.c:222:21: expected struct >>> >> dma_fence [noderef] <asn:4>*prev >>> >> drivers/dma-buf/dma-fence-chain.c:222:21: got struct dma_fence >>> >> *prev >>> >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression >>> >> using sizeof(void) >>> >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression >>> >> using sizeof(void) >>> >> >>> >> vim +73 drivers/dma-buf/dma-fence-chain.c >>> >> >>> >> 38 >>> >> 39 /** >>> >> 40 * dma_fence_chain_walk - chain walking function >>> >> 41 * @fence: current chain node >>> >> 42 * >>> >> 43 * Walk the chain to the next node. Returns the next >>> fence >>> >> or NULL if we are at >>> >> 44 * the end of the chain. Garbage collects chain nodes >>> >> which are already >>> >> 45 * signaled. >>> >> 46 */ >>> >> 47 struct dma_fence *dma_fence_chain_walk(struct dma_fence >>> >> *fence) >>> >> 48 { >>> >> 49 struct dma_fence_chain *chain, *prev_chain; >>> >> 50 struct dma_fence *prev, *replacement, *tmp; >>> >> 51 >>> >> 52 chain = to_dma_fence_chain(fence); >>> >> 53 if (!chain) { >>> >> 54 dma_fence_put(fence); >>> >> 55 return NULL; >>> >> 56 } >>> >> 57 >>> >> 58 while ((prev = dma_fence_chain_get_prev(chain))) { >>> >> 59 >>> >> 60 prev_chain = to_dma_fence_chain(prev); >>> >> 61 if (prev_chain) { >>> >> 62 if (!dma_fence_is_signaled(prev_chain->fence)) >>> >> 63 break; >>> >> 64 >>> >> 65 replacement = >>> >> dma_fence_chain_get_prev(prev_chain); >>> >> 66 } else { >>> >> 67 if (!dma_fence_is_signaled(prev)) >>> >> 68 break; >>> >> 69 >>> >> 70 replacement = NULL; >>> >> 71 } >>> >> 72 >>> >> > 73 tmp = cmpxchg(&chain->prev, prev, replacement); >>> >> 74 if (tmp == prev) >>> >> 75 dma_fence_put(tmp); >>> >> 76 else >>> >> 77 dma_fence_put(replacement); >>> >> 78 dma_fence_put(prev); >>> >> 79 } >>> >> 80 >>> >> 81 dma_fence_put(fence); >>> >> 82 return prev; >>> >> 83 } >>> >> 84 EXPORT_SYMBOL(dma_fence_chain_walk); >>> >> 85 >>> >> 86 /** >>> >> 87 * dma_fence_chain_find_seqno - find fence chain node by >>> >> seqno >>> >> 88 * @pfence: pointer to the chain node where to start >>> >> 89 * @seqno: the sequence number to search for >>> >> 90 * >>> >> 91 * Advance the fence pointer to the chain node which will >>> >> signal this sequence >>> >> 92 * number. If no sequence number is provided then this is >>> >> a no-op. >>> >> 93 * >>> >> 94 * Returns EINVAL if the fence is not a chain node or the >>> >> sequence number has >>> >> 95 * not yet advanced far enough. >>> >> 96 */ >>> >> 97 int dma_fence_chain_find_seqno(struct dma_fence **pfence, >>> >> uint64_t seqno) >>> >> 98 { >>> >> 99 struct dma_fence_chain *chain; >>> >> 100 >>> >> 101 if (!seqno) >>> >> 102 return 0; >>> >> 103 >>> >> 104 chain = to_dma_fence_chain(*pfence); >>> >> 105 if (!chain || chain->base.seqno < seqno) >>> >> 106 return -EINVAL; >>> >> 107 >>> >> 108 dma_fence_chain_for_each(*pfence, &chain->base) { >>> >> 109 if ((*pfence)->context != chain->base.context || >>> >> 110 to_dma_fence_chain(*pfence)->prev_seqno < seqno) >>> >> 111 break; >>> >> 112 } >>> >> 113 dma_fence_put(&chain->base); >>> >> 114 >>> >> 115 return 0; >>> >> 116 } >>> >> 117 EXPORT_SYMBOL(dma_fence_chain_find_seqno); >>> >> 118 >>> >> 119 static const char *dma_fence_chain_get_driver_name(struct >>> >> dma_fence *fence) >>> >> 120 { >>> >> 121 return "dma_fence_chain"; >>> >> 122 } >>> >> 123 >>> >> 124 static const char >>> >> *dma_fence_chain_get_timeline_name(struct dma_fence *fence) >>> >> 125 { >>> >> 126 return "unbound"; >>> >> 127 } >>> >> 128 >>> >> 129 static void dma_fence_chain_irq_work(struct irq_work >>> *work) >>> >> 130 { >>> >> 131 struct dma_fence_chain *chain; >>> >> 132 >>> >> 133 chain = container_of(work, typeof(*chain), work); >>> >> 134 >>> >> 135 /* Try to rearm the callback */ >>> >> 136 if (!dma_fence_chain_enable_signaling(&chain->base)) >>> >> 137 /* Ok, we are done. No more unsignaled fences >>> left */ >>> >> 138 dma_fence_signal(&chain->base); >>> >> 139 dma_fence_put(&chain->base); >>> >> 140 } >>> >> 141 >>> >> 142 static void dma_fence_chain_cb(struct dma_fence *f, >>> struct >>> >> dma_fence_cb *cb) >>> >> 143 { >>> >> 144 struct dma_fence_chain *chain; >>> >> 145 >>> >> 146 chain = container_of(cb, typeof(*chain), cb); >>> >> 147 irq_work_queue(&chain->work); >>> >> 148 dma_fence_put(f); >>> >> 149 } >>> >> 150 >>> >> 151 static bool dma_fence_chain_enable_signaling(struct >>> >> dma_fence *fence) >>> >> 152 { >>> >> 153 struct dma_fence_chain *head = >>> to_dma_fence_chain(fence); >>> >> 154 >>> >> 155 dma_fence_get(&head->base); >>> >> 156 dma_fence_chain_for_each(fence, &head->base) { >>> >> 157 struct dma_fence_chain *chain = >>> >> to_dma_fence_chain(fence); >>> >> 158 struct dma_fence *f = chain ? chain->fence : >>> fence; >>> >> 159 >>> >> 160 dma_fence_get(f); >>> >> 161 if (!dma_fence_add_callback(f, &head->cb, >>> >> dma_fence_chain_cb)) { >>> >> 162 dma_fence_put(fence); >>> >> 163 return true; >>> >> 164 } >>> >> 165 dma_fence_put(f); >>> >> 166 } >>> >> 167 dma_fence_put(&head->base); >>> >> 168 return false; >>> >> 169 } >>> >> 170 >>> >> 171 static bool dma_fence_chain_signaled(struct dma_fence >>> *fence) >>> >> 172 { >>> >> 173 dma_fence_chain_for_each(fence, fence) { >>> >> 174 struct dma_fence_chain *chain = >>> >> to_dma_fence_chain(fence); >>> >> 175 struct dma_fence *f = chain ? chain->fence : >>> fence; >>> >> 176 >>> >> 177 if (!dma_fence_is_signaled(f)) { >>> >> 178 dma_fence_put(fence); >>> >> 179 return false; >>> >> 180 } >>> >> 181 } >>> >> 182 >>> >> 183 return true; >>> >> 184 } >>> >> 185 >>> >> 186 static void dma_fence_chain_release(struct dma_fence >>> *fence) >>> >> 187 { >>> >> 188 struct dma_fence_chain *chain = >>> >> to_dma_fence_chain(fence); >>> >> 189 >>> >> > 190 dma_fence_put(chain->prev); >>> >> 191 dma_fence_put(chain->fence); >>> >> 192 dma_fence_free(fence); >>> >> 193 } >>> >> 194 >>> >> 195 const struct dma_fence_ops dma_fence_chain_ops = { >>> >> 196 .get_driver_name = dma_fence_chain_get_driver_name, >>> >> 197 .get_timeline_name = >>> dma_fence_chain_get_timeline_name, >>> >> 198 .enable_signaling = dma_fence_chain_enable_signaling, >>> >> 199 .signaled = dma_fence_chain_signaled, >>> >> 200 .release = dma_fence_chain_release, >>> >> 201 }; >>> >> 202 EXPORT_SYMBOL(dma_fence_chain_ops); >>> >> 203 >>> >> 204 /** >>> >> 205 * dma_fence_chain_init - initialize a fence chain >>> >> 206 * @chain: the chain node to initialize >>> >> 207 * @prev: the previous fence >>> >> 208 * @fence: the current fence >>> >> 209 * >>> >> 210 * Initialize a new chain node and either start a new >>> >> chain or add the node to >>> >> 211 * the existing chain of the previous fence. >>> >> 212 */ >>> >> 213 void dma_fence_chain_init(struct dma_fence_chain *chain, >>> >> 214 struct dma_fence *prev, >>> >> 215 struct dma_fence *fence, >>> >> 216 uint64_t seqno) >>> >> 217 { >>> >> 218 struct dma_fence_chain *prev_chain = >>> >> to_dma_fence_chain(prev); >>> >> 219 uint64_t context; >>> >> 220 >>> >> 221 spin_lock_init(&chain->lock); >>> >> > 222 chain->prev = prev; >>> >> >>> >> --- >>> >> 0-DAY kernel test infrastructure Open Source >>> >> Technology Center >>> >> https://lists.01.org/pipermail/kbuild-all Intel Corporation >>> > >>> >>> >>> _______________________________________________ >>> amd-gfx mailing list >>> amd-gfx@lists.freedesktop.org >>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >> > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">Yeah, that should work.<br> <br> Christian.<br> <br> Am 22.03.19 um 08:34 schrieb zhoucm1:<br> </div> <blockquote type="cite" cite="mid:5cb29811-a383-f473-5443-25e9d968c516@amd.com"> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <p>how about the attached?</p> <p>If ok, I will merge to pathc#1.</p> <p><br> </p> <p>-David<br> </p> <br> <div class="moz-cite-prefix">On 2019年03月21日 22:40, Christian König wrote:<br> </div> <blockquote type="cite" cite="mid:6bd1f7e6-965b-3bd5-e4e0-f3b04e0638fd@gmail.com"> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <div class="moz-cite-prefix">No, atomic cmpxchg is a hardware operation. If you want to replace that you need a lock again.<br> <br> Maybe just add a comment and use an explicit cast to void* ? Not sure if that silences the warning.<br> <br> Christian.<br> <br> Am 21.03.19 um 15:13 schrieb Zhou, David(ChunMing):<br> </div> <blockquote type="cite" cite="mid:2q1nzdv6akhy5260mi-2nbzia-ttsfc8-dz76ft-4ifnnm-oz4kfp-uezs6vwoq2oq-wd0h34-v7m6m7-cd3muc-v4wzqd-yktmtp-2338r6riorqe-ez3yxk-8jr766yyjh0ob0v5e8-33h712k31w5b1ntkih.1553177522341@email.android.com"> <meta name="Generator" content="Microsoft Exchange Server"> <!-- converted from text --> <style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style> <div>cmpxchg be replaced by some simple c sentance?<br> otherwise we have to remove __rcu of chian->prev.<br> <br> -David<br> <br> -------- Original Message --------<br> Subject: Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6<br> From: Christian König <br> To: "Zhou, David(ChunMing)" ,kbuild test robot ,"Zhou, David(ChunMing)" <br> CC: <a class="moz-txt-link-abbreviated" href="mailto:kbuild-all@01.org,dri-devel@lists.freedesktop.org,amd-gfx@lists.freedesktop.org,lionel.g.landwerlin@intel.com,jason@jlekstrand.net" moz-do-not-send="true">kbuild-all@01.org,dri-devel@lists.freedesktop.org,amd-gfx@lists.freedesktop.org,lionel.g.landwerlin@intel.com,jason@jlekstrand.net</a>,"Koenig, Christian" ,"Hector, Tobias" <br> <br> </div> <font size="2"><span style="font-size:11pt;"> <div class="PlainText">Hi David,<br> <br> For the cmpxchg() case I of hand don't know either. Looks like so far <br> nobody has used cmpxchg() with rcu protected structures.<br> <br> The other cases should be replaced by RCU_INIT_POINTER() or <br> rcu_dereference_protected(.., true);<br> <br> Regards,<br> Christian.<br> <br> Am 21.03.19 um 07:34 schrieb zhoucm1:<br> > Hi Lionel and Christian,<br> ><br> > Below is robot report for chain->prev, which was added __rcu as you <br> > suggested.<br> ><br> > How to fix this line "tmp = cmpxchg(&chain->prev, prev, replacement); "?<br> > I checked kernel header file, seems it has no cmpxchg for rcu.<br> ><br> > Any suggestion to fix this robot report?<br> ><br> > Thanks,<br> > -David<br> ><br> > On 2019年03月21日 08:24, kbuild test robot wrote:<br> >> Hi Chunming,<br> >><br> >> I love your patch! Perhaps something to improve:<br> >><br> >> [auto build test WARNING on linus/master]<br> >> [also build test WARNING on v5.1-rc1 next-20190320]<br> >> [if your patch is applied to the wrong git tree, please drop us a <br> >> note to help improve the system]<br> >><br> >> url: <br> >> <a href="https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v6/20190320-223607" moz-do-not-send="true"> https://github.com/0day-ci/linux/commits/Chunming-Zhou/dma-buf-add-new-dma_fence_chain-container-v6/20190320-223607</a><br> >> reproduce:<br> >> # apt-get install sparse<br> >> make ARCH=x86_64 allmodconfig<br> >> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'<br> >><br> >><br> >> sparse warnings: (new ones prefixed by >>)<br> >><br> >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in <br> >>>> initializer (different address spaces) @@ expected struct <br> >>>> dma_fence [noderef] <asn:4>*__old @@ got dma_fence [noderef] <br> >>>> <asn:4>*__old @@<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct <br> >> dma_fence [noderef] <asn:4>*__old<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence <br> >> *[assigned] prev<br> >>>> drivers/dma-buf/dma-fence-chain.c:73:23: sparse: incorrect type in <br> >>>> initializer (different address spaces) @@ expected struct <br> >>>> dma_fence [noderef] <asn:4>*__new @@ got dma_fence [noderef] <br> >>>> <asn:4>*__new @@<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: expected struct <br> >> dma_fence [noderef] <asn:4>*__new<br> >> drivers/dma-buf/dma-fence-chain.c:73:23: got struct dma_fence <br> >> *[assigned] replacement<br> >>>> drivers/dma-buf/dma-fence-chain.c:73:21: sparse: incorrect type in <br> >>>> assignment (different address spaces) @@ expected struct <br> >>>> dma_fence *tmp @@ got struct dma_fence [noderef] <struct <br> >>>> dma_fence *tmp @@<br> >> drivers/dma-buf/dma-fence-chain.c:73:21: expected struct <br> >> dma_fence *tmp<br> >> drivers/dma-buf/dma-fence-chain.c:73:21: got struct dma_fence <br> >> [noderef] <asn:4>*[assigned] __ret<br> >>>> drivers/dma-buf/dma-fence-chain.c:190:28: sparse: incorrect type in <br> >>>> argument 1 (different address spaces) @@ expected struct <br> >>>> dma_fence *fence @@ got struct dma_fence struct dma_fence *fence @@<br> >> drivers/dma-buf/dma-fence-chain.c:190:28: expected struct <br> >> dma_fence *fence<br> >> drivers/dma-buf/dma-fence-chain.c:190:28: got struct dma_fence <br> >> [noderef] <asn:4>*prev<br> >>>> drivers/dma-buf/dma-fence-chain.c:222:21: sparse: incorrect type in <br> >>>> assignment (different address spaces) @@ expected struct <br> >>>> dma_fence [noderef] <asn:4>*prev @@ got [noderef] <asn:4>*prev @@<br> >> drivers/dma-buf/dma-fence-chain.c:222:21: expected struct <br> >> dma_fence [noderef] <asn:4>*prev<br> >> drivers/dma-buf/dma-fence-chain.c:222:21: got struct dma_fence <br> >> *prev<br> >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression <br> >> using sizeof(void)<br> >> drivers/dma-buf/dma-fence-chain.c:235:33: sparse: expression <br> >> using sizeof(void)<br> >><br> >> vim +73 drivers/dma-buf/dma-fence-chain.c<br> >><br> >> 38<br> >> 39 /**<br> >> 40 * dma_fence_chain_walk - chain walking function<br> >> 41 * @fence: current chain node<br> >> 42 *<br> >> 43 * Walk the chain to the next node. Returns the next fence <br> >> or NULL if we are at<br> >> 44 * the end of the chain. Garbage collects chain nodes <br> >> which are already<br> >> 45 * signaled.<br> >> 46 */<br> >> 47 struct dma_fence *dma_fence_chain_walk(struct dma_fence <br> >> *fence)<br> >> 48 {<br> >> 49 struct dma_fence_chain *chain, *prev_chain;<br> >> 50 struct dma_fence *prev, *replacement, *tmp;<br> >> 51<br> >> 52 chain = to_dma_fence_chain(fence);<br> >> 53 if (!chain) {<br> >> 54 dma_fence_put(fence);<br> >> 55 return NULL;<br> >> 56 }<br> >> 57<br> >> 58 while ((prev = dma_fence_chain_get_prev(chain))) {<br> >> 59<br> >> 60 prev_chain = to_dma_fence_chain(prev);<br> >> 61 if (prev_chain) {<br> >> 62 if (!dma_fence_is_signaled(prev_chain->fence))<br> >> 63 break;<br> >> 64<br> >> 65 replacement = <br> >> dma_fence_chain_get_prev(prev_chain);<br> >> 66 } else {<br> >> 67 if (!dma_fence_is_signaled(prev))<br> >> 68 break;<br> >> 69<br> >> 70 replacement = NULL;<br> >> 71 }<br> >> 72<br> >> > 73 tmp = cmpxchg(&chain->prev, prev, replacement);<br> >> 74 if (tmp == prev)<br> >> 75 dma_fence_put(tmp);<br> >> 76 else<br> >> 77 dma_fence_put(replacement);<br> >> 78 dma_fence_put(prev);<br> >> 79 }<br> >> 80<br> >> 81 dma_fence_put(fence);<br> >> 82 return prev;<br> >> 83 }<br> >> 84 EXPORT_SYMBOL(dma_fence_chain_walk);<br> >> 85<br> >> 86 /**<br> >> 87 * dma_fence_chain_find_seqno - find fence chain node by <br> >> seqno<br> >> 88 * @pfence: pointer to the chain node where to start<br> >> 89 * @seqno: the sequence number to search for<br> >> 90 *<br> >> 91 * Advance the fence pointer to the chain node which will <br> >> signal this sequence<br> >> 92 * number. If no sequence number is provided then this is <br> >> a no-op.<br> >> 93 *<br> >> 94 * Returns EINVAL if the fence is not a chain node or the <br> >> sequence number has<br> >> 95 * not yet advanced far enough.<br> >> 96 */<br> >> 97 int dma_fence_chain_find_seqno(struct dma_fence **pfence, <br> >> uint64_t seqno)<br> >> 98 {<br> >> 99 struct dma_fence_chain *chain;<br> >> 100<br> >> 101 if (!seqno)<br> >> 102 return 0;<br> >> 103<br> >> 104 chain = to_dma_fence_chain(*pfence);<br> >> 105 if (!chain || chain->base.seqno < seqno)<br> >> 106 return -EINVAL;<br> >> 107<br> >> 108 dma_fence_chain_for_each(*pfence, &chain->base) {<br> >> 109 if ((*pfence)->context != chain->base.context ||<br> >> 110 to_dma_fence_chain(*pfence)->prev_seqno < seqno)<br> >> 111 break;<br> >> 112 }<br> >> 113 dma_fence_put(&chain->base);<br> >> 114<br> >> 115 return 0;<br> >> 116 }<br> >> 117 EXPORT_SYMBOL(dma_fence_chain_find_seqno);<br> >> 118<br> >> 119 static const char *dma_fence_chain_get_driver_name(struct <br> >> dma_fence *fence)<br> >> 120 {<br> >> 121 return "dma_fence_chain";<br> >> 122 }<br> >> 123<br> >> 124 static const char <br> >> *dma_fence_chain_get_timeline_name(struct dma_fence *fence)<br> >> 125 {<br> >> 126 return "unbound";<br> >> 127 }<br> >> 128<br> >> 129 static void dma_fence_chain_irq_work(struct irq_work *work)<br> >> 130 {<br> >> 131 struct dma_fence_chain *chain;<br> >> 132<br> >> 133 chain = container_of(work, typeof(*chain), work);<br> >> 134<br> >> 135 /* Try to rearm the callback */<br> >> 136 if (!dma_fence_chain_enable_signaling(&chain->base))<br> >> 137 /* Ok, we are done. No more unsignaled fences left */<br> >> 138 dma_fence_signal(&chain->base);<br> >> 139 dma_fence_put(&chain->base);<br> >> 140 }<br> >> 141<br> >> 142 static void dma_fence_chain_cb(struct dma_fence *f, struct <br> >> dma_fence_cb *cb)<br> >> 143 {<br> >> 144 struct dma_fence_chain *chain;<br> >> 145<br> >> 146 chain = container_of(cb, typeof(*chain), cb);<br> >> 147 irq_work_queue(&chain->work);<br> >> 148 dma_fence_put(f);<br> >> 149 }<br> >> 150<br> >> 151 static bool dma_fence_chain_enable_signaling(struct <br> >> dma_fence *fence)<br> >> 152 {<br> >> 153 struct dma_fence_chain *head = to_dma_fence_chain(fence);<br> >> 154<br> >> 155 dma_fence_get(&head->base);<br> >> 156 dma_fence_chain_for_each(fence, &head->base) {<br> >> 157 struct dma_fence_chain *chain = <br> >> to_dma_fence_chain(fence);<br> >> 158 struct dma_fence *f = chain ? chain->fence : fence;<br> >> 159<br> >> 160 dma_fence_get(f);<br> >> 161 if (!dma_fence_add_callback(f, &head->cb, <br> >> dma_fence_chain_cb)) {<br> >> 162 dma_fence_put(fence);<br> >> 163 return true;<br> >> 164 }<br> >> 165 dma_fence_put(f);<br> >> 166 }<br> >> 167 dma_fence_put(&head->base);<br> >> 168 return false;<br> >> 169 }<br> >> 170<br> >> 171 static bool dma_fence_chain_signaled(struct dma_fence *fence)<br> >> 172 {<br> >> 173 dma_fence_chain_for_each(fence, fence) {<br> >> 174 struct dma_fence_chain *chain = <br> >> to_dma_fence_chain(fence);<br> >> 175 struct dma_fence *f = chain ? chain->fence : fence;<br> >> 176<br> >> 177 if (!dma_fence_is_signaled(f)) {<br> >> 178 dma_fence_put(fence);<br> >> 179 return false;<br> >> 180 }<br> >> 181 }<br> >> 182<br> >> 183 return true;<br> >> 184 }<br> >> 185<br> >> 186 static void dma_fence_chain_release(struct dma_fence *fence)<br> >> 187 {<br> >> 188 struct dma_fence_chain *chain = <br> >> to_dma_fence_chain(fence);<br> >> 189<br> >> > 190 dma_fence_put(chain->prev);<br> >> 191 dma_fence_put(chain->fence);<br> >> 192 dma_fence_free(fence);<br> >> 193 }<br> >> 194<br> >> 195 const struct dma_fence_ops dma_fence_chain_ops = {<br> >> 196 .get_driver_name = dma_fence_chain_get_driver_name,<br> >> 197 .get_timeline_name = dma_fence_chain_get_timeline_name,<br> >> 198 .enable_signaling = dma_fence_chain_enable_signaling,<br> >> 199 .signaled = dma_fence_chain_signaled,<br> >> 200 .release = dma_fence_chain_release,<br> >> 201 };<br> >> 202 EXPORT_SYMBOL(dma_fence_chain_ops);<br> >> 203<br> >> 204 /**<br> >> 205 * dma_fence_chain_init - initialize a fence chain<br> >> 206 * @chain: the chain node to initialize<br> >> 207 * @prev: the previous fence<br> >> 208 * @fence: the current fence<br> >> 209 *<br> >> 210 * Initialize a new chain node and either start a new <br> >> chain or add the node to<br> >> 211 * the existing chain of the previous fence.<br> >> 212 */<br> >> 213 void dma_fence_chain_init(struct dma_fence_chain *chain,<br> >> 214 struct dma_fence *prev,<br> >> 215 struct dma_fence *fence,<br> >> 216 uint64_t seqno)<br> >> 217 {<br> >> 218 struct dma_fence_chain *prev_chain = <br> >> to_dma_fence_chain(prev);<br> >> 219 uint64_t context;<br> >> 220<br> >> 221 spin_lock_init(&chain->lock);<br> >> > 222 chain->prev = prev;<br> >><br> >> ---<br> >> 0-DAY kernel test infrastructure Open Source <br> >> Technology Center<br> >> <a href="https://lists.01.org/pipermail/kbuild-all" moz-do-not-send="true">https://lists.01.org/pipermail/kbuild-all</a> Intel Corporation<br> ><br> <br> </div> </span></font> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <pre class="moz-quote-pre" wrap="">_______________________________________________ amd-gfx mailing list <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></pre> </blockquote> <br> </blockquote> <br> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <pre class="moz-quote-pre" wrap="">_______________________________________________ amd-gfx mailing list <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></pre> </blockquote> <br> </body> </html>
diff --git a/drivers/dma-buf/Makefile b/drivers/dma-buf/Makefile index 0913a6ccab5a..1f006e083eb9 100644 --- a/drivers/dma-buf/Makefile +++ b/drivers/dma-buf/Makefile @@ -1,4 +1,5 @@ -obj-y := dma-buf.o dma-fence.o dma-fence-array.o reservation.o seqno-fence.o +obj-y := dma-buf.o dma-fence.o dma-fence-array.o dma-fence-chain.o \ + reservation.o seqno-fence.o obj-$(CONFIG_SYNC_FILE) += sync_file.o obj-$(CONFIG_SW_SYNC) += sw_sync.o sync_debug.o obj-$(CONFIG_UDMABUF) += udmabuf.o diff --git a/drivers/dma-buf/dma-fence-chain.c b/drivers/dma-buf/dma-fence-chain.c new file mode 100644 index 000000000000..0c5e3c902fa0 --- /dev/null +++ b/drivers/dma-buf/dma-fence-chain.c @@ -0,0 +1,241 @@ +/* + * fence-chain: chain fences together in a timeline + * + * Copyright (C) 2018 Advanced Micro Devices, Inc. + * Authors: + * Christian König <christian.koenig@amd.com> + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 as published by + * the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + */ + +#include <linux/dma-fence-chain.h> + +static bool dma_fence_chain_enable_signaling(struct dma_fence *fence); + +/** + * dma_fence_chain_get_prev - use RCU to get a reference to the previous fence + * @chain: chain node to get the previous node from + * + * Use dma_fence_get_rcu_safe to get a reference to the previous fence of the + * chain node. + */ +static struct dma_fence *dma_fence_chain_get_prev(struct dma_fence_chain *chain) +{ + struct dma_fence *prev; + + rcu_read_lock(); + prev = dma_fence_get_rcu_safe(&chain->prev); + rcu_read_unlock(); + return prev; +} + +/** + * dma_fence_chain_walk - chain walking function + * @fence: current chain node + * + * Walk the chain to the next node. Returns the next fence or NULL if we are at + * the end of the chain. Garbage collects chain nodes which are already + * signaled. + */ +struct dma_fence *dma_fence_chain_walk(struct dma_fence *fence) +{ + struct dma_fence_chain *chain, *prev_chain; + struct dma_fence *prev, *replacement, *tmp; + + chain = to_dma_fence_chain(fence); + if (!chain) { + dma_fence_put(fence); + return NULL; + } + + while ((prev = dma_fence_chain_get_prev(chain))) { + + prev_chain = to_dma_fence_chain(prev); + if (prev_chain) { + if (!dma_fence_is_signaled(prev_chain->fence)) + break; + + replacement = dma_fence_chain_get_prev(prev_chain); + } else { + if (!dma_fence_is_signaled(prev)) + break; + + replacement = NULL; + } + + tmp = cmpxchg(&chain->prev, prev, replacement); + if (tmp == prev) + dma_fence_put(tmp); + else + dma_fence_put(replacement); + dma_fence_put(prev); + } + + dma_fence_put(fence); + return prev; +} +EXPORT_SYMBOL(dma_fence_chain_walk); + +/** + * dma_fence_chain_find_seqno - find fence chain node by seqno + * @pfence: pointer to the chain node where to start + * @seqno: the sequence number to search for + * + * Advance the fence pointer to the chain node which will signal this sequence + * number. If no sequence number is provided then this is a no-op. + * + * Returns EINVAL if the fence is not a chain node or the sequence number has + * not yet advanced far enough. + */ +int dma_fence_chain_find_seqno(struct dma_fence **pfence, uint64_t seqno) +{ + struct dma_fence_chain *chain; + + if (!seqno) + return 0; + + chain = to_dma_fence_chain(*pfence); + if (!chain || chain->base.seqno < seqno) + return -EINVAL; + + dma_fence_chain_for_each(*pfence, &chain->base) { + if ((*pfence)->context != chain->base.context || + to_dma_fence_chain(*pfence)->prev_seqno < seqno) + break; + } + dma_fence_put(&chain->base); + + return 0; +} +EXPORT_SYMBOL(dma_fence_chain_find_seqno); + +static const char *dma_fence_chain_get_driver_name(struct dma_fence *fence) +{ + return "dma_fence_chain"; +} + +static const char *dma_fence_chain_get_timeline_name(struct dma_fence *fence) +{ + return "unbound"; +} + +static void dma_fence_chain_irq_work(struct irq_work *work) +{ + struct dma_fence_chain *chain; + + chain = container_of(work, typeof(*chain), work); + + /* Try to rearm the callback */ + if (!dma_fence_chain_enable_signaling(&chain->base)) + /* Ok, we are done. No more unsignaled fences left */ + dma_fence_signal(&chain->base); + dma_fence_put(&chain->base); +} + +static void dma_fence_chain_cb(struct dma_fence *f, struct dma_fence_cb *cb) +{ + struct dma_fence_chain *chain; + + chain = container_of(cb, typeof(*chain), cb); + irq_work_queue(&chain->work); + dma_fence_put(f); +} + +static bool dma_fence_chain_enable_signaling(struct dma_fence *fence) +{ + struct dma_fence_chain *head = to_dma_fence_chain(fence); + + dma_fence_get(&head->base); + dma_fence_chain_for_each(fence, &head->base) { + struct dma_fence_chain *chain = to_dma_fence_chain(fence); + struct dma_fence *f = chain ? chain->fence : fence; + + dma_fence_get(f); + if (!dma_fence_add_callback(f, &head->cb, dma_fence_chain_cb)) { + dma_fence_put(fence); + return true; + } + dma_fence_put(f); + } + dma_fence_put(&head->base); + return false; +} + +static bool dma_fence_chain_signaled(struct dma_fence *fence) +{ + dma_fence_chain_for_each(fence, fence) { + struct dma_fence_chain *chain = to_dma_fence_chain(fence); + struct dma_fence *f = chain ? chain->fence : fence; + + if (!dma_fence_is_signaled(f)) { + dma_fence_put(fence); + return false; + } + } + + return true; +} + +static void dma_fence_chain_release(struct dma_fence *fence) +{ + struct dma_fence_chain *chain = to_dma_fence_chain(fence); + + dma_fence_put(chain->prev); + dma_fence_put(chain->fence); + dma_fence_free(fence); +} + +const struct dma_fence_ops dma_fence_chain_ops = { + .get_driver_name = dma_fence_chain_get_driver_name, + .get_timeline_name = dma_fence_chain_get_timeline_name, + .enable_signaling = dma_fence_chain_enable_signaling, + .signaled = dma_fence_chain_signaled, + .release = dma_fence_chain_release, +}; +EXPORT_SYMBOL(dma_fence_chain_ops); + +/** + * dma_fence_chain_init - initialize a fence chain + * @chain: the chain node to initialize + * @prev: the previous fence + * @fence: the current fence + * + * Initialize a new chain node and either start a new chain or add the node to + * the existing chain of the previous fence. + */ +void dma_fence_chain_init(struct dma_fence_chain *chain, + struct dma_fence *prev, + struct dma_fence *fence, + uint64_t seqno) +{ + struct dma_fence_chain *prev_chain = to_dma_fence_chain(prev); + uint64_t context; + + spin_lock_init(&chain->lock); + chain->prev = prev; + chain->fence = fence; + chain->prev_seqno = 0; + init_irq_work(&chain->work, dma_fence_chain_irq_work); + + /* Try to reuse the context of the previous chain node. */ + if (prev_chain && __dma_fence_is_later(seqno, prev->seqno)) { + context = prev->context; + chain->prev_seqno = prev->seqno; + } else { + context = dma_fence_context_alloc(1); + /* Make sure that we always have a valid sequence number. */ + if (prev_chain) + seqno = max(prev->seqno, seqno); + } + + dma_fence_init(&chain->base, &dma_fence_chain_ops, + &chain->lock, context, seqno); +} +EXPORT_SYMBOL(dma_fence_chain_init); diff --git a/include/linux/dma-fence-chain.h b/include/linux/dma-fence-chain.h new file mode 100644 index 000000000000..934a442db8ac --- /dev/null +++ b/include/linux/dma-fence-chain.h @@ -0,0 +1,81 @@ +/* + * fence-chain: chain fences together in a timeline + * + * Copyright (C) 2018 Advanced Micro Devices, Inc. + * Authors: + * Christian König <christian.koenig@amd.com> + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 as published by + * the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + */ + +#ifndef __LINUX_DMA_FENCE_CHAIN_H +#define __LINUX_DMA_FENCE_CHAIN_H + +#include <linux/dma-fence.h> +#include <linux/irq_work.h> + +/** + * struct dma_fence_chain - fence to represent an node of a fence chain + * @base: fence base class + * @lock: spinlock for fence handling + * @prev: previous fence of the chain + * @prev_seqno: original previous seqno before garbage collection + * @fence: encapsulated fence + * @cb: callback structure for signaling + * @work: irq work item for signaling + */ +struct dma_fence_chain { + struct dma_fence base; + spinlock_t lock; + struct dma_fence __rcu *prev; + u64 prev_seqno; + struct dma_fence *fence; + struct dma_fence_cb cb; + struct irq_work work; +}; + +extern const struct dma_fence_ops dma_fence_chain_ops; + +/** + * to_dma_fence_chain - cast a fence to a dma_fence_chain + * @fence: fence to cast to a dma_fence_array + * + * Returns NULL if the fence is not a dma_fence_chain, + * or the dma_fence_chain otherwise. + */ +static inline struct dma_fence_chain * +to_dma_fence_chain(struct dma_fence *fence) +{ + if (!fence || fence->ops != &dma_fence_chain_ops) + return NULL; + + return container_of(fence, struct dma_fence_chain, base); +} + +/** + * dma_fence_chain_for_each - iterate over all fences in chain + * @iter: current fence + * @head: starting point + * + * Iterate over all fences in the chain. We keep a reference to the current + * fence while inside the loop which must be dropped when breaking out. + */ +#define dma_fence_chain_for_each(iter, head) \ + for (iter = dma_fence_get(head); iter; \ + iter = dma_fence_chain_walk(iter)) + +struct dma_fence *dma_fence_chain_walk(struct dma_fence *fence); +int dma_fence_chain_find_seqno(struct dma_fence **pfence, uint64_t seqno); +void dma_fence_chain_init(struct dma_fence_chain *chain, + struct dma_fence *prev, + struct dma_fence *fence, + uint64_t seqno); + +#endif /* __LINUX_DMA_FENCE_CHAIN_H */