| Message ID | 20190321175128.32178-1-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Really calculate the cursor ddb based on the highest enabled wm level | expand |
On Thu, Mar 21, 2019 at 07:51:28PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > I added the loop but neglected to actually pass the level to the > function. So we were just looping 8 times calculating the exact > same thing every time. > > Fixes: df331de3f8aa ("drm/i915: Allocate enough DDB for the cursor") > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/intel_pm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index fcd3baff8b65..eaf0793ebf60 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -3953,7 +3953,7 @@ skl_cursor_allocation(const struct intel_crtc_state *crtc_state, > WARN_ON(ret); > > for (level = 0; level <= max_level; level++) { > - skl_compute_plane_wm(crtc_state, 7, &wp, &wm, &wm); > + skl_compute_plane_wm(crtc_state, level, &wp, &wm, &wm); > if (wm.min_ddb_alloc == U16_MAX) > break; > > -- > 2.19.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Thu, Mar 21, 2019 at 01:20:51PM -0700, Rodrigo Vivi wrote: > On Thu, Mar 21, 2019 at 07:51:28PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > I added the loop but neglected to actually pass the level to the > > function. So we were just looping 8 times calculating the exact > > same thing every time. > > > > Fixes: df331de3f8aa ("drm/i915: Allocate enough DDB for the cursor") > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Thanks. Pushed. > > > --- > > drivers/gpu/drm/i915/intel_pm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > > index fcd3baff8b65..eaf0793ebf60 100644 > > --- a/drivers/gpu/drm/i915/intel_pm.c > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > @@ -3953,7 +3953,7 @@ skl_cursor_allocation(const struct intel_crtc_state *crtc_state, > > WARN_ON(ret); > > > > for (level = 0; level <= max_level; level++) { > > - skl_compute_plane_wm(crtc_state, 7, &wp, &wm, &wm); > > + skl_compute_plane_wm(crtc_state, level, &wp, &wm, &wm); > > if (wm.min_ddb_alloc == U16_MAX) > > break; > > > > -- > > 2.19.2 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index fcd3baff8b65..eaf0793ebf60 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -3953,7 +3953,7 @@ skl_cursor_allocation(const struct intel_crtc_state *crtc_state, WARN_ON(ret); for (level = 0; level <= max_level; level++) { - skl_compute_plane_wm(crtc_state, 7, &wp, &wm, &wm); + skl_compute_plane_wm(crtc_state, level, &wp, &wm, &wm); if (wm.min_ddb_alloc == U16_MAX) break;