| Message ID | 1553680707-28579-1-git-send-email-stanley.chu@mediatek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | scsi: ufs: Fix regulator operations and remove "<name>-fixed-regulator" device tree property | expand |
> Hi, > > Resend this patch series for review. > > This version (v3) fixed and added more details in commit messages, and added > one patch to fix "undefined voltage range" issue as well. > > This patch series fixes UFS regulator operations, including voltage and current > (re-)configuration flow during UFS initialization and power mode switching. > > In the end, remove "<name>-fixed-regulator" device tree property because it is > not necessary anymore after these fixes. > > V3: > - Fix and add more details in commit messages. > - Add one patch "scsi: ufs: Avoid configuring undefined voltage range on a > regulator". > > V2: > - Add two patches to prepare to and remove "<name>-fixed-regulator" device > tree property. > - Add more details on patch "scsi: ufs: remove unused min_uA field in struct > ufs_vreg" (Marc Gonzalez). > > Stanley Chu (5): > scsi: ufs: Remove unused min_uA field in struct ufs_vreg > scsi: ufs: Avoid configuring regulator with undefined voltage range > scsi: ufs: Fix regulator load and icc-level configuration > scsi: ufs: Change "<name>-max-microamp" to non-mandatory property > scsi: ufs: Remove "<name>-fixed-regulator" device tree property > This series looks good to me, but better get acked-by from couple of platform guys as well. Thanks, Avri
Hi Avri, On Wed, 2019-03-27 at 10:57 +0000, Avri Altman wrote: > > Hi, > > > > Resend this patch series for review. > > > > This version (v3) fixed and added more details in commit messages, and added > > one patch to fix "undefined voltage range" issue as well. > > > > This patch series fixes UFS regulator operations, including voltage and current > > (re-)configuration flow during UFS initialization and power mode switching. > > > > In the end, remove "<name>-fixed-regulator" device tree property because it is > > not necessary anymore after these fixes. > > > > V3: > > - Fix and add more details in commit messages. > > - Add one patch "scsi: ufs: Avoid configuring undefined voltage range on a > > regulator". > > > > V2: > > - Add two patches to prepare to and remove "<name>-fixed-regulator" device > > tree property. > > - Add more details on patch "scsi: ufs: remove unused min_uA field in struct > > ufs_vreg" (Marc Gonzalez). > > > > Stanley Chu (5): > > scsi: ufs: Remove unused min_uA field in struct ufs_vreg > > scsi: ufs: Avoid configuring regulator with undefined voltage range > > scsi: ufs: Fix regulator load and icc-level configuration > > scsi: ufs: Change "<name>-max-microamp" to non-mandatory property > > scsi: ufs: Remove "<name>-fixed-regulator" device tree property > > > This series looks good to me, but better get acked-by from couple of platform guys as well. Thanks so much for review. I'll fix commit message and invite more reviewers in next version. > > Thanks, > Avri > Thanks, Stanley
Hi Stanley,
Please collect all the {review/acked}-by tags when reposting so that
people are aware which all patches need to review.
https://www.spinics.net/lists/linux-scsi/msg128818.html
This series looks good, it will be if we get a Tested-by as well.
For this series
Acked-by: Alim Akhtar <alim.akhtar@samsung.com>
On Wed, Mar 27, 2019 at 3:29 PM Stanley Chu <stanley.chu@mediatek.com> wrote:
>
> Hi,
>
> Resend this patch series for review.
>
> This version (v3) fixed and added more details in commit messages, and added one patch to fix "undefined voltage range" issue as well.
>
> This patch series fixes UFS regulator operations, including voltage and current (re-)configuration flow during UFS initialization and power mode switching.
>
> In the end, remove "<name>-fixed-regulator" device tree property because it is not necessary anymore after these fixes.
>
> V3:
> - Fix and add more details in commit messages.
> - Add one patch "scsi: ufs: Avoid configuring undefined voltage range on a regulator".
>
> V2:
> - Add two patches to prepare to and remove "<name>-fixed-regulator" device tree property.
> - Add more details on patch "scsi: ufs: remove unused min_uA field in struct ufs_vreg" (Marc Gonzalez).
>
> Stanley Chu (5):
> scsi: ufs: Remove unused min_uA field in struct ufs_vreg
> scsi: ufs: Avoid configuring regulator with undefined voltage range
> scsi: ufs: Fix regulator load and icc-level configuration
> scsi: ufs: Change "<name>-max-microamp" to non-mandatory property
> scsi: ufs: Remove "<name>-fixed-regulator" device tree property
>
> drivers/scsi/ufs/ufs.h | 1 -
> drivers/scsi/ufs/ufshcd-pltfrm.c | 14 +++-----------
> drivers/scsi/ufs/ufshcd.c | 28 ++++++++++++++++++++--------
> 3 files changed, 23 insertions(+), 20 deletions(-)
>
> --
> 2.18.0
>
Hi Alim, On Wed, 2019-03-27 at 22:48 +0530, Alim Akhtar wrote: > Hi Stanley, > Please collect all the {review/acked}-by tags when reposting so that > people are aware which all patches need to review. > https://www.spinics.net/lists/linux-scsi/msg128818.html Sorry it's my mistake to miss some tags in reposted patch. Will fix it in next version. > This series looks good, it will be if we get a Tested-by as well. > For this series > Acked-by: Alim Akhtar <alim.akhtar@samsung.com> Thanks so much for review. > > On Wed, Mar 27, 2019 at 3:29 PM Stanley Chu <stanley.chu@mediatek.com> wrote: > > > > Hi, > > > > Resend this patch series for review. > > > > This version (v3) fixed and added more details in commit messages, and added one patch to fix "undefined voltage range" issue as well. > > > > This patch series fixes UFS regulator operations, including voltage and current (re-)configuration flow during UFS initialization and power mode switching. > > > > In the end, remove "<name>-fixed-regulator" device tree property because it is not necessary anymore after these fixes. > > > > V3: > > - Fix and add more details in commit messages. > > - Add one patch "scsi: ufs: Avoid configuring undefined voltage range on a regulator". > > > > V2: > > - Add two patches to prepare to and remove "<name>-fixed-regulator" device tree property. > > - Add more details on patch "scsi: ufs: remove unused min_uA field in struct ufs_vreg" (Marc Gonzalez). > > > > Stanley Chu (5): > > scsi: ufs: Remove unused min_uA field in struct ufs_vreg > > scsi: ufs: Avoid configuring regulator with undefined voltage range > > scsi: ufs: Fix regulator load and icc-level configuration > > scsi: ufs: Change "<name>-max-microamp" to non-mandatory property > > scsi: ufs: Remove "<name>-fixed-regulator" device tree property > > > > drivers/scsi/ufs/ufs.h | 1 - > > drivers/scsi/ufs/ufshcd-pltfrm.c | 14 +++----------- > > drivers/scsi/ufs/ufshcd.c | 28 ++++++++++++++++++++-------- > > 3 files changed, 23 insertions(+), 20 deletions(-) > > > > -- > > 2.18.0 > > > > Thanks, Stanley