| Message ID | 20190321231037.25104-3-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/15] block: add a req_bvec helper | expand |
On 3/21/19 4:11 PM, Christoph Hellwig wrote: > This provides a nice little shortcut to get the integrity data for > drivers like NVMe that only support a single integrity segment. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > include/linux/blkdev.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 255e20313cde..f9a072610d28 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -1552,6 +1552,16 @@ static inline unsigned int bio_integrity_bytes(struct blk_integrity *bi, > return bio_integrity_intervals(bi, sectors) * bi->tuple_size; > } > > +/* > + * Return the first bvec that contains integrity data. In general only > + * drivers that are limited to a single integrity segment should use this > + * helper. > + */ > +static inline struct bio_vec *rq_integrity_vec(struct request *rq) > +{ Wrt comment, should we add a check here to make sure underlaying driver has limited single integrity segment ? > + return rq->bio->bi_integrity->bip_vec; > +} > + > #else /* CONFIG_BLK_DEV_INTEGRITY */ > > struct bio; > @@ -1626,6 +1636,11 @@ static inline unsigned int bio_integrity_bytes(struct blk_integrity *bi, > return 0; > } > > +static inline struct bio_vec *rq_integrity_vec(struct request *rq) > +{ > + return NULL; > +} > + > #endif /* CONFIG_BLK_DEV_INTEGRITY */ > > struct block_device_operations { > Otherwise looks good. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On Mon, Mar 25, 2019 at 05:10:20AM +0000, Chaitanya Kulkarni wrote: > > +/* > > + * Return the first bvec that contains integrity data. In general only > > + * drivers that are limited to a single integrity segment should use this > > + * helper. > > + */ > > +static inline struct bio_vec *rq_integrity_vec(struct request *rq) > > +{ > Wrt comment, should we add a check here to make sure underlaying driver > has limited single integrity segment ? I've added a WARN_ON_ONCE.
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 255e20313cde..f9a072610d28 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -1552,6 +1552,16 @@ static inline unsigned int bio_integrity_bytes(struct blk_integrity *bi, return bio_integrity_intervals(bi, sectors) * bi->tuple_size; } +/* + * Return the first bvec that contains integrity data. In general only + * drivers that are limited to a single integrity segment should use this + * helper. + */ +static inline struct bio_vec *rq_integrity_vec(struct request *rq) +{ + return rq->bio->bi_integrity->bip_vec; +} + #else /* CONFIG_BLK_DEV_INTEGRITY */ struct bio; @@ -1626,6 +1636,11 @@ static inline unsigned int bio_integrity_bytes(struct blk_integrity *bi, return 0; } +static inline struct bio_vec *rq_integrity_vec(struct request *rq) +{ + return NULL; +} + #endif /* CONFIG_BLK_DEV_INTEGRITY */ struct block_device_operations {
This provides a nice little shortcut to get the integrity data for drivers like NVMe that only support a single integrity segment. Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/linux/blkdev.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+)