| Message ID | 20190319214123.27219-2-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | clk: meson8b: remove CLKID with typo ("ABP" -> "APB") | expand |
On 19/03/2019 22:41, Martin Blumenstingl wrote: > Commit 8e1dd17c8b0e3f ("dt-bindings: clock: meson8b: export the CPU post > dividers") added a new clock ID "CLKID_ABP" which contains a typo. This > was fixed by adding a new (typo-free) #define CLKID_APB in > commit 40d08f774c17ad ("dt-bindings: clock: meson8b: add APB clock > definition"). > Now that the new #define is used by the driver we can remove the old > one (because the old one is not used anywhere). > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > include/dt-bindings/clock/meson8b-clkc.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/dt-bindings/clock/meson8b-clkc.h b/include/dt-bindings/clock/meson8b-clkc.h > index 8067077a62ca..cd11628f50f8 100644 > --- a/include/dt-bindings/clock/meson8b-clkc.h > +++ b/include/dt-bindings/clock/meson8b-clkc.h > @@ -103,7 +103,6 @@ > #define CLKID_MPLL1 94 > #define CLKID_MPLL2 95 > #define CLKID_NAND_CLK 112 > -#define CLKID_ABP 124 > #define CLKID_APB 124 > #define CLKID_PERIPH 126 > #define CLKID_AXI 128 > Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes: > On 19/03/2019 22:41, Martin Blumenstingl wrote: >> Commit 8e1dd17c8b0e3f ("dt-bindings: clock: meson8b: export the CPU post >> dividers") added a new clock ID "CLKID_ABP" which contains a typo. This >> was fixed by adding a new (typo-free) #define CLKID_APB in >> commit 40d08f774c17ad ("dt-bindings: clock: meson8b: add APB clock >> definition"). >> Now that the new #define is used by the driver we can remove the old >> one (because the old one is not used anywhere). >> >> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >> --- >> include/dt-bindings/clock/meson8b-clkc.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/include/dt-bindings/clock/meson8b-clkc.h b/include/dt-bindings/clock/meson8b-clkc.h >> index 8067077a62ca..cd11628f50f8 100644 >> --- a/include/dt-bindings/clock/meson8b-clkc.h >> +++ b/include/dt-bindings/clock/meson8b-clkc.h >> @@ -103,7 +103,6 @@ >> #define CLKID_MPLL1 94 >> #define CLKID_MPLL2 95 >> #define CLKID_NAND_CLK 112 >> -#define CLKID_ABP 124 >> #define CLKID_APB 124 >> #define CLKID_PERIPH 126 >> #define CLKID_AXI 128 >> > > Acked-by: Neil Armstrong <narmstrong@baylibre.com> Neil / Jerome, I'm assuming you will queue this via the clk-meson tree? Kevin
Le 23/03/2019 00:53, Kevin Hilman a écrit : > Neil Armstrong <narmstrong@baylibre.com> writes: > >> On 19/03/2019 22:41, Martin Blumenstingl wrote: >>> Commit 8e1dd17c8b0e3f ("dt-bindings: clock: meson8b: export the CPU post >>> dividers") added a new clock ID "CLKID_ABP" which contains a typo. This >>> was fixed by adding a new (typo-free) #define CLKID_APB in >>> commit 40d08f774c17ad ("dt-bindings: clock: meson8b: add APB clock >>> definition"). >>> Now that the new #define is used by the driver we can remove the old >>> one (because the old one is not used anywhere). >>> >>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >>> --- >>> include/dt-bindings/clock/meson8b-clkc.h | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/include/dt-bindings/clock/meson8b-clkc.h b/include/dt-bindings/clock/meson8b-clkc.h >>> index 8067077a62ca..cd11628f50f8 100644 >>> --- a/include/dt-bindings/clock/meson8b-clkc.h >>> +++ b/include/dt-bindings/clock/meson8b-clkc.h >>> @@ -103,7 +103,6 @@ >>> #define CLKID_MPLL1 94 >>> #define CLKID_MPLL2 95 >>> #define CLKID_NAND_CLK 112 >>> -#define CLKID_ABP 124 >>> #define CLKID_APB 124 >>> #define CLKID_PERIPH 126 >>> #define CLKID_AXI 128 >>> >> >> Acked-by: Neil Armstrong <narmstrong@baylibre.com> > > Neil / Jerome, I'm assuming you will queue this via the clk-meson tree? Yes, Neil > > Kevin >
On Tue, 19 Mar 2019 22:41:23 +0100, Martin Blumenstingl wrote: > Commit 8e1dd17c8b0e3f ("dt-bindings: clock: meson8b: export the CPU post > dividers") added a new clock ID "CLKID_ABP" which contains a typo. This > was fixed by adding a new (typo-free) #define CLKID_APB in > commit 40d08f774c17ad ("dt-bindings: clock: meson8b: add APB clock > definition"). > Now that the new #define is used by the driver we can remove the old > one (because the old one is not used anywhere). > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > include/dt-bindings/clock/meson8b-clkc.h | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/include/dt-bindings/clock/meson8b-clkc.h b/include/dt-bindings/clock/meson8b-clkc.h index 8067077a62ca..cd11628f50f8 100644 --- a/include/dt-bindings/clock/meson8b-clkc.h +++ b/include/dt-bindings/clock/meson8b-clkc.h @@ -103,7 +103,6 @@ #define CLKID_MPLL1 94 #define CLKID_MPLL2 95 #define CLKID_NAND_CLK 112 -#define CLKID_ABP 124 #define CLKID_APB 124 #define CLKID_PERIPH 126 #define CLKID_AXI 128
Commit 8e1dd17c8b0e3f ("dt-bindings: clock: meson8b: export the CPU post dividers") added a new clock ID "CLKID_ABP" which contains a typo. This was fixed by adding a new (typo-free) #define CLKID_APB in commit 40d08f774c17ad ("dt-bindings: clock: meson8b: add APB clock definition"). Now that the new #define is used by the driver we can remove the old one (because the old one is not used anywhere). Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- include/dt-bindings/clock/meson8b-clkc.h | 1 - 1 file changed, 1 deletion(-)