| Message ID | 1554035655-11352-3-git-send-email-hhhawa@amazon.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | al-msi: Rename driver and add support for ACPI | expand |
On 3/31/2019 6:04 PM, Hanna Hawa wrote: > Update driver license to be in-line with Linux conventions. > > Signed-off-by: Hanna Hawa <hhhawa@amazon.com> > --- > drivers/irqchip/irq-alpine-msi.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c > index ae2fca7..ec6a606 100644 > --- a/drivers/irqchip/irq-alpine-msi.c > +++ b/drivers/irqchip/irq-alpine-msi.c > @@ -1,13 +1,10 @@ > +// SPDX-License-Identifier: GPL-2.0 Please fix this as per. https://lkml.org/lkml/2019/2/13/570 cheers, Mukesh > /* > * Annapurna Labs MSIX support services > * > * Copyright (C) 2016, Amazon.com, Inc. or its affiliates. All Rights Reserved. > * > * Antoine Tenart <antoine.tenart@free-electrons.com> > - * > - * This file is licensed under the terms of the GNU General Public > - * License version 2. This program is licensed "as is" without any > - * warranty of any kind, whether express or implied. > */ > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
On 3/31/2019 3:46 PM, Mukesh Ojha wrote: > > On 3/31/2019 6:04 PM, Hanna Hawa wrote: >> Update driver license to be in-line with Linux conventions. >> >> Signed-off-by: Hanna Hawa <hhhawa@amazon.com> > >> --- >> drivers/irqchip/irq-alpine-msi.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/drivers/irqchip/irq-alpine-msi.c >> b/drivers/irqchip/irq-alpine-msi.c >> index ae2fca7..ec6a606 100644 >> --- a/drivers/irqchip/irq-alpine-msi.c >> +++ b/drivers/irqchip/irq-alpine-msi.c >> @@ -1,13 +1,10 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > > Please fix this as per. > https://lkml.org/lkml/2019/2/13/570 > I'll fix in next patch-set, I'll wait for more inputs on other patches in the series. Thanks, Hanna > > cheers, > Mukesh > >> /* >> * Annapurna Labs MSIX support services >> * >> * Copyright (C) 2016, Amazon.com, Inc. or its affiliates. All >> Rights Reserved. >> * >> * Antoine Tenart <antoine.tenart@free-electrons.com> >> - * >> - * This file is licensed under the terms of the GNU General Public >> - * License version 2. This program is licensed "as is" without any >> - * warranty of any kind, whether express or implied. >> */ >> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
On Sun, 2019-03-31 at 18:16 +0530, Mukesh Ojha wrote: > On 3/31/2019 6:04 PM, Hanna Hawa wrote: > > Update driver license to be in-line with Linux conventions. > > > > Signed-off-by: Hanna Hawa <hhhawa@amazon.com> > > --- > > drivers/irqchip/irq-alpine-msi.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/drivers/irqchip/irq-alpine-msi.c > > b/drivers/irqchip/irq-alpine-msi.c > > index ae2fca7..ec6a606 100644 > > --- a/drivers/irqchip/irq-alpine-msi.c > > +++ b/drivers/irqchip/irq-alpine-msi.c > > @@ -1,13 +1,10 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > > Please fix this as per. > https://lkml.org/lkml/2019/2/13/570 I find myself struggling to care. And that was even before I spotted: $ grep -A6 "Style" Documentation/process/license-rules.rst 2. Style: The SPDX license identifier is added in form of a comment. The comment style depends on the file type:: C source: // SPDX-License-Identifier: <SPDX License Expression> C header: /* SPDX-License-Identifier: <SPDX License Expression> */
diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c index ae2fca7..ec6a606 100644 --- a/drivers/irqchip/irq-alpine-msi.c +++ b/drivers/irqchip/irq-alpine-msi.c @@ -1,13 +1,10 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Annapurna Labs MSIX support services * * Copyright (C) 2016, Amazon.com, Inc. or its affiliates. All Rights Reserved. * * Antoine Tenart <antoine.tenart@free-electrons.com> - * - * This file is licensed under the terms of the GNU General Public - * License version 2. This program is licensed "as is" without any - * warranty of any kind, whether express or implied. */ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Update driver license to be in-line with Linux conventions. Signed-off-by: Hanna Hawa <hhhawa@amazon.com> --- drivers/irqchip/irq-alpine-msi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)