| Message ID | 20190327001843.2420-3-megous@megous.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add bluetooth, gps and accelerometer to TBS A711 | expand |
Hi, On Wed, Mar 27, 2019 at 01:18:38AM +0100, megous@megous.com wrote: > From: Ondrej Jirman <megous@megous.com> > > A711 tablet has BMA250 accelerometer connected to I2C1 bus. Enable > both the I2C1 bus and add the accelerometer device to it. > > Signed-off-by: Ondrej Jirman <megous@megous.com> > --- > arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > index 6aae70c89a1e..347fc0c31fa4 100644 > --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > @@ -156,6 +156,21 @@ > status = "okay"; > }; > > +&i2c1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; It's there already > + clock-frequency = <400000>; > + status = "okay"; > + > + /* Accelerometer */ > + bma250@18 { The node name should be the class of the device, not its model, so something like accelerometer. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Hello Maxime, On Mon, Apr 01, 2019 at 08:30:49AM +0200, Maxime Ripard wrote: > Hi, > > On Wed, Mar 27, 2019 at 01:18:38AM +0100, megous@megous.com wrote: > > From: Ondrej Jirman <megous@megous.com> > > > > A711 tablet has BMA250 accelerometer connected to I2C1 bus. Enable > > both the I2C1 bus and add the accelerometer device to it. > > > > Signed-off-by: Ondrej Jirman <megous@megous.com> > > --- > > arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > > index 6aae70c89a1e..347fc0c31fa4 100644 > > --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > > +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > > @@ -156,6 +156,21 @@ > > status = "okay"; > > }; > > > > +&i2c1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&i2c1_pins>; > > It's there already I see, I'll drop it. Thanks. > > + clock-frequency = <400000>; > > + status = "okay"; > > + > > + /* Accelerometer */ > > + bma250@18 { > > The node name should be the class of the device, not its model, so > something like accelerometer. I'll rename this. thank you, Ondrej > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts index 6aae70c89a1e..347fc0c31fa4 100644 --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts @@ -156,6 +156,21 @@ status = "okay"; }; +&i2c1 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c1_pins>; + clock-frequency = <400000>; + status = "okay"; + + /* Accelerometer */ + bma250@18 { + compatible = "bosch,bma250"; + reg = <0x18>; + interrupt-parent = <&pio>; + interrupts = <7 10 IRQ_TYPE_EDGE_RISING>; /* PH10 / EINT10 */ + }; +}; + &mmc0 { vmmc-supply = <®_dcdc1>; pinctrl-names = "default";