[v1,0/2] minor asciidoc/tor formatting fixes

Message

Todd Zullinger March 30, 2019, 6:29 p.m. UTC

Just chipping away at the remaining differences between asciidoc and
asciidoctor.

Todd Zullinger (2):
  Documentation/rev-list-options: wrap --date=<format> block with "--"
  Documentation/git-status: fix titles in porcelain v2 section

 Documentation/git-status.txt       | 12 ++++++++----
 Documentation/rev-list-options.txt | 22 +++++++++++-----------
 2 files changed, 19 insertions(+), 15 deletions(-)

Comments

Martin Ågren April 3, 2019, 9:26 a.m. UTC | #1

On Sat, 30 Mar 2019 at 19:30, Todd Zullinger <[e-mail]> wrote:
>
> Just chipping away at the remaining differences between asciidoc and
> asciidoctor.
>
> Todd Zullinger (2):
>   Documentation/rev-list-options: wrap --date=<format> block with "--"
>   Documentation/git-status: fix titles in porcelain v2 section

Nice. I've tested and diffed across various dimensions. Looks good to me.

Martin

Todd Zullinger April 5, 2019, 1:40 a.m. UTC | #2

Hi,

Martin Ågren wrote:
> On Sat, 30 Mar 2019 at 19:30, Todd Zullinger <[e-mail]> wrote:
>>
>> Just chipping away at the remaining differences between asciidoc and
>> asciidoctor.
>>
>> Todd Zullinger (2):
>>   Documentation/rev-list-options: wrap --date=<format> block with "--"
>>   Documentation/git-status: fix titles in porcelain v2 section
> 
> Nice. I've tested and diffed across various dimensions. Looks good to me.

Thanks for testing!  On pu we're down to a fairly small
amount of differences now.  Most of what remains are
whitespace changes; some of which I would like to bring up
to the Asciidoctor team to see if they're intentional.

There are two other changes I've got queued locally.  One in
git-show-branch.txt removes the last use of {apostrophe}.
Another in git-svn.txt is a bit of a work-around for a
difference in the way asciidoc and asciidoctor parse the
second paragraph in the CONFIGURATION section.  That may
well be an asiidoctor bug, but it seems like one we can
adjust for without much effort.

Martin Ågren April 5, 2019, 10:23 a.m. UTC | #3

Hi Todd,

On Fri, 5 Apr 2019 at 03:40, Todd Zullinger <[e-mail]> wrote:

> > On Sat, 30 Mar 2019 at 19:30, Todd Zullinger <[e-mail]> wrote:
> >>
> >> Just chipping away at the remaining differences between asciidoc and
> >> asciidoctor.
> >>
> >> Todd Zullinger (2):
> >>   Documentation/rev-list-options: wrap --date=<format> block with "--"
> >>   Documentation/git-status: fix titles in porcelain v2 section

> There are two other changes I've got queued locally.  One in
> git-show-branch.txt removes the last use of {apostrophe}.
> Another in git-svn.txt is a bit of a work-around for a
> difference in the way asciidoc and asciidoctor parse the
> second paragraph in the CONFIGURATION section.  That may
> well be an asiidoctor bug, but it seems like one we can
> adjust for without much effort.

The second one looks like it can be fixed by using `*` instead of '\*',
which I think is more correct anyway. I don't know what your local
workaround looks like, but I think a patch like "use backticks
consistently" (both change to them, in a number of places, and add them,
where we currently have nothing) would be a good change by itself, and
we could note that "BTW, this fixes ...". How does that compare to what
you have?

Martin