[0/2] tests: fw_cfg: add reboot-timeout test case

Message

Li Qiang March 19, 2019, 2:30 a.m. UTC

The first patch adds a util function to get the fw_cfg file entry.
And second adds the reboot-timeout test case.

Li Qiang (2):
  tests: fw_cfg: add a function to get the fw_cfg file
  tests: fw_cfg: add reboot_timeout test case

 tests/fw_cfg-test.c   | 15 ++++++++++++++-
 tests/libqos/fw_cfg.c | 45 +++++++++++++++++++++++++++++++++++++++++++
 tests/libqos/fw_cfg.h |  2 ++
 3 files changed, 61 insertions(+), 1 deletion(-)

Comments

Laszlo Ersek March 20, 2019, 4:37 p.m. UTC | #1

Hi,

On 03/19/19 03:30, Li Qiang wrote:
> The first patch adds a util function to get the fw_cfg file entry.
> And second adds the reboot-timeout test case.
> 
> Li Qiang (2):
>   tests: fw_cfg: add a function to get the fw_cfg file
>   tests: fw_cfg: add reboot_timeout test case
> 
>  tests/fw_cfg-test.c   | 15 ++++++++++++++-
>  tests/libqos/fw_cfg.c | 45 +++++++++++++++++++++++++++++++++++++++++++
>  tests/libqos/fw_cfg.h |  2 ++
>  3 files changed, 61 insertions(+), 1 deletion(-)
> 

I signed up to co-review fw_cfg patches in order to review Phil's
patches [1], and maybe to prevent edk2 regressions; so on these
particular patches, I'll defer to Phil. I've been fighting email
bankruptcy for weeks now, sorry.

[1] msgid <[e-mail]>

Thanks
Laszlo

Philippe Mathieu-Daudé April 5, 2019, 3:47 p.m. UTC | #2

On 3/28/19 11:45 AM, 李强 wrote:
> Ping...
> 
> What's your opinion, Philippe?

Eh sorry my email client tagged this series as reviewed since your
previous v1 was reviewed by Laszlo. I'll review your patches, but please
increase the version between series next time so I won't miss it that
easily ;)

> 
> Thanks,
> Li Qiang