| Message ID | 20190405205736.55177-3-icenowy@aosc.io (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Allwinner H6 USB3 support | expand |
On Sat, Apr 06, 2019 at 04:57:33AM +0800, Icenowy Zheng wrote: > The new Allwinner H6 SoC contains a USB3 PHY that is wired to the > external USB3 pins of the SoC. > > Add a device tree binding for the PHY. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > --- > Changes in v5: > - Dropped Vbus regulator and added connector subnode. > > Changes in v4: > - Changed Vbus regulator property to vbus-supply. > > Changes in v3: > - Added Chen-Yu's Review tag. > > No changes in v2, v1. > > .../bindings/phy/sun50i-usb3-phy.txt | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt > > diff --git a/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt b/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt > new file mode 100644 > index 000000000000..eeedc53e6360 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt > @@ -0,0 +1,28 @@ > +Allwinner sun50i USB3 PHY > +----------------------- > + > +Required properties: > +- compatible : should be one of > + * allwinner,sun60i-h6-usb3-phy > +- reg : a list of offset + length pairs > +- #phy-cells : from the generic phy bindings, must be 0 > +- clocks : phandle + clock specifier for the phy clock > +- resets : phandle + reset specifier for the phy reset > + > +Optional nodes: > +- connector : A sub-node required for representing the connector connected > + to the USB PHY. See ../connector/usb-connector.txt for details. > + > +Example: > + usb3phy: phy@5210000 { > + compatible = "allwinner,sun50i-h6-usb3-phy"; > + reg = <0x5210000 0x10000>; > + clocks = <&ccu CLK_USB_PHY1>; > + resets = <&ccu RST_USB_PHY1>; > + #phy-cells = <0>; > + > + connector { > + compatible = "usb-a-connector"; > + label = "USB3"; The binding defines that a connector is a child of USB controller or some port controller (such as USB-C ctrlr) with OF graph to USB controller. So either way, this is wrong unless this is more than just a phy. Rob
于 2019年4月6日 GMT+08:00 下午3:14:02, Rob Herring <robh@kernel.org> 写到: >On Sat, Apr 06, 2019 at 04:57:33AM +0800, Icenowy Zheng wrote: >> The new Allwinner H6 SoC contains a USB3 PHY that is wired to the >> external USB3 pins of the SoC. >> >> Add a device tree binding for the PHY. >> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> >> Reviewed-by: Chen-Yu Tsai <wens@csie.org> >> --- >> Changes in v5: >> - Dropped Vbus regulator and added connector subnode. >> >> Changes in v4: >> - Changed Vbus regulator property to vbus-supply. >> >> Changes in v3: >> - Added Chen-Yu's Review tag. >> >> No changes in v2, v1. >> >> .../bindings/phy/sun50i-usb3-phy.txt | 28 >+++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 >Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt >> >> diff --git >a/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt >b/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt >> new file mode 100644 >> index 000000000000..eeedc53e6360 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt >> @@ -0,0 +1,28 @@ >> +Allwinner sun50i USB3 PHY >> +----------------------- >> + >> +Required properties: >> +- compatible : should be one of >> + * allwinner,sun60i-h6-usb3-phy >> +- reg : a list of offset + length pairs >> +- #phy-cells : from the generic phy bindings, must be 0 >> +- clocks : phandle + clock specifier for the phy clock >> +- resets : phandle + reset specifier for the phy reset >> + >> +Optional nodes: >> +- connector : A sub-node required for representing the connector >connected >> + to the USB PHY. See ../connector/usb-connector.txt for >details. >> + >> +Example: >> + usb3phy: phy@5210000 { >> + compatible = "allwinner,sun50i-h6-usb3-phy"; >> + reg = <0x5210000 0x10000>; >> + clocks = <&ccu CLK_USB_PHY1>; >> + resets = <&ccu RST_USB_PHY1>; >> + #phy-cells = <0>; >> + >> + connector { >> + compatible = "usb-a-connector"; >> + label = "USB3"; > >The binding defines that a connector is a child of USB controller or Please note that the word used is not "USB controller", but "USB interface controller". A USB controller is something that deal with USB protocol, and connect to a USB PHY with ULPI/UTMI/PIPE interface. It's not connected to the connector directly at all. Then the PHY is connected to the interface controller (if present), or the connector, with D+, D- and SS pins. >some port controller (such as USB-C ctrlr) with OF graph to USB >controller. So either way, this is wrong unless this is more than just >a >phy. > >Rob > >_______________________________________________ >linux-arm-kernel mailing list >linux-arm-kernel@lists.infradead.org >http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi, On Sat, Apr 06, 2019 at 04:57:33AM +0800, Icenowy Zheng wrote: > The new Allwinner H6 SoC contains a USB3 PHY that is wired to the > external USB3 pins of the SoC. > > Add a device tree binding for the PHY. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > Reviewed-by: Chen-Yu Tsai <wens@csie.org> I know that this isn't the first iteration, and sorry if this comes out a bit late, but could you make a YAML schemas for this instead? Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On Sat, Apr 6, 2019 at 2:24 AM Icenowy Zheng <icenowy@aosc.io> wrote: > > > > 于 2019年4月6日 GMT+08:00 下午3:14:02, Rob Herring <robh@kernel.org> 写到: > >On Sat, Apr 06, 2019 at 04:57:33AM +0800, Icenowy Zheng wrote: > >> The new Allwinner H6 SoC contains a USB3 PHY that is wired to the > >> external USB3 pins of the SoC. > >> > >> Add a device tree binding for the PHY. > >> > >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > >> Reviewed-by: Chen-Yu Tsai <wens@csie.org> > >> --- > >> Changes in v5: > >> - Dropped Vbus regulator and added connector subnode. > >> > >> Changes in v4: > >> - Changed Vbus regulator property to vbus-supply. > >> > >> Changes in v3: > >> - Added Chen-Yu's Review tag. > >> > >> No changes in v2, v1. > >> > >> .../bindings/phy/sun50i-usb3-phy.txt | 28 > >+++++++++++++++++++ > >> 1 file changed, 28 insertions(+) > >> create mode 100644 > >Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt > >> > >> diff --git > >a/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt > >b/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt > >> new file mode 100644 > >> index 000000000000..eeedc53e6360 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt > >> @@ -0,0 +1,28 @@ > >> +Allwinner sun50i USB3 PHY > >> +----------------------- > >> + > >> +Required properties: > >> +- compatible : should be one of > >> + * allwinner,sun60i-h6-usb3-phy > >> +- reg : a list of offset + length pairs > >> +- #phy-cells : from the generic phy bindings, must be 0 > >> +- clocks : phandle + clock specifier for the phy clock > >> +- resets : phandle + reset specifier for the phy reset > >> + > >> +Optional nodes: > >> +- connector : A sub-node required for representing the connector > >connected > >> + to the USB PHY. See ../connector/usb-connector.txt for > >details. > >> + > >> +Example: > >> + usb3phy: phy@5210000 { > >> + compatible = "allwinner,sun50i-h6-usb3-phy"; > >> + reg = <0x5210000 0x10000>; > >> + clocks = <&ccu CLK_USB_PHY1>; > >> + resets = <&ccu RST_USB_PHY1>; > >> + #phy-cells = <0>; > >> + > >> + connector { > >> + compatible = "usb-a-connector"; > >> + label = "USB3"; > > > >The binding defines that a connector is a child of USB controller or > > Please note that the word used is not "USB controller", but "USB interface > controller". Same thing. We do not represent PHYs as part of the hierarchy. The controller just points to its PHY with the 'phys' property, but is not part of the graph. Unless your PHY handle USB-C functions like PD and alternate modes, then it shouldn't be part of the graph. > A USB controller is something that deal with USB protocol, and connect to a USB > PHY with ULPI/UTMI/PIPE interface. It's not connected to the connector > directly at all. Then the PHY is connected to the interface controller (if present), or > the connector, with D+, D- and SS pins. > > >some port controller (such as USB-C ctrlr) with OF graph to USB > >controller. So either way, this is wrong unless this is more than just > >a > >phy. > > > >Rob > > > >_______________________________________________ > >linux-arm-kernel mailing list > >linux-arm-kernel@lists.infradead.org > >http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > -- > 使用 K-9 Mail 发送自我的Android设备。
diff --git a/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt b/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt new file mode 100644 index 000000000000..eeedc53e6360 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt @@ -0,0 +1,28 @@ +Allwinner sun50i USB3 PHY +----------------------- + +Required properties: +- compatible : should be one of + * allwinner,sun60i-h6-usb3-phy +- reg : a list of offset + length pairs +- #phy-cells : from the generic phy bindings, must be 0 +- clocks : phandle + clock specifier for the phy clock +- resets : phandle + reset specifier for the phy reset + +Optional nodes: +- connector : A sub-node required for representing the connector connected + to the USB PHY. See ../connector/usb-connector.txt for details. + +Example: + usb3phy: phy@5210000 { + compatible = "allwinner,sun50i-h6-usb3-phy"; + reg = <0x5210000 0x10000>; + clocks = <&ccu CLK_USB_PHY1>; + resets = <&ccu RST_USB_PHY1>; + #phy-cells = <0>; + + connector { + compatible = "usb-a-connector"; + label = "USB3"; + }; + };