diff mbox series

[1/2] drm/lima: add missing Kconfig dependency

Message ID 20190409003617.4470-1-yuq825@gmail.com (mailing list archive)
State New, archived
Headers show
Series [1/2] drm/lima: add missing Kconfig dependency | expand

Commit Message

Qiang Yu April 9, 2019, 12:36 a.m. UTC 
Current implementation does not support MMU-less
plarforms.

Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Fixes: a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")
Signed-off-by: Qiang Yu <yuq825@gmail.com>
---
 drivers/gpu/drm/lima/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Neil Armstrong April 9, 2019, 7:22 a.m. UTC | #1 
On 09/04/2019 02:36, Qiang Yu wrote:
> Current implementation does not support MMU-less
> plarforms.
> 
> Cc: Randy Dunlap <rdunlap@infradead.org>

You could also add :
Suggested-by: Randy Dunlap <rdunlap@infradead.org>
Like patch 2.

But you can fix it while applying it

> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Fixes: a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")
> Signed-off-by: Qiang Yu <yuq825@gmail.com>
> ---
>  drivers/gpu/drm/lima/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/lima/Kconfig b/drivers/gpu/drm/lima/Kconfig
> index f11314448093..bb4ddc6bb0a6 100644
> --- a/drivers/gpu/drm/lima/Kconfig
> +++ b/drivers/gpu/drm/lima/Kconfig
> @@ -5,6 +5,9 @@ config DRM_LIMA
>         tristate "LIMA (DRM support for ARM Mali 400/450 GPU)"
>         depends on DRM
>         depends on ARM || ARM64 || COMPILE_TEST
> +       depends on MMU
> +       depends on COMMON_CLK
> +       depends on OF
>         select DRM_SCHED
>         help
>           DRM driver for ARM Mali 400/450 GPUs.
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Qiang Yu April 9, 2019, 11:11 a.m. UTC | #2 
Modify comments and pushed to drm-misc-next.

Thanks,
Qiang

On Tue, Apr 9, 2019 at 8:36 AM Qiang Yu <yuq825@gmail.com> wrote:
>
> Current implementation does not support MMU-less
> plarforms.
>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Fixes: a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")
> Signed-off-by: Qiang Yu <yuq825@gmail.com>
> ---
>  drivers/gpu/drm/lima/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/lima/Kconfig b/drivers/gpu/drm/lima/Kconfig
> index f11314448093..bb4ddc6bb0a6 100644
> --- a/drivers/gpu/drm/lima/Kconfig
> +++ b/drivers/gpu/drm/lima/Kconfig
> @@ -5,6 +5,9 @@ config DRM_LIMA
>         tristate "LIMA (DRM support for ARM Mali 400/450 GPU)"
>         depends on DRM
>         depends on ARM || ARM64 || COMPILE_TEST
> +       depends on MMU
> +       depends on COMMON_CLK
> +       depends on OF
>         select DRM_SCHED
>         help
>           DRM driver for ARM Mali 400/450 GPUs.
> --
> 2.17.1
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/lima/Kconfig b/drivers/gpu/drm/lima/Kconfig
index f11314448093..bb4ddc6bb0a6 100644
--- a/drivers/gpu/drm/lima/Kconfig
+++ b/drivers/gpu/drm/lima/Kconfig
@@ -5,6 +5,9 @@  config DRM_LIMA
        tristate "LIMA (DRM support for ARM Mali 400/450 GPU)"
        depends on DRM
        depends on ARM || ARM64 || COMPILE_TEST
+       depends on MMU
+       depends on COMMON_CLK
+       depends on OF
        select DRM_SCHED
        help
          DRM driver for ARM Mali 400/450 GPUs.