| Message ID | 20190410140949.26716-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 8990e381d1888f82ca65a31469f2327cf1f56d52 |
| Headers | show |
| Series | [-next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static | expand |
On Wed, 10 Apr 2019 22:09:49 +0800 Yue Haibing <yuehaibing@huawei.com> wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fix sparse warning: > > drivers/pci/controller/pci-mvebu.c:557:28: warning: > symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Thomas
On Wed, Apr 10, 2019 at 10:09:49PM +0800, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fix sparse warning: > > drivers/pci/controller/pci-mvebu.c:557:28: warning: > symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> Is Mr.Robot reachable by email ? If it is a CI bot I doubt it is useful to leave this tag there unless you want it for accounting purposes, just let me know. Thanks, Lorenzo > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/pci/controller/pci-mvebu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c > index d3a0419..ed032e9 100644 > --- a/drivers/pci/controller/pci-mvebu.c > +++ b/drivers/pci/controller/pci-mvebu.c > @@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge, > } > } > > -struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = { > +static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = { > .write_base = mvebu_pci_bridge_emul_base_conf_write, > .read_pcie = mvebu_pci_bridge_emul_pcie_conf_read, > .write_pcie = mvebu_pci_bridge_emul_pcie_conf_write, > -- > 2.7.4 > >
On 2019/4/15 21:00, Lorenzo Pieralisi wrote: > On Wed, Apr 10, 2019 at 10:09:49PM +0800, Yue Haibing wrote: >> From: YueHaibing <yuehaibing@huawei.com> >> >> Fix sparse warning: >> >> drivers/pci/controller/pci-mvebu.c:557:28: warning: >> symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static? >> >> Reported-by: Hulk Robot <hulkci@huawei.com> > > Is Mr.Robot reachable by email ? > > If it is a CI bot I doubt it is useful to leave this tag there unless > you want it for accounting purposes, just let me know. Yes, it is our CI bot. > > Thanks, > Lorenzo > >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> drivers/pci/controller/pci-mvebu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c >> index d3a0419..ed032e9 100644 >> --- a/drivers/pci/controller/pci-mvebu.c >> +++ b/drivers/pci/controller/pci-mvebu.c >> @@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge, >> } >> } >> >> -struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = { >> +static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = { >> .write_base = mvebu_pci_bridge_emul_base_conf_write, >> .read_pcie = mvebu_pci_bridge_emul_pcie_conf_read, >> .write_pcie = mvebu_pci_bridge_emul_pcie_conf_write, >> -- >> 2.7.4 >> >> > > . >
On Wed, Apr 10, 2019 at 10:09:49PM +0800, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fix sparse warning: > > drivers/pci/controller/pci-mvebu.c:557:28: warning: > symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/pci/controller/pci-mvebu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to pci/misc, thanks. Lorenzo > diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c > index d3a0419..ed032e9 100644 > --- a/drivers/pci/controller/pci-mvebu.c > +++ b/drivers/pci/controller/pci-mvebu.c > @@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge, > } > } > > -struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = { > +static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = { > .write_base = mvebu_pci_bridge_emul_base_conf_write, > .read_pcie = mvebu_pci_bridge_emul_pcie_conf_read, > .write_pcie = mvebu_pci_bridge_emul_pcie_conf_write, > -- > 2.7.4 > >
diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c index d3a0419..ed032e9 100644 --- a/drivers/pci/controller/pci-mvebu.c +++ b/drivers/pci/controller/pci-mvebu.c @@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge, } } -struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = { +static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = { .write_base = mvebu_pci_bridge_emul_base_conf_write, .read_pcie = mvebu_pci_bridge_emul_pcie_conf_read, .write_pcie = mvebu_pci_bridge_emul_pcie_conf_write,