| Message ID | 20190409132940.477fd7c5@endymion (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Input: olpc_apsp - depend on ARM | expand |
On Tue, 2019-04-09 at 13:29 +0200, Jean Delvare wrote: > The OLPC XO-1.75 and XO-4 are ARM-based laptops, so don't present > this driver on other architectures except for build-testing purposes. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Lubomir Rintel <lkundrak@v3.sk> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > We could even go for a more specific dependency, if anyone knows > which would be appropriate. > > drivers/input/serio/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-5.0.orig/drivers/input/serio/Kconfig 2019-03-04 00:21:29.000000000 +0100 > +++ linux-5.0/drivers/input/serio/Kconfig 2019-04-09 13:20:09.822700623 +0200 > @@ -254,6 +254,7 @@ config SERIO_APBPS2 > > config SERIO_OLPC_APSP > tristate "OLPC AP-SP input support" > + depends on ARM || COMPILE_TEST > help > Say Y here if you want support for the keyboard and touchpad included > in the OLPC XO-1.75 and XO-4 laptops. Looks good. Limit this to ARCH_MMP might make even more sense if you care about uncluttering make config. Either way, Reviewed-by: Lubomir Rintel <lkundrak@v3.sk>
On Wed, 10 Apr 2019 18:13:40 +0200, Lubomir Rintel wrote: > On Tue, 2019-04-09 at 13:29 +0200, Jean Delvare wrote: > > The OLPC XO-1.75 and XO-4 are ARM-based laptops, so don't present > > this driver on other architectures except for build-testing purposes. > > > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > > Cc: Lubomir Rintel <lkundrak@v3.sk> > > Cc: Pavel Machek <pavel@ucw.cz> > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > --- > > We could even go for a more specific dependency, if anyone knows > > which would be appropriate. > > > > drivers/input/serio/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > --- linux-5.0.orig/drivers/input/serio/Kconfig 2019-03-04 00:21:29.000000000 +0100 > > +++ linux-5.0/drivers/input/serio/Kconfig 2019-04-09 13:20:09.822700623 +0200 > > @@ -254,6 +254,7 @@ config SERIO_APBPS2 > > > > config SERIO_OLPC_APSP > > tristate "OLPC AP-SP input support" > > + depends on ARM || COMPILE_TEST > > help > > Say Y here if you want support for the keyboard and touchpad included > > in the OLPC XO-1.75 and XO-4 laptops. > > Looks good. Limit this to ARCH_MMP might make even more sense if you > care about uncluttering make config. Yes, that's pretty much my intention. Does ARCH_MMP cover both the XO-1.75 (Armada 610 / Marvell Sheeva) and XO-4 (Marvell PXA2128)? > Either way, > > Reviewed-by: Lubomir Rintel <lkundrak@v3.sk> Thanks,
On Wed, 2019-04-10 at 19:55 +0200, Jean Delvare wrote: > On Wed, 10 Apr 2019 18:13:40 +0200, Lubomir Rintel wrote: > > On Tue, 2019-04-09 at 13:29 +0200, Jean Delvare wrote: > > > The OLPC XO-1.75 and XO-4 are ARM-based laptops, so don't present > > > this driver on other architectures except for build-testing purposes. > > > > > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > > > Cc: Lubomir Rintel <lkundrak@v3.sk> > > > Cc: Pavel Machek <pavel@ucw.cz> > > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > --- > > > We could even go for a more specific dependency, if anyone knows > > > which would be appropriate. > > > > > > drivers/input/serio/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > --- linux-5.0.orig/drivers/input/serio/Kconfig 2019-03-04 00:21:29.000000000 +0100 > > > +++ linux-5.0/drivers/input/serio/Kconfig 2019-04-09 13:20:09.822700623 +0200 > > > @@ -254,6 +254,7 @@ config SERIO_APBPS2 > > > > > > config SERIO_OLPC_APSP > > > tristate "OLPC AP-SP input support" > > > + depends on ARM || COMPILE_TEST > > > help > > > Say Y here if you want support for the keyboard and touchpad included > > > in the OLPC XO-1.75 and XO-4 laptops. > > > > Looks good. Limit this to ARCH_MMP might make even more sense if you > > care about uncluttering make config. > > Yes, that's pretty much my intention. Does ARCH_MMP cover both the > XO-1.75 (Armada 610 / Marvell Sheeva) and XO-4 (Marvell PXA2128)? There's no PXA2128/MMP3 support in mainline. If it's ever added, I'd guess ARCH_MMP would cover it. It does cover MMP and MMP2, and I think MMP3 is mostly the same, just with an extra PJ4 core and a newer GPU. > > > Either way, > > > > Reviewed-by: Lubomir Rintel <lkundrak@v3.sk> > > Thanks, Lubo
On Thu 2019-04-11 07:04:19, Lubomir Rintel wrote: > On Wed, 2019-04-10 at 19:55 +0200, Jean Delvare wrote: > > On Wed, 10 Apr 2019 18:13:40 +0200, Lubomir Rintel wrote: > > > On Tue, 2019-04-09 at 13:29 +0200, Jean Delvare wrote: > > > > The OLPC XO-1.75 and XO-4 are ARM-based laptops, so don't present > > > > this driver on other architectures except for build-testing purposes. > > > > > > > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > > > > Cc: Lubomir Rintel <lkundrak@v3.sk> > > > > Cc: Pavel Machek <pavel@ucw.cz> > > > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > --- > > > > We could even go for a more specific dependency, if anyone knows > > > > which would be appropriate. > > > > > > > > drivers/input/serio/Kconfig | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > --- linux-5.0.orig/drivers/input/serio/Kconfig 2019-03-04 00:21:29.000000000 +0100 > > > > +++ linux-5.0/drivers/input/serio/Kconfig 2019-04-09 13:20:09.822700623 +0200 > > > > @@ -254,6 +254,7 @@ config SERIO_APBPS2 > > > > > > > > config SERIO_OLPC_APSP > > > > tristate "OLPC AP-SP input support" > > > > + depends on ARM || COMPILE_TEST > > > > help > > > > Say Y here if you want support for the keyboard and touchpad included > > > > in the OLPC XO-1.75 and XO-4 laptops. > > > > > > Looks good. Limit this to ARCH_MMP might make even more sense if you > > > care about uncluttering make config. > > > > Yes, that's pretty much my intention. Does ARCH_MMP cover both the > > XO-1.75 (Armada 610 / Marvell Sheeva) and XO-4 (Marvell PXA2128)? > > There's no PXA2128/MMP3 support in mainline. > > If it's ever added, I'd guess ARCH_MMP would cover it. It does cover > MMP and MMP2, and I think MMP3 is mostly the same, just with an extra > PJ4 core and a newer GPU. I guess depends on ARCH_MMP || COMPILE_TEST would be nicest solution, then. Anyway, this is ok, too. Acked-by: Pavel Machek <pavel@ucw.cz> Pavel
--- linux-5.0.orig/drivers/input/serio/Kconfig 2019-03-04 00:21:29.000000000 +0100 +++ linux-5.0/drivers/input/serio/Kconfig 2019-04-09 13:20:09.822700623 +0200 @@ -254,6 +254,7 @@ config SERIO_APBPS2 config SERIO_OLPC_APSP tristate "OLPC AP-SP input support" + depends on ARM || COMPILE_TEST help Say Y here if you want support for the keyboard and touchpad included in the OLPC XO-1.75 and XO-4 laptops.
The OLPC XO-1.75 and XO-4 are ARM-based laptops, so don't present this driver on other architectures except for build-testing purposes. Signed-off-by: Jean Delvare <jdelvare@suse.de> Cc: Lubomir Rintel <lkundrak@v3.sk> Cc: Pavel Machek <pavel@ucw.cz> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- We could even go for a more specific dependency, if anyone knows which would be appropriate. drivers/input/serio/Kconfig | 1 + 1 file changed, 1 insertion(+)