| Message ID | 20190416032743.180517-1-evgreen@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 41a918026407be4ca2727cd0d6243fe6cdbfc4ed |
| Headers | show |
| Series | spi: pxa2xx: Add support for Intel Comet Lake | expand |
On Tue, Apr 16, 2019 at 6:28 AM Evan Green <evgreen@chromium.org> wrote: > > Add PCI IDs for SPI on Comet Lake. > I didn't check IDs, perhaps Jarkko can do it. From other prospectives looks good. Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Evan Green <evgreen@chromium.org> > > --- > > drivers/spi/spi-pxa2xx.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c > index b6ddba833d021..493223e1d032d 100644 > --- a/drivers/spi/spi-pxa2xx.c > +++ b/drivers/spi/spi-pxa2xx.c > @@ -1451,6 +1451,10 @@ static const struct pci_device_id pxa2xx_spi_pci_compound_match[] = { > { PCI_VDEVICE(INTEL, 0xa32a), LPSS_CNL_SSP }, > { PCI_VDEVICE(INTEL, 0xa32b), LPSS_CNL_SSP }, > { PCI_VDEVICE(INTEL, 0xa37b), LPSS_CNL_SSP }, > + /* CML-LP */ > + { PCI_VDEVICE(INTEL, 0x02aa), LPSS_CNL_SSP }, > + { PCI_VDEVICE(INTEL, 0x02ab), LPSS_CNL_SSP }, > + { PCI_VDEVICE(INTEL, 0x02fb), LPSS_CNL_SSP }, > { }, > }; > > -- > 2.20.1 >
On 4/16/19 11:00 AM, Andy Shevchenko wrote: > On Tue, Apr 16, 2019 at 6:28 AM Evan Green <evgreen@chromium.org> wrote: >> >> Add PCI IDs for SPI on Comet Lake. >> > > I didn't check IDs, perhaps Jarkko can do it. > From other prospectives looks good. > Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Yes, those IDs and compatibility with Cannon Lake match with my understanding. Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index b6ddba833d021..493223e1d032d 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1451,6 +1451,10 @@ static const struct pci_device_id pxa2xx_spi_pci_compound_match[] = { { PCI_VDEVICE(INTEL, 0xa32a), LPSS_CNL_SSP }, { PCI_VDEVICE(INTEL, 0xa32b), LPSS_CNL_SSP }, { PCI_VDEVICE(INTEL, 0xa37b), LPSS_CNL_SSP }, + /* CML-LP */ + { PCI_VDEVICE(INTEL, 0x02aa), LPSS_CNL_SSP }, + { PCI_VDEVICE(INTEL, 0x02ab), LPSS_CNL_SSP }, + { PCI_VDEVICE(INTEL, 0x02fb), LPSS_CNL_SSP }, { }, };
Add PCI IDs for SPI on Comet Lake. Signed-off-by: Evan Green <evgreen@chromium.org> --- drivers/spi/spi-pxa2xx.c | 4 ++++ 1 file changed, 4 insertions(+)