| Message ID | 20190416032801.200694-1-marcos.souza.org@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/3] blk-mq.c: Add documention of function blk_mq_init_queue | expand |
On Tue, 2019-04-16 at 00:27 -0300, Marcos Paulo de Souza wrote: > Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> > --- > > No changes from v1. > > block/blk-mq.c | 9 ﯯ뻻 > 1 file changed, 9 insertions() Please always include a cover letter with a patch series that gives an overview of the purpose of the patch series. Thanks, Bart.
gentle ping v2. On Tue, Apr 16, 2019 at 12:27:59AM -0300, Marcos Paulo de Souza wrote: > Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> > --- > > No changes from v1. > > block/blk-mq.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index 9516304a38ee..4a8277a54c03 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -2650,6 +2650,15 @@ void blk_mq_release(struct request_queue *q) > blk_mq_sysfs_deinit(q); > } > > +/** > + * blk_mq_init_queue - Create a new request queue associating a blk_mq_tag_set > + * @set: tag_set to be associated with the request queue > + * > + * Description: > + * This function creates a new request queue, associating @set with it. > + * > + * Returns a new request queue on success, or ERR_PTR() on failure. > + */ > struct request_queue *blk_mq_init_queue(struct blk_mq_tag_set *set) > { > struct request_queue *uninit_q, *q; > -- > 2.16.4 >
On 5/1/19 8:04 PM, Marcos Paulo de Souza wrote:
> gentle ping v2.
It's not that I hate the series, I just don't see it adding any real
value. It should already be quite clear what the functions do, by name,
and the comments don't really add to that.
On Thu, May 02, 2019 at 02:37:56PM -0600, Jens Axboe wrote: > On 5/1/19 8:04 PM, Marcos Paulo de Souza wrote: > > gentle ping v2. > > It's not that I hate the series, I just don't see it adding any real > value. It should already be quite clear what the functions do, by name, > and the comments don't really add to that. My first goal was to make someone to first read the function comment without going into the details of the code, and at the same time, by adding these documentations, having these functions being listed at https://www.kernel.org/doc/html/latest/. So, in IMHO, they add a fast way, for someone who is trying to understand how things work, to understand exactly what the function does in some seconds, than reading the functions code. In you're now happy with these comments, can you point how can I improve them? Thanks in advance, Marcos > > -- > Jens Axboe >
diff --git a/block/blk-mq.c b/block/blk-mq.c index 9516304a38ee..4a8277a54c03 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -2650,6 +2650,15 @@ void blk_mq_release(struct request_queue *q) blk_mq_sysfs_deinit(q); } +/** + * blk_mq_init_queue - Create a new request queue associating a blk_mq_tag_set + * @set: tag_set to be associated with the request queue + * + * Description: + * This function creates a new request queue, associating @set with it. + * + * Returns a new request queue on success, or ERR_PTR() on failure. + */ struct request_queue *blk_mq_init_queue(struct blk_mq_tag_set *set) { struct request_queue *uninit_q, *q;