| Message ID | 20190415145505.18397-3-digetx@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | NVIDIA Tegra devfreq improvements and Tegra20/30 support | expand |
Hi, On 19. 4. 15. 오후 11:54, Dmitry Osipenko wrote: > There is no need to insert memory barrier on each readl/writel > invocation, hence use the relaxed versions. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/devfreq/tegra-devfreq.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c > index 02905978abe1..0c0909fba545 100644 > --- a/drivers/devfreq/tegra-devfreq.c > +++ b/drivers/devfreq/tegra-devfreq.c > @@ -191,23 +191,23 @@ static struct tegra_actmon_emc_ratio actmon_emc_ratios[] = { > > static u32 actmon_readl(struct tegra_devfreq *tegra, u32 offset) > { > - return readl(tegra->regs + offset); > + return readl_relaxed(tegra->regs + offset); > } > > static void actmon_writel(struct tegra_devfreq *tegra, u32 val, u32 offset) > { > - writel(val, tegra->regs + offset); > + writel_relaxed(val, tegra->regs + offset); > } > > static u32 device_readl(struct tegra_devfreq_device *dev, u32 offset) > { > - return readl(dev->regs + offset); > + return readl_relaxed(dev->regs + offset); > } > > static void device_writel(struct tegra_devfreq_device *dev, u32 val, > u32 offset) > { > - writel(val, dev->regs + offset); > + writel_relaxed(val, dev->regs + offset); > } > > static unsigned long do_percent(unsigned long val, unsigned int pct) > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c index 02905978abe1..0c0909fba545 100644 --- a/drivers/devfreq/tegra-devfreq.c +++ b/drivers/devfreq/tegra-devfreq.c @@ -191,23 +191,23 @@ static struct tegra_actmon_emc_ratio actmon_emc_ratios[] = { static u32 actmon_readl(struct tegra_devfreq *tegra, u32 offset) { - return readl(tegra->regs + offset); + return readl_relaxed(tegra->regs + offset); } static void actmon_writel(struct tegra_devfreq *tegra, u32 val, u32 offset) { - writel(val, tegra->regs + offset); + writel_relaxed(val, tegra->regs + offset); } static u32 device_readl(struct tegra_devfreq_device *dev, u32 offset) { - return readl(dev->regs + offset); + return readl_relaxed(dev->regs + offset); } static void device_writel(struct tegra_devfreq_device *dev, u32 val, u32 offset) { - writel(val, dev->regs + offset); + writel_relaxed(val, dev->regs + offset); } static unsigned long do_percent(unsigned long val, unsigned int pct)
There is no need to insert memory barrier on each readl/writel invocation, hence use the relaxed versions. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/devfreq/tegra-devfreq.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)