| Message ID | 1555487288-4777-2-git-send-email-l.luba@partner.samsung.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Exynos Performance Monitoring Counters enhancements | expand |
Hi Lukasz, On 19. 4. 17. 오후 4:48, Lukasz Luba wrote: > This patch add support of a new feature which can be used in DT: > Performance Monitoring Unit with defined event data type. > In this patch the event data types are defined for Exynos PPMU. > The patch also updates the MAINTAINERS file accordingly. > > Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> > --- > MAINTAINERS | 5 +++++ > include/dt-bindings/pmu/exynos_ppmu.h | 24 ++++++++++++++++++++++++ > 2 files changed, 29 insertions(+) > create mode 100644 include/dt-bindings/pmu/exynos_ppmu.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index 3671fde..f4aac78 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12376,6 +12376,11 @@ L: linux-scsi@vger.kernel.org > S: Supported > F: drivers/scsi/pm8001/ > > +PMU EXYNOS DT BINDINGS > +M: Lukasz Luba <l.luba@partner.samsung.com> > +S: Maintained > +F: include/dt-bindings/pmu/exynos_ppmu.h > + IMHO, I'm not sure that it is right of adding one dt-binding header file to MAINTAINERS file. If right, I'm OK. > PNP SUPPORT > M: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> > S: Maintained > diff --git a/include/dt-bindings/pmu/exynos_ppmu.h b/include/dt-bindings/pmu/exynos_ppmu.h > new file mode 100644 > index 0000000..a6971eb > --- /dev/null > +++ b/include/dt-bindings/pmu/exynos_ppmu.h > @@ -0,0 +1,24 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Samsung Exynos PPMU event types for counting in regs > + * > + * Copyright (c) 2019, Samsung > + * Author: Lukasz Luba <l.luba@partner.samsung.com> > + */ > + > +#ifndef __DT_BINDINGS_PMU_EXYNOS_PPMU_H > +#define __DT_BINDINGS_PMU_EXYNOS_PPMU_H > + > + > +#define PPMU_RO_BUSY_CYCLE_CNT 0x0 > +#define PPMU_WO_BUSY_CYCLE_CNT 0x1 > +#define PPMU_RW_BUSY_CYCLE_CNT 0x2 > +#define PPMU_RO_REQUEST_CNT 0x3 > +#define PPMU_WO_REQUEST_CNT 0x4 > +#define PPMU_RO_DATA_CNT 0x5 > +#define PPMU_WO_DATA_CNT 0x6 > +#define PPMU_RO_LATENCY 0x12 > +#define PPMU_WO_LATENCY 0x16 > +#define PPMU_V2_EVT3_RW_DATA_CNT 0x22 If we can select the data type for monitoring, it looks good to me. But, when I developed the Exynos PPMU, I has not tested other data type except for PPMU_RO_DATA_CNT and PPMU_WO_DATA_CNT. Do you test all data types with PPMU device? > + > +#endif >
Hi Chanwoo, On 4/17/19 10:10 AM, Chanwoo Choi wrote: > Hi Lukasz, > > On 19. 4. 17. 오후 4:48, Lukasz Luba wrote: >> This patch add support of a new feature which can be used in DT: >> Performance Monitoring Unit with defined event data type. >> In this patch the event data types are defined for Exynos PPMU. >> The patch also updates the MAINTAINERS file accordingly. >> >> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> >> --- >> MAINTAINERS | 5 +++++ >> include/dt-bindings/pmu/exynos_ppmu.h | 24 ++++++++++++++++++++++++ >> 2 files changed, 29 insertions(+) >> create mode 100644 include/dt-bindings/pmu/exynos_ppmu.h >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 3671fde..f4aac78 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -12376,6 +12376,11 @@ L: linux-scsi@vger.kernel.org >> S: Supported >> F: drivers/scsi/pm8001/ >> >> +PMU EXYNOS DT BINDINGS >> +M: Lukasz Luba <l.luba@partner.samsung.com> >> +S: Maintained >> +F: include/dt-bindings/pmu/exynos_ppmu.h >> + > > IMHO, I'm not sure that it is right of adding one dt-binding header file > to MAINTAINERS file. If right, I'm OK. > > >> PNP SUPPORT >> M: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> >> S: Maintained >> diff --git a/include/dt-bindings/pmu/exynos_ppmu.h b/include/dt-bindings/pmu/exynos_ppmu.h >> new file mode 100644 >> index 0000000..a6971eb >> --- /dev/null >> +++ b/include/dt-bindings/pmu/exynos_ppmu.h >> @@ -0,0 +1,24 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* >> + * Samsung Exynos PPMU event types for counting in regs >> + * >> + * Copyright (c) 2019, Samsung >> + * Author: Lukasz Luba <l.luba@partner.samsung.com> >> + */ >> + >> +#ifndef __DT_BINDINGS_PMU_EXYNOS_PPMU_H >> +#define __DT_BINDINGS_PMU_EXYNOS_PPMU_H >> + >> + >> +#define PPMU_RO_BUSY_CYCLE_CNT 0x0 >> +#define PPMU_WO_BUSY_CYCLE_CNT 0x1 >> +#define PPMU_RW_BUSY_CYCLE_CNT 0x2 >> +#define PPMU_RO_REQUEST_CNT 0x3 >> +#define PPMU_WO_REQUEST_CNT 0x4 >> +#define PPMU_RO_DATA_CNT 0x5 >> +#define PPMU_WO_DATA_CNT 0x6 >> +#define PPMU_RO_LATENCY 0x12 >> +#define PPMU_WO_LATENCY 0x16 >> +#define PPMU_V2_EVT3_RW_DATA_CNT 0x22 > > If we can select the data type for monitoring, it looks good to me. > But, when I developed the Exynos PPMU, I has not tested other data type > except for PPMU_RO_DATA_CNT and PPMU_WO_DATA_CNT. > > Do you test all data types with PPMU device? Yes, I have tested all - 1 of them on Odroid XU4 with memory controller and they work. I haven't checked the last option for Exynos5433, but it should work since it was default option in your driver. Regards, Lukasz > >> + >> +#endif >> > >
diff --git a/MAINTAINERS b/MAINTAINERS index 3671fde..f4aac78 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12376,6 +12376,11 @@ L: linux-scsi@vger.kernel.org S: Supported F: drivers/scsi/pm8001/ +PMU EXYNOS DT BINDINGS +M: Lukasz Luba <l.luba@partner.samsung.com> +S: Maintained +F: include/dt-bindings/pmu/exynos_ppmu.h + PNP SUPPORT M: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> S: Maintained diff --git a/include/dt-bindings/pmu/exynos_ppmu.h b/include/dt-bindings/pmu/exynos_ppmu.h new file mode 100644 index 0000000..a6971eb --- /dev/null +++ b/include/dt-bindings/pmu/exynos_ppmu.h @@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Samsung Exynos PPMU event types for counting in regs + * + * Copyright (c) 2019, Samsung + * Author: Lukasz Luba <l.luba@partner.samsung.com> + */ + +#ifndef __DT_BINDINGS_PMU_EXYNOS_PPMU_H +#define __DT_BINDINGS_PMU_EXYNOS_PPMU_H + + +#define PPMU_RO_BUSY_CYCLE_CNT 0x0 +#define PPMU_WO_BUSY_CYCLE_CNT 0x1 +#define PPMU_RW_BUSY_CYCLE_CNT 0x2 +#define PPMU_RO_REQUEST_CNT 0x3 +#define PPMU_WO_REQUEST_CNT 0x4 +#define PPMU_RO_DATA_CNT 0x5 +#define PPMU_WO_DATA_CNT 0x6 +#define PPMU_RO_LATENCY 0x12 +#define PPMU_WO_LATENCY 0x16 +#define PPMU_V2_EVT3_RW_DATA_CNT 0x22 + +#endif
This patch add support of a new feature which can be used in DT: Performance Monitoring Unit with defined event data type. In this patch the event data types are defined for Exynos PPMU. The patch also updates the MAINTAINERS file accordingly. Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> --- MAINTAINERS | 5 +++++ include/dt-bindings/pmu/exynos_ppmu.h | 24 ++++++++++++++++++++++++ 2 files changed, 29 insertions(+) create mode 100644 include/dt-bindings/pmu/exynos_ppmu.h