| Message ID | 20190417023112.162916-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | 82f26185a91298a21aa33a985893dd5f8ed4c75a |
| Headers | show |
| Series | [-next] regulator: stm32-pwr: Make some symbols static | expand |
On Wed, Apr 17, 2019 at 02:31:12AM +0000, Wei Yongjun wrote: > Fixes the following sparse warnings: > > drivers/regulator/stm32-pwr.c:35:5: warning: > symbol 'ready_mask_table' was not declared. Should it be static? > drivers/regulator/stm32-pwr.c:47:5: warning: > symbol 'stm32_pwr_reg_is_ready' was not declared. Should it be static? > drivers/regulator/stm32-pwr.c:57:5: warning: > symbol 'stm32_pwr_reg_is_enabled' was not declared. Should it be static? Someone already sent a patch for this.
diff --git a/drivers/regulator/stm32-pwr.c b/drivers/regulator/stm32-pwr.c index e434b26d4c8b..222d593d76a2 100644 --- a/drivers/regulator/stm32-pwr.c +++ b/drivers/regulator/stm32-pwr.c @@ -32,7 +32,7 @@ enum { STM32PWR_REG_NUM_REGS }; -u32 ready_mask_table[STM32PWR_REG_NUM_REGS] = { +static u32 ready_mask_table[STM32PWR_REG_NUM_REGS] = { [PWR_REG11] = REG_1_1_RDY, [PWR_REG18] = REG_1_8_RDY, [PWR_USB33] = USB_3_3_RDY, @@ -44,7 +44,7 @@ struct stm32_pwr_reg { u32 ready_mask; }; -int stm32_pwr_reg_is_ready(struct regulator_dev *rdev) +static int stm32_pwr_reg_is_ready(struct regulator_dev *rdev) { struct stm32_pwr_reg *priv = rdev_get_drvdata(rdev); u32 val; @@ -54,7 +54,7 @@ int stm32_pwr_reg_is_ready(struct regulator_dev *rdev) return (val & priv->ready_mask); } -int stm32_pwr_reg_is_enabled(struct regulator_dev *rdev) +static int stm32_pwr_reg_is_enabled(struct regulator_dev *rdev) { struct stm32_pwr_reg *priv = rdev_get_drvdata(rdev); u32 val;
Fixes the following sparse warnings: drivers/regulator/stm32-pwr.c:35:5: warning: symbol 'ready_mask_table' was not declared. Should it be static? drivers/regulator/stm32-pwr.c:47:5: warning: symbol 'stm32_pwr_reg_is_ready' was not declared. Should it be static? drivers/regulator/stm32-pwr.c:57:5: warning: symbol 'stm32_pwr_reg_is_enabled' was not declared. Should it be static? Fixes: 6cdae8173f67 ("regulator: Add support for stm32 power regulators") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/regulator/stm32-pwr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)