| Message ID | 1555487288-4777-4-git-send-email-l.luba@partner.samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/3] include: dt-bindings: add Performance Monitoring Unit for Exynos | expand |
Hi Lukasz, On 19. 4. 17. 오후 4:48, Lukasz Luba wrote: > Extend the documenation by events description with new 'event-data-type' > field. Add example how the event might be defined in DT. > > Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> > --- > .../devicetree/bindings/devfreq/event/exynos-ppmu.txt | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt > index 3e36c1d..47feb5f 100644 > --- a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt > +++ b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt > @@ -145,3 +145,21 @@ Example3 : PPMUv2 nodes in exynos5433.dtsi are listed below. > reg = <0x104d0000 0x2000>; > status = "disabled"; > }; > + > +The 'event' type specified in the PPMU node defines 'event-name' > +which also contains 'id' number and optionally 'event-data-type'. > + > +Example: > + > + events { > + ppmu_leftbus_0: ppmu-event0-leftbus { > + event-name = "ppmu-event0-leftbus"; > + event-data-type = <PPMU_RO_DATA_CNT>; > + }; > + }; > + > +The 'event-data-type' defines the type of data which shell be counted > +by the counter. You can check include/dt-bindings/pmu/exynos_ppmu.h for I replied about 'pmu' name on patch2. Please check it. > +all possible type, i.e. count read requests, count write data in bytes, > +etc. This field is optional and when it is missing, the driver code will > +use default data type. > Looks good to me. But, If you want to add the new 'event-data-type' property, you better to add 'event-data-type' to Exynos dts file including PPMU device. If the dts file contain the data type information, I think it is easy to understand for the user what is monitoring on PPMU device.
Hi Chanwoo, On 4/17/19 10:26 AM, Chanwoo Choi wrote: > Hi Lukasz, > > On 19. 4. 17. 오후 4:48, Lukasz Luba wrote: >> Extend the documenation by events description with new 'event-data-type' >> field. Add example how the event might be defined in DT. >> >> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> >> --- >> .../devicetree/bindings/devfreq/event/exynos-ppmu.txt | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt >> index 3e36c1d..47feb5f 100644 >> --- a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt >> +++ b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt >> @@ -145,3 +145,21 @@ Example3 : PPMUv2 nodes in exynos5433.dtsi are listed below. >> reg = <0x104d0000 0x2000>; >> status = "disabled"; >> }; >> + >> +The 'event' type specified in the PPMU node defines 'event-name' >> +which also contains 'id' number and optionally 'event-data-type'. >> + >> +Example: >> + >> + events { >> + ppmu_leftbus_0: ppmu-event0-leftbus { >> + event-name = "ppmu-event0-leftbus"; >> + event-data-type = <PPMU_RO_DATA_CNT>; >> + }; >> + }; >> + >> +The 'event-data-type' defines the type of data which shell be counted >> +by the counter. You can check include/dt-bindings/pmu/exynos_ppmu.h for > > I replied about 'pmu' name on patch2. Please check it. Yes, I've seen it and responded. > >> +all possible type, i.e. count read requests, count write data in bytes, >> +etc. This field is optional and when it is missing, the driver code will >> +use default data type. >> > Looks good to me. > But, If you want to add the new 'event-data-type' property, > you better to add 'event-data-type' to Exynos dts file including > PPMU device. > > If the dts file contain the data type information, > I think it is easy to understand for the user > what is monitoring on PPMU device. Make sense, I will do that. It will be explicitly telling the user what is currently monitored in the PPMU device event. Regards, Lukasz > >
diff --git a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt index 3e36c1d..47feb5f 100644 --- a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt +++ b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt @@ -145,3 +145,21 @@ Example3 : PPMUv2 nodes in exynos5433.dtsi are listed below. reg = <0x104d0000 0x2000>; status = "disabled"; }; + +The 'event' type specified in the PPMU node defines 'event-name' +which also contains 'id' number and optionally 'event-data-type'. + +Example: + + events { + ppmu_leftbus_0: ppmu-event0-leftbus { + event-name = "ppmu-event0-leftbus"; + event-data-type = <PPMU_RO_DATA_CNT>; + }; + }; + +The 'event-data-type' defines the type of data which shell be counted +by the counter. You can check include/dt-bindings/pmu/exynos_ppmu.h for +all possible type, i.e. count read requests, count write data in bytes, +etc. This field is optional and when it is missing, the driver code will +use default data type.
Extend the documenation by events description with new 'event-data-type' field. Add example how the event might be defined in DT. Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> --- .../devicetree/bindings/devfreq/event/exynos-ppmu.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)