| Message ID | 20190418104012.4841-1-skashyap@marvell.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 0228034d8e5915b98c33db35a98f5e909e848ae9 |
| Headers | show |
| Series | Revert "scsi: fcoe: clear FC_RP_STARTED flags when receiving a LOGO" | expand |
On 4/18/19 12:40 PM, Saurav Kashyap wrote: > This patch clears FC_RP_STARTED flag during logoff, because of > this re-login(flogi) didn't happen to the switch. > > This reverts commit 1550ec458e0cf1a40a170ab1f4c46e3f52860f65. > --- > drivers/scsi/libfc/fc_rport.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c > index dfba492..5bf6143 100644 > --- a/drivers/scsi/libfc/fc_rport.c > +++ b/drivers/scsi/libfc/fc_rport.c > @@ -2162,7 +2162,6 @@ static void fc_rport_recv_logo_req(struct fc_lport *lport, struct fc_frame *fp) > FC_RPORT_DBG(rdata, "Received LOGO request while in state %s\n", > fc_rport_state(rdata)); > > - rdata->flags &= ~FC_RP_STARTED; > fc_rport_enter_delete(rdata, RPORT_EV_STOP); > mutex_unlock(&rdata->rp_mutex); > kref_put(&rdata->kref, fc_rport_destroy); > Reviewed-by: Hannes Reinecke <hare@#suse.com> Cheers, Hannes
This is missing you Signed-off-by
Saurav, > This patch clears FC_RP_STARTED flag during logoff, because of this > re-login(flogi) didn't happen to the switch. Applied to 5.1/scsi-fixes with your SoB added.
diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index dfba492..5bf6143 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b/drivers/scsi/libfc/fc_rport.c @@ -2162,7 +2162,6 @@ static void fc_rport_recv_logo_req(struct fc_lport *lport, struct fc_frame *fp) FC_RPORT_DBG(rdata, "Received LOGO request while in state %s\n", fc_rport_state(rdata)); - rdata->flags &= ~FC_RP_STARTED; fc_rport_enter_delete(rdata, RPORT_EV_STOP); mutex_unlock(&rdata->rp_mutex); kref_put(&rdata->kref, fc_rport_destroy);