| Message ID | 20190416064024.20414-1-wens@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | ARM: sun8i: a83t: Enable USB OTG | expand |
Hi, On Tue, Apr 16, 2019 at 02:40:17PM +0800, Chen-Yu Tsai wrote: > This is v4 of my A83T USB power supply / OTG series. Hopefully this is > the last revision even though it's kind of late in the -rc cycle for > the patches to make the next release. Fingers crossed. Patches 1-5 (i.e. all except DTS) queued to power-supply subsystem. -- Sebastian
On Wed, Apr 17, 2019 at 11:27:03PM +0200, Sebastian Reichel wrote: > Hi, > > On Tue, Apr 16, 2019 at 02:40:17PM +0800, Chen-Yu Tsai wrote: > > This is v4 of my A83T USB power supply / OTG series. Hopefully this is > > the last revision even though it's kind of late in the -rc cycle for > > the patches to make the next release. Fingers crossed. > > Patches 1-5 (i.e. all except DTS) queued to power-supply subsystem. Applied 6 and 7, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
From: Chen-Yu Tsai <wens@csie.org> Hi everyone, This is v4 of my A83T USB power supply / OTG series. Hopefully this is the last revision even though it's kind of late in the -rc cycle for the patches to make the next release. Fingers crossed. Changes since v3: - Dropped patch for disabling current limit - Dropped mfd patch as it is already merged Changes since v2: - Added Rob's ack for dt bindings patch - Rebased onto v5.1-rc1 Changes since v1: - Added Lee's ack for mfd patch - Make axp803_usb_power_supply_resources[] const This series has since been tested. Both host mode and gadget mode work well. However this SoC seems to have a glitch in hardware. After host mode is used by plugging in a host mode cable, the hardware will not revert back to gadget mode if a standard USB cable is plugged in. Host mode continues to work however. This will likely have to be addressed with some workaround in either the musb driver or our USB PHY driver. The patches have no cross-tree dependencies, so each part can go through their respective trees (power-supply / arm-soc). I also have some follow-up patches to enable the USB power supply on AXP803 / A64. It's the boiler-plate mfd cell and device node addition. Original cover letter follows: This series enables USB OTG on the A83T boards. The AXP813/AXP818 PMICs used with the A83T have the same behavior as the AXP221 and AXP223, where if the N_VBUSEN pin is driven high, the VBUS sensing interrupts stop working. In the past Hans made a polling workaround in the USB PHY driver. In this series polling is added to the power supply driver. The power supply driver work was started by Quentin, and shared with me when I expressed interest in getting USB OTG to work some time ago. Neither of us got around to finishing it, until now that is. Patch 1 adds a new compatible string for the AXP813 VBUS power supply part. Patch 2 is a bit of cleanup work for the driver. Patch 3 allows disabling VBUS input current limiting on the AXP20x / AXP22x PMICs. While not strictly related to this series, I found it easier to just send everything together. This patch depends on the previous one. Patch 4 adds the VBUS status polling feature. This is enabled on AXP221 and all later PMICs. Patch 5 factors out code to read out the configured input current limit for the AXP20x and AXP22x PMICs. As the AXP813 uses different values, factoring out the code based on model will make the main function more readable. Patch 6 adds support for the AXP813 VBUS power supply. checkpatch.pl reports a few warnings for this patch: WARNING: Possible switch case/default not preceded by break or fallthrough comment #100: FILE: drivers/power/supply/axp20x_usb_power.c:306: + case 1500000: WARNING: Possible switch case/default not preceded by break or fallthrough comment #101: FILE: drivers/power/supply/axp20x_usb_power.c:307: + case 2000000: WARNING: Possible switch case/default not preceded by break or fallthrough comment #102: FILE: drivers/power/supply/axp20x_usb_power.c:308: + case 2500000: However they seem to be a false positive. The preceding line of the reported lines is a return statement, which is definitely not a fallthrough. Patch 7 adds an mfd cell for the newly supported VBUS power supply. Patch 8 adds a device node for the VBUS power supply to the common axp81x dtsi file. Patch 9 enables USB OTG on the Cubietruck Plus and Bananapi M3. Please have a look, and also test it on boards you have, and don't limit it to just the A83T ones. As mentioned above, the polling feature affects all boards that have an AXP221 or newer PMIC. I haven't removed the polling workaround from the USB PHY driver yet. That would be the next step after this series is merged, and preferrably a release has passed. Regards ChenYu Chen-Yu Tsai (4): dt-bindings: power: supply: axp20x_usb_power: add axp813 compatible power: supply: axp20x_usb_power: Fix typo in VBUS current limit macros power: supply: axp20x_usb_power: use polling to detect vbus status change ARM: dts: sun8i: a83t: Enable USB OTG controller on some boards Quentin Schulz (3): power: supply: axp20x_usb_power: add function to get max current power: supply: axp20x_usb_power: add support for AXP813 ARM: dtsi: axp81x: add USB power supply node .../power/supply/axp20x_usb_power.txt | 1 + arch/arm/boot/dts/axp81x.dtsi | 4 + arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 12 ++ .../boot/dts/sun8i-a83t-cubietruck-plus.dts | 12 ++ drivers/power/supply/axp20x_usb_power.c | 179 +++++++++++++++--- 5 files changed, 181 insertions(+), 27 deletions(-)