| Message ID | 20180910163932.13722-1-katsuhiro@katsuster.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: rockchip: add missing INTERLEAVED PCM attribute | expand |
Hi, On Sep 10, 2018 at 4:39 PM Katsuhiro Suzuki <katsuhiro@katsuster.net> wrote: > > This patch adds SNDRV_PCM_INFO_INTERLEAVED into PCM hardware info. > > Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net> > --- > sound/soc/rockchip/rockchip_pcm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) I just tracked down that audio was broken on 4.19 and needs this change to work. Stable: can you please pick it? Specifically I believe you'd want to treat it as if it had: Fixes: 75b31192fe6a ("ASoC: rockchip: add config for rockchip dmaengine pcm register") -Doug
On Tue, Apr 23, 2019 at 03:26:42PM -0700, Doug Anderson wrote: > Hi, > > On Sep 10, 2018 at 4:39 PM Katsuhiro Suzuki <katsuhiro@katsuster.net> wrote: > > > > This patch adds SNDRV_PCM_INFO_INTERLEAVED into PCM hardware info. > > > > Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net> > > --- > > sound/soc/rockchip/rockchip_pcm.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > I just tracked down that audio was broken on 4.19 and needs this > change to work. Stable: can you please pick it? Specifically I > believe you'd want to treat it as if it had: > > Fixes: 75b31192fe6a ("ASoC: rockchip: add config for rockchip > dmaengine pcm register") What is the git commit id of this patch in Linus's tree? thanks, greg k-h
Am Mittwoch, 24. April 2019, 15:45:36 CEST schrieb Greg KH: > On Tue, Apr 23, 2019 at 03:26:42PM -0700, Doug Anderson wrote: > > Hi, > > > > On Sep 10, 2018 at 4:39 PM Katsuhiro Suzuki <katsuhiro@katsuster.net> wrote: > > > > > > This patch adds SNDRV_PCM_INFO_INTERLEAVED into PCM hardware info. > > > > > > Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net> > > > --- > > > sound/soc/rockchip/rockchip_pcm.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > I just tracked down that audio was broken on 4.19 and needs this > > change to work. Stable: can you please pick it? Specifically I > > believe you'd want to treat it as if it had: > > > > Fixes: 75b31192fe6a ("ASoC: rockchip: add config for rockchip > > dmaengine pcm register") > > What is the git commit id of this patch in Linus's tree? Commit id is 24d6638302b48328a58c13439276d4531af4ca7d [0] [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=24d6638302b48328a58c13439276d4531af4ca7d
On Wed, Apr 24, 2019 at 03:53:54PM +0200, Heiko Stuebner wrote: > Am Mittwoch, 24. April 2019, 15:45:36 CEST schrieb Greg KH: > > On Tue, Apr 23, 2019 at 03:26:42PM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On Sep 10, 2018 at 4:39 PM Katsuhiro Suzuki <katsuhiro@katsuster.net> wrote: > > > > > > > > This patch adds SNDRV_PCM_INFO_INTERLEAVED into PCM hardware info. > > > > > > > > Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net> > > > > --- > > > > sound/soc/rockchip/rockchip_pcm.c | 3 ++- > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > I just tracked down that audio was broken on 4.19 and needs this > > > change to work. Stable: can you please pick it? Specifically I > > > believe you'd want to treat it as if it had: > > > > > > Fixes: 75b31192fe6a ("ASoC: rockchip: add config for rockchip > > > dmaengine pcm register") > > > > What is the git commit id of this patch in Linus's tree? > > Commit id is 24d6638302b48328a58c13439276d4531af4ca7d [0] > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=24d6638302b48328a58c13439276d4531af4ca7d Thanks, now queued up. greg k-h
diff --git a/sound/soc/rockchip/rockchip_pcm.c b/sound/soc/rockchip/rockchip_pcm.c index f77538319221..9e7b5fa4cf59 100644 --- a/sound/soc/rockchip/rockchip_pcm.c +++ b/sound/soc/rockchip/rockchip_pcm.c @@ -21,7 +21,8 @@ static const struct snd_pcm_hardware snd_rockchip_hardware = { .info = SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID | SNDRV_PCM_INFO_PAUSE | - SNDRV_PCM_INFO_RESUME, + SNDRV_PCM_INFO_RESUME | + SNDRV_PCM_INFO_INTERLEAVED, .period_bytes_min = 32, .period_bytes_max = 8192, .periods_min = 1,
This patch adds SNDRV_PCM_INFO_INTERLEAVED into PCM hardware info. Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net> --- sound/soc/rockchip/rockchip_pcm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)