| Message ID | 20190424092505.6578-3-masneyb@onstation.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | backlight: lm3630a: bug fix and fwnode support | expand |
Hi! > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > @@ -0,0 +1,129 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/backlight/lm3630a-backlight.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# I'm not a great fan on links to external websites. But this is comment for Rob. > +title: TI LM3630A High-Efficiency Dual-String White LED > + > +maintainers: > + - Lee Jones <lee.jones@linaro.org> > + - Daniel Thompson <daniel.thompson@linaro.org> > + - Jingoo Han <jingoohan1@gmail.com> Not a great fan of duplicating MAINTAINERS information here. But this is a comment for Rob, again. Acked-by: Pavel Machek <pavel@ucw.cz>
On Wed, Apr 24, 2019 at 9:20 AM Pavel Machek <pavel@ucw.cz> wrote: > > Hi! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > > @@ -0,0 +1,129 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/leds/backlight/lm3630a-backlight.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > I'm not a great fan on links to external websites. But this is comment > for Rob. This is simply how json-schema works. $schema says what meta-schema this file should validate against so it's versioned if we change the schema format. $id is just a unique identifier and is used to resolve $ref values. Note that these aren't live urls either (but could be at some point in the future). > > +title: TI LM3630A High-Efficiency Dual-String White LED > > + > > +maintainers: > > + - Lee Jones <lee.jones@linaro.org> > > + - Daniel Thompson <daniel.thompson@linaro.org> > > + - Jingoo Han <jingoohan1@gmail.com> > > Not a great fan of duplicating MAINTAINERS information here. But this > is a comment for Rob, again. Hopefully this is temporary until we move to per directory MAINTAINERS files. Not sure what happened with that. Rob
On Wed 2019-04-24 10:57:50, Rob Herring wrote: > On Wed, Apr 24, 2019 at 9:20 AM Pavel Machek <pavel@ucw.cz> wrote: > > > > Hi! > > > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > > > @@ -0,0 +1,129 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/leds/backlight/lm3630a-backlight.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > I'm not a great fan on links to external websites. But this is comment > > for Rob. > > This is simply how json-schema works. $schema says what meta-schema > this file should validate against so it's versioned if we change the > schema format. $id is just a unique identifier and is used to resolve > $ref values. Note that these aren't live urls either (but could be at > some point in the future). Umm. Interesting design :-). > > > +title: TI LM3630A High-Efficiency Dual-String White LED > > > + > > > +maintainers: > > > + - Lee Jones <lee.jones@linaro.org> > > > + - Daniel Thompson <daniel.thompson@linaro.org> > > > + - Jingoo Han <jingoohan1@gmail.com> > > > > Not a great fan of duplicating MAINTAINERS information here. But this > > is a comment for Rob, again. > > Hopefully this is temporary until we move to per directory MAINTAINERS > files. Not sure what happened with that. Aha, ok. Pavel
On 24/04/2019 10:25, Brian Masney wrote: > Add new backlight bindings for the TI LM3630A dual-string white LED. > > Signed-off-by: Brian Masney <masneyb@onstation.org> > Reviewed-by: Rob Herring <robh@kernel.org> > Acked-by: Pavel Machek <pavel@ucw.cz> Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > Changes since v5: > - Change 'lm3630a_bl@38' in examples to 'led-controller@38' > > Changes since v4: > - Drop $ref from led-sources > - Drop description from reg of i2c address > - Expand description of reg for the control bank > - Drop status from examples > > Changes since v3: > - Add label. I didn't add a description for it since that'll come from > the common properties once its converted. > > Changes since v2: > - Update description of max-brightness > - Add description for reg > - Correct typo: s/tranisiton/transition > - add reg to control banks > - add additionalProperties > > .../leds/backlight/lm3630a-backlight.yaml | 129 ++++++++++++++++++ > 1 file changed, 129 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > > diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > new file mode 100644 > index 000000000000..4d61fe0a98a4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > @@ -0,0 +1,129 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/backlight/lm3630a-backlight.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TI LM3630A High-Efficiency Dual-String White LED > + > +maintainers: > + - Lee Jones <lee.jones@linaro.org> > + - Daniel Thompson <daniel.thompson@linaro.org> > + - Jingoo Han <jingoohan1@gmail.com> > + > +description: | > + The LM3630A is a current-mode boost converter which supplies the power and > + controls the current in up to two strings of 10 LEDs per string. > + https://www.ti.com/product/LM3630A > + > +properties: > + compatible: > + const: ti,lm3630a > + > + reg: > + maxItems: 1 > + > + ti,linear-mapping-mode: > + description: | > + Enable linear mapping mode. If disabled, then it will use exponential > + mapping mode in which the ramp up/down appears to have a more uniform > + transition to the human eye. > + type: boolean > + > +required: > + - compatible > + - reg > + > +patternProperties: > + "^led@[01]$": > + type: object > + description: | > + Properties for a string of connected LEDs. > + > + properties: > + reg: > + description: | > + The control bank that is used to program the two current sinks. The > + LM3630A has two control banks (A and B) and are represented as 0 or 1 > + in this property. The two current sinks can be controlled > + independently with both banks, or bank A can be configured to control > + both sinks with the led-sources property. > + maxItems: 1 > + minimum: 0 > + maximum: 1 > + > + label: > + maxItems: 1 > + > + led-sources: > + allOf: > + - minItems: 1 > + maxItems: 2 > + items: > + minimum: 0 > + maximum: 1 > + > + default-brightness: > + description: Default brightness level on boot. > + minimum: 0 > + maximum: 255 > + > + max-brightness: > + description: Maximum brightness that is allowed during runtime. > + minimum: 0 > + maximum: 255 > + > + required: > + - reg > + > + additionalProperties: false > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + led-controller@38 { > + compatible = "ti,lm3630a"; > + reg = <0x38>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@0 { > + reg = <0>; > + led-sources = <0 1>; > + label = "lcd-backlight"; > + default-brightness = <200>; > + max-brightness = <255>; > + }; > + }; > + }; > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + led-controller@38 { > + compatible = "ti,lm3630a"; > + reg = <0x38>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@0 { > + reg = <0>; > + default-brightness = <150>; > + ti,linear-mapping-mode; > + }; > + > + led@1 { > + reg = <1>; > + default-brightness = <225>; > + ti,linear-mapping-mode; > + }; > + }; > + }; >
On Wed, Apr 24, 2019 at 4:25 AM Brian Masney <masneyb@onstation.org> wrote: > > Add new backlight bindings for the TI LM3630A dual-string white LED. > > Signed-off-by: Brian Masney <masneyb@onstation.org> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > Changes since v5: > - Change 'lm3630a_bl@38' in examples to 'led-controller@38' > > Changes since v4: > - Drop $ref from led-sources > - Drop description from reg of i2c address > - Expand description of reg for the control bank > - Drop status from examples > > Changes since v3: > - Add label. I didn't add a description for it since that'll come from > the common properties once its converted. > > Changes since v2: > - Update description of max-brightness > - Add description for reg > - Correct typo: s/tranisiton/transition > - add reg to control banks > - add additionalProperties > > .../leds/backlight/lm3630a-backlight.yaml | 129 ++++++++++++++++++ > 1 file changed, 129 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml I'm working on getting the examples to be validated by the schema (in addition to just building with dtc) and there's a couple of errors: Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: '#address-cells', '#size-cells' do not match any of the regexes: '^led@[01]$', 'pinctrl-[0-9]+' Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: '#address-cells', '#size-cells' do not match any of the regexes: '^led@[01]$', 'pinctrl-[0-9]+' You didn't list '#address-cells' and '#size-cells'. Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: led@0: 'ti,linear-mapping-mode' does not match any of the regexes: 'pinctrl-[0-9]+' Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: led@1: 'ti,linear-mapping-mode' does not match any of the regexes: 'pinctrl-[0-9]+' 'ti,linear-mapping-mode' is not defined in the child nodes. Rob
Hi Rob, On Fri, May 17, 2019 at 04:11:48PM -0500, Rob Herring wrote: > On Wed, Apr 24, 2019 at 4:25 AM Brian Masney <masneyb@onstation.org> wrote: > > > > Add new backlight bindings for the TI LM3630A dual-string white LED. > > > > Signed-off-by: Brian Masney <masneyb@onstation.org> > > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > Changes since v5: > > - Change 'lm3630a_bl@38' in examples to 'led-controller@38' > > > > Changes since v4: > > - Drop $ref from led-sources > > - Drop description from reg of i2c address > > - Expand description of reg for the control bank > > - Drop status from examples > > > > Changes since v3: > > - Add label. I didn't add a description for it since that'll come from > > the common properties once its converted. > > > > Changes since v2: > > - Update description of max-brightness > > - Add description for reg > > - Correct typo: s/tranisiton/transition > > - add reg to control banks > > - add additionalProperties > > > > .../leds/backlight/lm3630a-backlight.yaml | 129 ++++++++++++++++++ > > 1 file changed, 129 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > > I'm working on getting the examples to be validated by the schema (in > addition to just building with dtc) and there's a couple of errors: > > Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: > '#address-cells', '#size-cells' do not match any of the regexes: > '^led@[01]$', 'pinctrl-[0-9]+' > Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: > '#address-cells', '#size-cells' do not match any of the regexes: > '^led@[01]$', 'pinctrl-[0-9]+' > > You didn't list '#address-cells' and '#size-cells'. > > Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: > led@0: 'ti,linear-mapping-mode' does not match any of the regexes: > 'pinctrl-[0-9]+' > Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: > led@1: 'ti,linear-mapping-mode' does not match any of the regexes: > 'pinctrl-[0-9]+' > > 'ti,linear-mapping-mode' is not defined in the child nodes. I'm sorry about that. I'll send out a patch this weekend to correct this. I have 'make dt_binding_check' in my local build script. Is there something else that I should be running as well? Or do you have a branch somewhere with your validation work that I can test my changes against? Brian
diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml new file mode 100644 index 000000000000..4d61fe0a98a4 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml @@ -0,0 +1,129 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/lm3630a-backlight.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI LM3630A High-Efficiency Dual-String White LED + +maintainers: + - Lee Jones <lee.jones@linaro.org> + - Daniel Thompson <daniel.thompson@linaro.org> + - Jingoo Han <jingoohan1@gmail.com> + +description: | + The LM3630A is a current-mode boost converter which supplies the power and + controls the current in up to two strings of 10 LEDs per string. + https://www.ti.com/product/LM3630A + +properties: + compatible: + const: ti,lm3630a + + reg: + maxItems: 1 + + ti,linear-mapping-mode: + description: | + Enable linear mapping mode. If disabled, then it will use exponential + mapping mode in which the ramp up/down appears to have a more uniform + transition to the human eye. + type: boolean + +required: + - compatible + - reg + +patternProperties: + "^led@[01]$": + type: object + description: | + Properties for a string of connected LEDs. + + properties: + reg: + description: | + The control bank that is used to program the two current sinks. The + LM3630A has two control banks (A and B) and are represented as 0 or 1 + in this property. The two current sinks can be controlled + independently with both banks, or bank A can be configured to control + both sinks with the led-sources property. + maxItems: 1 + minimum: 0 + maximum: 1 + + label: + maxItems: 1 + + led-sources: + allOf: + - minItems: 1 + maxItems: 2 + items: + minimum: 0 + maximum: 1 + + default-brightness: + description: Default brightness level on boot. + minimum: 0 + maximum: 255 + + max-brightness: + description: Maximum brightness that is allowed during runtime. + minimum: 0 + maximum: 255 + + required: + - reg + + additionalProperties: false + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + led-controller@38 { + compatible = "ti,lm3630a"; + reg = <0x38>; + + #address-cells = <1>; + #size-cells = <0>; + + led@0 { + reg = <0>; + led-sources = <0 1>; + label = "lcd-backlight"; + default-brightness = <200>; + max-brightness = <255>; + }; + }; + }; + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + led-controller@38 { + compatible = "ti,lm3630a"; + reg = <0x38>; + + #address-cells = <1>; + #size-cells = <0>; + + led@0 { + reg = <0>; + default-brightness = <150>; + ti,linear-mapping-mode; + }; + + led@1 { + reg = <1>; + default-brightness = <225>; + ti,linear-mapping-mode; + }; + }; + };