diff mbox series

[1/5] usb: dwc2: Move UTMI_PHY_DATA defines closer

Message ID 20190402103922.16729-2-jmaselbas@kalray.eu (mailing list archive)
State Superseded
Headers show
Series usb: dwc2: Improve gadget phy init | expand

Commit Message

Jules Maselbas April 2, 2019, 10:39 a.m. UTC
Makes GHWCFG4_UTMI_PHY_DATA* defines closer to their relative shift and
mask defines to improve readability.

Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
---
 drivers/usb/dwc2/hw.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Felipe Balbi April 25, 2019, 12:52 p.m. UTC | #1
Jules Maselbas <jmaselbas@kalray.eu> writes:

> Makes GHWCFG4_UTMI_PHY_DATA* defines closer to their relative shift and
> mask defines to improve readability.
>
> Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>

Doesn't apply. Please make sure to rebase on testing/next
Jules Maselbas April 25, 2019, 3:33 p.m. UTC | #2
Hi Felipe,

On Thu, Apr 25, 2019 at 03:52:16PM +0300, Felipe Balbi wrote:
> Jules Maselbas <jmaselbas@kalray.eu> writes:
> 
> > Makes GHWCFG4_UTMI_PHY_DATA* defines closer to their relative shift and
> > mask defines to improve readability.
> >
> > Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
> 
> Doesn't apply. Please make sure to rebase on testing/next

I've applied this patch serie on v5.1-rc6 and I didn't saw any problems.
I also found that theses patchs are already included in testing/next.
Did I miss something? 


Regards,
--
Jules
diff mbox series

Patch

diff --git a/drivers/usb/dwc2/hw.h b/drivers/usb/dwc2/hw.h
index 98af924a9a5c..7dbf392783c4 100644
--- a/drivers/usb/dwc2/hw.h
+++ b/drivers/usb/dwc2/hw.h
@@ -310,12 +310,12 @@ 
 #define GHWCFG4_NUM_DEV_MODE_CTRL_EP_SHIFT	16
 #define GHWCFG4_UTMI_PHY_DATA_WIDTH_MASK	(0x3 << 14)
 #define GHWCFG4_UTMI_PHY_DATA_WIDTH_SHIFT	14
-#define GHWCFG4_ACG_SUPPORTED			BIT(12)
-#define GHWCFG4_IPG_ISOC_SUPPORTED		BIT(11)
-#define GHWCFG4_SERVICE_INTERVAL_SUPPORTED      BIT(10)
 #define GHWCFG4_UTMI_PHY_DATA_WIDTH_8		0
 #define GHWCFG4_UTMI_PHY_DATA_WIDTH_16		1
 #define GHWCFG4_UTMI_PHY_DATA_WIDTH_8_OR_16	2
+#define GHWCFG4_ACG_SUPPORTED			BIT(12)
+#define GHWCFG4_IPG_ISOC_SUPPORTED		BIT(11)
+#define GHWCFG4_SERVICE_INTERVAL_SUPPORTED      BIT(10)
 #define GHWCFG4_XHIBER				BIT(7)
 #define GHWCFG4_HIBER				BIT(6)
 #define GHWCFG4_MIN_AHB_FREQ			BIT(5)