| Message ID | 20190426034015.4696-1-chen.zhang@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | migration/colo.c: Remove redundant input parameter | expand |
This patch have been integrated in this series: http://lists.nongnu.org/archive/html/qemu-devel/2019-04/msg04520.html Please review it at this link. Thanks Zhang Chen > -----Original Message----- > From: Zhang, Chen > Sent: Friday, April 26, 2019 11:40 AM > To: Laurent Vivier <laurent@vivier.eu>; Dr. David Alan Gilbert > <dgilbert@redhat.com>; Juan Quintela <quintela@redhat.com>; zhanghailiang > <zhang.zhanghailiang@huawei.com>; qemu-dev <qemu-devel@nongnu.org> > Cc: Zhang Chen <zhangckid@gmail.com>; Zhang, Chen <chen.zhang@intel.com> > Subject: [PATCH] migration/colo.c: Remove redundant input parameter > > From: Zhang Chen <chen.zhang@intel.com> > > The colo_do_failover no need the input parameter. > > Signed-off-by: Zhang Chen <chen.zhang@intel.com> > --- > include/migration/colo.h | 2 +- > migration/colo-failover.c | 2 +- > migration/colo.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/migration/colo.h b/include/migration/colo.h index > 99ce17aca7..ddebe0ad27 100644 > --- a/include/migration/colo.h > +++ b/include/migration/colo.h > @@ -37,7 +37,7 @@ bool migration_incoming_in_colo_state(void); > COLOMode get_colo_mode(void); > > /* failover */ > -void colo_do_failover(MigrationState *s); > +void colo_do_failover(void); > > void colo_checkpoint_notify(void *opaque); #endif diff --git a/migration/colo- > failover.c b/migration/colo-failover.c index 4854a96c92..e9ca0b4774 100644 > --- a/migration/colo-failover.c > +++ b/migration/colo-failover.c > @@ -39,7 +39,7 @@ static void colo_failover_bh(void *opaque) > return; > } > > - colo_do_failover(NULL); > + colo_do_failover(); > } > > void failover_request_active(Error **errp) diff --git a/migration/colo.c > b/migration/colo.c index 238a6d62c7..8c1644091f 100644 > --- a/migration/colo.c > +++ b/migration/colo.c > @@ -193,7 +193,7 @@ COLOMode get_colo_mode(void) > } > } > > -void colo_do_failover(MigrationState *s) > +void colo_do_failover(void) > { > /* Make sure VM stopped while failover happened. */ > if (!colo_runstate_is_stopped()) { > -- > 2.17.GIT
diff --git a/include/migration/colo.h b/include/migration/colo.h index 99ce17aca7..ddebe0ad27 100644 --- a/include/migration/colo.h +++ b/include/migration/colo.h @@ -37,7 +37,7 @@ bool migration_incoming_in_colo_state(void); COLOMode get_colo_mode(void); /* failover */ -void colo_do_failover(MigrationState *s); +void colo_do_failover(void); void colo_checkpoint_notify(void *opaque); #endif diff --git a/migration/colo-failover.c b/migration/colo-failover.c index 4854a96c92..e9ca0b4774 100644 --- a/migration/colo-failover.c +++ b/migration/colo-failover.c @@ -39,7 +39,7 @@ static void colo_failover_bh(void *opaque) return; } - colo_do_failover(NULL); + colo_do_failover(); } void failover_request_active(Error **errp) diff --git a/migration/colo.c b/migration/colo.c index 238a6d62c7..8c1644091f 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -193,7 +193,7 @@ COLOMode get_colo_mode(void) } } -void colo_do_failover(MigrationState *s) +void colo_do_failover(void) { /* Make sure VM stopped while failover happened. */ if (!colo_runstate_is_stopped()) {