| Message ID | 20190423215236.13664-3-hmadhani@marvell.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | a1f9ab4844acdd8415dddd588f4fcac4d5b05c8e |
| Headers | show |
| Series | qla2xxx: Minor fixes | expand |
On Tue, 2019-04-23 at 14:52 -0700, Himanshu Madhani wrote: > ELS IOCB done message should be moved to verbose logging > to prevent confusion about the error case v/s sucessful > submission case. > > Signed-off-by: Himanshu Madhani <hmadhani@marvell.com> > --- > drivers/scsi/qla2xxx/qla_isr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c > index 8432ef05f20b..063c78cfa997 100644 > --- a/drivers/scsi/qla2xxx/qla_isr.c > +++ b/drivers/scsi/qla2xxx/qla_isr.c > @@ -1625,7 +1625,7 @@ qla24xx_els_ct_entry(scsi_qla_host_t *vha, struct req_que *req, > res = DID_ERROR << 16; > } > } > - ql_log(ql_log_info, vha, 0x503f, > + ql_dbg(ql_dbg_user, vha, 0x503f, > "ELS IOCB Done -%s error hdl=%x comp_status=0x%x error subcode 1=0x%x error subcode 2=0x%x total_byte=0x%x\n", > type, sp->handle, comp_status, fw_status[1], fw_status[2], > le16_to_cpu(((struct els_sts_entry_24xx *) Reviewed-by: Ewan D. Milne <emilne@redhat.com>
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index 8432ef05f20b..063c78cfa997 100644 --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c @@ -1625,7 +1625,7 @@ qla24xx_els_ct_entry(scsi_qla_host_t *vha, struct req_que *req, res = DID_ERROR << 16; } } - ql_log(ql_log_info, vha, 0x503f, + ql_dbg(ql_dbg_user, vha, 0x503f, "ELS IOCB Done -%s error hdl=%x comp_status=0x%x error subcode 1=0x%x error subcode 2=0x%x total_byte=0x%x\n", type, sp->handle, comp_status, fw_status[1], fw_status[2], le16_to_cpu(((struct els_sts_entry_24xx *)
ELS IOCB done message should be moved to verbose logging to prevent confusion about the error case v/s sucessful submission case. Signed-off-by: Himanshu Madhani <hmadhani@marvell.com> --- drivers/scsi/qla2xxx/qla_isr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)