| Message ID | 20190427175441.GA21587@lenoch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALSA: hda/realtek: Enable internal speaker of ASUS UX362FA with ALC294 | expand |
Hi Petr, please keep list Cced. On Sun, Apr 28, 2019 at 12:48:06AM +0100, Petr Nosek wrote: > Hi Ladislav, > > it repairs both. Inernal speaker and headphones. Ok, will adjust commit message. > I'm sending output of dmesg - I think it helps you to see information, > when is computer booting. Your patch looks like good. Assuming this part of your boot log comes from patched kernel, right? snd_hda_codec_realtek hdaudioC0D0: autoconfig for ALC294: line_outs=1 (0x17/0x0/0x0/0x0/0x0) type:speaker snd_hda_codec_realtek hdaudioC0D0: speaker_outs=0 (0x0/0x0/0x0/0x0/0x0) snd_hda_codec_realtek hdaudioC0D0: hp_outs=1 (0x21/0x0/0x0/0x0/0x0) snd_hda_codec_realtek hdaudioC0D0: mono: mono_out=0x0 snd_hda_codec_realtek hdaudioC0D0: inputs: snd_hda_codec_realtek hdaudioC0D0: Headset Mic=0x19 snd_hda_codec_realtek hdaudioC0D0: Internal Mic=0x12 > Can I do something else to help with repair? I'm not sure, what you mean > by the last sentence. If I have anything else to do. I'll send v2 shortly, Thank you, ladis
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 070749b50eff..490b42e3e3dc 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6896,6 +6896,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x12f0, "ASUS X541UV", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x12e0, "ASUS X541SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC), + SND_PCI_QUIRK(0x1043, 0x13e1, "ASUS UX362FA", ALC294_FIXUP_ASUS_SPK), SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK), SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC),
The ASUS UX362FA with ALC294 cannot detect the outputs through the internal speaker until ALC294_FIXUP_ASUS_SPK quirk applied. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=203443 Suggested-by: Petr Nosek <petr.nosek@gmail.com> Signed-off-by: Ladislav Michl <ladis@linux-mips.org> --- Hi Petr, I tried to verify information in your patch, but all links you provided are unpleasant to read and you also didn't provide bootlog, so I had to trust you that your machine comes with ALC294... Also, does it fix internal speaker only or also headphones? We need to get commit log right. Once verified, let's send v2 of this patch with your Tested-by tag and posibly Cc: stable. Thank you. sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)