| Message ID | 1556369542-13247-2-git-send-email-info@metux.net (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [01/41] drivers: tty: serial: dz: use dev_err() instead of printk() | expand |
On Sat, Apr 27, 2019 at 02:51:42PM +0200, Enrico Weigelt, metux IT consult wrote: > Using dev_err() instead of printk() for more consistent output. > (prints device name, etc). > > Signed-off-by: Enrico Weigelt <info@metux.net> Your "From:" line does not match the signed-off-by line, so I can't take any of these if I wanted to :( Please fix up. thanks, greg k-h
On Sat, Apr 27, 2019 at 02:51:42PM +0200, Enrico Weigelt, metux IT consult wrote: > Using dev_err() instead of printk() for more consistent output. > (prints device name, etc). > > Signed-off-by: Enrico Weigelt <info@metux.net> > --- > drivers/tty/serial/dz.c | 8 ++++---- Do you have this hardware to test any of these changes with? thanks, greg k-h
On 27.04.19 15:31, Greg KH wrote: > On Sat, Apr 27, 2019 at 02:51:42PM +0200, Enrico Weigelt, metux IT consult wrote: >> Using dev_err() instead of printk() for more consistent output. >> (prints device name, etc). >> >> Signed-off-by: Enrico Weigelt <info@metux.net> >> --- >> drivers/tty/serial/dz.c | 8 ++++---- > > Do you have this hardware to test any of these changes with? Unfortunately not :( Do you happen to know anybody who has ? --mtx
On 27.04.19 15:31, Greg KH wrote: > On Sat, Apr 27, 2019 at 02:51:42PM +0200, Enrico Weigelt, metux IT consult wrote: >> Using dev_err() instead of printk() for more consistent output. >> (prints device name, etc). >> >> Signed-off-by: Enrico Weigelt <info@metux.net> >> --- >> drivers/tty/serial/dz.c | 8 ++++---- > > Do you have this hardware to test any of these changes with? Unfortunately not :( --mtx
On Mon, Apr 29, 2019 at 02:37:04PM +0200, Enrico Weigelt, metux IT consult wrote: > On 27.04.19 15:31, Greg KH wrote: > > On Sat, Apr 27, 2019 at 02:51:42PM +0200, Enrico Weigelt, metux IT consult wrote: > >> Using dev_err() instead of printk() for more consistent output. > >> (prints device name, etc). > >> > >> Signed-off-by: Enrico Weigelt <info@metux.net> > >> --- > >> drivers/tty/serial/dz.c | 8 ++++---- > > > > Do you have this hardware to test any of these changes with? > > Unfortunately not :( Then I can take the "basic" types of patches for the driver (like this one), but not any others, sorry. thanks, greg k-h
On 27.04.19 15:29, Greg KH wrote: > On Sat, Apr 27, 2019 at 02:51:42PM +0200, Enrico Weigelt, metux IT consult wrote: >> Using dev_err() instead of printk() for more consistent output. >> (prints device name, etc). >> >> Signed-off-by: Enrico Weigelt <info@metux.net> > > Your "From:" line does not match the signed-off-by line, so I can't take > any of these if I wanted to :( Grmpf. I've manually changed it, as you isisted in having my company name remove from it .... --mtx
On Mon, Apr 29, 2019 at 04:11:15PM +0200, Enrico Weigelt, metux IT consult wrote: > On 27.04.19 15:29, Greg KH wrote: > > On Sat, Apr 27, 2019 at 02:51:42PM +0200, Enrico Weigelt, metux IT consult wrote: > >> Using dev_err() instead of printk() for more consistent output. > >> (prints device name, etc). > >> > >> Signed-off-by: Enrico Weigelt <info@metux.net> > > > > Your "From:" line does not match the signed-off-by line, so I can't take > > any of these if I wanted to :( > > Grmpf. I've manually changed it, as you isisted in having my company > name remove from it .... Yes, that's fine, but the lines have to match. See the documentation for how to have a "From:" in the changelog text to override whatever your email client happens to pollute the email with :) thanks, greg k-h
On Mon, 29 Apr 2019, Greg KH wrote: > > >> drivers/tty/serial/dz.c | 8 ++++---- > > > > > > Do you have this hardware to test any of these changes with? > > > > Unfortunately not :( > > Then I can take the "basic" types of patches for the driver (like this > one), but not any others, sorry. I can verify changes to dz.c, sb1250-duart.c and zs.c with real hardware, but regrettably not right away: the hardware is in a remote location and while I have it wired for remote operation unfortunately its connectivity has been cut off by an unfriendly ISP. I'm not sure if all the changes make sense though: if there is a compiler warning or a usability issue, then a patch is surely welcome, otherwise: "If it ain't broke, don't fix it". Maciej
diff --git a/drivers/tty/serial/dz.c b/drivers/tty/serial/dz.c index 7b57e84..96e35af 100644 --- a/drivers/tty/serial/dz.c +++ b/drivers/tty/serial/dz.c @@ -416,7 +416,7 @@ static int dz_startup(struct uart_port *uport) IRQF_SHARED, "dz", mux); if (ret) { atomic_add(-1, &mux->irq_guard); - printk(KERN_ERR "dz: Cannot get IRQ %d!\n", dport->port.irq); + dev_err(uport->dev, "Cannot get IRQ %d!\n", dport->port.irq); return ret; } @@ -680,7 +680,7 @@ static int dz_map_port(struct uart_port *uport) uport->membase = ioremap_nocache(uport->mapbase, dec_kn_slot_size); if (!uport->membase) { - printk(KERN_ERR "dz: Cannot map MMIO\n"); + dev_err(uport->dev, "Cannot map MMIO\n"); return -ENOMEM; } return 0; @@ -697,8 +697,8 @@ static int dz_request_port(struct uart_port *uport) if (!request_mem_region(uport->mapbase, dec_kn_slot_size, "dz")) { atomic_add(-1, &mux->map_guard); - printk(KERN_ERR - "dz: Unable to reserve MMIO resource\n"); + dev_err(uport->dev, + "Unable to reserve MMIO resource\n"); return -EBUSY; } }
Using dev_err() instead of printk() for more consistent output. (prints device name, etc). Signed-off-by: Enrico Weigelt <info@metux.net> --- drivers/tty/serial/dz.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)