| Message ID | 20190417214443.243152-1-bvanassche@acm.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | qla2xxx source code cleanup and bug fixes | expand |
On Wed, 2019-04-17 at 14:44 -0700, Bart Van Assche wrote: > This patch series includes source code cleanup patches and also several bug > fixes. These patches are the result of manual code inspection, static source > code analysis and testing with lockdep and KASAN enabled. Please consider this > patch series for kernel v5.2. Hi Himanshu, Do you want to share any feedback about this patch series? Thanks, Bart.
Hi Bart,
Still reviewing it. About half way done. Will ACK if no issues found during testing.
Thanks,
Himanshu
On 4/25/19, 3:04 PM, "linux-scsi-owner@vger.kernel.org on behalf of Bart Van Assche" <linux-scsi-owner@vger.kernel.org on behalf of bvanassche@acm.org> wrote:
On Wed, 2019-04-17 at 14:44 -0700, Bart Van Assche wrote:
> This patch series includes source code cleanup patches and also several bug
> fixes. These patches are the result of manual code inspection, static source
> code analysis and testing with lockdep and KASAN enabled. Please consider this
> patch series for kernel v5.2.
Hi Himanshu,
Do you want to share any feedback about this patch series?
Thanks,
Bart.
Himanshu, > Still reviewing it. About half way done. Will ACK if no issues found > during testing. Gentle poke. There are just a couple of days left before the merge window and we'll need some -next/0-day coverage.
Hi Martin, Please add for the series, Acked-by: Himanshu Madhani <hmadhani@marvell.com> On 4/29/19, 10:59 AM, "linux-scsi-owner@vger.kernel.org on behalf of Martin K. Petersen" <linux-scsi-owner@vger.kernel.org on behalf of martin.petersen@oracle.com> wrote: Himanshu, > Still reviewing it. About half way done. Will ACK if no issues found > during testing. Gentle poke. There are just a couple of days left before the merge window and we'll need some -next/0-day coverage. -- Martin K. Petersen Oracle Linux Engineering Thanks, Himanshu
Bart, > This patch series includes source code cleanup patches and also > several bug fixes. These patches are the result of manual code > inspection, static source code analysis and testing with lockdep and > KASAN enabled. Please consider this patch series for kernel v5.2. Applied to 5.2/scsi-queue, thank you!
Hi Martin, This patch series includes source code cleanup patches and also several bug fixes. These patches are the result of manual code inspection, static source code analysis and testing with lockdep and KASAN enabled. Please consider this patch series for kernel v5.2. Thanks, Bart. Bart Van Assche (34): qla2xxx: Update two source code comments qla2xxx: Fix a format specifier qla2xxx: Move qla2x00_set_reserved_loop_ids() definition qla2xxx: Declare qla2x00_find_new_loop_id() static qla2xxx: Remove a set-but-not-used variable qla2xxx: Move qla2x00_clear_loop_id() from qla_inline.h into qla_init.c qla2xxx: Move qla2x00_is_reserved_id() from qla_inline.h into qla_init.c qla2xxx: Uninline qla2x00_init_timer() qla2xxx: Remove the fcport test from qla_nvme_abort_work() qla2xxx: Avoid that Coverity complains about dereferencing a NULL rport pointer qla2xxx: Log the status code if a firmware command fails qla2xxx: Increase the size of the mailbox arrays from 4 to 8 qla2xxx: Make qla2x00_mem_free() easier to verify qla2xxx: Avoid that qla2x00_mem_free() crashes if called twice qla2xxx: Fix a qla24xx_enable_msix() error path qla2xxx: Fix use-after-free issues in qla2xxx_qpair_sp_free_dma() qla2xxx: Simplify qlt_send_term_imm_notif() qla2xxx: Fix error handling in qlt_alloc_qfull_cmd() qla2xxx: Fix abort handling in tcm_qla2xxx_write_pending() qla2xxx, target: Fix offline port handling and host reset handling qla2xxx: Complain if a command is released that is owned by the firmware qla2xxx: Remove qla_tgt_cmd.released qla2xxx: Remove unnecessary locking from the target code qla2xxx: Make qla24xx_async_abort_cmd() static qla2xxx: Use an on-stack completion in qla24xx_control_vp() qla2xxx: Fix race conditions in the code for aborting SCSI commands qla2xxx: Pass little-endian values to the firmware qla2xxx: Check the size of firmware data structures at compile time qla2xxx: Introduce the dsd32 and dsd64 data structures qla2xxx: Use __le64 instead of uint32_t[2] for sending DMA addresses to firmware qla2xxx: Complain loudly about reference count underflow qla2xxx: Fix hardirq-unsafe locking qla2xxx: Avoid that qlt_send_resp_ctio() corrupts memory qla2xxx: Avoid that lockdep complains about unsafe locking in tcm_qla2xxx_close_session() drivers/scsi/qla2xxx/qla_bsg.c | 10 +- drivers/scsi/qla2xxx/qla_def.h | 67 ++---- drivers/scsi/qla2xxx/qla_dsd.h | 30 +++ drivers/scsi/qla2xxx/qla_fw.h | 67 +++--- drivers/scsi/qla2xxx/qla_gbl.h | 11 +- drivers/scsi/qla2xxx/qla_gs.c | 47 ++--- drivers/scsi/qla2xxx/qla_init.c | 279 +++++++++++++------------ drivers/scsi/qla2xxx/qla_inline.h | 49 ----- drivers/scsi/qla2xxx/qla_iocb.c | 316 +++++++++++----------------- drivers/scsi/qla2xxx/qla_isr.c | 10 +- drivers/scsi/qla2xxx/qla_mbx.c | 4 +- drivers/scsi/qla2xxx/qla_mid.c | 9 +- drivers/scsi/qla2xxx/qla_mr.c | 63 ++---- drivers/scsi/qla2xxx/qla_mr.h | 11 +- drivers/scsi/qla2xxx/qla_nvme.c | 74 ++----- drivers/scsi/qla2xxx/qla_nvme.h | 14 +- drivers/scsi/qla2xxx/qla_nx.c | 12 +- drivers/scsi/qla2xxx/qla_nx2.c | 2 +- drivers/scsi/qla2xxx/qla_os.c | 323 +++++++++++++---------------- drivers/scsi/qla2xxx/qla_target.c | 165 ++++----------- drivers/scsi/qla2xxx/qla_target.h | 29 ++- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 50 ++--- 22 files changed, 662 insertions(+), 980 deletions(-) create mode 100644 drivers/scsi/qla2xxx/qla_dsd.h