| Message ID | 20190422082836.3734-6-shawnguo@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [GIT,PULL,1/6] i.MX drivers change for 5.2 | expand |
On Mon, Apr 22, 2019 at 04:28:36PM +0800, Shawn Guo wrote: > The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: > > Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git tags/imx-defconfig-5.2 > > for you to fetch changes up to a3f12aac21848796f5b5c6e9ce2f04e411ec2129: > > arm64: defconfig: NVMEM_IMX_OCOTP=y for imx8m (2019-04-22 10:33:53 +0800) > > ---------------------------------------------------------------- > i.MX defconfig update for 5.2: > - Enable PCF857X GPIO expander and SIOX bus driver support for > imx_v6_v7_defconfig. > - Enable more drivers for i.MX8 platform support in arm64 defconfig: > SNVS RTC, SCU Watchdog, SPI, i.MX8MM pinctrl and clock, LPI2C, > ROHM_BD718XX PMIC and OCOTP NVMEM. All of these are enabled as =y. I don't think all of them are critical for booting the system up to a rootfs. Can you please switch over any non-critical drivers to =m? (Not merged) Thanks! -Olof
On Mon, Apr 29, 2019 at 09:29:10AM -0700, Olof Johansson wrote: > On Mon, Apr 22, 2019 at 04:28:36PM +0800, Shawn Guo wrote: > > The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: > > > > Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git tags/imx-defconfig-5.2 > > > > for you to fetch changes up to a3f12aac21848796f5b5c6e9ce2f04e411ec2129: > > > > arm64: defconfig: NVMEM_IMX_OCOTP=y for imx8m (2019-04-22 10:33:53 +0800) > > > > ---------------------------------------------------------------- > > i.MX defconfig update for 5.2: > > - Enable PCF857X GPIO expander and SIOX bus driver support for > > imx_v6_v7_defconfig. > > - Enable more drivers for i.MX8 platform support in arm64 defconfig: > > SNVS RTC, SCU Watchdog, SPI, i.MX8MM pinctrl and clock, LPI2C, > > ROHM_BD718XX PMIC and OCOTP NVMEM. > > All of these are enabled as =y. I don't think all of them are critical for > booting the system up to a rootfs. Can you please switch over any non-critical > drivers to =m? Okay, let's check them one by one. - CONFIG_SPI_IMX=y @Fabio, do you have a critical use case for this to be 'y'? Or can we change this to 'm'? - CONFIG_RTC_DRV_SNVS=y @Abel, I guess this can be 'm'? Or you have a good reason for this to be 'y'? - CONFIG_PINCTRL_IMX8MM=y, CONFIG_CLK_IMX8MM=y @Olof, I think we shouldn't have problem to have pinctrl and clock driver to be 'y', as they are pretty fundamental for a platform support. - CONFIG_GPIO_MAX732X=y @Olof, this is essentially a GPIO controller, just like CONFIG_GPIO_PCA953X=y currently sitting in defconfig. - CONFIG_I2C_IMX_LPI2C=y @Olof, this is a driver for I2C bus controller which is used for many I2C devices, and above GPIO expander is one example. So we would treat it as fundamental one. - CONFIG_MFD_ROHM_BD718XX=y, CONFIG_REGULATOR_BD718XX=y @Leonard, are they critical for booting imx8mm-evk board up? Or can they be installed as module after system is up? - CONFIG_NVMEM_IMX_OCOTP=y @Olof, this is the driver for fuse access on i.MX platform. Drivers like cpufreq will need to access fuse for cpu grade data. So we would take this driver as fundamental infrastructural. Shawn > > (Not merged)
On Mon, Apr 29, 2019 at 11:27 PM Shawn Guo <shawnguo@kernel.org> wrote: > Okay, let's check them one by one. > > - CONFIG_SPI_IMX=y > > @Fabio, do you have a critical use case for this to be 'y'? Or can we > change this to 'm'? Yes, we can change it to be a module.
On 4/30/2019 5:27 AM, Shawn Guo wrote: > On Mon, Apr 29, 2019 at 09:29:10AM -0700, Olof Johansson wrote: >> On Mon, Apr 22, 2019 at 04:28:36PM +0800, Shawn Guo wrote: >>> The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: >>> >>> Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) >>> >>> are available in the Git repository at: >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git tags/imx-defconfig-5.2 >>> >>> for you to fetch changes up to a3f12aac21848796f5b5c6e9ce2f04e411ec2129: >>> >>> arm64: defconfig: NVMEM_IMX_OCOTP=y for imx8m (2019-04-22 10:33:53 +0800) >>> >>> ---------------------------------------------------------------- >>> i.MX defconfig update for 5.2: >>> - Enable PCF857X GPIO expander and SIOX bus driver support for >>> imx_v6_v7_defconfig. >>> - Enable more drivers for i.MX8 platform support in arm64 defconfig: >>> SNVS RTC, SCU Watchdog, SPI, i.MX8MM pinctrl and clock, LPI2C, >>> ROHM_BD718XX PMIC and OCOTP NVMEM. >> >> All of these are enabled as =y. I don't think all of them are critical for >> booting the system up to a rootfs. Can you please switch over any non-critical >> drivers to =m? > - CONFIG_MFD_ROHM_BD718XX=y, CONFIG_REGULATOR_BD718XX=y > > @Leonard, are they critical for booting imx8mm-evk board up? Or can > they be installed as module after system is up? This is the PMIC used on imx8mm-evk and also the purism devkit. Since it's used for main chip power "y" makes sense but boards can boot without it and I can't think of a corner case where we could fail to reach rootfs because of no PMIC driver. Looking through arm64 defconfig other PMIC regulators seem to be "y" > - CONFIG_GPIO_MAX732X=y > - CONFIG_I2C_IMX_LPI2C=y Other I2C/GPIO drivers are "y" but again can't point to anything specific that would fail. > - CONFIG_NVMEM_IMX_OCOTP=y > > @Olof, this is the driver for fuse access on i.MX platform. Drivers > like cpufreq will need to access fuse for cpu grade data. So we would > take this driver as fundamental infrastructural. Other than thermal and speed grading fuses also contain MAC address on imx chips. Since FEC (imx ethernet controller) is "y" for easy netboots it makes a lot of sense to keep this "y" as well. These are all relatively small drivers. I don't think that RTC drivers are worth excluding either. -- Regards, Leonard
On Tue, Apr 30, 2019 at 09:18:18PM +0000, Leonard Crestez wrote: > On 4/30/2019 5:27 AM, Shawn Guo wrote: > > On Mon, Apr 29, 2019 at 09:29:10AM -0700, Olof Johansson wrote: > >> On Mon, Apr 22, 2019 at 04:28:36PM +0800, Shawn Guo wrote: > >>> The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: > >>> > >>> Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) > >>> > >>> are available in the Git repository at: > >>> > >>> git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git tags/imx-defconfig-5.2 > >>> > >>> for you to fetch changes up to a3f12aac21848796f5b5c6e9ce2f04e411ec2129: > >>> > >>> arm64: defconfig: NVMEM_IMX_OCOTP=y for imx8m (2019-04-22 10:33:53 +0800) > >>> > >>> ---------------------------------------------------------------- > >>> i.MX defconfig update for 5.2: > >>> - Enable PCF857X GPIO expander and SIOX bus driver support for > >>> imx_v6_v7_defconfig. > >>> - Enable more drivers for i.MX8 platform support in arm64 defconfig: > >>> SNVS RTC, SCU Watchdog, SPI, i.MX8MM pinctrl and clock, LPI2C, > >>> ROHM_BD718XX PMIC and OCOTP NVMEM. > >> > >> All of these are enabled as =y. I don't think all of them are critical for > >> booting the system up to a rootfs. Can you please switch over any non-critical > >> drivers to =m? > > > - CONFIG_MFD_ROHM_BD718XX=y, CONFIG_REGULATOR_BD718XX=y > > > > @Leonard, are they critical for booting imx8mm-evk board up? Or can > > they be installed as module after system is up? > > This is the PMIC used on imx8mm-evk and also the purism devkit. Since > it's used for main chip power "y" makes sense but boards can boot > without it and I can't think of a corner case where we could fail to > reach rootfs because of no PMIC driver. > > Looking through arm64 defconfig other PMIC regulators seem to be "y" Okay. > > > - CONFIG_GPIO_MAX732X=y > > - CONFIG_I2C_IMX_LPI2C=y > > Other I2C/GPIO drivers are "y" but again can't point to anything > specific that would fail. I understand that the rootfs in Olof's context might be ramdisk, and missing GPIO driver shouldn't be a problem. However, I really would like build a kernel image out of defconfig that can run into rootfs on SD/MMC or NFS, which would be much more useful. In that case, drivers like GPIO should be required. > > > - CONFIG_NVMEM_IMX_OCOTP=y > > > > @Olof, this is the driver for fuse access on i.MX platform. Drivers > > like cpufreq will need to access fuse for cpu grade data. So we would > > take this driver as fundamental infrastructural. > > Other than thermal and speed grading fuses also contain MAC address on > imx chips. Since FEC (imx ethernet controller) is "y" for easy netboots > it makes a lot of sense to keep this "y" as well. Agreed. > > These are all relatively small drivers. I don't think that RTC drivers > are worth excluding either. I don't think that is a good argument. The need of being 'y' is based on necessity rather than driver size. arm-soc folks are maintaining one single defconfig for all arm64 platforms. There could be hundreds of such small drivers to be 'y' for no good reason. Shawn
On 01.05.2019 03:42, Shawn Guo wrote: > On Tue, Apr 30, 2019 at 09:18:18PM +0000, Leonard Crestez wrote: >> On 4/30/2019 5:27 AM, Shawn Guo wrote: >>> On Mon, Apr 29, 2019 at 09:29:10AM -0700, Olof Johansson wrote: >>>> On Mon, Apr 22, 2019 at 04:28:36PM +0800, Shawn Guo wrote: >>>>> The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: >>>>> >>>>> Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) >>>>> >>>>> are available in the Git repository at: >>>>> >>>>> git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git tags/imx-defconfig-5.2 >>>>> >>>>> for you to fetch changes up to a3f12aac21848796f5b5c6e9ce2f04e411ec2129: >>>>> >>>>> arm64: defconfig: NVMEM_IMX_OCOTP=y for imx8m (2019-04-22 10:33:53 +0800) >>>>> >>>>> ---------------------------------------------------------------- >>>>> i.MX defconfig update for 5.2: >>>>> - Enable PCF857X GPIO expander and SIOX bus driver support for >>>>> imx_v6_v7_defconfig. >>>>> - Enable more drivers for i.MX8 platform support in arm64 defconfig: >>>>> SNVS RTC, SCU Watchdog, SPI, i.MX8MM pinctrl and clock, LPI2C, >>>>> ROHM_BD718XX PMIC and OCOTP NVMEM. >>>> >>>> All of these are enabled as =y. I don't think all of them are critical for >>>> booting the system up to a rootfs. Can you please switch over any non-critical >>>> drivers to =m? >> > - CONFIG_GPIO_MAX732X=y >> > - CONFIG_I2C_IMX_LPI2C=y >> >> Other I2C/GPIO drivers are "y" but again can't point to anything >> specific that would fail. > > I understand that the rootfs in Olof's context might be ramdisk, and > missing GPIO driver shouldn't be a problem. However, I really would > like build a kernel image out of defconfig that can run into rootfs on > SD/MMC or NFS, which would be much more useful. In that case, drivers > like GPIO should be required. Indeed, some boards might use i2c gpio expanders to reset SD/MCC or ethernet phys; tracking down exactly which i2c gpio expanders are used in this way in order to fix boot issues wouldn't be fun. -- Regards, Leonard
Hi Olof, On Mon, Apr 29, 2019 at 09:29:10AM -0700, Olof Johansson wrote: > On Mon, Apr 22, 2019 at 04:28:36PM +0800, Shawn Guo wrote: > > The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: > > > > Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git tags/imx-defconfig-5.2 > > > > for you to fetch changes up to a3f12aac21848796f5b5c6e9ce2f04e411ec2129: > > > > arm64: defconfig: NVMEM_IMX_OCOTP=y for imx8m (2019-04-22 10:33:53 +0800) > > > > ---------------------------------------------------------------- > > i.MX defconfig update for 5.2: > > - Enable PCF857X GPIO expander and SIOX bus driver support for > > imx_v6_v7_defconfig. > > - Enable more drivers for i.MX8 platform support in arm64 defconfig: > > SNVS RTC, SCU Watchdog, SPI, i.MX8MM pinctrl and clock, LPI2C, > > ROHM_BD718XX PMIC and OCOTP NVMEM. > > All of these are enabled as =y. I don't think all of them are critical for > booting the system up to a rootfs. Can you please switch over any non-critical > drivers to =m? > > (Not merged) I updated the tag with CONFIG_SPI_IMX and CONFIG_RTC_DRV_SNVS being changed to 'm'. Please consider to pull, thanks. Shawn The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git tags/imx-defconfig-5.2 for you to fetch changes up to 4aaa1c7a05db51e0f1b6ac41ce6e76f6b0125389: arm64: defconfig: NVMEM_IMX_OCOTP=y for imx8m (2019-05-04 21:17:57 +0800) ---------------------------------------------------------------- i.MX defconfig update for 5.2: - Enable PCF857X GPIO expander and SIOX bus driver support for imx_v6_v7_defconfig. - Enable more drivers for i.MX8 platform support in arm64 defconfig: SNVS RTC, SCU Watchdog, SPI, i.MX8MM pinctrl and clock, LPI2C, ROHM_BD718XX PMIC and OCOTP NVMEM. ---------------------------------------------------------------- Abel Vesa (1): arm64: defconfig: Enable RTC_DRV_SNVS Adam Ford (1): ARM: imx_v6_v7_defconfig: Add GPIO_PCF857X Anson Huang (1): arm64: defconfig: add support for i.MX system controller watchdog Fabio Estevam (1): arm64: defconfig: Enable CONFIG_SPI_IMX Leonard Crestez (4): arm64: defconfig: Enable imx8mm clk/pinctrl arm64: defconfig: Enable lpi2c for imx8qxp and sensors arm64: defconfig: Enable ROHM_BD718XX PMIC for imx8mm-evk arm64: defconfig: NVMEM_IMX_OCOTP=y for imx8m Uwe Kleine-König (1): ARM: imx_v6_v7_defconfig: Enable SIOX bus arch/arm/configs/imx_v6_v7_defconfig | 4 ++++ arch/arm64/configs/defconfig | 12 ++++++++++++ 2 files changed, 16 insertions(+)
The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git tags/imx-defconfig-5.2 for you to fetch changes up to a3f12aac21848796f5b5c6e9ce2f04e411ec2129: arm64: defconfig: NVMEM_IMX_OCOTP=y for imx8m (2019-04-22 10:33:53 +0800) ---------------------------------------------------------------- i.MX defconfig update for 5.2: - Enable PCF857X GPIO expander and SIOX bus driver support for imx_v6_v7_defconfig. - Enable more drivers for i.MX8 platform support in arm64 defconfig: SNVS RTC, SCU Watchdog, SPI, i.MX8MM pinctrl and clock, LPI2C, ROHM_BD718XX PMIC and OCOTP NVMEM. ---------------------------------------------------------------- Abel Vesa (1): arm64: defconfig: Enable RTC_DRV_SNVS Adam Ford (1): ARM: imx_v6_v7_defconfig: Add GPIO_PCF857X Anson Huang (1): arm64: defconfig: add support for i.MX system controller watchdog Fabio Estevam (1): arm64: defconfig: Enable CONFIG_SPI_IMX Leonard Crestez (4): arm64: defconfig: Enable imx8mm clk/pinctrl arm64: defconfig: Enable lpi2c for imx8qxp and sensors arm64: defconfig: Enable ROHM_BD718XX PMIC for imx8mm-evk arm64: defconfig: NVMEM_IMX_OCOTP=y for imx8m Uwe Kleine-König (1): ARM: imx_v6_v7_defconfig: Enable SIOX bus arch/arm/configs/imx_v6_v7_defconfig | 4 ++++ arch/arm64/configs/defconfig | 12 ++++++++++++ 2 files changed, 16 insertions(+)