Message ID | 20190428155451.15653-1-thuth@redhat.com (mailing list archive) |
---|---|
Headers | show |
Series | tests/qemu-iotests: Run basic iotests during "make check" | expand |
Patchew URL: https://patchew.org/QEMU/20190428155451.15653-1-thuth@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190428155451.15653-1-thuth@redhat.com Subject: [Qemu-devel] [PATCH v2 0/8] tests/qemu-iotests: Run basic iotests during "make check" === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190428155451.15653-1-thuth@redhat.com -> patchew/20190428155451.15653-1-thuth@redhat.com Switched to a new branch 'test' 7bb09e08a3 tests: Run the iotests during "make check" again 3d905a091e tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run 565003ac8a tests/qemu-iotests: Remove the "_supported_os Linux" line from many tests fb27dba3d9 cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD 02ac8a4bf6 tests/qemu-iotests: Do not hard-code the path to bash 34c6a891ea tests/qemu-iotests/check: Pick a default machine if necessary d091edf7c1 tests/qemu-iotests/005: Add a sanity check for large sparse file support 3cf4caa193 tests/qemu-iotests: Fix output of qemu-io related tests === OUTPUT BEGIN === 1/8 Checking commit 3cf4caa193cc (tests/qemu-iotests: Fix output of qemu-io related tests) 2/8 Checking commit d091edf7c1ef (tests/qemu-iotests/005: Add a sanity check for large sparse file support) 3/8 Checking commit 34c6a891ea6e (tests/qemu-iotests/check: Pick a default machine if necessary) 4/8 Checking commit 02ac8a4bf608 (tests/qemu-iotests: Do not hard-code the path to bash) 5/8 Checking commit fb27dba3d9f0 (cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD) 6/8 Checking commit 565003ac8a70 (tests/qemu-iotests: Remove the "_supported_os Linux" line from many tests) 7/8 Checking commit 3d905a091e64 (tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run) ERROR: trailing whitespace #125: FILE: tests/qemu-iotests/group:115: +093 $ total: 1 errors, 0 warnings, 294 lines checked Patch 7/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/8 Checking commit 7bb09e08a3b1 (tests: Run the iotests during "make check" again) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #126: deleted file mode 100755 total: 0 errors, 1 warnings, 85 lines checked Patch 8/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190428155451.15653-1-thuth@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190428155451.15653-1-thuth@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 === TEST SCRIPT END === The full log is available at http://patchew.org/logs/20190428155451.15653-1-thuth@redhat.com/testing.asan/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 28/04/2019 18.10, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190428155451.15653-1-thuth@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20190428155451.15653-1-thuth@redhat.com > Subject: [Qemu-devel] [PATCH v2 0/8] tests/qemu-iotests: Run basic iotests during "make check" > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] patchew/20190428155451.15653-1-thuth@redhat.com -> patchew/20190428155451.15653-1-thuth@redhat.com > Switched to a new branch 'test' > 7bb09e08a3 tests: Run the iotests during "make check" again > 3d905a091e tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run > 565003ac8a tests/qemu-iotests: Remove the "_supported_os Linux" line from many tests > fb27dba3d9 cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD > 02ac8a4bf6 tests/qemu-iotests: Do not hard-code the path to bash > 34c6a891ea tests/qemu-iotests/check: Pick a default machine if necessary > d091edf7c1 tests/qemu-iotests/005: Add a sanity check for large sparse file support > 3cf4caa193 tests/qemu-iotests: Fix output of qemu-io related tests > > === OUTPUT BEGIN === > 1/8 Checking commit 3cf4caa193cc (tests/qemu-iotests: Fix output of qemu-io related tests) > 2/8 Checking commit d091edf7c1ef (tests/qemu-iotests/005: Add a sanity check for large sparse file support) > 3/8 Checking commit 34c6a891ea6e (tests/qemu-iotests/check: Pick a default machine if necessary) > 4/8 Checking commit 02ac8a4bf608 (tests/qemu-iotests: Do not hard-code the path to bash) > 5/8 Checking commit fb27dba3d9f0 (cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD) > 6/8 Checking commit 565003ac8a70 (tests/qemu-iotests: Remove the "_supported_os Linux" line from many tests) > 7/8 Checking commit 3d905a091e64 (tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run) > ERROR: trailing whitespace > #125: FILE: tests/qemu-iotests/group:115: > +093 $ Not an error: The trailing whitespace is currently required for the parsing code in the "check" script. Thomas
On 29/04/2019 05.47, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190428155451.15653-1-thuth@redhat.com/ > > This series failed the asan build test. Please find the testing commands and > their output below. If you have Docker installed, you can probably reproduce it > locally. > > === TEST SCRIPT BEGIN === > #!/bin/bash > time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 > === TEST SCRIPT END === > > The full log is available at > http://patchew.org/logs/20190428155451.15653-1-thuth@redhat.com/testing.asan/?type=message. The asan test failed since it could not check out the repository ... a networking problem? Anyway, looks like there was a real bug here: https://patchew.org/logs/20190428155451.15653-1-thuth@redhat.com/testing.docker-clang@ubuntu/?type=message Test 162 failed with: 162 - output mismatch (see 162.out.bad) --- /tmp/qemu-test/src/tests/qemu-iotests/162.out 2019-04-28 16:09:31.000000000 +0000 +++ /tmp/qemu-test/build/tests/qemu-iotests/162.out.bad 2019-04-28 16:24:21.669646149 +0000 @@ -6,7 +6,9 @@ image: nbd+unix://?socket=42 === SSH === +qemu-img: warning: GLib: getpwuid_r(): failed due to unknown user id (1003) qemu-img: Could not open 'json:{"driver": "ssh", "host": "localhost", "port": "0", "path": "/foo"}': Failed to connect socket: Connection refused +qemu-img: warning: GLib: getpwuid_r(): failed due to unknown user id (1003) qemu-img: Could not open 'driver=ssh,host=localhost,port=0,path=/foo': Failed to connect socket: Connection refused qemu-img: Could not open 'json:{"driver": "ssh", "host": "localhost", "port": 0.42, "path": "/foo"}': Parameter 'port' expects a number qemu-img: Could not open 'driver=ssh,host=localhost,port=0.42,path=/foo': Parameter 'port' expects a number ... I think I'll remove 162 from the "auto" group to avoid this. Thomas
Thomas Huth <thuth@redhat.com> writes: > People often forget to run the iotests before submitting patches or > pull requests - this is likely due to the fact that we do not run the > tests during our mandatory "make check" tests yet. > This patch series now changes the "auto" group to only include tests > that should be safe to run in all CI environments (including FreeBSD > and macOS!). Thus these iotests can now always be run during "make > check" automatically, too. Assuming my local tests work I think I should queue these and submit a PR right away. Sorry about the delay getting to them. > > v2: > - Use "auto" group instead of adding a new "ci" group > - Adjusted the tests that are run automatically (after doing lots > of CI runs on cirrus-ci.com, gitlab and travis) > - Added patch to fix the current regression with the "qemu-io:" > prefix in the master branch > - Added a fix for iotest 005 on ext4 filesystems (skip it there) > > Thomas Huth (8): > tests/qemu-iotests: Fix output of qemu-io related tests > tests/qemu-iotests/005: Add a sanity check for large sparse file > support > tests/qemu-iotests/check: Pick a default machine if necessary > tests/qemu-iotests: Do not hard-code the path to bash > cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD > tests/qemu-iotests: Remove the "_supported_os Linux" line from many > tests > tests/qemu-iotests/group: Re-use the "auto" group for tests that can > always run > tests: Run the iotests during "make check" again > > .cirrus.yml | 4 +- > .travis.yml | 1 + > tests/Makefile.include | 8 +- > tests/check-block.sh | 44 +++++++--- > tests/qemu-iotests-quick.sh | 8 -- > tests/qemu-iotests/001 | 1 - > tests/qemu-iotests/002 | 1 - > tests/qemu-iotests/003 | 1 - > tests/qemu-iotests/004 | 1 - > tests/qemu-iotests/005 | 9 ++ > tests/qemu-iotests/007 | 1 - > tests/qemu-iotests/008 | 1 - > tests/qemu-iotests/009 | 1 - > tests/qemu-iotests/010 | 1 - > tests/qemu-iotests/011 | 1 - > tests/qemu-iotests/012 | 1 - > tests/qemu-iotests/015 | 1 - > tests/qemu-iotests/017 | 1 - > tests/qemu-iotests/020 | 1 - > tests/qemu-iotests/021 | 1 - > tests/qemu-iotests/022 | 1 - > tests/qemu-iotests/025 | 1 - > tests/qemu-iotests/026 | 1 - > tests/qemu-iotests/026.out | 168 +++++++++++++++++------------------ > tests/qemu-iotests/027 | 1 - > tests/qemu-iotests/029 | 1 - > tests/qemu-iotests/031 | 1 - > tests/qemu-iotests/032 | 1 - > tests/qemu-iotests/033 | 1 - > tests/qemu-iotests/035 | 1 - > tests/qemu-iotests/036 | 1 - > tests/qemu-iotests/037 | 1 - > tests/qemu-iotests/042 | 1 - > tests/qemu-iotests/043 | 1 - > tests/qemu-iotests/046 | 1 - > tests/qemu-iotests/047 | 1 - > tests/qemu-iotests/049 | 1 - > tests/qemu-iotests/050 | 1 - > tests/qemu-iotests/051 | 1 - > tests/qemu-iotests/052 | 1 - > tests/qemu-iotests/053 | 1 - > tests/qemu-iotests/054 | 1 - > tests/qemu-iotests/060.out | 6 +- > tests/qemu-iotests/062 | 1 - > tests/qemu-iotests/063 | 1 - > tests/qemu-iotests/066 | 1 - > tests/qemu-iotests/067 | 1 - > tests/qemu-iotests/068 | 1 - > tests/qemu-iotests/069 | 1 - > tests/qemu-iotests/069.out | 2 +- > tests/qemu-iotests/070.out | 2 +- > tests/qemu-iotests/071 | 1 - > tests/qemu-iotests/072 | 1 - > tests/qemu-iotests/073 | 1 - > tests/qemu-iotests/075.out | 14 +-- > tests/qemu-iotests/076.out | 6 +- > tests/qemu-iotests/078.out | 12 +-- > tests/qemu-iotests/079 | 1 - > tests/qemu-iotests/080.out | 40 ++++----- > tests/qemu-iotests/081.out | 2 +- > tests/qemu-iotests/082 | 1 - > tests/qemu-iotests/085 | 1 - > tests/qemu-iotests/088.out | 12 +-- > tests/qemu-iotests/089 | 1 - > tests/qemu-iotests/090 | 1 - > tests/qemu-iotests/094 | 1 - > tests/qemu-iotests/095 | 1 - > tests/qemu-iotests/098 | 1 - > tests/qemu-iotests/102 | 1 - > tests/qemu-iotests/103 | 1 - > tests/qemu-iotests/103.out | 14 +-- > tests/qemu-iotests/104 | 1 - > tests/qemu-iotests/105 | 1 - > tests/qemu-iotests/107 | 1 - > tests/qemu-iotests/110 | 1 - > tests/qemu-iotests/111 | 1 - > tests/qemu-iotests/112 | 1 - > tests/qemu-iotests/114 | 1 - > tests/qemu-iotests/114.out | 2 +- > tests/qemu-iotests/115 | 1 - > tests/qemu-iotests/116.out | 14 +-- > tests/qemu-iotests/117 | 1 - > tests/qemu-iotests/120 | 1 - > tests/qemu-iotests/125 | 1 - > tests/qemu-iotests/126 | 1 - > tests/qemu-iotests/127 | 1 - > tests/qemu-iotests/131.out | 2 +- > tests/qemu-iotests/133 | 1 - > tests/qemu-iotests/133.out | 30 +++---- > tests/qemu-iotests/134 | 1 - > tests/qemu-iotests/137.out | 28 +++--- > tests/qemu-iotests/140.out | 2 +- > tests/qemu-iotests/142 | 1 - > tests/qemu-iotests/143 | 1 - > tests/qemu-iotests/143.out | 2 +- > tests/qemu-iotests/144 | 1 - > tests/qemu-iotests/145 | 1 - > tests/qemu-iotests/153 | 1 - > tests/qemu-iotests/153.out | 30 +++---- > tests/qemu-iotests/156 | 1 - > tests/qemu-iotests/157 | 1 - > tests/qemu-iotests/158 | 1 - > tests/qemu-iotests/159 | 1 - > tests/qemu-iotests/162 | 1 - > tests/qemu-iotests/170 | 1 - > tests/qemu-iotests/173 | 1 - > tests/qemu-iotests/182 | 1 - > tests/qemu-iotests/183 | 1 - > tests/qemu-iotests/186 | 1 - > tests/qemu-iotests/187 | 1 - > tests/qemu-iotests/187.out | 6 +- > tests/qemu-iotests/188.out | 2 +- > tests/qemu-iotests/190 | 1 - > tests/qemu-iotests/191 | 1 - > tests/qemu-iotests/192 | 1 - > tests/qemu-iotests/195 | 1 - > tests/qemu-iotests/197 | 1 - > tests/qemu-iotests/197.out | 2 +- > tests/qemu-iotests/200 | 1 - > tests/qemu-iotests/205 | 2 +- > tests/qemu-iotests/214 | 1 - > tests/qemu-iotests/215 | 1 - > tests/qemu-iotests/215.out | 2 +- > tests/qemu-iotests/217 | 1 - > tests/qemu-iotests/226.out | 16 ++-- > tests/qemu-iotests/227 | 1 - > tests/qemu-iotests/231 | 1 - > tests/qemu-iotests/233 | 1 - > tests/qemu-iotests/239 | 2 +- > tests/qemu-iotests/240 | 3 +- > tests/qemu-iotests/241 | 2 +- > tests/qemu-iotests/243 | 2 +- > tests/qemu-iotests/244 | 2 +- > tests/qemu-iotests/244.out | 10 +-- > tests/qemu-iotests/247 | 1 - > tests/qemu-iotests/check | 13 ++- > tests/qemu-iotests/group | 169 +++++++++++++++++++----------------- > 137 files changed, 372 insertions(+), 421 deletions(-) > delete mode 100755 tests/qemu-iotests-quick.sh -- Alex Bennée
Thomas Huth <thuth@redhat.com> writes: > On 29/04/2019 05.47, no-reply@patchew.org wrote: >> Patchew URL: https://patchew.org/QEMU/20190428155451.15653-1-thuth@redhat.com/ >> >> This series failed the asan build test. Please find the testing commands and >> their output below. If you have Docker installed, you can probably reproduce it >> locally. >> >> === TEST SCRIPT BEGIN === >> #!/bin/bash >> time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 >> === TEST SCRIPT END === >> >> The full log is available at >> http://patchew.org/logs/20190428155451.15653-1-thuth@redhat.com/testing.asan/?type=message. > > The asan test failed since it could not check out the repository ... > a networking problem? > > Anyway, looks like there was a real bug here: > > https://patchew.org/logs/20190428155451.15653-1-thuth@redhat.com/testing.docker-clang@ubuntu/?type=message > > Test 162 failed with: > > 162 - output mismatch (see 162.out.bad) > --- /tmp/qemu-test/src/tests/qemu-iotests/162.out 2019-04-28 16:09:31.000000000 +0000 > +++ /tmp/qemu-test/build/tests/qemu-iotests/162.out.bad 2019-04-28 16:24:21.669646149 +0000 > @@ -6,7 +6,9 @@ > image: nbd+unix://?socket=42 > > === SSH === > +qemu-img: warning: GLib: getpwuid_r(): failed due to unknown user id (1003) > qemu-img: Could not open 'json:{"driver": "ssh", "host": "localhost", "port": "0", "path": "/foo"}': Failed to connect socket: Connection refused > +qemu-img: warning: GLib: getpwuid_r(): failed due to unknown user id (1003) > qemu-img: Could not open 'driver=ssh,host=localhost,port=0,path=/foo': Failed to connect socket: Connection refused > qemu-img: Could not open 'json:{"driver": "ssh", "host": "localhost", "port": 0.42, "path": "/foo"}': Parameter 'port' expects a number > qemu-img: Could not open 'driver=ssh,host=localhost,port=0.42,path=/foo': Parameter 'port' expects a number > > ... I think I'll remove 162 from the "auto" group to avoid this. Should I wait for a v3 then? -- Alex Bennée
On 01/05/2019 10.30, Alex Bennée wrote: > > Thomas Huth <thuth@redhat.com> writes: > >> On 29/04/2019 05.47, no-reply@patchew.org wrote: >>> Patchew URL: https://patchew.org/QEMU/20190428155451.15653-1-thuth@redhat.com/ >>> >>> This series failed the asan build test. Please find the testing commands and >>> their output below. If you have Docker installed, you can probably reproduce it >>> locally. >>> >>> === TEST SCRIPT BEGIN === >>> #!/bin/bash >>> time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 >>> === TEST SCRIPT END === >>> >>> The full log is available at >>> http://patchew.org/logs/20190428155451.15653-1-thuth@redhat.com/testing.asan/?type=message. >> >> The asan test failed since it could not check out the repository ... >> a networking problem? >> >> Anyway, looks like there was a real bug here: >> >> https://patchew.org/logs/20190428155451.15653-1-thuth@redhat.com/testing.docker-clang@ubuntu/?type=message >> >> Test 162 failed with: >> >> 162 - output mismatch (see 162.out.bad) >> --- /tmp/qemu-test/src/tests/qemu-iotests/162.out 2019-04-28 16:09:31.000000000 +0000 >> +++ /tmp/qemu-test/build/tests/qemu-iotests/162.out.bad 2019-04-28 16:24:21.669646149 +0000 >> @@ -6,7 +6,9 @@ >> image: nbd+unix://?socket=42 >> >> === SSH === >> +qemu-img: warning: GLib: getpwuid_r(): failed due to unknown user id (1003) >> qemu-img: Could not open 'json:{"driver": "ssh", "host": "localhost", "port": "0", "path": "/foo"}': Failed to connect socket: Connection refused >> +qemu-img: warning: GLib: getpwuid_r(): failed due to unknown user id (1003) >> qemu-img: Could not open 'driver=ssh,host=localhost,port=0,path=/foo': Failed to connect socket: Connection refused >> qemu-img: Could not open 'json:{"driver": "ssh", "host": "localhost", "port": 0.42, "path": "/foo"}': Parameter 'port' expects a number >> qemu-img: Could not open 'driver=ssh,host=localhost,port=0.42,path=/foo': Parameter 'port' expects a number >> >> ... I think I'll remove 162 from the "auto" group to avoid this. > > Should I wait for a v3 then? Yes, I've got to respin anyway since there is a conflict with the new iotest 249. Thomas