| Message ID | 20190501161417.32592-25-hch@lst.de (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [01/24] scsi: add SPDX tags to scsi midlayer files missing licensing information | expand |
On 5/1/19 6:14 PM, Christoph Hellwig wrote: > osst.c is the only osst file missing licensing information. Add a > GPLv2 tag for the default kernel license. > > Signed-off-by: Chriosstoph Hellwig <hch@losst.de> > --- > drivers/scsi/osst.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c > index be3c73ebbfde..fe4f0e7d6359 100644 > --- a/drivers/scsi/osst.c > +++ b/drivers/scsi/osst.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0 > /* > SCSI Tape Driver for Linux version 1.1 and newer. See the accompanying > file Documentation/scsi/st.txt for more information. > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
On Thu, May 02, 2019 at 08:06:38AM +0200, Hannes Reinecke wrote: > On 5/1/19 6:14 PM, Christoph Hellwig wrote: >> osst.c is the only osst file missing licensing information. Add a >> GPLv2 tag for the default kernel license. >> >> Signed-off-by: Chriosstoph Hellwig <hch@losst.de> FYI, my s/st/osst/ on the commit message message up my signoff, this should be: Signed-off-by: Christoph Hellwig <hch@lst.de>
On 5/2/19 2:53 PM, Christoph Hellwig wrote: > On Thu, May 02, 2019 at 08:06:38AM +0200, Hannes Reinecke wrote: >> On 5/1/19 6:14 PM, Christoph Hellwig wrote: >>> osst.c is the only osst file missing licensing information. Add a >>> GPLv2 tag for the default kernel license. >>> >>> Signed-off-by: Chriosstoph Hellwig <hch@losst.de> > > FYI, my s/st/osst/ on the commit message message up my signoff, this > should be: > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Maybe it's time to kill osst.c for good ... Cheers, Hannes
On 5/2/19 9:55 PM, Willem Riede wrote: > On Thu, May 2, 2019 at 7:19 AM Hannes Reinecke <hare@suse.de > <mailto:hare@suse.de>> wrote: > > On 5/2/19 2:53 PM, Christoph Hellwig wrote: > > On Thu, May 02, 2019 at 08:06:38AM +0200, Hannes Reinecke wrote: > >> On 5/1/19 6:14 PM, Christoph Hellwig wrote: > >>> osst.c is the only osst file missing licensing information. Add a > >>> GPLv2 tag for the default kernel license. > >>> > >>> Signed-off-by: Chriosstoph Hellwig <hch@losst.de > <mailto:hch@losst.de>> > > > > FYI, my s/st/osst/ on the commit message message up my signoff, this > > should be: > > > > Signed-off-by: Christoph Hellwig <hch@lst.de <mailto:hch@lst.de>> > > > Maybe it's time to kill osst.c for good ... > > > Yes. I've been thinking about doing just that. The devices it supports > are now thoroughly obsolete. The manufacturer has gone out of business. > All my test drives have broken down over time, so I can't even test any > changes any more. > Just when I thought to reach out to you :-) Thing is, we've done numerous changes to the 'st' driver in the course of the years, most of which seem to have avoided osst :-( So what's your suggestion here? Just drop it completely? Or can we somehow fold the OnStream-specific things back into st.c? Cheers, Hannes
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c index be3c73ebbfde..fe4f0e7d6359 100644 --- a/drivers/scsi/osst.c +++ b/drivers/scsi/osst.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* SCSI Tape Driver for Linux version 1.1 and newer. See the accompanying file Documentation/scsi/st.txt for more information.
osst.c is the only osst file missing licensing information. Add a GPLv2 tag for the default kernel license. Signed-off-by: Chriosstoph Hellwig <hch@losst.de> --- drivers/scsi/osst.c | 1 + 1 file changed, 1 insertion(+)