| Message ID | 20190506144030.29056-1-nsaenzjulienne@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | staging: vchiq: use interruptible waits | expand |
Hi Nicolas, Am 06.05.19 um 16:40 schrieb Nicolas Saenz Julienne: > Hi, > ... > > Regards, > Nicolas > > [1] https://github.com/raspberrypi/linux/issues/2881 > [2] https://archlinuxarm.org/forum/viewtopic.php?f=65&t=13485 > [3] https://lists.fedoraproject.org/archives/list/arm@lists.fedoraproject.org/message/GBXGJ7DOV5CQQXFPOZCXTRD6W4BEPT4Q/ > > -- > > Changes since v1: > - Proplery format revert commits > - Add code comment to remind of this issue > - Add Fixes tags > > Nicolas Saenz Julienne (3): > staging: vchiq_2835_arm: revert "quit using custom > down_interruptible()" > staging: vchiq: revert "switch to wait_for_completion_killable" > staging: vchiq: make wait events interruptible > > .../interface/vchiq_arm/vchiq_2835_arm.c | 2 +- > .../interface/vchiq_arm/vchiq_arm.c | 21 +++++++------ > .../interface/vchiq_arm/vchiq_core.c | 31 ++++++++++++------- > .../interface/vchiq_arm/vchiq_util.c | 6 ++-- > 4 files changed, 35 insertions(+), 25 deletions(-) > against which tree should this series apply? Since the merge window opened the current staging-linus wont be available soon. Stefan
On Mon, 2019-05-06 at 20:12 +0200, Stefan Wahren wrote: > Hi Nicolas, > > Am 06.05.19 um 16:40 schrieb Nicolas Saenz Julienne: > > Hi, > > ... > > > > Regards, > > Nicolas > > > > [1] https://github.com/raspberrypi/linux/issues/2881 > > [2] https://archlinuxarm.org/forum/viewtopic.php?f=65&t=13485 > > [3] > > https://lists.fedoraproject.org/archives/list/arm@lists.fedoraproject.org/message/GBXGJ7DOV5CQQXFPOZCXTRD6W4BEPT4Q/ > > > > -- > > > > Changes since v1: > > - Proplery format revert commits > > - Add code comment to remind of this issue > > - Add Fixes tags > > > > Nicolas Saenz Julienne (3): > > staging: vchiq_2835_arm: revert "quit using custom > > down_interruptible()" > > staging: vchiq: revert "switch to wait_for_completion_killable" > > staging: vchiq: make wait events interruptible > > > > .../interface/vchiq_arm/vchiq_2835_arm.c | 2 +- > > .../interface/vchiq_arm/vchiq_arm.c | 21 +++++++------ > > .../interface/vchiq_arm/vchiq_core.c | 31 ++++++++++++------- > > .../interface/vchiq_arm/vchiq_util.c | 6 ++-- > > 4 files changed, 35 insertions(+), 25 deletions(-) > > > against which tree should this series apply? > > Since the merge window opened the current staging-linus wont be > available soon. I don't know if that's what you meant, but I guess we should wait for 5.2-rc1 and then push it, the fixes will eventually get into the stable version of 5.1. Regards, Nicolas
Hi, this series tries to address an issue that came up in Raspbian's kernel tree [1] and upstream distros [2][3]. We adopted some changes that moved wait calls from a custom implementation to the more standard killable family of functions. Users complained that all the VCHIQ threads showed up in D state (which is the expected behaviour). The custom implementation we deleted tried to mimic the killable family of functions, yet accepted more signals than the later; SIGKILL | SIGINT | SIGQUIT | SIGTRAP | SIGSTOP | SIGCONT for the custom implementation as opposed to plain old SIGKILL. Raspbian maintainers decided roll back some of those changes and leave the wait functions as interruptible. Hence creating some divergence between both trees. One could argue that not liking having the threads stuck in D state is not really a software issue. It's more a cosmetic thing that can scare people when they look at "uptime". On the other hand, if we are ever to unstage this driver, we'd really need a proper justification for using the killable family of functions. Which I think it's not really clear at the moment. As Raspbian's kernel has been working for a while with interruptible waits I propose we follow through. If needed we can always go back to killable. But at least we'll have a proper understanding on the actual needs. In the end the driver is in staging, and the potential for errors small. Regards, Nicolas [1] https://github.com/raspberrypi/linux/issues/2881 [2] https://archlinuxarm.org/forum/viewtopic.php?f=65&t=13485 [3] https://lists.fedoraproject.org/archives/list/arm@lists.fedoraproject.org/message/GBXGJ7DOV5CQQXFPOZCXTRD6W4BEPT4Q/ -- Changes since v1: - Proplery format revert commits - Add code comment to remind of this issue - Add Fixes tags Nicolas Saenz Julienne (3): staging: vchiq_2835_arm: revert "quit using custom down_interruptible()" staging: vchiq: revert "switch to wait_for_completion_killable" staging: vchiq: make wait events interruptible .../interface/vchiq_arm/vchiq_2835_arm.c | 2 +- .../interface/vchiq_arm/vchiq_arm.c | 21 +++++++------ .../interface/vchiq_arm/vchiq_core.c | 31 ++++++++++++------- .../interface/vchiq_arm/vchiq_util.c | 6 ++-- 4 files changed, 35 insertions(+), 25 deletions(-)