| Message ID | 20190507034734.20622-5-leo.yan@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dts: Update DT bindings for CoreSight replicator and funnel | expand |
Hi Leo, On Tue, May 7, 2019 at 12:48 AM Leo Yan <leo.yan@linaro.org> wrote: > > Switch to the new CoreSight dynamic funnel bindings. This commit log does not contain the reasoning for the change. Please explain why you are changing the compatible string here.
Hi Fabio, On Tue, May 07, 2019 at 07:57:00AM -0300, Fabio Estevam wrote: > Hi Leo, > > On Tue, May 7, 2019 at 12:48 AM Leo Yan <leo.yan@linaro.org> wrote: > > > > Switch to the new CoreSight dynamic funnel bindings. > > This commit log does not contain the reasoning for the change. > > Please explain why you are changing the compatible string here. The main reason for changing the compatible string is: the old binding strings are obsolete (the old bindings are still supported for backwards compatibility) and the drivers will report warning if DTS uses these obsolete strings; so this patch tries to update bindings with latest compatible strings and thus can dismiss warning during CoreSight driver's initialization. Please let me know if anything is not clear for you. Thanks, Leo Yan
Hi Leo, On Tue, May 7, 2019 at 9:34 AM Leo Yan <leo.yan@linaro.org> wrote: > The main reason for changing the compatible string is: the old binding > strings are obsolete (the old bindings are still supported for backwards > compatibility) and the drivers will report warning if DTS uses these > obsolete strings; so this patch tries to update bindings with latest > compatible strings and thus can dismiss warning during CoreSight > driver's initialization. > > Please let me know if anything is not clear for you. What I am saying is that the patch should have such explanation in the commit log.
Hi Fabio, On Tue, May 07, 2019 at 09:36:43AM -0300, Fabio Estevam wrote: > Hi Leo, > > On Tue, May 7, 2019 at 9:34 AM Leo Yan <leo.yan@linaro.org> wrote: > > > The main reason for changing the compatible string is: the old binding > > strings are obsolete (the old bindings are still supported for backwards > > compatibility) and the drivers will report warning if DTS uses these > > obsolete strings; so this patch tries to update bindings with latest > > compatible strings and thus can dismiss warning during CoreSight > > driver's initialization. > > > > Please let me know if anything is not clear for you. > > What I am saying is that the patch should have such explanation in the > commit log. Makes sense :) Will spin new patch set with more clear explanation. Thanks for the suggestion! Leo Yan
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index fb98761edac9..d8b4eb67146d 100644 --- a/arch/arm/boot/dts/imx7s.dtsi +++ b/arch/arm/boot/dts/imx7s.dtsi @@ -175,7 +175,7 @@ ranges; funnel@30041000 { - compatible = "arm,coresight-funnel", "arm,primecell"; + compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; reg = <0x30041000 0x1000>; clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>; clock-names = "apb_pclk"; @@ -217,7 +217,7 @@ }; funnel@30083000 { - compatible = "arm,coresight-funnel", "arm,primecell"; + compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; reg = <0x30083000 0x1000>; clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>; clock-names = "apb_pclk";
Switch to the new CoreSight dynamic funnel bindings. Cc: Shawn Guo <shawnguo@kernel.org> Cc: Chris Healy <cphealy@gmail.com> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Fabio Estevam <festevam@gmail.com> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Suzuki K Poulose <suzuki.poulose@arm.com> Signed-off-by: Leo Yan <leo.yan@linaro.org> --- arch/arm/boot/dts/imx7s.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)