| Message ID | 1556793795-25204-4-git-send-email-michael.kao@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Mediatek thermal dirver and dtsi | expand |
Hi Michael, On Thu, 2019-05-02 at 18:43 +0800, michael.kao wrote: > The #cooling-cells property needs to be specified to allow a CPU > to be used as cooling device. > > Signed-off-by: michael.kao <Michael.Kao@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 5668fb8..95f1d7b 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -11,6 +11,8 @@ > #include <dt-bindings/power/mt8183-power.h> > #include <dt-bindings/reset-controller/mt8183-resets.h> > #include "mt8183-pinfunc.h" > +#include <dt-bindings/thermal/thermal.h> > + > / { > compatible = "mediatek,mt8183"; > interrupt-parent = <&sysirq>; It seems this patch don't have #cooling-cells but in your 2/8 patch in this series
On Mon, 2019-05-06 at 13:25 +0800, Eddie Huang wrote: > Hi Michael, > > On Thu, 2019-05-02 at 18:43 +0800, michael.kao wrote: > > The #cooling-cells property needs to be specified to allow a CPU > > to be used as cooling device. > > > > Signed-off-by: michael.kao <Michael.Kao@mediatek.com> > > --- > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > index 5668fb8..95f1d7b 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > @@ -11,6 +11,8 @@ > > #include <dt-bindings/power/mt8183-power.h> > > #include <dt-bindings/reset-controller/mt8183-resets.h> > > #include "mt8183-pinfunc.h" > > +#include <dt-bindings/thermal/thermal.h> > > + > > / { > > compatible = "mediatek,mt8183"; > > interrupt-parent = <&sysirq>; > > It seems this patch don't have #cooling-cells but in your 2/8 patch in > this series > > I will fix the mistake at v2 patch list.
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 5668fb8..95f1d7b 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi @@ -11,6 +11,8 @@ #include <dt-bindings/power/mt8183-power.h> #include <dt-bindings/reset-controller/mt8183-resets.h> #include "mt8183-pinfunc.h" +#include <dt-bindings/thermal/thermal.h> + / { compatible = "mediatek,mt8183"; interrupt-parent = <&sysirq>;
The #cooling-cells property needs to be specified to allow a CPU to be used as cooling device. Signed-off-by: michael.kao <Michael.Kao@mediatek.com> --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++ 1 file changed, 2 insertions(+)