diff mbox series

multipath-tools: document missing mpathpersist flags in help output

Message ID 20190502214901.3170-1-xose.vazquez@gmail.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show
Series multipath-tools: document missing mpathpersist flags in help output | expand

Commit Message

Xose Vazquez Perez May 2, 2019, 9:49 p.m. UTC 
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: DM-DEVEL ML <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 mpathpersist/main.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

Comments

Martin Wilck May 10, 2019, 7:05 p.m. UTC | #1 
On Thu, 2019-05-02 at 23:49 +0200, Xose Vazquez Perez wrote:
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: DM-DEVEL ML <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  mpathpersist/main.c | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)

Reviewed-by: Martin Wilck <mwilck@suse.com>


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
diff mbox series

Patch

diff --git a/mpathpersist/main.c b/mpathpersist/main.c
index 10cba45..5a2cf9a 100644
--- a/mpathpersist/main.c
+++ b/mpathpersist/main.c
@@ -15,6 +15,7 @@ 
 #include <pthread.h>
 #include <ctype.h>
 #include <string.h>
+#include "version.h"
 
 static const char * pr_type_strs[] = {
 	"obsolete [0]",
@@ -687,6 +688,7 @@  void mpath_print_buf_readfullstat( struct prin_resp *pr_buff)
 
 static void usage(void)
 {
+	fprintf(stderr, VERSION_STRING);
 	fprintf(stderr,
 			"Usage: mpathpersist [OPTIONS] [DEVICE]\n"
 			" Options:\n"
@@ -706,10 +708,8 @@  static void usage(void)
 			"    --param-aptpl|-Z           PR Out parameter 'APTPL'\n"
 			"    --read-keys|-k             PR In: Read Keys\n"
 			"    --param-rk=RK|-K RK        PR Out parameter reservation key\n"
-			"    --param-sark=SARK|-S SARK  PR Out parameter service "
-			"action\n"
-			"                               reservation key (SARK is in "
-			"hex)\n"
+			"    --param-sark=SARK|-S SARK  PR Out parameter service action\n"
+			"                               reservation key (SARK is in hex)\n"
 			"    --preempt|-P               PR Out: Preempt\n"
 			"    --preempt-abort|-A         PR Out: Preempt and Abort\n"
 			"    --prout-type=TYPE|-T TYPE  PR Out command type\n"
@@ -721,11 +721,14 @@  static void usage(void)
 			"    --release|-L               PR Out: Release\n"
 			"    --report-capabilities|-c   PR In: Report Capabilities\n"
 			"    --reserve|-R               PR Out: Reserve\n"
-			"    --transport-id=TIDS|-X TIDS  TransportIDs can be mentioned \n"
-			"                               in several forms\n"
+			"    --transport-id=TIDS|-X TIDS  TransportIDs can be mentioned\n"
+			"                                 in several forms\n"
+			"    --alloc-length=LEN|-l LEN  PR In: maximum allocation length\n"
 			" Examples:\n"
 			"     mpathpersist --out --register --param-sark=123abc --prout-type=5 /dev/mapper/mpath9\n"
-			"     mpathpersist -i -k /dev/mapper/mpath9\n"	);
+			"     mpathpersist -i -k /dev/mapper/mpath9\n"
+			"     mpathpersist --out --reserve --param-sark=123abc --prout-type=8 -d /dev/mapper/mpath9\n"
+			"     mpathpersist -i -s -d /dev/mapper/mpath9\n");
 }
 
 void