| Message ID | 346806ac-2018-b780-4939-87f29648017c@linux.alibaba.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix two bugs CB_NOTIFY_LOCK failing to wake a water | expand |
On Mon, 2019-05-13 at 14:49 +0800, Yihao Wu wrote: > This patch set fix bugs related to CB_NOTIFY_LOCK. These bugs cause > poor performance in locking operation. And this patchset should also fix > the failure when running xfstests generic/089 on a NFSv4.1 filesystem. > > Yihao Wu (2): > NFSv4.1: Again fix a race where CB_NOTIFY_LOCK fails to wake a waiter > NFSv4.1: Fix bug only first CB_NOTIFY_LOCK is handled > > fs/nfs/nfs4proc.c | 31 ++++++++++++------------------- > 1 file changed, 12 insertions(+), 19 deletions(-) > Looks good to me. Nice catch, btw! Reviewed-by: Jeff Layton <jlayton@kernel.org>
On 2019/5/13 9:36 PM, Jeff Layton wrote: > On Mon, 2019-05-13 at 14:49 +0800, Yihao Wu wrote: >> This patch set fix bugs related to CB_NOTIFY_LOCK. These bugs cause >> poor performance in locking operation. And this patchset should also fix >> the failure when running xfstests generic/089 on a NFSv4.1 filesystem. >> >> Yihao Wu (2): >> NFSv4.1: Again fix a race where CB_NOTIFY_LOCK fails to wake a waiter >> NFSv4.1: Fix bug only first CB_NOTIFY_LOCK is handled >> >> fs/nfs/nfs4proc.c | 31 ++++++++++++------------------- >> 1 file changed, 12 insertions(+), 19 deletions(-) >> > > Looks good to me. Nice catch, btw! > > Reviewed-by: Jeff Layton <jlayton@kernel.org> > Thank you for your reviewing, Jeff! And it seems I forgot to CC maintainers of fs/nfs. So I added you to the CC list, Trond and Anna. Does this patchset need further reviewing? Sorry to bother you. Thanks, Yihao Wu
On Thu, 2019-05-16 at 16:01 +0800, Yihao Wu wrote: > On 2019/5/13 9:36 PM, Jeff Layton wrote: > > On Mon, 2019-05-13 at 14:49 +0800, Yihao Wu wrote: > > > This patch set fix bugs related to CB_NOTIFY_LOCK. These bugs cause > > > poor performance in locking operation. And this patchset should also fix > > > the failure when running xfstests generic/089 on a NFSv4.1 filesystem. > > > > > > Yihao Wu (2): > > > NFSv4.1: Again fix a race where CB_NOTIFY_LOCK fails to wake a waiter > > > NFSv4.1: Fix bug only first CB_NOTIFY_LOCK is handled > > > > > > fs/nfs/nfs4proc.c | 31 ++++++++++++------------------- > > > 1 file changed, 12 insertions(+), 19 deletions(-) > > > > > > > Looks good to me. Nice catch, btw! > > > > Reviewed-by: Jeff Layton <jlayton@kernel.org> > > > > Thank you for your reviewing, Jeff! > > And it seems I forgot to CC maintainers of fs/nfs. So I added you to the CC > list, Trond and Anna. Does this patchset need further reviewing? > > Sorry to bother you. > This should probably go through Anna's tree, and I assume she'll pick it up once she and/or Trond have had a chance to review it. Thanks,