| Message ID | 20190514054251.186196-9-brendanhiggins@google.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | kunit: introduce KUnit, the Linux kernel unit testing framework | expand |
On Mon, May 13, 2019 at 10:42:42PM -0700, Brendan Higgins wrote: > This fixes the following warning seen on GCC 7.3: > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() > What is that file and function; no kernel tree near me seems to have that.
On Tue, May 14, 2019 at 08:56:43AM +0200, Peter Zijlstra wrote: > On Mon, May 13, 2019 at 10:42:42PM -0700, Brendan Higgins wrote: > > This fixes the following warning seen on GCC 7.3: > > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() > > > > What is that file and function; no kernel tree near me seems to have > that. Oh, sorry about that. The function is added in the following patch, "[PATCH v3 09/18] kunit: test: add support for test abort"[1]. My apologies if this patch is supposed to come after it in sequence, but I assumed it should come before otherwise objtool would complain about the symbol when it is introduced. Thanks! [1] https://lkml.org/lkml/2019/5/14/44
On Tue, May 14, 2019 at 01:12:23AM -0700, Brendan Higgins wrote: > On Tue, May 14, 2019 at 08:56:43AM +0200, Peter Zijlstra wrote: > > On Mon, May 13, 2019 at 10:42:42PM -0700, Brendan Higgins wrote: > > > This fixes the following warning seen on GCC 7.3: > > > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() > > > > > > > What is that file and function; no kernel tree near me seems to have > > that. > > Oh, sorry about that. The function is added in the following patch, > "[PATCH v3 09/18] kunit: test: add support for test abort"[1]. > > My apologies if this patch is supposed to come after it in sequence, but > I assumed it should come before otherwise objtool would complain about > the symbol when it is introduced. Or send me all patches such that I have context, or have a sane Changelog that gives me context. Just don't give me one patch with a crappy changelog.
On Tue, May 14, 2019 at 10:46:55AM +0200, Peter Zijlstra wrote: > On Tue, May 14, 2019 at 01:12:23AM -0700, Brendan Higgins wrote: > > On Tue, May 14, 2019 at 08:56:43AM +0200, Peter Zijlstra wrote: > > > On Mon, May 13, 2019 at 10:42:42PM -0700, Brendan Higgins wrote: > > > > This fixes the following warning seen on GCC 7.3: > > > > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() > > > > > > > > > > What is that file and function; no kernel tree near me seems to have > > > that. > > > > Oh, sorry about that. The function is added in the following patch, > > "[PATCH v3 09/18] kunit: test: add support for test abort"[1]. > > > > My apologies if this patch is supposed to come after it in sequence, but > > I assumed it should come before otherwise objtool would complain about > > the symbol when it is introduced. > > Or send me all patches such that I have context, or have a sane > Changelog that gives me context. Just don't give me one patch with a > crappy changelog. I will provide more context in the next revision. Sorry about that!
diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 479196aeb4096..be431d4557fe5 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -166,6 +166,7 @@ static int __dead_end_function(struct objtool_file *file, struct symbol *func, "usercopy_abort", "machine_real_restart", "rewind_stack_do_exit", + "kunit_try_catch_throw", }; if (func->bind == STB_WEAK)
This fixes the following warning seen on GCC 7.3: kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() Reported-by: kbuild test robot <lkp@intel.com> To: Josh Poimboeuf <jpoimboe@redhat.com> To: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Brendan Higgins <brendanhiggins@google.com> Link: https://www.spinics.net/lists/linux-kbuild/msg21708.html --- tools/objtool/check.c | 1 + 1 file changed, 1 insertion(+)