Message ID | 1557761837-24993-1-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive) |
---|---|
Headers | show |
Series | Add basic support for the iwg23s | expand |
Hi! > This series adds basic support for the iwg23s from iWave, based > on the RZ/G1C (a.k.a. r8a77470). Ok, let me take a look... Pavel
Hi! > This series adds basic support for the iwg23s from iWave, based > on the RZ/G1C (a.k.a. r8a77470). Thanks, applied. Minor comments were sent in replies to response to patches. Best regards, Pavel
Hi, On Mon, May 13, 2019 at 10:17:18PM +0200, Pavel Machek wrote: > Hi! > > > This series adds basic support for the iwg23s from iWave, based > > on the RZ/G1C (a.k.a. r8a77470). > > Thanks, applied. Minor comments were sent in replies to response to > patches. There are patches in this patch series that is not match to the CIP kernel maintenance rules. If we include these, I think that the commit message is not enough. Best regards, Nobuhiro
Thank you guys for your help! I think for the future we would need to agree on a format we are all comfortable with when backporting a patch from mainline is not an option. Do you have any suggestions? Thanks, Fab > From: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > Sent: 14 May 2019 01:28 > Subject: Re: [cip-dev] [PATCH 4.4.y 00/52] Add basic support for the iwg23s > > Hi, > > On Mon, May 13, 2019 at 10:17:18PM +0200, Pavel Machek wrote: > > Hi! > > > > > This series adds basic support for the iwg23s from iWave, based > > > on the RZ/G1C (a.k.a. r8a77470). > > > > Thanks, applied. Minor comments were sent in replies to response to > > patches. > > There are patches in this patch series that is not match to the CIP kernel maintenance rules. > If we include these, I think that the commit message is not enough. > > Best regards, > Nobuhiro
Hi, 2019年5月14日(火) 19:12 Fabrizio Castro <fabrizio.castro@bp.renesas.com>: > > Thank you guys for your help! > > I think for the future we would need to agree on a format we are all comfortable with > when backporting a patch from mainline is not an option. > > Do you have any suggestions? I think it is enough to write down a note why each commit is not backported from the linux kernel. CIP has an "upstream first" policy, so if we can not choice this policy, it is better to include a reason to commit message, I think. For example, 'We can not backport a patch because the clock framework is different in 4.4, so we need to create a new patch.' How is this? Best regards, Nobuhiro > > Thanks, > Fab > > > From: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > > Sent: 14 May 2019 01:28 > > Subject: Re: [cip-dev] [PATCH 4.4.y 00/52] Add basic support for the iwg23s > > > > Hi, > > > > On Mon, May 13, 2019 at 10:17:18PM +0200, Pavel Machek wrote: > > > Hi! > > > > > > > This series adds basic support for the iwg23s from iWave, based > > > > on the RZ/G1C (a.k.a. r8a77470). > > > > > > Thanks, applied. Minor comments were sent in replies to response to > > > patches. > > > > There are patches in this patch series that is not match to the CIP kernel maintenance rules. > > If we include these, I think that the commit message is not enough. > > > > Best regards, > > Nobuhiro > _______________________________________________ > cip-dev mailing list > cip-dev@lists.cip-project.org > https://lists.cip-project.org/mailman/listinfo/cip-dev -- Nobuhiro Iwamatsu iwamatsu at {nigauri.org / debian.org} GPG ID: 40AD1FA6
Hello Nobuhiro-san, Thank you for your feedback! > From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org> > Sent: 14 May 2019 14:28 > Subject: Re: [cip-dev] [PATCH 4.4.y 00/52] Add basic support for the iwg23s > > Hi, > > 2019年5月14日(火) 19:12 Fabrizio Castro <fabrizio.castro@bp.renesas.com>: > > > > Thank you guys for your help! > > > > I think for the future we would need to agree on a format we are all comfortable with > > when backporting a patch from mainline is not an option. > > > > Do you have any suggestions? > > I think it is enough to write down a note why each commit is not > backported from the linux kernel. > CIP has an "upstream first" policy, so if we can not choice this > policy, it is better to include a > reason to commit message, I think. > For example, 'We can not backport a patch because the clock framework > is different in 4.4, so we > need to create a new patch.' > > How is this? It sounds good to me. Thanks, Fab > > Best regards, > Nobuhiro > > > > > > Thanks, > > Fab > > > > > From: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > > > Sent: 14 May 2019 01:28 > > > Subject: Re: [cip-dev] [PATCH 4.4.y 00/52] Add basic support for the iwg23s > > > > > > Hi, > > > > > > On Mon, May 13, 2019 at 10:17:18PM +0200, Pavel Machek wrote: > > > > Hi! > > > > > > > > > This series adds basic support for the iwg23s from iWave, based > > > > > on the RZ/G1C (a.k.a. r8a77470). > > > > > > > > Thanks, applied. Minor comments were sent in replies to response to > > > > patches. > > > > > > There are patches in this patch series that is not match to the CIP kernel maintenance rules. > > > If we include these, I think that the commit message is not enough. > > > > > > Best regards, > > > Nobuhiro > > _______________________________________________ > > cip-dev mailing list > > cip-dev@lists.cip-project.org > > https://lists.cip-project.org/mailman/listinfo/cip-dev > > > > -- > Nobuhiro Iwamatsu > iwamatsu at {nigauri.org / debian.org} > GPG ID: 40AD1FA6
Hi, > -----Original Message----- > From: Fabrizio Castro [mailto:fabrizio.castro@bp.renesas.com] > Sent: Wednesday, May 15, 2019 9:57 PM > To: Nobuhiro Iwamatsu <iwamatsu@nigauri.org> > Cc: iwamatsu nobuhiro(岩松 信洋 ○SWC□OST) > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>; > cip-dev@lists.cip-project.org; Biju Das <biju.das@bp.renesas.com> > Subject: RE: [cip-dev] [PATCH 4.4.y 00/52] Add basic support for the > iwg23s > > Hello Nobuhiro-san, > > Thank you for your feedback! > > > From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org> > > Sent: 14 May 2019 14:28 > > Subject: Re: [cip-dev] [PATCH 4.4.y 00/52] Add basic support for the > > iwg23s > > > > Hi, > > > > 2019年5月14日(火) 19:12 Fabrizio Castro > <fabrizio.castro@bp.renesas.com>: > > > > > > Thank you guys for your help! > > > > > > I think for the future we would need to agree on a format we are all > > > comfortable with when backporting a patch from mainline is not an > option. > > > > > > Do you have any suggestions? > > > > I think it is enough to write down a note why each commit is not > > backported from the linux kernel. > > CIP has an "upstream first" policy, so if we can not choice this > > policy, it is better to include a reason to commit message, I think. > > For example, 'We can not backport a patch because the clock framework > > is different in 4.4, so we need to create a new patch.' > > > > How is this? > > It sounds good to me. Thanks. Could you add a comment to the targeted patch and resend it? > > Thanks, > Fab Best regards, Nobuhiro > > > > > Best regards, > > Nobuhiro > > > > > > > > > > Thanks, > > > Fab > > > > > > > From: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > > > > Sent: 14 May 2019 01:28 > > > > Subject: Re: [cip-dev] [PATCH 4.4.y 00/52] Add basic support for > > > > the iwg23s > > > > > > > > Hi, > > > > > > > > On Mon, May 13, 2019 at 10:17:18PM +0200, Pavel Machek wrote: > > > > > Hi! > > > > > > > > > > > This series adds basic support for the iwg23s from iWave, > > > > > > based on the RZ/G1C (a.k.a. r8a77470). > > > > > > > > > > Thanks, applied. Minor comments were sent in replies to response > > > > > to patches. > > > > > > > > There are patches in this patch series that is not match to the > CIP kernel maintenance rules. > > > > If we include these, I think that the commit message is not enough. > > > > > > > > Best regards, > > > > Nobuhiro > > > _______________________________________________ > > > cip-dev mailing list > > > cip-dev@lists.cip-project.org > > > https://lists.cip-project.org/mailman/listinfo/cip-dev > > > > > > > > -- > > Nobuhiro Iwamatsu > > iwamatsu at {nigauri.org / debian.org} > > GPG ID: 40AD1FA6
Hello Iwamatsu-san, > From: nobuhiro1.iwamatsu@toshiba.co.jp <nobuhiro1.iwamatsu@toshiba.co.jp> > Sent: 16 May 2019 01:20 > Subject: RE: [cip-dev] [PATCH 4.4.y 00/52] Add basic support for the iwg23s > > Hi, > > > -----Original Message----- > > From: Fabrizio Castro [mailto:fabrizio.castro@bp.renesas.com] > > Sent: Wednesday, May 15, 2019 9:57 PM > > To: Nobuhiro Iwamatsu <iwamatsu@nigauri.org> > > Cc: iwamatsu nobuhiro(岩松 信洋 ○SWC□OST) > > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>; > > cip-dev@lists.cip-project.org; Biju Das <biju.das@bp.renesas.com> > > Subject: RE: [cip-dev] [PATCH 4.4.y 00/52] Add basic support for the > > iwg23s > > > > Hello Nobuhiro-san, > > > > Thank you for your feedback! > > > > > From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org> > > > Sent: 14 May 2019 14:28 > > > Subject: Re: [cip-dev] [PATCH 4.4.y 00/52] Add basic support for the > > > iwg23s > > > > > > Hi, > > > > > > 2019年5月14日(火) 19:12 Fabrizio Castro > > <fabrizio.castro@bp.renesas.com>: > > > > > > > > Thank you guys for your help! > > > > > > > > I think for the future we would need to agree on a format we are all > > > > comfortable with when backporting a patch from mainline is not an > > option. > > > > > > > > Do you have any suggestions? > > > > > > I think it is enough to write down a note why each commit is not > > > backported from the linux kernel. > > > CIP has an "upstream first" policy, so if we can not choice this > > > policy, it is better to include a reason to commit message, I think. > > > For example, 'We can not backport a patch because the clock framework > > > is different in 4.4, so we need to create a new patch.' > > > > > > How is this? > > > > It sounds good to me. > > Thanks. > Could you add a comment to the targeted patch and resend it? Will resend the whole thing for simplicity. Thanks, Fab > > > > Thanks, > > Fab > > Best regards, > Nobuhiro > > > > > > > > > Best regards, > > > Nobuhiro > > > > > > > > > > > > > > Thanks, > > > > Fab > > > > > > > > > From: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > > > > > Sent: 14 May 2019 01:28 > > > > > Subject: Re: [cip-dev] [PATCH 4.4.y 00/52] Add basic support for > > > > > the iwg23s > > > > > > > > > > Hi, > > > > > > > > > > On Mon, May 13, 2019 at 10:17:18PM +0200, Pavel Machek wrote: > > > > > > Hi! > > > > > > > > > > > > > This series adds basic support for the iwg23s from iWave, > > > > > > > based on the RZ/G1C (a.k.a. r8a77470). > > > > > > > > > > > > Thanks, applied. Minor comments were sent in replies to response > > > > > > to patches. > > > > > > > > > > There are patches in this patch series that is not match to the > > CIP kernel maintenance rules. > > > > > If we include these, I think that the commit message is not enough. > > > > > > > > > > Best regards, > > > > > Nobuhiro > > > > _______________________________________________ > > > > cip-dev mailing list > > > > cip-dev@lists.cip-project.org > > > > https://lists.cip-project.org/mailman/listinfo/cip-dev > > > > > > > > > > > > -- > > > Nobuhiro Iwamatsu > > > iwamatsu at {nigauri.org / debian.org} > > > GPG ID: 40AD1FA6