| Message ID | c3596e996c9ab39c6b9bc14b93309244c4a55014.1557306151.git.chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 451d15a1731c7db9d4868ea084174346e8ffe0dd |
| Headers | show |
| Series | [v3] dt-binding: usb: add usb-role-switch property | expand |
On Wed, 8 May 2019 17:17:44 +0800, Chunfeng Yun wrote: > Add a property usb-role-switch to tell the driver that use > USB Role Switch framework to handle the role switch, > it's useful when the driver has already supported other ways, > such as extcon framework etc. > > Cc: Biju Das <biju.das@bp.renesas.com> > Cc: Yu Chen <chenyu56@huawei.com> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > v3: > add property type, modify description suggested by Heikki > > v2: > describe it in terms of h/w functionality suggested by Rob > > v1: > the property is discussed in: > [v2,2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property > https://patchwork.kernel.org/patch/10852497/ > > Mediatek and Hisilicon also try to use it: > [v4,3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch > https://patchwork.kernel.org/patch/10918385/ > [v4,6/6] usb: mtu3: register a USB Role Switch for dual role mode > https://patchwork.kernel.org/patch/10918367/ > > [v6,10/13] usb: dwc3: Registering a role switch in the DRD code > https://patchwork.kernel.org/patch/10909981/ > --- > Documentation/devicetree/bindings/usb/generic.txt | 4 ++++ > 1 file changed, 4 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, May 08, 2019 at 05:17:44PM +0800, Chunfeng Yun wrote: > Add a property usb-role-switch to tell the driver that use > USB Role Switch framework to handle the role switch, > it's useful when the driver has already supported other ways, > such as extcon framework etc. > > Cc: Biju Das <biju.das@bp.renesas.com> > Cc: Yu Chen <chenyu56@huawei.com> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> Who is meant to pick this? Can you include this in your series where you introduce that USB Type-B GPIO connector driver? FWIW: Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > v3: > add property type, modify description suggested by Heikki > > v2: > describe it in terms of h/w functionality suggested by Rob > > v1: > the property is discussed in: > [v2,2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property > https://patchwork.kernel.org/patch/10852497/ > > Mediatek and Hisilicon also try to use it: > [v4,3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch > https://patchwork.kernel.org/patch/10918385/ > [v4,6/6] usb: mtu3: register a USB Role Switch for dual role mode > https://patchwork.kernel.org/patch/10918367/ > > [v6,10/13] usb: dwc3: Registering a role switch in the DRD code > https://patchwork.kernel.org/patch/10909981/ > --- > Documentation/devicetree/bindings/usb/generic.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/generic.txt b/Documentation/devicetree/bindings/usb/generic.txt > index 0a74ab8dfdc2..cf5a1ad456e6 100644 > --- a/Documentation/devicetree/bindings/usb/generic.txt > +++ b/Documentation/devicetree/bindings/usb/generic.txt > @@ -30,6 +30,10 @@ Optional properties: > optional for OTG device. > - adp-disable: tells OTG controllers we want to disable OTG ADP, ADP is > optional for OTG device. > + - usb-role-switch: boolean, indicates that the device is capable of assigning > + the USB data role (USB host or USB device) for a given > + USB connector, such as Type-C, Type-B(micro). > + see connector/usb-connector.txt. > > This is an attribute to a USB controller such as: > > -- > 2.21.0 thanks,
On Fri, 2019-05-17 at 16:27 +0300, Heikki Krogerus wrote: > On Wed, May 08, 2019 at 05:17:44PM +0800, Chunfeng Yun wrote: > > Add a property usb-role-switch to tell the driver that use > > USB Role Switch framework to handle the role switch, > > it's useful when the driver has already supported other ways, > > such as extcon framework etc. > > > > Cc: Biju Das <biju.das@bp.renesas.com> > > Cc: Yu Chen <chenyu56@huawei.com> > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > Who is meant to pick this? > Can you include this in your series where > you introduce that USB Type-B GPIO connector driver? > Ok, I'll do it if need > FWIW: > > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > > --- > > v3: > > add property type, modify description suggested by Heikki > > > > v2: > > describe it in terms of h/w functionality suggested by Rob > > > > v1: > > the property is discussed in: > > [v2,2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property > > https://patchwork.kernel.org/patch/10852497/ > > > > Mediatek and Hisilicon also try to use it: > > [v4,3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch > > https://patchwork.kernel.org/patch/10918385/ > > [v4,6/6] usb: mtu3: register a USB Role Switch for dual role mode > > https://patchwork.kernel.org/patch/10918367/ > > > > [v6,10/13] usb: dwc3: Registering a role switch in the DRD code > > https://patchwork.kernel.org/patch/10909981/ > > --- > > Documentation/devicetree/bindings/usb/generic.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/generic.txt b/Documentation/devicetree/bindings/usb/generic.txt > > index 0a74ab8dfdc2..cf5a1ad456e6 100644 > > --- a/Documentation/devicetree/bindings/usb/generic.txt > > +++ b/Documentation/devicetree/bindings/usb/generic.txt > > @@ -30,6 +30,10 @@ Optional properties: > > optional for OTG device. > > - adp-disable: tells OTG controllers we want to disable OTG ADP, ADP is > > optional for OTG device. > > + - usb-role-switch: boolean, indicates that the device is capable of assigning > > + the USB data role (USB host or USB device) for a given > > + USB connector, such as Type-C, Type-B(micro). > > + see connector/usb-connector.txt. > > > > This is an attribute to a USB controller such as: > > > > -- > > 2.21.0 > > thanks, >
diff --git a/Documentation/devicetree/bindings/usb/generic.txt b/Documentation/devicetree/bindings/usb/generic.txt index 0a74ab8dfdc2..cf5a1ad456e6 100644 --- a/Documentation/devicetree/bindings/usb/generic.txt +++ b/Documentation/devicetree/bindings/usb/generic.txt @@ -30,6 +30,10 @@ Optional properties: optional for OTG device. - adp-disable: tells OTG controllers we want to disable OTG ADP, ADP is optional for OTG device. + - usb-role-switch: boolean, indicates that the device is capable of assigning + the USB data role (USB host or USB device) for a given + USB connector, such as Type-C, Type-B(micro). + see connector/usb-connector.txt. This is an attribute to a USB controller such as:
Add a property usb-role-switch to tell the driver that use USB Role Switch framework to handle the role switch, it's useful when the driver has already supported other ways, such as extcon framework etc. Cc: Biju Das <biju.das@bp.renesas.com> Cc: Yu Chen <chenyu56@huawei.com> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- v3: add property type, modify description suggested by Heikki v2: describe it in terms of h/w functionality suggested by Rob v1: the property is discussed in: [v2,2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property https://patchwork.kernel.org/patch/10852497/ Mediatek and Hisilicon also try to use it: [v4,3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch https://patchwork.kernel.org/patch/10918385/ [v4,6/6] usb: mtu3: register a USB Role Switch for dual role mode https://patchwork.kernel.org/patch/10918367/ [v6,10/13] usb: dwc3: Registering a role switch in the DRD code https://patchwork.kernel.org/patch/10909981/ --- Documentation/devicetree/bindings/usb/generic.txt | 4 ++++ 1 file changed, 4 insertions(+)